RE: RFR: JDK-8190198 - SA: Framework for writing 'jhsdb clhsdb' commands tests and testcases for some of the commands

I have made changes to use the outputAnalyzer (thanks Jini). Latest webrev is : http://cr.openjdk.java.net/~sballal/8190198/webrev.02/ Thanks, Sharath -Original Message- From: Sharath Ballal Sent: Sunday, November 05, 2017 10:04 PM To: David Holmes;

Re: RFR : JDK-8044122 MBean access to the PID

Hi, kindly take a look at latest changes. webrev: http://cr.openjdk.java.net/~uvangapally/webrev/2017/8044122/webrev.05/ Thanks, Ujwal. On 10/31/2017 9:20 AM, Ujwal Vangapally wrote: Thanks for the Review Roger, Mandy. Ujwal. On 10/31/2017 4:09 AM, mandy chung wrote: On 10/30/17

Re: RFR(S): 8059334: nsk/jvmti/scenarios/hotswap/HS201/hs201t001 fails with exit code 0 after timeout

Hi Chris, The fix looks good. I'm not that familiar with the compiler code to judge if this the best place to make this check. But, at least, it looks as such to me. Perhaps, it would be great if Vladimir could also look at it. But now pressure for this. Thanks, Serguei On 11/3/17 17:25,

Re: RFR(S): 8059334: nsk/jvmti/scenarios/hotswap/HS201/hs201t001 fails with exit code 0 after timeout

On 11/6/17 1:56 PM, Chris Plummer wrote: Hi Dean, It looks like ciEnv::jvmti_state_changed() is used to support the JVMTI AddCapabilities() interface, which I believe typically a JVMTI agent uses to setup the available capabilities when the agent is first loaded (although capabilities can by

Re: RFR(S): 8059334: nsk/jvmti/scenarios/hotswap/HS201/hs201t001 fails with exit code 0 after timeout

Hi Dan, On 11/6/17 12:23 PM, Daniel D. Daugherty wrote: On 11/3/17 8:25 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8059334 Wow! This bug was quite the adventure... I know how to pick 'em, huh? :)

Re: RFR(S): 8059334: nsk/jvmti/scenarios/hotswap/HS201/hs201t001 fails with exit code 0 after timeout

On 11/3/17 8:25 PM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8059334 Wow! This bug was quite the adventure... http://cr.openjdk.java.net/~cjplummer/8059334/webrev.00/webrev.open/

Re: RFR(S): 8059334: nsk/jvmti/scenarios/hotswap/HS201/hs201t001 fails with exit code 0 after timeout

OK thanks. dl On 11/6/17 10:56 AM, Chris Plummer wrote: Hi Dean, It looks like ciEnv::jvmti_state_changed() is used to support the JVMTI AddCapabilities() interface, which I believe typically a JVMTI agent uses to setup the available capabilities when the agent is first loaded (although

Re: RFR(S): 8059334: nsk/jvmti/scenarios/hotswap/HS201/hs201t001 fails with exit code 0 after timeout

Hi Dean, It looks like ciEnv::jvmti_state_changed() is used to support the JVMTI AddCapabilities() interface, which I believe typically a JVMTI agent uses to setup the available capabilities when the agent is first loaded (although capabilities can by changed afterwords also). So I don't see

Re: PING: RFR: 8165736: Error message should be shown when JVMTI agent cannot be attached

Hi Serguei, On 2017/11/06 20:06, serguei.spit...@oracle.com wrote: Hi Yasumasa, The changes looks good. Thank you for making them! Thanks! On 11/3/17 05:10, Yasumasa Suenaga wrote: Hi Serguei, Thank you for your comment! I uploaded new webrev:  

Re: PING: RFR: 8165736: Error message should be shown when JVMTI agent cannot be attached

Hi Yasumasa, The changes looks good. Thank you for making them! On 11/3/17 05:10, Yasumasa Suenaga wrote: Hi Serguei, Thank you for your comment! I uploaded new webrev:   http://cr.openjdk.java.net/~ysuenaga/JDK-8165736/webrev.01/

Re: RFR: 8183542: Factor out serial GC specific code from GenCollectedHeap into its own subclass

Am 02.11.2017 um 04:55 schrieb Kim Barrett: On Oct 25, 2017, at 4:07 AM, Roman Kennke wrote: Hi Kim, hi Jini, thank you both for your reviews! I think I need a sponsor now. The final webrev (same as before plus Reviewed-by line):