On Wed, 20 Oct 2021 18:34:36 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this tiny patch?
>
> from JBS:
>> serviceability/jvmti/GetObjectSizeClass.java doesn't ignore external flags
>> (where it matters) and hence should not have been marked
On Wed, 20 Oct 2021 18:34:36 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this tiny patch?
>
> from JBS:
>> serviceability/jvmti/GetObjectSizeClass.java doesn't ignore external flags
>> (where it matters) and hence should not have been marked
Hi all,
could you please review this tiny patch?
from JBS:
> serviceability/jvmti/GetObjectSizeClass.java doesn't ignore external flags
> (where it matters) and hence should not have been marked w/ vm.flagless
Thanks,
-- Igor
-
Commit messages:
- 8275666
Changes:
On Tue, 17 Aug 2021 14:58:48 GMT, Mikhailo Seledtsov
wrote:
>> Please review this change that updates the buildJdkDockerImage() test
>> library API.
>>
>> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
>> support for containers is not tested".
>> The initial intent
On Mon, 16 Aug 2021 23:31:41 GMT, Mikhailo Seledtsov
wrote:
> Please review this change that updates the buildJdkDockerImage() test library
> API.
>
> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
> support for containers is not tested".
> The initial intent was
On Mon, 16 Aug 2021 23:47:04 GMT, Igor Ignatyev wrote:
>> Please review this change that updates the buildJdkDockerImage() test
>> library API.
>>
>> This work originated while working on "8195809: [TESTBUG] jps and jcmd -l
>> support for containers is
On Wed, 28 Jul 2021 17:13:49 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this big tedious and trivial(-ish) patch which moves
> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>
> the majority of the patch is the following subs
On Mon, 2 Aug 2021 15:56:39 GMT, Vladimir Kozlov wrote:
> I agree with these revised changes for JDK 17.
Thanks for your review, Vladimir.
I'll rerun my testing before integrating (just for good luck).
-- Igor
-
PR: https://git.openjdk.java.net/jdk17/pull/290
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this big tedious and trivial(-ish) patch which moves
>> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>>
>> the majority of the
g`
>
> testing: tier1-4
>
> Thanks,
> -- Igor
Igor Ignatyev has updated the pull request incrementally with two additional
commits since the last revision:
- copyright update
- fixed typo in ClassFileInstaller
-
Changes:
- all: https://git.openjdk.java.net/jdk17/p
On Sat, 31 Jul 2021 20:42:10 GMT, Igor Ignatyev wrote:
>> Hi all,
>>
>> could you please review this big tedious and trivial(-ish) patch which moves
>> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>>
>> the majority of the
g`
>
> testing: tier1-4
>
> Thanks,
> -- Igor
Igor Ignatyev has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull request contains 12 new commits
sinc
On Thu, 29 Jul 2021 01:30:37 GMT, Vladimir Kozlov wrote:
>> Hi all,
>>
>> could you please review this big tedious and trivial(-ish) patch which moves
>> `sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
>>
>> the majority of the patch is the following substitutions:
Hi all,
could you please review this big tedious and trivial(-ish) patch which moves
`sun.hotspot.WhiteBox` and related classes to `jdk.test.whitebox` package?
the majority of the patch is the following substitutions:
- `s~sun/hotspot/WhiteBox~jdk/test/whitebox/WhiteBox~g`
-
On Fri, 23 Jul 2021 04:34:50 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch that adds an exit-code check to
> `serviceability/jvmti/GetObjectSizeClass.java` test?
>
> from JBS:
>> `serviceability/jvmti/GetObjectSizeClass.java` test spawns a
On Fri, 23 Jul 2021 04:34:50 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch that adds an exit-code check to
> `serviceability/jvmti/GetObjectSizeClass.java` test?
>
> from JBS:
>> `serviceability/jvmti/GetObjectSizeClass.java` test spawns a
Hi all,
could you please review the patch that adds an exit-code check to
`serviceability/jvmti/GetObjectSizeClass.java` test?
from JBS:
> `serviceability/jvmti/GetObjectSizeClass.java` test spawns a new JVM but
> doesn't check its exit code which might lead to both type-I and type-II errors
On Thu, 10 Jun 2021 18:23:45 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this one-liner that adds `@requires vm.flagless` to 2
> `serviceability/attach` tests that ignore external VM flags?
>
> Thanks,
> -- Igor
This pull request has now been i
On Thu, 10 Jun 2021 16:46:12 GMT, Igor Ignatyev wrote:
> (recreating openjdk/jdk#4453 against jdk17)
>
> Hi all,
>
> could you please review this patch that adds `@requires vm.flagless` to
> `SDTProbesGNULinuxTest` test as it ignores all external VM flags?
>
> Than
On Thu, 10 Jun 2021 18:08:45 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this one-liner that adds `@requires vm.flagless` to
> `serviceability/sa/TestJhsdbJstackLineNumbers.java` as it ignores external VM
> flags?
>
> Thanks,
> -- Igor
This p
On Thu, 10 Jun 2021 18:19:46 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this one-liner that adds `@requires vm.flagless` to 6
> `serviceability/jvmti` tests that ignore external VM flags?
>
> Thanks,
> -- Igor
This pull request has now been i
On Thu, 10 Jun 2021 18:23:45 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this one-liner that adds `@requires vm.flagless` to 2
> `serviceability/attach` tests that ignore external VM flags?
>
> Thanks,
> -- Igor
Thank you, Serguei.
---
On Thu, 10 Jun 2021 16:46:12 GMT, Igor Ignatyev wrote:
> (recreating openjdk/jdk#4453 against jdk17)
>
> Hi all,
>
> could you please review this patch that adds `@requires vm.flagless` to
> `SDTProbesGNULinuxTest` test as it ignores all external VM flags?
>
> Th
On Thu, 10 Jun 2021 18:08:45 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this one-liner that adds `@requires vm.flagless` to
> `serviceability/sa/TestJhsdbJstackLineNumbers.java` as it ignores external VM
> flags?
>
> Thanks,
> --
On Thu, 10 Jun 2021 18:19:46 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this one-liner that adds `@requires vm.flagless` to 6
> `serviceability/jvmti` tests that ignore external VM flags?
>
> Thanks,
> -- Igor
Serguei, thank you for your review.
---
On Thu, 10 Jun 2021 21:27:09 GMT, Chris Plummer wrote:
> Can you explain a bit more how `@requires vm.flagless` works? The way I read
> it, that would indicate that the test should not be run if any flags are
> specified. I'm not sure why you would want to do that. I understand that the
>
Hi all,
could you please review this one-liner that adds `@requires vm.flagless` to 2
`serviceability/attach` tests that ignore external VM flags?
Thanks,
-- Igor
-
Commit messages:
- 8268564
Changes: https://git.openjdk.java.net/jdk17/pull/8/files
Webrev:
Hi all,
could you please review this one-liner that adds `@requires vm.flagless` to 6
`serviceability/jvmti` tests that ignore external VM flags?
Thanks,
-- Igor
-
Commit messages:
- update copyright year
- 8268563
Changes: https://git.openjdk.java.net/jdk17/pull/7/files
Hi all,
could you please review this one-liner that adds `@requires vm.flagless` to
`serviceability/sa/TestJhsdbJstackLineNumbers.java` as it ignores external VM
flags?
Thanks,
-- Igor
-
Commit messages:
- 8268541
Changes: https://git.openjdk.java.net/jdk17/pull/6/files
On Thu, 10 Jun 2021 17:11:15 GMT, Igor Ignatyev wrote:
> 8268539: several serviceability/sa tests should be run in driver mode
This pull request has now been integrated.
Changeset: 5b8c51f5
Author: Igor Ignatyev
URL:
https://git.openjdk.java.net/jdk17/com
8268539: several serviceability/sa tests should be run in driver mode
-
Commit messages:
- 8268539
Changes: https://git.openjdk.java.net/jdk17/pull/4/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk17=4=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8268539
Stats:
On Thu, 10 Jun 2021 10:07:48 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this _test-only_ patch that switches the execution
> mode of several `serviceability/sa` tests to `driver`? all these tests seem
> not to perform actual testing, and just organize other
On Thu, 10 Jun 2021 10:07:48 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this _test-only_ patch that switches the execution
> mode of several `serviceability/sa` tests to `driver`? all these tests seem
> not to perform actual testing, and just organize other
(recreating openjdk/jdk#4453 against jdk17)
Hi all,
could you please review this patch that adds `@requires vm.flagless` to
`SDTProbesGNULinuxTest` test as it ignores all external VM flags?
Thanks,
-- Igor
-
Commit messages:
- update copyright year
- 8268531
Changes:
On Thu, 10 Jun 2021 07:24:26 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this patch that adds `@requires vm.flagless` to
> `SDTProbesGNULinuxTest` test as it ignores all external VM flags?
>
> Thanks,
> -- Igor
closed in favor of openjdk/jdk17#1
---
On Thu, 10 Jun 2021 10:26:46 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small fix for
> `serviceability/logging/TestFullNames.java` test?
> from JBS:
>> serviceability/logging/TestFullNames.java test contains two test cases:
>> specifyin
On Thu, 10 Jun 2021 10:26:46 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small fix for
> `serviceability/logging/TestFullNames.java` test?
> from JBS:
>> serviceability/logging/TestFullNames.java test contains two test cases:
>> specifyin
Hi all,
could you please review this small fix for
`serviceability/logging/TestFullNames.java` test?
from JBS:
> serviceability/logging/TestFullNames.java test contains two test cases:
> specifying filename w/ and w/o "file=" prefix. yet, the test doesn't remove
> the file, hence its 2nd test
Hi all,
could you please review this _test-only_ patch that switches the execution mode
of several `serviceability/sa` tests to `driver`? all these tests seem not to
perform actual testing, and just organize other JDK executions and validates
their outputs.
`ClhsdbDumpclass.java` had to be
On Thu, 10 Jun 2021 08:14:16 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that switches execution mode in 4
> `serviceability/jvmti` tests?
> in all instances, the main test classes seem not to do actual testing and
> just orc
On Thu, 10 Jun 2021 08:15:49 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that switches execution mode in 4
> `serviceability/attach` tests?
> in all instances, the main test classes seem not to do actual testing and
> just orc
On Thu, 10 Jun 2021 08:15:49 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch that switches execution mode in 4
> `serviceability/attach` tests?
> in all instances, the main test classes seem not to do actual testing and
> just orc
On Thu, 10 Jun 2021 08:41:41 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which adds `@requires vm.flagless` to
> serviceability/logging` tests that ignore external VM flags?
>
> Thanks,
> -- Igor
This pull request has now been integrated.
On Thu, 10 Jun 2021 08:41:41 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which adds `@requires vm.flagless` to
> serviceability/logging` tests that ignore external VM flags?
>
> Thanks,
> -- Igor
Thank you for your reviews, Serguei!
---
On Thu, 10 Jun 2021 08:28:25 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which adds `@requires vm.flagless` to
> `serviceability/dcmd/gc/RunFinalizationTest.java` and
> `serviceability/dcmd/compiler/CodeHeapAnalyticsParams.java` tests as they
>
On Thu, 10 Jun 2021 08:28:25 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which adds `@requires vm.flagless` to
> `serviceability/dcmd/gc/RunFinalizationTest.java` and
> `serviceability/dcmd/compiler/CodeHeapAnalyticsParams.java` tests as they
>
On Thu, 10 Jun 2021 07:02:36 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small and test-only change for
> `resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java` test?
>
> the test's main class just orchestrates execution and hence should be
On Thu, 10 Jun 2021 07:02:36 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small and test-only change for
> `resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java` test?
>
> the test's main class just orchestrates execution and hence should be
Hi all,
could you please review this small patch that switches execution mode in 4
`serviceability/jvmti` tests?
in all instances, the main test classes seem not to do actual testing and just
orchestrate execution.
testing: `serviceability/jvmti` on `{linux,windows,macosx}-x64`
Thanks,
--
Hi all,
could you please review this small patch that switches execution mode in 4
`serviceability/attach` tests?
in all instances, the main test classes seem not to do actual testing and just
orchestrate execution.
testing: `serviceability/attach` on `{linux,windows,macosx}-x64`
Thanks,
--
Hi all,
could you please review the patch which adds `@requires vm.flagless` to
serviceability/logging` tests that ignore external VM flags?
Thanks,
-- Igor
-
Commit messages:
- update copyright year
- 8268538
Changes: https://git.openjdk.java.net/jdk/pull/4458/files
Webrev:
Hi all,
could you please review the patch which adds `@requires vm.flagless` to
`serviceability/dcmd/gc/RunFinalizationTest.java` and
`serviceability/dcmd/compiler/CodeHeapAnalyticsParams.java` tests as they
completely ignore external vm flags?
Thanks,
-- Igor
-
Commit messages:
Hi all,
could you please review this small and test-only change for
`resourcehogs/serviceability/jvmti/GetObjectSizeOverflow.java` test?
the test's main class just orchestrates execution and hence should be run in a
driver mode, the patch also makes small refactoring of the test code: removes
Hi all,
could you please review this patch that adds `@requires vm.flagless` to
`SDTProbesGNULinuxTest` test as it ignores all external VM flags?
Thanks,
-- Igor
-
Commit messages:
- update copyright year
- 8268531
Changes: https://git.openjdk.java.net/jdk/pull/4453/files
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for
On Wed, 17 Mar 2021 07:02:59 GMT, Serguei Spitsyn wrote:
>> resurrecting old
>> [RFR](https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-June/041981.html):
>>
>>> Hi all,
>>>
>>> could you please review the patch which introduces a new @requires property
>>> to filter out the tests
On Tue, 2 Mar 2021 23:27:21 GMT, Igor Ignatyev wrote:
> resurrecting old
> [RFR](https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-June/041981.html):
>
>> Hi all,
>>
>> could you please review the patch which introduces a new @requires property
>> to
On Wed, 17 Mar 2021 00:45:00 GMT, Mikhailo Seledtsov
wrote:
>> resurrecting old
>> [RFR](https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-June/041981.html):
>>
>>> Hi all,
>>>
>>> could you please review the patch which introduces a new @requires property
>>> to filter out the tests
On Sat, 13 Mar 2021 04:31:31 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and remov
On Sat, 13 Mar 2021 14:20:20 GMT, Daniel D. Daugherty
wrote:
>> Igor Ignatyev has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
>
nowhere to be found, hence we
>> get NCDFE.
>
> testing:
> - [x] `grep ' ClassFileInstaller[^.]`
> - [ ] tier1-3
>
> Thanks,
> -- Igor
Igor Ignatyev has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will sh
On Sat, 13 Mar 2021 06:16:37 GMT, Ioi Lam wrote:
>> Igor Ignatyev has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR. The pull request contains
nowhere to be found, hence we
>> get NCDFE.
>
> testing:
> - [x] `grep ' ClassFileInstaller[^.]`
> - [ ] tier1-3
>
> Thanks,
> -- Igor
Igor Ignatyev has updated the pull request incrementally with one additional
commit since the last revision:
fix compilation error i
On Sat, 13 Mar 2021 04:31:31 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this dull patch that replaces `ClassFileInstaller` w/
> `jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
> ensure we won't get split testlibrary, and remov
Hi all,
could you please review this dull patch that replaces `ClassFileInstaller` w/
`jdk.test.lib.helpers.ClassFileInstaller` in all jtreg test descriptions to
ensure we won't get split testlibrary, and removes
`jdk/test/lib/ClassFileInstaller.java` (so it won't be accidentally used).
from
On Tue, 2 Mar 2021 23:27:21 GMT, Igor Ignatyev wrote:
> resurrecting old
> [RFR](https://mail.openjdk.java.net/pipermail/hotspot-dev/2020-June/041981.html):
>
>> Hi all,
>>
>> could you please review the patch which introduces a new @requires property
>> to
On Fri, 12 Mar 2021 02:08:09 GMT, Mikhailo Seledtsov
wrote:
>> Hi all,
>>
>> could you please review the patch which moves `ClassFileInstaller` class to
>> `jdk.test.lib.helpers` package?
>> to reduce changes in the tests, `ClassFileInstaller` in the default package
>> is kept w/ just
On Thu, 11 Mar 2021 05:47:00 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which moves `ClassFileInstaller` class to
> `jdk.test.lib.helpers` package?
> to reduce changes in the tests, `ClassFileInstaller` in the default package
> is kept w/
Hi all,
could you please review the patch which moves `ClassFileInstaller` class to
`jdk.test.lib.helpers` package?
to reduce changes in the tests, `ClassFileInstaller` in the default package is
kept w/ just `main` method that calls `jdk.test.lib.helpers.
ClassFileInstaller::main`.
from
RFR got migrated to github as https://github.com/openjdk/jdk/pull/2800
-- Igor
On Jun 5, 2020, at 9:10 AM, Igor Ignatyev
mailto:igor.ignat...@oracle.com>> wrote:
Hi Per,
you are reading this correctly, make
TEST=test/hotspot/jtreg/gc/z/TestSmallHeap.java JTREG="VM_OPTIONS=-XX:+Use
On Thu, 4 Feb 2021 09:40:33 GMT, Roland Westrelin wrote:
>> `OutputAnalyzer`/ `OutputBuffer` already have an exit value, which arguable
>> has nothing to do w/ the text output either, so I think it's ok to add a pid
>> into `OutputBuffer` i-face and both of its implementations.
>
> I just
On Thu, 4 Feb 2021 09:44:13 GMT, Roland Westrelin wrote:
>> I noticed that the SA's dumpreplaydata command fails with:
>>
>> java.lang.AssertionError: CLHSDB wasn't run successfully: Opening core file,
>> please wait...
>> hsdb> Exception in thread "main" java.lang.InternalError: ciMetadata
On Wed, 3 Feb 2021 12:04:00 GMT, Roland Westrelin wrote:
>> test/lib/jdk/test/lib/process/ProcessTools.java line 461:
>>
>>> 459: }
>>> 460:
>>> 461: static public class OutputAnalyzerAndPID {
>>
>> can we either change `OutputAnalyzer` to store pid (and use -1 for cases
>> when
On Wed, 27 Jan 2021 08:07:04 GMT, Roland Westrelin wrote:
>> I noticed that the SA's dumpreplaydata command fails with:
>>
>> java.lang.AssertionError: CLHSDB wasn't run successfully: Opening core file,
>> please wait...
>> hsdb> Exception in thread "main" java.lang.InternalError: ciMetadata
On Wed, 27 Jan 2021 08:07:04 GMT, Roland Westrelin wrote:
>> I noticed that the SA's dumpreplaydata command fails with:
>>
>> java.lang.AssertionError: CLHSDB wasn't run successfully: Opening core file,
>> please wait...
>> hsdb> Exception in thread "main" java.lang.InternalError: ciMetadata
On Thu, 14 Jan 2021 20:32:17 GMT, Leonid Mesnik wrote:
>> est vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 has incorrect check of
>> strcmp results here:
>>
>> for (i=0; i> if (strcmp(methNam,METHODS[i][0]) &&
>> strcmp(methSig,METHODS[i][1])) {
>>
On Thu, 14 Jan 2021 19:09:59 GMT, Leonid Mesnik wrote:
> est vmTestbase/nsk/jvmti/Breakpoint/breakpoint001 has incorrect check of
> strcmp results here:
>
> for (i=0; i if (strcmp(methNam,METHODS[i][0]) &&
> strcmp(methSig,METHODS[i][1])) {
> printf("CHECK
On Thu, 15 Oct 2020 22:47:43 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this patch which reformats/cleans up the code of
> vmTestbase/nsk/jdb tests?
>
> the part of this patch is a spinoff from #350.
>
> testing:
> * [x] `vmTestbase/nsk/jdb
On Wed, 11 Nov 2020 15:38:10 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I get reviews for this change that removes the "Allocation of old
>> generation of Java heap on alternate memory devices" functionality
>> introduced with JDK 12 with
>>
On Wed, 11 Nov 2020 15:42:36 GMT, Lin Zang wrote:
>> The implementation of jmap tool depends on the implementation of object
>> iteration by different GC heap.
>> This patch extend the BasicJMapTest to cover differet GC Heap.
>
> Lin Zang has updated the pull request incrementally with one
On Wed, 11 Nov 2020 11:24:08 GMT, Lin Zang wrote:
>> The implementation of jmap tool depends on the implementation of object
>> iteration by different GC heap.
>> This patch extend the BasicJMapTest to cover differet GC Heap.
>
> Lin Zang has updated the pull request incrementally with one
On Fri, 30 Oct 2020 17:40:51 GMT, Vladimir Kozlov wrote:
> We shipped Ahead-of-Time compilation (the jaotc tool) in JDK 9, as an
> experimental feature. We shipped Graal as an experimental JIT compiler in JDK
> 10. We haven't seen much use of these features, and the effort required to
>
On Wed, 21 Oct 2020 21:04:55 GMT, Daniel D. Daugherty
wrote:
> Reduce the noise in the JDK16 CI by ProblemListing com/sun/jdi/EATests.java
> for ZGC.
Marked as reviewed by iignatyev (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/787
On Wed, 21 Oct 2020 20:12:51 GMT, Chris Plummer wrote:
> Do we have coding guidelines that say to indent them 8?
old "official" guidelines don't tell much about it, @aioobe's guidelines don't
special-case array initiation, so it is covered by:
> A continuation line should be indented in one
On Tue, 20 Oct 2020 01:13:33 GMT, Chris Plummer wrote:
>> although horizontal alignment (of variable names, initialization,
>> expressions, etc) seems to somewhat improve
>> readability, it almost always associated with a higher maintenance cost, and
>> the current consensus is not to do that.
On Mon, 19 Oct 2020 23:56:00 GMT, Chris Plummer wrote:
>> b/c you get indentation unit for each block, 1st block is `fields001` class
>> definition, next block is the array
>> initializations (start at L#86 and L#99 for `checkedFields1` and
>> `checkedFields2` respecitively)
>
> I don't
On Mon, 19 Oct 2020 18:37:58 GMT, Chris Plummer wrote:
>> Igor Ignatyev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update copyright years
>
> test/hotspot/jtreg/vmTestbase/nsk/jdb/caught
On Mon, 19 Oct 2020 18:51:15 GMT, Chris Plummer wrote:
>> Igor Ignatyev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update copyright years
>
> test/hotspot/jtreg/vmTestbase/nsk/jdb/fields/fields
On Mon, 19 Oct 2020 18:44:56 GMT, Chris Plummer wrote:
>> Igor Ignatyev has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update copyright years
>
> test/hotspot/jtreg/vmTestbase/nsk/jdb/caught
On Thu, 15 Oct 2020 22:47:43 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this patch which reformats/cleans up the code of
> vmTestbase/nsk/jdb tests?
>
> the part of this patch is a spinoff from #350.
>
> testing:
> * [x] `vmTestbase/nsk/jdb
> Hi all,
>
> could you please review this patch which reformats/cleans up the code of
> vmTestbase/nsk/jdb tests?
>
> the part of this patch is a spinoff from #350.
>
> testing:
> * [x] `vmTestbase/nsk/jdb` tests on `linux-x64-debug`
Igor Ignatyev has updated the
Hi all,
could you please review this patch which reformats/cleans up the code of
vmTestbase/nsk/jdb tests?
the part of this patch is a spinoff from #350.
testing:
* [x] `vmTestbase/nsk/jdb` tests on `linux-x64-debug`
-
Commit messages:
- 8254861: reformat code in
On Thu, 8 Oct 2020 11:00:41 GMT, Aleksei Voitylov wrote:
> @iignatev I resolved the conflict in whitebox.cpp and fixed a minor style nit
> on the way. Could you take a look?
LGTM
-
PR: https://git.openjdk.java.net/jdk/pull/49
On Wed, 30 Sep 2020 22:11:43 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this small patch which reformats `ArgumentHandler`,
> removes unused
> `findOptionStringValue(String name, String defaultValue)` method, fixes typos?
This pull request has now
On Wed, 30 Sep 2020 23:28:11 GMT, Chris Plummer wrote:
>> Hi all,
>>
>> could you please review this small patch which reformats `ArgumentHandler`,
>> removes unused
>> `findOptionStringValue(String name, String defaultValue)` method, fixes
>> typos?
>
> Marked as reviewed by cjplummer
On Wed, 30 Sep 2020 22:58:38 GMT, Chris Plummer wrote:
>> Hi all,
>>
>> could you please review this small patch which reformats `ArgumentHandler`,
>> removes unused
>> `findOptionStringValue(String name, String defaultValue)` method, fixes
>> typos?
>
>
On Wed, 30 Sep 2020 23:00:30 GMT, Chris Plummer wrote:
>> Hi all,
>>
>> could you please review this small patch which reformats `ArgumentHandler`,
>> removes unused
>> `findOptionStringValue(String name, String defaultValue)` method, fixes
>> typos?
>
>
Hi all,
could you please review this small patch which reformats `ArgumentHandler`,
removes unused
`findOptionStringValue(String name, String defaultValue)` method, fixes typos?
-
Commit messages:
- 8253878: clean up nsk/share/jvmti/ArgumentHandler
Changes:
On Fri, 25 Sep 2020 23:48:30 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review the patch which removes `PropertyResolvingWrapper`
> from `vmTestbase/nsk/jvmti` tests? as
> `jtreg` doesn't support spaces in the arguments and doesn't handle `"` in any
>
On Wed, 30 Sep 2020 21:34:22 GMT, Serguei Spitsyn wrote:
>>> What are the meaning of these properties ?:
>>> -Dnsk.jvmti.test.property=value_of_nsk.jvmti.test.property
>>> -Dnsk.jvmti.test.property=initial_value_of_nsk.jvmti.test.property
>>>
1 - 100 of 324 matches
Mail list logo
