On Fri, 22 Jan 2021 14:21:52 GMT, Roland Westrelin wrote:
> I noticed that the SA's dumpreplaydata command fails with:
>
> java.lang.AssertionError: CLHSDB wasn't run successfully: Opening core file,
> please wait...
> hsdb> Exception in thread "main" java.lang.In
by systemd (I'm running some recent version of fedora). I
> suppose, the system can be configured differently but having the test
> work out the box is nice. I extended the test case to handle that.
>
> With the improved test, there are a few differences between the VM and
> SA re
On Thu, 4 Feb 2021 18:25:45 GMT, Igor Ignatyev wrote:
>> Roland Westrelin has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
by systemd (I'm running some recent version of fedora). I
> suppose, the system can be configured differently but having the test
> work out the box is nice. I extended the test case to handle that.
>
> With the improved test, there are a few differences between the VM and
> SA re
On Wed, 3 Feb 2021 18:51:57 GMT, Igor Ignatyev wrote:
>> Thanks for reviewing this. I did not store the pid in the OutputAnalyzer
>> because it doesn't seem to belong there as it has nothing to do with the
>> text output of a test. But if you think that's ok. that's fine with me too.
>> Do
On Wed, 3 Feb 2021 05:45:02 GMT, Igor Ignatyev wrote:
>> Roland Westrelin has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Fri, 22 Jan 2021 17:44:34 GMT, Vladimir Kozlov wrote:
>> Roland Westrelin has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Mon, 25 Jan 2021 19:43:56 GMT, Chris Plummer wrote:
>> Roland Westrelin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> use CoreUtils
>
> test/lib/jdk/test/lib/util/CoreUtils.java line 193:
>
by systemd (I'm running some recent version of fedora). I
> suppose, the system can be configured differently but having the test
> work out the box is nice. I extended the test case to handle that.
>
> With the improved test, there are a few differences between the VM and
> SA re
by systemd (I'm running some recent version of fedora). I
> suppose, the system can be configured differently but having the test
> work out the box is nice. I extended the test case to handle that.
>
> With the improved test, there are a few differences between the VM and
> SA re
On Fri, 22 Jan 2021 21:28:33 GMT, Chris Plummer wrote:
>> Roland Westrelin has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> use CoreUtils
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Profile
I noticed that the SA's dumpreplaydata command fails with:
java.lang.AssertionError: CLHSDB wasn't run successfully: Opening core file,
please wait...
hsdb> Exception in thread "main" java.lang.InternalError: ciMetadata does not
appear to be polymorphic
with a simple test program. This happens
> http://cr.openjdk.java.net/~rkennke/shenandoah-upstream/05/
C2 changes look good to me.
Roland.
Thanks for the reviews, Vladimir, Dmitry and Staffan.
Roland.
So it isn't default methods that are the problem but bridge methods?
Yes, it looks like it.
Roland.
Hi Chris,
Since you’re saying it only fixes it partially should we file a followup bug
and maybe leave a comment behind?
Actually I don’t know if it’s partial or not. I don’t understand default
methods enough to be sure.
Roland.
Hi David,
I wouldn't say it supports default methods rather it ignores them so they
don't trigger exceptions. I'm still puzzling over why default methods have a
zero _codeIndex as that seems to be the real cause of the trouble. ??
I took another look and it turns out the test on _codeIndex
buildreplayjars sometimes fail with an exception and I think that's
caused by the lack of support for default methods when the SA dumps
classes. This change fixes it at least partially. It may not be the
cleanest way to support default methods but it already proved useful
when investigating a
Hi Staffan,
Please review this fix for a problem with compiler/ciReplay/TestSA.sh. It
fails with an exception because SA can’t find the values for some the enum
entries in Deoptimization::DeoptReason since they are missing from
vmStructs.cpp. The patch below adds them.
bug:
AM, Roland Westrelin wrote:
http://cr.openjdk.java.net/~kvn/8028468/webrev/
New webrev:
http://cr.openjdk.java.net/~kvn/8028468/webrev.01/
Should the agent/doc/cireplay.html be updated? Is there another doc on how
to use the replay support somewhere (wiki)?
cireplay.html describes
http://cr.openjdk.java.net/~kvn/8028468/webrev/
Should the agent/doc/cireplay.html be updated? Is there another doc on how to
use the replay support somewhere (wiki)?
ciReplay.cpp
typos:
// Use pointer because we may need to retirn inline records
// Replay Inlinig
vmError.cpp
typo:
// Do not
:39 AM, Roland Westrelin roland.westre...@oracle.com
wrote:
http://cr.openjdk.java.net/~kvn/8028468/webrev/
Should the agent/doc/cireplay.html be updated? Is there another doc on how to
use the replay support somewhere (wiki)?
ciReplay.cpp
typos:
// Use pointer because we may need
Thanks for the review Vladimir Christian
Roland.
) {
+ notice_modification();
Thanks,
Vladimir
On 12/9/13 9:03 AM, Roland Westrelin wrote:
http://cr.openjdk.java.net/~roland/8029383/webrev.00/
When an anonymous class is defined through Unsafe (not recorded in the
system dictionary), SystemDictionary::notice_modification() is not called
It looks good to me.
Roland.
Changeset: 2fecca53a2c6
Author:roland
Date: 2011-09-07 14:15 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/2fecca53a2c6
7085012: ARM: com/sun/jdi/PopSynchronousTest.java still fails
Summary: InterpreterRuntime::popframe_move_outgoing_args() is required for the
26 matches
Mail list logo
