Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-06 Thread Staffan Larsen
On 6 mar 2013, at 00:23, David Holmes david.hol...@oracle.com wrote: On 6/03/2013 9:08 AM, Dean Long wrote: What if allocate_init_map() fails to allocate memory? Shouldn't add_class_share_map_info() follow the pattern of add_map_info(): return NULL or map, and have the caller check for

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-05 Thread serguei.spit...@oracle.com
Looks good. Thanks, Serguei On 3/4/13 11:24 PM, Staffan Larsen wrote: A very small fix for a warning. webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ Thanks, /Staffan

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-05 Thread Mikael Vidstedt
Looks good! Cheers, Mikael On 2013-03-04 23:24, Staffan Larsen wrote: A very small fix for a warning. webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ Thanks, /Staffan

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-05 Thread Dean Long
What if allocate_init_map() fails to allocate memory? Shouldn't add_class_share_map_info() follow the pattern of add_map_info(): return NULL or map, and have the caller check for NULL? dl On 3/4/2013 11:39 PM, David Holmes wrote: Looks fine to me - thanks Staffan! David On 5/03/2013 5:24

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-05 Thread David Holmes
On 6/03/2013 9:08 AM, Dean Long wrote: What if allocate_init_map() fails to allocate memory? Shouldn't add_class_share_map_info() follow the pattern of add_map_info(): return NULL or map, and have the caller check for NULL? AFAICS apart from one seeming bug, if we can't allocate a new map it

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-05 Thread David Holmes
On 6/03/2013 10:44 AM, Dean Long wrote: On 3/5/2013 3:23 PM, David Holmes wrote: On 6/03/2013 9:08 AM, Dean Long wrote: What if allocate_init_map() fails to allocate memory? Shouldn't add_class_share_map_info() follow the pattern of add_map_info(): return NULL or map, and have the caller

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-05 Thread Dean Long
On 3/5/2013 3:23 PM, David Holmes wrote: On 6/03/2013 9:08 AM, Dean Long wrote: What if allocate_init_map() fails to allocate memory? Shouldn't add_class_share_map_info() follow the pattern of add_map_info(): return NULL or map, and have the caller check for NULL? AFAICS apart from one

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-05 Thread Dean Long
On 3/5/2013 4:48 PM, David Holmes wrote: On 6/03/2013 10:44 AM, Dean Long wrote: On 3/5/2013 3:23 PM, David Holmes wrote: On 6/03/2013 9:08 AM, Dean Long wrote: What if allocate_init_map() fails to allocate memory? Shouldn't add_class_share_map_info() follow the pattern of add_map_info():

RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-04 Thread Staffan Larsen
A very small fix for a warning. webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ Thanks, /Staffan

Re: RFR(XS): 8009287 Uninitialised variable in hotspot/agent/src/os/linux/ps_core.c

2013-03-04 Thread David Holmes
Looks fine to me - thanks Staffan! David On 5/03/2013 5:24 PM, Staffan Larsen wrote: A very small fix for a warning. webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/ Thanks, /Staffan