On 6 mar 2013, at 00:23, David Holmes david.hol...@oracle.com wrote:
On 6/03/2013 9:08 AM, Dean Long wrote:
What if allocate_init_map() fails to allocate memory? Shouldn't
add_class_share_map_info() follow the pattern of add_map_info():
return NULL or map, and have the caller check for
Looks good.
Thanks,
Serguei
On 3/4/13 11:24 PM, Staffan Larsen wrote:
A very small fix for a warning.
webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/
Thanks,
/Staffan
Looks good!
Cheers,
Mikael
On 2013-03-04 23:24, Staffan Larsen wrote:
A very small fix for a warning.
webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/
Thanks,
/Staffan
What if allocate_init_map() fails to allocate memory? Shouldn't
add_class_share_map_info() follow the pattern of add_map_info():
return NULL or map, and have the caller check for NULL?
dl
On 3/4/2013 11:39 PM, David Holmes wrote:
Looks fine to me - thanks Staffan!
David
On 5/03/2013 5:24
On 6/03/2013 9:08 AM, Dean Long wrote:
What if allocate_init_map() fails to allocate memory? Shouldn't
add_class_share_map_info() follow the pattern of add_map_info():
return NULL or map, and have the caller check for NULL?
AFAICS apart from one seeming bug, if we can't allocate a new map it
On 6/03/2013 10:44 AM, Dean Long wrote:
On 3/5/2013 3:23 PM, David Holmes wrote:
On 6/03/2013 9:08 AM, Dean Long wrote:
What if allocate_init_map() fails to allocate memory? Shouldn't
add_class_share_map_info() follow the pattern of add_map_info():
return NULL or map, and have the caller
On 3/5/2013 3:23 PM, David Holmes wrote:
On 6/03/2013 9:08 AM, Dean Long wrote:
What if allocate_init_map() fails to allocate memory? Shouldn't
add_class_share_map_info() follow the pattern of add_map_info():
return NULL or map, and have the caller check for NULL?
AFAICS apart from one
On 3/5/2013 4:48 PM, David Holmes wrote:
On 6/03/2013 10:44 AM, Dean Long wrote:
On 3/5/2013 3:23 PM, David Holmes wrote:
On 6/03/2013 9:08 AM, Dean Long wrote:
What if allocate_init_map() fails to allocate memory? Shouldn't
add_class_share_map_info() follow the pattern of add_map_info():
A very small fix for a warning.
webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/
Thanks,
/Staffan
Looks fine to me - thanks Staffan!
David
On 5/03/2013 5:24 PM, Staffan Larsen wrote:
A very small fix for a warning.
webrev: http://cr.openjdk.java.net/~sla/8009287/webrev.00/
Thanks,
/Staffan
10 matches
Mail list logo