Looks good.
On May 13, 2014, at 11:58 PM, Staffan Larsen staffan.lar...@oracle.com wrote:
Thanks Christian,
I will make the change below before I push.
/Staffan
diff --git a/src/cpu/x86/vm/sharedRuntime_x86_32.cpp
b/src/cpu/x86/vm/sharedRuntime_x86_32.cpp
---
On 9 maj 2014, at 20:18, serguei.spit...@oracle.com wrote:
Staffan,
This is important discovery, thanks!
The fix looks good to me.
One question below.
Thanks,
Serguei
On 5/9/14 3:47 AM, Staffan Larsen wrote:
On 8 maj 2014, at 19:05, Daniel D. Daugherty daniel.daughe...@oracle.com
new webrev is here: http://cr.openjdk.java.net/~sla/8041934/webrev.02/
src/share/vm/runtime/sharedRuntime.hpp
No comments.
src/share/vm/runtime/sharedRuntime.cpp
No comments.
src/cpu/sparc/vm/sharedRuntime_sparc.cpp
No comments.
src/cpu/x86/vm/sharedRuntime_x86_32.cpp
No
On 5/13/14 2:20 AM, Staffan Larsen wrote:
On 9 maj 2014, at 20:18, serguei.spit...@oracle.com
mailto:serguei.spit...@oracle.com wrote:
Staffan,
This is important discovery, thanks!
The fix looks good to me.
One question below.
Thanks,
Serguei
On 5/9/14 3:47 AM, Staffan Larsen wrote:
On
Since:
int _interp_only_mode;
is an int field I would prefer to actually read the value as an int instead of
just a byte on x86:
+__ cmpb(Address(r15_thread, JavaThread::interp_only_mode_offset()), 0);
Otherwise this looks good.
On May 13, 2014, at 11:30 AM, Staffan Larsen
On 8 maj 2014, at 19:05, Daniel D. Daugherty daniel.daughe...@oracle.com
wrote:
webrev: http://cr.openjdk.java.net/~sla/8041934/webrev.00/
src/share/vm/runtime/sharedRuntime.hpp
No comments.
src/share/vm/runtime/sharedRuntime.cpp
line 994: JRT_LEAF(int,
Updated review: http://cr.openjdk.java.net/~sla/8041934/webrev.01/
Thumbs up!
src/share/vm/runtime/sharedRuntime.hpp
No comments.
src/share/vm/runtime/sharedRuntime.cpp
Thanks for fixing the entry type.
src/cpu/sparc/vm/sharedRuntime_sparc.cpp
No comments.
Staffan,
This is important discovery, thanks!
The fix looks good to me.
One question below.
Thanks,
Serguei
On 5/9/14 3:47 AM, Staffan Larsen wrote:
On 8 maj 2014, at 19:05, Daniel D. Daugherty daniel.daughe...@oracle.com
wrote:
webrev: http://cr.openjdk.java.net/~sla/8041934/webrev.00/
All,
This is a fix for an assert in JVMTI that verifies that JVMTI’s internal notion
of the number of frames on the stack is correct.
When running in -Xcomp mode and enable single-stepping (or method_entry/exit)
we will revert all frames on the stack to be run by the interpreter. Only the
Note that RepStep was just added to ProblemList due to this issue and
will have to be removed from there when the fix is integrated.
Mikael
On 2014-05-08 08:06, Staffan Larsen wrote:
All,
This is a fix for an assert in JVMTI that verifies that JVMTI’s internal
notion of the number of
webrev: http://cr.openjdk.java.net/~sla/8041934/webrev.00/
src/share/vm/runtime/sharedRuntime.hpp
No comments.
src/share/vm/runtime/sharedRuntime.cpp
line 994: JRT_LEAF(int, SharedRuntime::jvmti_method_exit(
I'm not sure that JRT_LEAF is right. I would think that
11 matches
Mail list logo