Re: RFR: 8032901: WaitForMultipleObjects() return value not handled appropriately

2014-05-14 Thread David Holmes
On 14/05/2014 11:06 AM, Vitaly Davidovich wrote: In windows, you acquire a mutex by waiting on it using one of the wait functions, one of them employed in the code in question. If WaitForMultipleObjects succeeds and returns the index of the mutex, current thread has ownership now. Yes I

Re: RFR: 8032901: WaitForMultipleObjects() return value not handled appropriately

2014-05-14 Thread Aleksej Efimov
David, Vitaly, I totally agree with Vitaly's explanation (Vitaly - thank you for that) and code in shmemBase.c (the usage of enterMutex() function for sending/receiving bytes through shared memory connection) illustrates on how the connection shutdown event is used as a cancellation token.

Re: RFR: 8041934 com/sun/jdi/RepStep.java fails on all platforms with assert(_cur_stack_depth == count_frames()) failed: cur_stack_depth out of sync

2014-05-14 Thread Christian Thalinger
Looks good. On May 13, 2014, at 11:58 PM, Staffan Larsen staffan.lar...@oracle.com wrote: Thanks Christian, I will make the change below before I push. /Staffan diff --git a/src/cpu/x86/vm/sharedRuntime_x86_32.cpp b/src/cpu/x86/vm/sharedRuntime_x86_32.cpp ---

Re: RFR: 8032901: WaitForMultipleObjects() return value not handled appropriately

2014-05-14 Thread David Holmes
On 14/05/2014 11:18 PM, Aleksej Efimov wrote: David, Vitaly, I totally agree with Vitaly's explanation (Vitaly - thank you for that) and code in shmemBase.c (the usage of enterMutex() function for sending/receiving bytes through shared memory connection) illustrates on how the connection

Re: RFR: 8032901: WaitForMultipleObjects() return value not handled appropriately

2014-05-14 Thread Vitaly Davidovich
In windows, you acquire a mutex by waiting on it using one of the wait functions, one of them employed in the code in question. If WaitForMultipleObjects succeeds and returns the index of the mutex, current thread has ownership now. It's also common to use multi wait functions where the event is