Re: RFR: 8067295 - Need to port Utils chagnes... 8067307: Need custom classloaders... 8067291: Need additional vm checks...

2014-12-22 Thread Igor Ignatyev
Dmitrij, all fixes look good to me. // could you please send separate RFR for each CR next time? Thanks, Igor On 12/15/2014 05:06 PM, Dmitrij Pochepko wrote: Hi, a bit of update for https://bugs.openjdk.java.net/browse/JDK-8067295 (port of JDK-8066440)

Re: RFR: 8059625 - JEP-JDK-8043304: Test task: DTrace- tests for segmented codecache feature

2014-12-22 Thread Christian Thalinger
40 public static int[] getAvailableCompilationLevels() { 41 if (System.getProperty(java.vm.info).startsWith(interpreted )) { 42 return new int[0]; 43 } Wouldn’t it be better to check the UseCompiler flag instead? On Dec 19, 2014, at 11:03 AM, Dmitrij

Re: RFR: 8059625 - JEP-JDK-8043304: Test task: DTrace- tests for segmented codecache feature

2014-12-22 Thread serguei.spit...@oracle.com
Hi Dmitry, It looks good in general. Some minor comments are below. test/testlibrary/com/oracle/java/testlibrary/dtrace/DtraceRunner.java 42 public static final String PERMIT_DESCTUCTIVE_ACTIONS_DTRACE_OPTION = w; A typo in the constant name: DESCTUCTIVE = DESTRUCTIVE