Integrated: 8304919: Implementation of Virtual Threads

2023-04-10 Thread Alan Bateman
On Tue, 28 Mar 2023 07:28:01 GMT, Alan Bateman wrote: > JEP 444 proposes to make virtual threads a permanent feature in Java 21. The > APIs that were preview APIs in Java 19/20 are changed to permanent and their > `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The >

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects [v2]

2023-04-10 Thread Vladimir Kozlov
On Tue, 11 Apr 2023 01:05:49 GMT, Leonid Mesnik wrote: >> Updated VM internal object allocation C2 intrinsic to post jvmti events when >> needed. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > fixed after Sergey's

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects [v2]

2023-04-10 Thread Serguei Spitsyn
On Tue, 11 Apr 2023 01:05:49 GMT, Leonid Mesnik wrote: >> Updated VM internal object allocation C2 intrinsic to post jvmti events when >> needed. > > Leonid Mesnik has updated the pull request incrementally with one additional > commit since the last revision: > > fixed after Sergey's

Re: RFR: 8299414: JVMTI FollowReferences should support references from VirtualThread stack [v5]

2023-04-10 Thread David Holmes
On Fri, 7 Apr 2023 04:51:36 GMT, Alex Menkov wrote: >> The fix updates JVMTI FollowReferences implementation to report references >> from virtual threads: >> - added heap scanning to report unmounted vthreads; >> - stacks of mounted vthreads are splitted into 2 parts (vittual thread stack >>

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

2023-04-10 Thread Leonid Mesnik
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote: > Updated VM internal object allocation C2 intrinsic to post jvmti events when > needed. I have simplified #if #else #endif and renamed functions and variables. Also, changed _should_notify_object_alloc default value to false.

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects [v2]

2023-04-10 Thread Leonid Mesnik
> Updated VM internal object allocation C2 intrinsic to post jvmti events when > needed. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fixed after Sergey's comments - Changes: - all:

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

2023-04-10 Thread Serguei Spitsyn
On Mon, 10 Apr 2023 22:03:56 GMT, Leonid Mesnik wrote: >> src/hotspot/share/prims/jvmtiEventController.cpp line 727: >> >>> 725: JvmtiExport::set_should_post_on_exceptions((any_env_thread_enabled >>> & SHOULD_POST_ON_EXCEPTIONS_BITS) != 0); >>> 726: >>> 727:

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

2023-04-10 Thread Serguei Spitsyn
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote: > Updated VM internal object allocation C2 intrinsic to post jvmti events when > needed. src/hotspot/share/prims/jvmtiExport.cpp line 1050: > 1048: > 1049: // This flag is read by C2 during VM internal objects allocation > 1050: bool

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

2023-04-10 Thread Serguei Spitsyn
On Mon, 10 Apr 2023 22:02:10 GMT, Leonid Mesnik wrote: >> src/hotspot/share/opto/library_call.cpp line 2856: >> >>> 2854: set_result(ideal.value(result)); >>> 2855: return true; >>> 2856: #else >> >> Nit: It is better to replace #else at 2856 with #endif. Then #endif at 2859 >> is not

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

2023-04-10 Thread Leonid Mesnik
On Mon, 10 Apr 2023 18:46:42 GMT, Serguei Spitsyn wrote: >> Updated VM internal object allocation C2 intrinsic to post jvmti events when >> needed. > > src/hotspot/share/opto/library_call.cpp line 2856: > >> 2854: set_result(ideal.value(result)); >> 2855: return true; >> 2856: #else > >

Re: RFR: 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries [v2]

2023-04-10 Thread Jiangli Zhou
> Rename various 'jvm' variables to 'jvm_' to avoid duplicate symbol > problems when statically linking the launcher executable with JDK native > libraries. Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision: Update management.c and

Re: RFR: 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries

2023-04-10 Thread Jiangli Zhou
On Mon, 10 Apr 2023 13:52:39 GMT, Alan Bateman wrote: >> Rename various 'jvm' variables to 'jvm_' to avoid duplicate symbol >> problems when statically linking the launcher executable with JDK native >> libraries. > > src/java.management/share/native/libmanagement/management.c line 36: > >>

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

2023-04-10 Thread Serguei Spitsyn
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote: > Updated VM internal object allocation C2 intrinsic to post jvmti events when > needed. src/hotspot/share/prims/jvmtiEventController.cpp line 727: > 725: JvmtiExport::set_should_post_on_exceptions((any_env_thread_enabled & >

Re: RFR: 8277573: VmObjectAlloc is not generated by intrinsics methods which allocate objects

2023-04-10 Thread Serguei Spitsyn
On Mon, 3 Apr 2023 22:20:43 GMT, Leonid Mesnik wrote: > Updated VM internal object allocation C2 intrinsic to post jvmti events when > needed. It looks pretty good. But I'd like to request a couple of changes. The `notify_allocation` sounds to generic. What about to replace it with

Re: RFR: 8305761: Resolve multiple definition of 'jvm' when statically linking with JDK native libraries

2023-04-10 Thread Alan Bateman
On Sat, 8 Apr 2023 01:11:08 GMT, Jiangli Zhou wrote: > Rename various 'jvm' variables to 'jvm_' to avoid duplicate symbol > problems when statically linking the launcher executable with JDK native > libraries. src/java.management/share/native/libmanagement/management.c line 36: > 34: const