Re: RFR: 8319465: Typos in javadoc of com.sun.management.OperatingSystemMXBean methods

2023-11-05 Thread David Holmes
On Mon, 6 Nov 2023 06:55:21 GMT, Jaikiran Pai wrote: > Can I please get a review of this PR which fixes the typos in the method > javadocs of com.sun.management.OperatingSystemMXBean? > > As noted in https://bugs.openjdk.org/browse/JDK-8319465, this PR replaces the > word "betweens" by

RFR: 8319465: Typos in javadoc of com.sun.management.OperatingSystemMXBean methods

2023-11-05 Thread Jaikiran Pai
Can I please get a review of this PR which fixes the typos in the method javadocs of com.sun.management.OperatingSystemMXBean? As noted in https://bugs.openjdk.org/browse/JDK-8319465, this PR replaces the word "betweens" by "between" - Commit messages: - 8319465: Typos in

Re: getProcessCPULoad returns different CPU percentage as comparead to top linux command

2023-11-05 Thread David Holmes
On 6/11/2023 3:53 pm, Nikhil Agarwal wrote: Hi David, Thanks for your reply , It seems top command also uses /proc/stat to do the magic .Reading a similar issue for top vs another monitor tool on

Re: RFR: 8318631: GetStackTraceSuspendedStressTest.java failed with: check_jvmti_status: JVMTI function returned error: JVMTI_ERROR_THREAD_NOT_ALIVE (15)

2023-11-05 Thread Alan Bateman
On Mon, 6 Nov 2023 05:34:04 GMT, David Holmes wrote: >> test/hotspot/jtreg/serviceability/jvmti/stress/StackTrace/Suspended/libGetStackTraceSuspendedStress.cpp >> line 125: >> >>> 123: err = jvmti->SetEventNotificationMode(JVMTI_ENABLE, >>> JVMTI_EVENT_SINGLE_STEP, vthread); >>> 124: if

Re: RFR: 8319376: Parallel: Forwarded objects during heap inspection

2023-11-05 Thread David Holmes
On Fri, 3 Nov 2023 12:42:46 GMT, Roman Kennke wrote: > See JBS issue for details. > > Testing: > - [x] gc/logging/TestUnifiedLoggingSwitchStress.java -XX:+UseParallelGC > - [x] tier1 -XX:+UseParallelGC > - [ ] tier2 -XX:+UseParallelGC > - [ ] hotspot_gc @rkennke could you update the title

RE: getProcessCPULoad returns different CPU percentage as comparead to top linux command

2023-11-05 Thread Nikhil Agarwal
Hi David, Thanks for your reply , It seems top command also uses /proc/stat to do the magic .Reading a similar issue for top vs another monitor tool on https://medium.com/@yogita088/how-to-calculate-cpu-usage-proc-stat-vs-top-e74f99f02d08 , What is the duration for which

Re: RFR: 8318631: GetStackTraceSuspendedStressTest.java failed with: check_jvmti_status: JVMTI function returned error: JVMTI_ERROR_THREAD_NOT_ALIVE (15)

2023-11-05 Thread David Holmes
On Fri, 3 Nov 2023 20:09:28 GMT, Alex Menkov wrote: >> It is a fix of a minor test issue. >> The test should not fail when the JVMTI function >> `SetEventNotificationMode()` returns errors codes: >> - `JVMTI_ERROR_THREAD_NOT_ALIVE` >> - `JVMTI_ERROR_WRONG_PHASE` >> >> Tested the fix locally

Re: getProcessCPULoad returns different CPU percentage as comparead to top linux command

2023-11-05 Thread David Holmes
Hi, On 3/11/2023 11:50 pm, Nikhil Agarwal wrote: Hi All,   getProcessCPULoad returns different CPU percentage as compared to top linux command intermittently . Does it supposed to returned same data as top command always .  Should the getProcessCPULoad value be same as