Re: RFR: 8329113: Deprecate -XX:+UseNotificationThread

2024-04-22 Thread David Holmes
On Fri, 19 Apr 2024 01:16:46 GMT, Alex Menkov wrote: > The fix deprecates -XX:+UseNotificationThread VM option > > Testing: tier1-3,hs-tier5-svc Changes look good but please ensure tier5 svc tests pass with the warning enabled EDIT: Ah I see you already indicated they did - thanks Thanks.

Re: RFR: 8329113: Deprecate -XX:+UseNotificationThread

2024-04-22 Thread David Holmes
On Fri, 19 Apr 2024 18:07:00 GMT, Alex Menkov wrote: > > Have you looked for any tests that are using this option? > > No tests use the option Well they do but it is done via a task definition in hs-tier5-svc.js. - PR Comment:

Re: RFR: 8330388: Remove invokedynamic cache index encoding [v2]

2024-04-22 Thread Coleen Phillimore
On Thu, 18 Apr 2024 16:22:31 GMT, Matias Saavedra Silva wrote: >> Before [JDK-8307190](https://bugs.openjdk.org/browse/JDK-8307190), >> [JDK-8309673](https://bugs.openjdk.org/browse/JDK-8309673), and >> [JDK-8301995](https://bugs.openjdk.org/browse/JDK-8301995), invokedynamic >> operands

Re: RFR: 8330155: Serial: Remove TenuredSpace

2024-04-22 Thread Chris Plummer
On Mon, 22 Apr 2024 16:24:06 GMT, Guoxiong Li wrote: > Hi all, > > This patch removes the class `TenuredSpace` and adjusts its usages. After > removing `TenuredSpace`, the file `space.inline.hpp` is empty, so I remove > this file and change the included header file to `space.hpp`. > > The

Re: RFR: 8330155: Serial: Remove TenuredSpace

2024-04-22 Thread Albert Mingkun Yang
On Mon, 22 Apr 2024 16:24:06 GMT, Guoxiong Li wrote: > Hi all, > > This patch removes the class `TenuredSpace` and adjusts its usages. After > removing `TenuredSpace`, the file `space.inline.hpp` is empty, so I remove > this file and change the included header file to `space.hpp`. > > The

RFR: 8330155: Serial: Remove TenuredSpace

2024-04-22 Thread Guoxiong Li
Hi all, This patch removes the class `TenuredSpace` and adjusts its usages. After removing `TenuredSpace`, the file `space.inline.hpp` is empty, so I remove this file and change the included header file to `space.hpp`. The test `make test-tier1_gc` passed locally. Thanks for taking the time to

Re: RFR: 8261242: [Linux] OSContainer::is_containerized() returns true when run outside a container

2024-04-22 Thread Jan Kratochvil
On Fri, 19 Apr 2024 05:18:51 GMT, Laurence Cable wrote: > I think (I am agreeing with you Severin) that the goal of the heuristic is to > inform the JVM (and any associated serviceability tools) that the JVM is in a > resource constrained/managed execution context... "resource constrained"

Re: RFR: 8330534: Update nsk/jdwp tests to use driver instead of othervm

2024-04-22 Thread Andrey Turbanov
On Wed, 17 Apr 2024 20:19:49 GMT, Leonid Mesnik wrote: > The jdwp tests use debugger and debugee. There is no goal to execute debugger > part with all VM flags, they are needed to be used with debugee VM only. > The change is all tests is to don't use System.exit() and use 'driver' > instead

Re: RFR: 8330694: Rename 'HeapRegion' to 'G1HeapRegion' [v3]

2024-04-22 Thread Thomas Schatzl
On Sat, 20 Apr 2024 08:44:45 GMT, Lei Zaakjyu wrote: >> follow up 8267941 > > Lei Zaakjyu has updated the pull request incrementally with one additional > commit since the last revision: > > also tidy up Indentation issues. I will run the higher tier SA tests just for verification. There