Integrated: 8332327: Return _methods_jmethod_ids field back in VMStructs

2024-05-17 Thread Andrei Pangin
On Wed, 15 May 2024 21:12:03 GMT, Andrei Pangin wrote: > The fix for [JDK-8313332](https://bugs.openjdk.org/browse/JDK-8313332) has > [removed](https://github.com/openjdk/jdk/commit/21867c929a2f2c961148f2cd1e79d672ac278d27#diff-7d448441e80a0b784429d5d8aee343fcb131c224b8ec7bc70ea636f78d

Re: RFR: 8332327: Return _methods_jmethod_ids field back in VMStructs

2024-05-15 Thread Andrei Pangin
On Wed, 15 May 2024 21:12:03 GMT, Andrei Pangin wrote: > The fix for [JDK-8313332](https://bugs.openjdk.org/browse/JDK-8313332) has > [removed](https://github.com/openjdk/jdk/commit/21867c929a2f2c961148f2cd1e79d672ac278d27#diff-7d448441e80a0b784429d5d8aee343fcb131c224b8ec7bc70ea636f78d

Integrated: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling

2024-04-01 Thread Andrei Pangin
On Wed, 27 Mar 2024 01:02:41 GMT, Andrei Pangin wrote: > This fix makes `AsyncGetCallTrace` reentrant and async-signal-safe. > Reentrancy is required in the cases when two or more profiling engines are > running at the same time, e.g., when CPU and Wall clock profilers work &

Re: RFR: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling [v2]

2024-03-29 Thread Andrei Pangin
On Fri, 29 Mar 2024 05:55:01 GMT, Serguei Spitsyn wrote: >> Andrei Pangin has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Rephrased comment about AsyncGetCallTrace reentrancy > > src/hotspot/share/runtime/

Re: RFR: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling [v2]

2024-03-29 Thread Andrei Pangin
n the middle of > getting a stack trace. > > Tested with async-profiler: > > java > -agentpath:/path/to/libasyncProfiler.so=start,event=cpu,interval=1ms,wall=1ms,file=profile.jfr Andrei Pangin has updated the pull request incrementally with one additional commit since the last

Re: RFR: 8329103: assert(!thread->in_asgct()) failed during multi-mode profiling

2024-03-28 Thread Andrei Pangin
On Thu, 28 Mar 2024 13:09:10 GMT, David Holmes wrote: >> This fix makes `AsyncGetCallTrace` reentrant and async-signal-safe. >> Reentrancy is required in the cases when two or more profiling engines are >> running at the same time, e.g., when CPU and Wall clock profilers work >> together and

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v19]

2023-12-27 Thread Andrei Pangin
On Fri, 22 Dec 2023 09:33:06 GMT, Dmitry Chuyko wrote: >> Compiler Control (https://openjdk.org/jeps/165) provides method-context >> dependent control of the JVM compilers (C1 and C2). The active directive >> stack is built from the directive files passed with the >>

Re: RFR: 8309271: A way to align already compiled methods with compiler directives [v15]

2023-12-19 Thread Andrei Pangin
On Thu, 14 Dec 2023 15:29:06 GMT, Dmitry Chuyko wrote: >> Compiler Control (https://openjdk.org/jeps/165) provides method-context >> dependent control of the JVM compilers (C1 and C2). The active directive >> stack is built from the directive files passed with the >>

Re: RFR: 8309271: A way to align already compiled methods with compiler directives

2023-06-12 Thread Andrei Pangin
On Wed, 24 May 2023 00:38:27 GMT, Dmitry Chuyko wrote: > Compiler Control (https://openjdk.org/jeps/165) provides method-context > dependent control of the JVM compilers (C1 and C2). The active directive > stack is built from the directive files passed with the > `-XX:CompilerDirectivesFile`

Re: RFR: 8307478: Implementation of Prepare to Restrict The Dynamic Loading of Agents [v5]

2023-05-26 Thread Andrei Pangin
On Tue, 23 May 2023 15:32:58 GMT, Alan Bateman wrote: >> This is the implementation for JEP 451. There are two parts to this: >> >> 1. A multi-line warning is printed when a JVM TI or Java agent is loaded >> into a running VM. For JVM TI, the message is printed to stderr from >>

Re: New candidate JEP: 451: Prepare to Disallow the Dynamic Loading of Agents

2023-05-19 Thread Andrei Pangin
2) taking mentioned use cases into account; 3) providing read-to-use alternatives; 4) matching the plan with the goals. Thank you, Andrei Pangin пт, 19 мая 2023 г. в 15:44, Ron Pressler : > Because the discussion of this JEP has veered in many directions, let me > summarise where w

Re: Disallowing the dynamic loading of agents by default

2023-03-19 Thread Andrei Pangin
Hi all, Serviceability has been one of the biggest Java strengths, but the proposed change is going to have a large negative impact on it. Disallowing dynamic agents by default means it will no longer be possible to attach a profiler to a running app in runtime. JFR cannot close this gap due to