Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-04-02 Thread Andrew Dinn
On Thu, 28 Mar 2024 17:15:26 GMT, Kevin Walls wrote: >>> In my opinion, UnlockDiagnosticVMOptions is not a good enough safeguard >>> since it guards a whole swathe of switches that we may instruct the >>> customer to enable. Once enabled, my experience is that >>> UnlockDiagnosticVMOptions

Re: RFR: 8318026: jcmd should provide access to detailed JVM object information [v9]

2024-03-28 Thread Andrew Dinn
On Wed, 27 Mar 2024 18:28:07 GMT, Kevin Walls wrote: >> It looks like the test only inspects a thread and a java object. Perhaps you >> could add tests for additional VM objects. Maybe grab a frame PC from a >> thread stack trace. > >> It looks like the test only inspects a thread and a java

Re: RFR: 8200559: Java agents doing instrumentation need a means to define auxiliary classes [v2]

2024-01-29 Thread Andrew Dinn
On Sat, 27 Jan 2024 05:11:28 GMT, Alexander Kriegisch wrote: > Bytecode transformation should not be rocket science, but it progressively is > developing in that direction. Hmm? Bytecode transformation of the JDK runtime implementation is a lot more complicated than your comments seem to

Re: RFR: 8200559: Java agents doing instrumentation need a means to define auxiliary classes [v2]

2024-01-29 Thread Andrew Dinn
On Sun, 28 Jan 2024 22:33:01 GMT, Rafael Winterhalter wrote: > What stops people from supplying a fake instance? Wouldn't you need to "test > run" the instance first? Not necessarily. When the generated API implementation relies on the capabilities of class `Instrumentation` -- such as

Re: RFR: 8200559: Java agents doing instrumentation need a means to define auxiliary classes [v2]

2024-01-26 Thread Andrew Dinn
On Fri, 26 Jan 2024 10:17:16 GMT, Alexander Kriegisch wrote: >>> @AlanBateman, the AspectJ weaving agent creates an auxiliary class to >>> implement an "around" advice for a method, i.e. a method execution is >>> intercepted and the user has options to do something before optionally >>>

Re: RFR: 8200559: Java agents doing instrumentation need a means to define auxiliary classes [v2]

2024-01-25 Thread Andrew Dinn
On Thu, 25 Jan 2024 12:16:13 GMT, Rafael Winterhalter wrote: > Requiring such an API opens the module to anybody, though, punching a hole > into the module boundary. How so? Any module created to print Lookups can easily rely on a shared secret to secure the API. Byteman employs a non-null

Re: RFR: 8200559: Java agents doing instrumentation need a means to define auxiliary classes [v2]

2024-01-25 Thread Andrew Dinn
On Thu, 25 Jan 2024 06:39:56 GMT, Alexander Kriegisch wrote: >> Setting '-javaagent' is mainly an operations problem. Many build tools do >> not allow to declare a test dependency this way as the life cycles are not >> laid out for it, the internal repository location might be machine >>

Re: JEP draft: Integrity and Strong Encapsulation

2023-05-22 Thread Andrew Dinn
of encapsulation that ignores thread and process encapsulation and the need for mechanisms to selectively bypass it at runtime is going to omit important considerations that many readers of this JEP will be highly aware of. regards, Andrew Dinn --- Red Hat Distinguished Engineer Red Ha

Re: New candidate JEP: 451: Prepare to Disallow the Dynamic Loading of Agents

2023-05-14 Thread Andrew Dinn
Revenger's tragedy. The more you spout guff like the text cited above the more you will deter anyone who actually contributes to this project from paying serious attention to whatever legitimate criticisms you might have to offer. regards, Andrew Dinn --- Red Hat Distinguished Engineer Red

Re: RFR: JDK-8307331: Correctly update line maps when class redefine rewrites bytecodes

2023-05-09 Thread Andrew Dinn
On Tue, 9 May 2023 13:16:00 GMT, Thomas Stuefe wrote: >> This small change ensures that repeated bytecode rewrites necessitated by >> class pool index updates are applied cumulatively when updating the method >> line number table. The current code applies each change to the original >> table

Re: RFR: JDK-8307331: Correctly update line maps when class redefine rewrites bytecodes

2023-05-09 Thread Andrew Dinn
On Tue, 9 May 2023 09:57:55 GMT, David Holmes wrote: >> This small change ensures that repeated bytecode rewrites necessitated by >> class pool index updates are applied cumulatively when updating the method >> line number table. The current code applies each change to the original >> table

Re: RFR: JDK-8307331: Correctly update line maps when class redefine rewrites bytecodes

2023-05-09 Thread Andrew Dinn
On Tue, 9 May 2023 08:47:38 GMT, Serguei Spitsyn wrote: >> @dholmes-ora Apologies for jumping the gun. Do I need to obtain a second, >> retrospective review? > >> Do I need to obtain a second, retrospective review? > > Yes, Serviceability changes need two reviews unless they are not trivial.

Re: RFR: JDK-8307331: Correctly update line maps when class redefine rewrites bytecodes

2023-05-09 Thread Andrew Dinn
On Mon, 8 May 2023 06:57:09 GMT, David Holmes wrote: >> @sspitsyn Thanks for the review. > > @adinn Please wait for two reviews for hotspot changes unless designated as > trivial. Thanks. @dholmes-ora Apologies for jumping the gun. Do I need to obtain a second, retrospective review?

Re: RFR: JDK-8307331: Correctly update line maps when class redefine rewrites bytecodes

2023-05-05 Thread Andrew Dinn
On Fri, 5 May 2023 03:33:51 GMT, Serguei Spitsyn wrote: >> This small change ensures that repeated bytecode rewrites necessitated by >> class pool index updates are applied cumulatively when updating the method >> line number table. The current code applies each change to the original >>

Re: RFR: JDK-8307331: Correctly update line maps when class redefine rewrites bytecodes

2023-05-05 Thread Andrew Dinn
On Thu, 4 May 2023 17:17:19 GMT, Andrew Dinn wrote: >> This small change ensures that repeated bytecode rewrites necessitated by >> class pool index updates are applied cumulatively when updating the method >> line number table. The current code applies each change to the

Integrated: JDK-8307331: Correctly update line maps when class redefine rewrites bytecodes

2023-05-05 Thread Andrew Dinn
On Thu, 4 May 2023 09:26:33 GMT, Andrew Dinn wrote: > This small change ensures that repeated bytecode rewrites necessitated by > class pool index updates are applied cumulatively when updating the method > line number table. The current code applies each change to the original table

Re: RFR: JDK-8307331: Correctly update line maps when class redefine rewrites bytecodes

2023-05-04 Thread Andrew Dinn
On Thu, 4 May 2023 09:26:33 GMT, Andrew Dinn wrote: > This small change ensures that repeated bytecode rewrites necessitated by > class pool index updates are applied cumulatively when updating the method > line number table. The current code applies each change to the original table

Re: [External] : Re: Disallowing the dynamic loading of agents by default

2023-03-29 Thread Andrew Dinn
a computer breaks down not at the point where expert remedy is needed but where it is sought and paid for. regards, Andrew Dinn --- Red Hat Distinguished Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("

Re: [External] : Re: Disallowing the dynamic loading of agents by default

2023-03-28 Thread Andrew Dinn
have not made this possible, worse to claim that Java has actually poisoned the well for desktop users, is a ridiculous and ignorant assertion. regards, Andrew Dinn --- Red Hat Distinguished Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903

Re: [External] : Re: Disallowing the dynamic loading of agents by default

2023-03-27 Thread Andrew Dinn
has to depend on details of the change, specifically what the effect might be on users. regards, Andrew Dinn --- Red Hat Distinguished Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill

Re: [External] : Re: Disallowing the dynamic loading of agents by default

2023-03-27 Thread Andrew Dinn
Sorry, let me correct some of my mangled grammar On 27/03/2023 17:06, Andrew Dinn wrote: On 27/03/2023 13:37, Volker Simonis wrote: The JEP itself is rather ambitious because I noticed that most of the strong encapsulation JEPs lacked a substantial motivation section (largely because they had

Re: [External] : Re: Disallowing the dynamic loading of agents by default

2023-03-27 Thread Andrew Dinn
or its success. Sacrificing some of them or making their usage increasingly expensive requires a broader discussion in the community and shouldn't happen "under the hood". I'm happy to continue that discussion on the actual JEP proposal. Amen to that. regards, Andrew Dinn ---

Re: Disallowing the dynamic loading of agents by default

2023-03-24 Thread Andrew Dinn
imply a need for the JEP to be targeted to a later release. regards, Andrew Dinn --- Red Hat Distinguished Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill

Re: RFR: 8257967: JFR: Events for loaded agents [v10]

2023-03-13 Thread Andrew Dinn
On Mon, 13 Mar 2023 06:29:11 GMT, David Holmes wrote: >> Markus Grönlund has updated the pull request incrementally with one >> additional commit since the last revision: >> >> more cleanup > > src/hotspot/share/prims/agentList.cpp line 64: > >> 62: void AgentList::add_xrun(const char*

Re: RFR: 8257967: JFR: Events for loaded agents [v10]

2023-03-13 Thread Andrew Dinn
On Fri, 10 Mar 2023 10:43:23 GMT, Markus Grönlund wrote: >> Greetings, >> >> We are adding support to let JFR report on Agents. >> >> Design >> >> An Agent is a library that uses any instrumentation or profiling APIs. Most >> agents are started and initialized on the command line, but

Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-03-09 Thread Andrew Dinn
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Wed, 8 Mar 2023 18:56:55 GMT, Markus Grönlund

Re: RFR: 8257967: JFR: Events for loaded agents [v4]

2023-03-09 Thread Andrew Dinn
The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. -- On Wed, 8 Mar 2023 23:28:52 GMT, Markus Grönlund