On Wed, 15 May 2024 21:12:03 GMT, Andrei Pangin wrote:
> The fix for [JDK-8313332](https://bugs.openjdk.org/browse/JDK-8313332) has
> [removed](https://github.com/openjdk/jdk/commit/21867c929a2f2c961148f2cd1e79d672ac278d27#diff-7d448441e80a0b784429d5d8aee343fcb131c224b8ec7bc70ea636f78d561ecd
>
On Fri, 19 Apr 2024 01:16:46 GMT, Alex Menkov wrote:
> The fix deprecates -XX:+UseNotificationThread VM option
>
> Testing: tier1-3,hs-tier5-svc
Looks good. Thank you for doing this.
-
Marked as reviewed by coleenp (Reviewer).
PR Review:
On Thu, 18 Apr 2024 16:22:31 GMT, Matias Saavedra Silva
wrote:
>> Before [JDK-8307190](https://bugs.openjdk.org/browse/JDK-8307190),
>> [JDK-8309673](https://bugs.openjdk.org/browse/JDK-8309673), and
>> [JDK-8301995](https://bugs.openjdk.org/browse/JDK-8301995), invokedynamic
>> operands
On Wed, 17 Apr 2024 15:26:52 GMT, Matias Saavedra Silva
wrote:
> Before [JDK-8307190](https://bugs.openjdk.org/browse/JDK-8307190),
> [JDK-8309673](https://bugs.openjdk.org/browse/JDK-8309673), and
> [JDK-8301995](https://bugs.openjdk.org/browse/JDK-8301995), invokedynamic
> operands needed
On Tue, 16 Apr 2024 18:54:40 GMT, Vladimir Kozlov wrote:
>> src/hotspot/share/code/codeBlob.cpp line 106:
>>
>>> 104:
>>> 105: // Simple CodeBlob used for simple BufferBlob.
>>> 106: CodeBlob::CodeBlob(const char* name, CodeBlobKind kind, int size,
>>> uint16_t header_size) :
>>
>> Just a
On Tue, 16 Apr 2024 03:31:25 GMT, Vladimir Kozlov wrote:
>> This is part of changes which try to reduce size of `nmethod` and `codeblob`
>> data vs code in CodeCache.
>> These changes reduced size of `nmethod` header from 288 to 232 bytes. From
>> 304 to 248 in optimized VM:
>>
>> Statistics
On Thu, 4 Apr 2024 12:19:03 GMT, Stefan Karlsson wrote:
>> I'm not even sure what they want to say, really. Should be good to remove,
>> and if anybody can make sense of it, record an issue in the bug-tracker?
>
> OK. I removed the %%%. I'll wait a little bit to see if someone else wants to
>
On Thu, 4 Apr 2024 12:18:24 GMT, Stefan Karlsson wrote:
>> We have a few places that uses the terms `KlassObj` and `klassOop` when
>> referring to Klasses. This is old code from before the PermGen removal, when
>> Klasses also were Java objects.
>>
>> These names tripped me up when I was
On Fri, 29 Mar 2024 15:25:48 GMT, Coleen Phillimore wrote:
> This change simplifies the code that grows the jmethodID cache in
> InstanceKlass. Instead of lazily, when there's a rare request for a
> jmethodID for an obsolete method, the jmethodID cache is grown during the
> Red
On Thu, 4 Apr 2024 00:07:34 GMT, Coleen Phillimore wrote:
>> This change simplifies the code that grows the jmethodID cache in
>> InstanceKlass. Instead of lazily, when there's a rare request for a
>> jmethodID for an obsolete method, the jmethodID cac
On Wed, 3 Apr 2024 23:50:47 GMT, Daniel D. Daugherty wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix spacing and punctuation. make log_info into log_debug.
>
> src/hotspo
java/lang/instrument tests (in case
> they're not in tier1-4).
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Two more.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18549/files
- new: https://git.op
On Wed, 3 Apr 2024 13:25:36 GMT, Coleen Phillimore wrote:
>> This change simplifies the code that grows the jmethodID cache in
>> InstanceKlass. Instead of lazily, when there's a rare request for a
>> jmethodID for an obsolete method, the jmethodID cac
On Wed, 3 Apr 2024 20:46:55 GMT, Daniel D. Daugherty wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refactoring suggested by Serguei.
>
> src/hotspot/share/oops/method.cpp l
java/lang/instrument tests (in case
> they're not in tier1-4).
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Fix spacing and punctuation. make log_info into log_debug.
-
Changes:
- all: https://git.openjdk.or
On Wed, 3 Apr 2024 12:42:30 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/oops/instanceKlass.cpp line 2335:
>>
>>> 2333: jmethodID new_id = Method::make_jmethod_id(class_loader_data(),
>>> method);
>>> 2334: Atomic::release_store([id
java/lang/instrument tests (in case
> they're not in tier1-4).
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Refactoring suggested by Serguei.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18549/files
- ne
On Wed, 3 Apr 2024 02:41:06 GMT, Serguei Spitsyn wrote:
>> This change simplifies the code that grows the jmethodID cache in
>> InstanceKlass. Instead of lazily, when there's a rare request for a
>> jmethodID for an obsolete method, the jmethodID cache is grown during the
>> RedefineClasses
On Thu, 28 Mar 2024 22:53:22 GMT, Coleen Phillimore wrote:
> Remove the notproduct distinction for command line options, rather than
> trying to wrestle the macros to fix the bug that they've been treated as
> develop options for some time now. This simplifies the command li
On Tue, 2 Apr 2024 19:47:23 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the c
On Tue, 2 Apr 2024 19:47:23 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the c
e platforms. Also built shenandoah.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Remove redundant test case.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18541/files
- new: https://git.openjdk.org/jd
On Tue, 2 Apr 2024 17:58:16 GMT, Kim Barrett wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix a couple issues pointed out by Stefank.
>
> test/hotspot/jtreg/runtime/CommandLin
On Thu, 28 Mar 2024 22:12:49 GMT, Alex Menkov wrote:
> PreserveAllAnnotations option causes class file parser to preserve
> RuntimeInvisibleAnnotations so VM considers them as RuntimeVisibleAnnotations.
> For class retransformation JvmtiClassFileReconstituter restores all
> annotations as
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the c
On Tue, 2 Apr 2024 17:25:12 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the c
e platforms. Also built shenandoah.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Fix a couple issues pointed out by Stefank.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18541/files
- new: https://g
On Tue, 2 Apr 2024 16:49:19 GMT, Stefan Karlsson wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Clean up notproduct from tests.
>
> src/hotspot/share/runtime/arguments.cpp line
On Tue, 2 Apr 2024 16:24:19 GMT, Coleen Phillimore wrote:
>> Remove the notproduct distinction for command line options, rather than
>> trying to wrestle the macros to fix the bug that they've been treated as
>> develop options for some time now. This simplifies the c
On Thu, 28 Mar 2024 22:53:22 GMT, Coleen Phillimore wrote:
> Remove the notproduct distinction for command line options, rather than
> trying to wrestle the macros to fix the bug that they've been treated as
> develop options for some time now. This simplifies the command li
e platforms. Also built shenandoah.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Clean up notproduct from tests.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18541/files
- new: https://git.openjdk.
Remove the notproduct distinction for command line options, rather than trying
to wrestle the macros to fix the bug that they've been treated as develop
options for some time now. This simplifies the command line option macros.
Tested with tier1-4, tier1 on Oracle platforms. Also built
On Fri, 29 Mar 2024 15:25:48 GMT, Coleen Phillimore wrote:
> This change simplifies the code that grows the jmethodID cache in
> InstanceKlass. Instead of lazily, when there's a rare request for a
> jmethodID for an obsolete method, the jmethodID cache is grown during the
> Red
This change simplifies the code that grows the jmethodID cache in
InstanceKlass. Instead of lazily, when there's a rare request for a jmethodID
for an obsolete method, the jmethodID cache is grown during the RedefineClasses
safepoint. The InstanceKlass's jmethodID cache is lazily allocated
On Thu, 14 Mar 2024 22:09:55 GMT, Alex Menkov wrote:
>> It does not matter what the `ClassFileParser` does.
>>
>>> ` JvmtiClassFileReconstituter` performs the reverse operation.
>>
>> True. It should know how to put the `attribute_count` value into the class
>> file but it does not need to
On Thu, 21 Mar 2024 18:10:49 GMT, Alex Menkov wrote:
>> RecordComponent class has _attributes_count field.
>> The only user of the field is JvmtiClassFileReconstituter. Incorrect value
>> of the field causes producing incorrect data for Record attribute.
>> Parsing Record attribute
On Fri, 8 Mar 2024 06:17:06 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Missed a word.
>> - David's comment fixes.
>
> src/hotspot/share/prim
On Tue, 6 Feb 2024 22:59:04 GMT, Coleen Phillimore wrote:
> This change creates a new sort of native recursive lock that can be held
> during JNI and Java calls, which can be used for synchronization while
> creating objArrayKlasses at runtime.
>
> Passes tier1-7.
This pull
On Thu, 7 Mar 2024 13:21:09 GMT, Coleen Phillimore wrote:
>> This change creates a new sort of native recursive lock that can be held
>> during JNI and Java calls, which can be used for synchronization while
>> creating objArrayKlasses at runtime.
>>
>> Passes
On Thu, 7 Mar 2024 01:44:22 GMT, David Holmes wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Dean's comments.
>
> src/hotspot/share/oops/instanceKlass.cpp line 1552:
>
On Thu, 7 Mar 2024 01:31:09 GMT, Coleen Phillimore wrote:
>> Semaphore seems simpler/cleaner and ready to use.
>
> It's such a rare race and unusual condition that we could execute more Java
> code, that I started out with just a shared bit. Then David suggested a
> se
On Thu, 7 Mar 2024 01:38:56 GMT, Coleen Phillimore wrote:
>> This change creates a new sort of native recursive lock that can be held
>> during JNI and Java calls, which can be used for synchronization while
>> creating objArrayKlasses at runtime.
>>
>> Passes
> This change creates a new sort of native recursive lock that can be held
> during JNI and Java calls, which can be used for synchronization while
> creating objArrayKlasses at runtime.
>
> Passes tier1-7.
Coleen Phillimore has updated the pull request incrementally with
On Thu, 7 Mar 2024 00:54:30 GMT, David Holmes wrote:
>> OK. It's a good thing HotSpot doesn't need to worry about
>> priority-inheritance for mutexes.
>
> Semaphore seems simpler/cleaner and ready to use.
It's such a rare race and unusual condition that we could execute more Java
code, that
On Thu, 7 Mar 2024 00:18:53 GMT, Dean Long wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Dean's comments.
>
> src/hotspot/share/oops/arrayKlass.cpp line 135:
>
>> 1
On Thu, 7 Mar 2024 01:35:45 GMT, Coleen Phillimore wrote:
>> This change creates a new sort of native recursive lock that can be held
>> during JNI and Java calls, which can be used for synchronization while
>> creating objArrayKlasses at runtime.
>>
>> Passes
> This change creates a new sort of native recursive lock that can be held
> during JNI and Java calls, which can be used for synchronization while
> creating objArrayKlasses at runtime.
>
> Passes tier1-7.
Coleen Phillimore has updated the pull request incrementally with
On Wed, 6 Mar 2024 23:09:34 GMT, Dean Long wrote:
>> This change creates a new sort of native recursive lock that can be held
>> during JNI and Java calls, which can be used for synchronization while
>> creating objArrayKlasses at runtime.
>>
>> Passes tier1-7.
>
>
On Tue, 5 Mar 2024 23:13:30 GMT, Dean Long wrote:
>> This change creates a new sort of native recursive lock that can be held
>> during JNI and Java calls, which can be used for synchronization while
>> creating objArrayKlasses at runtime.
>>
>> Passes tier1-7.
>
> Is the caller always a
On Tue, 13 Feb 2024 02:07:54 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/oops/arrayKlass.cpp line 141:
>>
>>> 139: ObjArrayKlass::allocate_objArray_klass(class_loader_data(),
>>> dim + 1, this, CHECK_NULL);
>>> 140: // use 'relea
On Thu, 8 Feb 2024 21:30:48 GMT, David Holmes wrote:
>> This change creates a new sort of native recursive lock that can be held
>> during JNI and Java calls, which can be used for synchronization while
>> creating objArrayKlasses at runtime.
>>
>> Passes tier1-4.
>
>
On Tue, 6 Feb 2024 22:59:04 GMT, Coleen Phillimore wrote:
> This change creates a new sort of native recursive lock that can be held
> during JNI and Java calls, which can be used for synchronization while
> creating objArrayKlasses at runtime.
>
> Passes tier1-4.
Tha
This change creates a new sort of native recursive lock that can be held during
JNI and Java calls, which can be used for synchronization while creating
objArrayKlasses at runtime.
Passes tier1-4.
-
Commit messages:
- 8308745: ObjArrayKlass::allocate_objArray_klass may call into
On Wed, 28 Feb 2024 03:58:39 GMT, Guoxiong Li wrote:
>> Please review this change that renames some test .h files to .hpp. These
>> files contain C++ code and should be named accordingly. Some of them contain
>> uses of NULL, which we change to nullptr.
>>
>> The renamed files are:
>>
>>
On Wed, 28 Feb 2024 01:18:50 GMT, Kim Barrett wrote:
> Please review this change that renames some test .h files to .hpp. These
> files contain C++ code and should be named accordingly. Some of them contain
> uses of NULL, which we change to nullptr.
>
> The renamed files are:
>
>
On Wed, 28 Feb 2024 14:13:58 GMT, Coleen Phillimore wrote:
>> Please review this change that renames some test .h files to .hpp. These
>> files contain C++ code and should be named accordingly. Some of them contain
>> uses of NULL, which we change to nullptr.
>&g
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
On Fri, 23 Feb 2024 04:29:47 GMT, Kim Barrett wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/jvmti/Deallocate/dealloc001/dealloc001.cpp
>> line 28:
>>
>>> 26: #include "jvmti.h"
>>> 27: #include "agent_common.hpp"
>>> 28: #include "JVMTITools.h"
>>
>> Why don't you change all of these together?
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
On Fri, 16 Feb 2024 21:42:18 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/aod/jvmti_aod.h to
> jvmti_aod.hpp,
> and replace uses of NULL in the file.
>
> The #include updates were performed mechanically, and
On Thu, 15 Feb 2024 08:46:43 GMT, Serguei Spitsyn wrote:
> This enhancement replaces uses of NULL with nullptr in the XML-description
> files for JVMTI. These are the files `hotsport/share/prims/jvmti.xml` and
> `hotspot/share/prims/jvmti*.xls`.
>
> The following files are auto-generated from
On Mon, 12 Feb 2024 12:43:09 GMT, Magnus Ihse Bursie wrote:
> There are several places in hotspot where an internal function should have
> been declared static, but isn't.
>
> These were discovered by trying to use the gcc option
> `-Wmissing-declarations` and the corresponding clang option
On Fri, 9 Feb 2024 20:42:14 GMT, Alex Menkov wrote:
>> The fix adds check that merged constant pool does not overflow u2 (two-byte
>> unsigned).
>> The check is added after merging `the_class` and `scratch_class` constant
>> pools, but before rewriting constant pool references.
>>
>> testing:
On Fri, 9 Feb 2024 02:34:26 GMT, Leonid Mesnik wrote:
>> The fix adds check that merged constant pool does not overflow u2 (two-byte
>> unsigned).
>> The check is added after merging `the_class` and `scratch_class` constant
>> pools, but before rewriting constant pool references.
>>
>>
On Wed, 7 Feb 2024 20:53:53 GMT, Alex Menkov wrote:
> The fix adds check that merged constant pool does not overflow u2 (two-byte
> unsigned).
> The check is added after merging `the_class` and `scratch_class` constant
> pools, but before rewriting constant pool references.
>
> testing:
> -
On Wed, 7 Feb 2024 20:48:18 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/native/nsk_list.h to nsk_list.hpp.
>
> Testing: mach5 tier1
> Note that build would fail if #include updates were incorrect or incomplete.
On Tue, 6 Feb 2024 22:08:18 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/native/native_thread.h
> to native_thread.hpp. and replaces uses of NULL in that file.
>
> Testing: mach5 tier1
Agree this looks trivial, if
On Wed, 31 Jan 2024 18:57:23 GMT, Coleen Phillimore wrote:
> This change uses a claim token to allocate multi dimensional arrays rather
> than holding MultiArray_lock around metaspace allocation. We can't hold a
> mutex around metaspace allocation because it can create an O
On Thu, 1 Feb 2024 05:22:24 GMT, David Holmes wrote:
>> This change uses a claim token to allocate multi dimensional arrays rather
>> than holding MultiArray_lock around metaspace allocation. We can't hold a
>> mutex around metaspace allocation because it can create an OOM object and it
>>
This change uses a claim token to allocate multi dimensional arrays rather than
holding MultiArray_lock around metaspace allocation. We can't hold a mutex
around metaspace allocation because it can create an OOM object and it can also
call into JVMTI for a resource exhausted event. Also, we
On Fri, 26 Jan 2024 16:40:32 GMT, Coleen Phillimore wrote:
> This mechanically replaces NULL with nullptr in hpp/cpp native files in test
> native code. This didn't attempt to change NULL in comments to say null
> because nullptr is generally the right thing for the comment to say.
On Mon, 29 Jan 2024 13:47:10 GMT, Coleen Phillimore wrote:
>> This mechanically replaces NULL with nullptr in hpp/cpp native files in test
>> native code. This didn't attempt to change NULL in comments to say null
>> because nullptr is generally the right thing for
On Mon, 29 Jan 2024 13:47:10 GMT, Coleen Phillimore wrote:
>> This mechanically replaces NULL with nullptr in hpp/cpp native files in test
>> native code. This didn't attempt to change NULL in comments to say null
>> because nullptr is generally the right thing for
; rather than "nullptr" in strings. Any
> changes for "nullptr" to "null" in comments can be changed in a future RFE in
> a smaller patch. I didn't see any when it was scrolling by to make my script
> more complicated.
>
> Ran tier1-4 testing.
Co
; rather than "nullptr" in strings. Any
> changes for "nullptr" to "null" in comments can be changed in a future RFE in
> a smaller patch. I didn't see any when it was scrolling by to make my script
> more complicated.
>
> Ran tier1-4 testing.
Co
see any when it was scrolling by to
> make my script more complicated.
>
> Ran tier1-4 testing.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Fix nullptr only contained in strings.
-
Changes:
- all: https:
see any when it was scrolling by to
> make my script more complicated.
>
> Ran tier1-4 testing.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
Fix the comments to "null"
-
Changes:
- all: https:/
This mechanically replaces NULL with nullptr in hpp/cpp native files in test
native code. This didn't attempt to change NULL in comments or strings to just
null. If you run into this and it bothers you after this push, you can change
it in a smaller patch. I didn't see any when it was
On Mon, 22 Jan 2024 23:37:35 GMT, John R Rose wrote:
>> src/hotspot/share/runtime/globals.hpp line 2013:
>>
>>> 2011: "Profile exception handlers")
>>> \
>>> 2012:
>>> \
On Mon, 22 Jan 2024 21:26:41 GMT, Volker Simonis wrote:
>> Currently we don't record dependencies on redefined methods (i.e.
>> `evol_method` dependencies) in JIT compiled methods if none of the
>> `can_redefine_classes`, `can_retransform_classes` or
>> `can_generate_breakpoint_events` JVMTI
On Sat, 20 Jan 2024 19:48:07 GMT, Volker Simonis wrote:
> Currently we don't record dependencies on redefined methods (i.e.
> `evol_method` dependencies) in JIT compiled methods if none of the
> `can_redefine_classes`, `can_retransform_classes` or
> `can_generate_breakpoint_events` JVMTI
On Wed, 17 Jan 2024 00:14:58 GMT, Jiangli Zhou wrote:
> Please review this PR with a simple solution for resolving duplicate `Thread`
> symbol issue. In https://github.com/openjdk/jdk/pull/14808 comments, there
> was an alternative suggestion to redefine the symbol at build time, such as
>
On Wed, 17 Jan 2024 00:14:58 GMT, Jiangli Zhou wrote:
> Please review this PR with a simple solution for resolving duplicate `Thread`
> symbol issue. In https://github.com/openjdk/jdk/pull/14808 comments, there
> was an alternative suggestion to redefine the symbol at build time, such as
>
On Mon, 4 Dec 2023 11:11:27 GMT, Thomas Stuefe wrote:
> Okay so why does this happen and is it a reasonable thing to be happening? On
> the surface it sounds wrong to deallocate anything associated with a live
> classloader.
If we didn't deallocate these old methods, there would be a memory
On Wed, 29 Nov 2023 11:49:31 GMT, Jaroslav Bachorik
wrote:
>> Please, review this fix for a corner case handling of `jmethodID` values.
>>
>> The issue is related to the interplay between `jmethodID` values and method
>> redefinitions. Each `jmethodID` value is effectively a pointer to a
On Thu, 30 Nov 2023 06:06:48 GMT, David Holmes wrote:
>> Thanks everyone involved in reviewing this PR! You were awesome and helped
>> me drive the PR to better place than it started!
>
> @jbachorik this should not have been integrated yet! You only have one
> review not the required two for
On Wed, 29 Nov 2023 15:14:59 GMT, Jaroslav Bachorik
wrote:
>> I am going to take a look.
>
> Ok, I found it.
> The reason for the jmethodID not being cleaned out is this assignment of a
> new jmethodID to obsolete methods -
>
On Wed, 29 Nov 2023 11:45:53 GMT, Jaroslav Bachorik
wrote:
>> src/hotspot/share/oops/instanceKlass.cpp line 4236:
>>
>>> 4234: if (method != nullptr) {
>>> 4235: method->clear_jmethod_id();
>>> 4236: }
>>
>> This loops through the methods in the InstanceKlass that was a previous
On Mon, 27 Nov 2023 09:16:30 GMT, Jaroslav Bachorik
wrote:
>> Please, review this fix for a corner case handling of `jmethodID` values.
>>
>> The issue is related to the interplay between `jmethodID` values and method
>> redefinitions. Each `jmethodID` value is effectively a pointer to a
On Thu, 16 Nov 2023 03:11:04 GMT, Jaroslav Bachorik
wrote:
>> src/hotspot/share/oops/method.cpp line 2277:
>>
>>> 2275: }
>>> 2276: }
>>> 2277:
>>
>> Can this race with redefinition?
>
> The cleanup of previous versions is executed in VM_Operation at a safepoint -
> therefore we should be
On Sat, 18 Nov 2023 00:23:44 GMT, Jaroslav Bachorik
wrote:
>> src/hotspot/share/oops/instanceKlass.cpp line 541:
>>
>>> 539: // The previous version will point to them so they're not
>>> totally dangling
>>> 540: assert (!method->on_stack(), "shouldn't be called with methods
>>>
On Tue, 14 Nov 2023 17:56:09 GMT, Jaroslav Bachorik
wrote:
> Please, review this fix for a corner case handling of `jmethodID` values.
>
> The issue is related to the interplay between `jmethodID` values and method
> redefinitions. Each `jmethodID` value is effectively a pointer to a `Method`
On Tue, 14 Nov 2023 17:56:09 GMT, Jaroslav Bachorik
wrote:
> Please, review this fix for a corner case handling of `jmethodID` values.
>
> The issue is related to the interplay between `jmethodID` values and method
> redefinitions. Each `jmethodID` value is effectively a pointer to a `Method`
On Tue, 26 Sep 2023 12:47:42 GMT, Coleen Phillimore wrote:
> This change makes WeakHandle and OopHandle release null out the obj pointer,
> at the cost of making the release function non-const and some changes that
> propagated from that. This enables ObjectMonitor code to test
On Thu, 28 Sep 2023 01:46:37 GMT, David Holmes wrote:
> Hmmm okay - it seems fragile to have a psuedo-destructor in release().
I don't know what this comment means. It was fragile to *not* have release
destroy the _obj pointer, which was the cause of the original confusion and
problems while
On Tue, 26 Sep 2023 12:47:42 GMT, Coleen Phillimore wrote:
> This change makes WeakHandle and OopHandle release null out the obj pointer,
> at the cost of making the release function non-const and some changes that
> propagated from that. This enables ObjectMonitor code to test
On Tue, 26 Sep 2023 08:35:10 GMT, Afshin Zafari wrote:
>> 1. `ArrayAllocatorMallocLimit` is removed. The test cases that tested it
>> also are removed.
>> 2. `AllocArrayAllocator` instances are replaced with `MallocArrayAllocator`.
>> 3. The signature of `CHeapBitMap::free(ptr, size)` is kept
On Tue, 26 Sep 2023 12:47:42 GMT, Coleen Phillimore wrote:
> This change makes WeakHandle and OopHandle release null out the obj pointer,
> at the cost of making the release function non-const and some changes that
> propagated from that. This enables ObjectMonitor code to test
This change makes WeakHandle and OopHandle release null out the obj pointer, at
the cost of making the release function non-const and some changes that
propagated from that. This enables ObjectMonitor code to test for null to see
if the obj was already released, and seems like the right thing
On Fri, 22 Sep 2023 08:36:10 GMT, Jean-Philippe Bempel
wrote:
> increase Metaspace size and loop count to avoid OOME in nominal case
This seems okay if it helps the test run reliably. I don't know a better way
to test the absence of a memory leak. If this fails again, maybe we need to
1 - 100 of 419 matches
Mail list logo
