On Fri, 6 Oct 2023 19:24:03 GMT, Leonid Mesnik wrote:
> I marked tests
> sun/tools/jcmd/TestProcessHelper.java
> sun/tools/jinfo/JInfoTest.java
> as headless. They used different specific VM options and are not worth
> executing with other VM flags.
> And fixed
>
On Fri, 6 Oct 2023 20:47:22 GMT, Leonid Mesnik wrote:
> Test fixed to accept vm flags.
Looks good modulo comment from Kevin.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16081#pullrequestreview-1665736592
On Fri, 6 Oct 2023 19:58:13 GMT, Leonid Mesnik wrote:
> The test uses specific classpath, and jar and is intended to test modules. So
> I marked is as flagless,
Looks good.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review:
::post_vthread_start()` and
> `JvmtiExport::post_vthread_end()`
>
> Testing: ran mach5 tiers 1-6. All tests are passed.
Serguei Spitsyn has updated the pull request incrementally with one additional
commit since the last revision:
review: convert hidden thread check for vthread end int
On Tue, 10 Oct 2023 00:21:27 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: removed unneeded comment
>
> src/hotspot/share/prims/jvmtiExport.cpp l
On Tue, 10 Oct 2023 00:09:53 GMT, Chris Plummer wrote:
>> Good catch, thanks. Forgot to remove this comment. Fixed now.
>
> I still would like to know how we might end up with a hidden virtual thread.
A JavaThread can be hidden, not a virtual thread.
For such a case, I'd treat it that a carrier
::post_vthread_start()` and
> `JvmtiExport::post_vthread_end()`
>
> Testing: ran mach5 tiers 1-6. All tests are passed.
Serguei Spitsyn has updated the pull request incrementally with one additional
commit since the last revision:
review: removed unneeded comment
-
Changes
On Fri, 6 Oct 2023 22:59:56 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: convert check for is_hidden_from_external_view check() into assert
>
On Sat, 7 Oct 2023 06:31:08 GMT, Alan Bateman wrote:
>> src/hotspot/share/prims/jvmti.xml line 13044:
>>
>>> 13042:
>>> 13043: >> 13044: id="VirtualThreadStart"
>>> const="JVMTI_EVENT_VIRTUAL_THREAD_START" num="87" phase="start" since="21">
>>
>> Does "filtered" mean that the event
On Sun, 8 Oct 2023 21:51:42 GMT, Christoph Langer wrote:
> Add listings for linux-ppc64le and aix-ppc64 for the 4 already problem listed
> jstat tests.
Looks good.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review:
On Sat, 7 Oct 2023 00:49:09 GMT, Alex Menkov wrote:
>> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
>> stack references
>> The change:
>> - reorganize thread-related code/prepare it to use for unmounted vthreads:
>> - new ThreadDumper class caches stack frames,
On Thu, 5 Oct 2023 18:21:06 GMT, Leonid Mesnik wrote:
>> Updated test to use createTesJvm.
>> Removed internal timeout to not fail when Xcomp is used and also to get more
>> info if the test times out.,
>>
>> Tested by running tier1, hs-tier5 and executing test with various VM flags.
>
>
On Fri, 29 Sep 2023 02:20:10 GMT, Alex Menkov wrote:
>> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
>> stack references
>> The change:
>> - reorganize thread-related code/prepare it to use for unmounted vthreads:
>> - new ThreadDumper class caches stack frames,
::post_vthread_start()` and
> `JvmtiExport::post_vthread_end()`
>
> Testing: ran mach5 tiers 1-6. All tests are passed.
Serguei Spitsyn has updated the pull request incrementally with one additional
commit since the last revision:
review: convert check for is_hidden_from_external_view check()
On Wed, 4 Oct 2023 21:59:54 GMT, Leonid Mesnik wrote:
>> The JVMTI VirtualThreadStart events have to follow the ThreadStart events
>> pattern and so, should not be thread-filtered.
>> The fix includes:
>> - `jvmti.xml`: remov the attribute `filtered="thread"` in the
>> `VirtuallThreadStart`
On Wed, 4 Oct 2023 21:55:21 GMT, Leonid Mesnik wrote:
>> The JVMTI VirtualThreadStart events have to follow the ThreadStart events
>> pattern and so, should not be thread-filtered.
>> The fix includes:
>> - `jvmti.xml`: remov the attribute `filtered="thread"` in the
>> `VirtuallThreadStart`
On Wed, 4 Oct 2023 01:21:02 GMT, Alex Menkov wrote:
> used the same logic to split stack traces as
> ThreadStackTrace::dump_stack_at_safepoint
> (it was added with VT integration, it's used, for example by VM_ThreadDump).
> My understanding that enterSpecial is considered as a special frame
On Wed, 4 Oct 2023 01:23:01 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> misspell getRefererId for consistency
>
> src/hotspot/share/services/heapDumper.cpp l
On Fri, 29 Sep 2023 02:20:10 GMT, Alex Menkov wrote:
>> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
>> stack references
>> The change:
>> - reorganize thread-related code/prepare it to use for unmounted vthreads:
>> - new ThreadDumper class caches stack frames,
On Fri, 29 Sep 2023 02:20:10 GMT, Alex Menkov wrote:
>> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
>> stack references
>> The change:
>> - reorganize thread-related code/prepare it to use for unmounted vthreads:
>> - new ThreadDumper class caches stack frames,
On Fri, 29 Sep 2023 02:20:10 GMT, Alex Menkov wrote:
>> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread
>> stack references
>> The change:
>> - reorganize thread-related code/prepare it to use for unmounted vthreads:
>> - new ThreadDumper class caches stack frames,
On Thu, 28 Sep 2023 21:23:25 GMT, Ashutosh Mehra wrote:
> Please review this change to fix the operands of the bytecodes that operate
> on fields when dumping a class using SA.
>
> Testing: hotspot_serviceability
>
> I have also verified that
>
The JVMTI VirtualThreadStart events have to follow the ThreadStart events
pattern and so, should not be thread-filtered.
The fix includes:
- `jvmti.xml`: remov the attribute `filtered="thread"` in the
`VirtuallThreadStart` event spec
- `jvmtiEventController.cpp`: remove the `VTHREAD_START_BIT`
On Fri, 29 Sep 2023 19:21:14 GMT, Alex Menkov wrote:
>> The change fixes 2 issues in hprof test library.
>> The issue were discovered during test development (logging values of dumped
>> heap objects).
>> - JavaValueArray.elementSize cannot determine size of the array elements and
>> throws
On Thu, 28 Sep 2023 21:04:58 GMT, Leonid Mesnik wrote:
>> The test fails because ThreadDeath is raised during class
>> jdk.internal.misc.VirtualThreads initialization. The proposed fix is to
>> pre-initialize this step to avoid such failures. See more details in the bug.
>> I reproduced the
On Thu, 28 Sep 2023 16:44:26 GMT, Varada M wrote:
>> Similar issue [JDK-8303549](https://bugs.openjdk.org/browse/JDK-8303549)
>> where AttachCurrentThread is failing on AIX due to stack size issue.
>> Test cases:
>> runtime/jni/terminatedThread/TestTerminatedThread.java
>>
On Wed, 20 Sep 2023 22:11:12 GMT, Leonid Mesnik wrote:
>> Test
>> com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java
>> check how beans work with VM flags and ignore external flags.
>> It doesn't make sense to run it with external options so just mark it as
>> flagless.
>> Tested with
On Thu, 28 Sep 2023 09:49:05 GMT, Afshin Zafari wrote:
>> The `find` method now is
>> ```C++
>> template
>> int find(T* token, bool f(T*, E)) const {
>> ...
>>
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
On Wed, 9 Aug 2023 07:46:58 GMT, Sergey Bylokhov wrote:
> The test uses this code to create a list of valid addresses for the localhost:
>
> String hostname = "localhost";
> List validAddresses = new LinkedList<>();
> validAddresses.add(hostname);
>
On Wed, 9 Aug 2023 07:46:58 GMT, Sergey Bylokhov wrote:
> The test uses this code to create a list of valid addresses for the localhost:
>
> String hostname = "localhost";
> List validAddresses = new LinkedList<>();
> validAddresses.add(hostname);
>
On Tue, 29 Aug 2023 10:09:21 GMT, Serguei Spitsyn wrote:
> This update fixes two important issues:
> - Issue reported by a bug submitter about missing JVMTI events on virtual
> threads after an a JVMTI agent dynamic attach
> - Known scalability/performance issue: a need to l
new test from the bug report was adopted:
> `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest`
> - ran mach5 tiers 1-6: all are passed
Serguei Spitsyn has updated the pull request incrementally with one additional
commit since the last revision:
use virtualThreadSchedu
new test from the bug report was adopted:
> `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest`
> - ran mach5 tiers 1-6: all are passed
Serguei Spitsyn has updated the pull request incrementally with two additional
commits since the last revision:
- removed a trailing spa
On Sat, 9 Sep 2023 18:05:51 GMT, Leonid Mesnik wrote:
>> It is strange that the the tested vthreads in sleep(timeout) have sate
>> WAITING, not TIMED_WAITING.
>> It can be a bug in the implementation.
>> I've decided to add a short sleep. Checking states looks a little bit over
>> complicated.
On Mon, 11 Sep 2023 22:18:03 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> addressed second round of review comments on VThreadEventTest.java
>
> test/hots
On Mon, 11 Sep 2023 21:22:18 GMT, Serguei Spitsyn wrote:
>> This update fixes two important issues:
>> - Issue reported by a bug submitter about missing JVMTI events on virtual
>> threads after an a JVMTI agent dynamic attach
>> - Known scalability/performance issue:
new test from the bug report was adopted:
> `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest`
> - ran mach5 tiers 1-6: all are passed
Serguei Spitsyn has updated the pull request incrementally with one additional
commit since the last revision:
addressed second round of
On Mon, 11 Sep 2023 19:53:19 GMT, Leonid Mesnik wrote:
> Could you please add comment why standard CountDownLatch doesn't work for
> this test.
Okay. Added comment.
-
PR Comment: https://git.openjdk.org/jdk/pull/15467#issuecomment-1714574938
On Mon, 11 Sep 2023 09:08:26 GMT, Serguei Spitsyn wrote:
>> This update fixes two important issues:
>> - Issue reported by a bug submitter about missing JVMTI events on virtual
>> threads after an a JVMTI agent dynamic attach
>> - Known scalability/performance issue:
new test from the bug report was adopted:
> `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest`
> - ran mach5 tiers 1-6: all are passed
Serguei Spitsyn has updated the pull request incrementally with one additional
commit since the last revision:
removed JavaThread::
new test from the bug report was adopted:
> `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest`
> - ran mach5 tiers 1-6: all are passed
Serguei Spitsyn has updated the pull request incrementally with one additional
commit since the last revision:
1) addressed revi
On Wed, 6 Sep 2023 20:32:03 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
On Fri, 8 Sep 2023 02:46:36 GMT, Leonid Mesnik wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
On Fri, 8 Sep 2023 03:08:33 GMT, Leonid Mesnik wrote:
>> test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest/VThreadEventTest.java
>> line 136:
>>
>>> 134: ready1.await();
>>> 135: mready.decr();
>>> 136: VirtualMachine vm =
>>>
On Fri, 8 Sep 2023 03:03:56 GMT, Leonid Mesnik wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
On Wed, 6 Sep 2023 20:39:59 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
On Wed, 6 Sep 2023 20:33:46 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
On Wed, 6 Sep 2023 20:24:59 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
On Wed, 6 Sep 2023 20:23:57 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
new test from the bug report was adopted:
> `test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest`
> - ran mach5 tiers 1-6: all are passed
Serguei Spitsyn has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelat
On Mon, 4 Sep 2023 08:24:19 GMT, Alan Bateman wrote:
>> In the virtual thread implementation, thread identity switches to the
>> carrier before freezing and switches back to the virtual thread after
>> thawing. This was a forced move due to issues getting JVMTI to work with
>> virtual
On Mon, 4 Sep 2023 08:24:19 GMT, Alan Bateman wrote:
>> In the virtual thread implementation, thread identity switches to the
>> carrier before freezing and switches back to the virtual thread after
>> thawing. This was a forced move due to issues getting JVMTI to work with
>> virtual
On Fri, 1 Sep 2023 21:11:03 GMT, Jiangli Zhou wrote:
>> Please review this simple change from @cjmoon1 for resolving static linking
>> issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be
>> found at:
>>
On Thu, 31 Aug 2023 07:55:01 GMT, Aleksey Shipilev wrote:
> Current vmTestbase/nsk/monitoring/stress/classload tests contains 24 tests,
> each running exclusively. This drags the tier4 test times up. There seem to
> be no reason to run these tests exclusively, though: they complete in
>
On Tue, 29 Aug 2023 23:37:06 GMT, Jiangli Zhou wrote:
> Please review this simple change from @cjmoon1 for resolving static linking
> issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be
> found at:
>
This update fixes two important issues:
- Issue reported by a bug submitter about missing JVMTI events on virtual
threads after an a JVMTI agent dynamic attach
- Known scalability/performance issue: a need to lazily create
`JvmtiThreadState's` for virtual threads
The issue is tricky to fix
On Thu, 24 Aug 2023 21:38:41 GMT, Kevin Walls wrote:
>> Several tests from test/jdk/sun/tools/jstatd are intermittent.
>>
>> Port clashes when run at the same time on the same machine have been a
>> problem.
>> The RMI error "no such object in table" can mean a reference on the RMI
>> server
On Sun, 27 Aug 2023 17:03:00 GMT, Kim Barrett wrote:
>> Not a review, just agreeing with @stefank and @jdksjolen . What they
>> describe is idiomatic C++.
>
> Also, why isn't this change also being applied to `find_from_end`
There can be a confusion related to selection of type names T and E:
On Mon, 28 Aug 2023 19:12:04 GMT, Leonid Mesnik wrote:
> Arguments were added to the launcher arguments.
Looks good.
Copyright comment needs an update.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review:
On Mon, 28 Aug 2023 20:10:59 GMT, Leonid Mesnik wrote:
> The test is fixed to start debuggee with tested VM options.
> Verified with tier1, running svc tests with different vm flags and virtual
> thread.
Looks okay.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR
On Wed, 23 Aug 2023 18:26:03 GMT, Chris Plummer wrote:
>> During [JDK-8151815](https://bugs.openjdk.org/browse/JDK-8151815) it was
>> noted that the PerfMemory _initialized and _destroyed fields should be
>> volatile, but VMStructs didn't have the needed support for doing that, so it
>> was
On Wed, 23 Aug 2023 03:15:48 GMT, Chris Plummer wrote:
>> During [JDK-8151815](https://bugs.openjdk.org/browse/JDK-8151815) it was
>> noted that the PerfMemory _initialized and _destroyed fields should be
>> volatile, but VMStructs didn't have the needed support for doing that, so it
>> was
On Tue, 22 Aug 2023 21:25:48 GMT, Kim Barrett wrote:
>> Please review this change which moves checked_cast from globalDefinitions.hpp
>> to a separate file. As part of this change we modify files that use
>> checked_cast to directly include that new file. There are around 80 such
>> files, and
On Mon, 21 Aug 2023 19:25:25 GMT, Chris Plummer wrote:
> The test tries to match up various GC -XX:+PrintFlagsFinal values with the
> output of jhsdb -jmap --pid --heap. With ZGC, MaxNewSize set to
> (size_t)-1, but PrintFlagsFinal prints it as an unsigned long:
>
> size_t MaxNewSize =
On Mon, 21 Aug 2023 21:26:11 GMT, Chris Plummer wrote:
>> ObjectMonitor.object() can be null so we need to defend against it. This bug
>> was discovered by code inspection while working on
>> [JDK-8280555](https://bugs.openjdk.org/browse/JDK-8280555). We have no test
>> for this, and I'm not
On Thu, 10 Aug 2023 01:45:47 GMT, Alex Menkov wrote:
> The change fixes several issues with capability management:
> - handling can_support_virtual_threads capability.
> JvmtiExport::can_support_virtual_threads() should be set to true if we have
> one or more agent with
On Thu, 17 Aug 2023 15:51:47 GMT, Aleksey Shipilev wrote:
>> Current test expects `G1HeapRegionSize` flag to be printed out from jmap.
>> But that one is not printed when Shenandoah is enabled. I opted for the
>> minimally intrusive fix: move the additional Shenandoah printout to the
>>
On Thu, 17 Aug 2023 16:33:17 GMT, Chris Plummer wrote:
>> [JDK-8250630](https://bugs.openjdk.org/browse/JDK-8250630) introduced the
>> following change:
>>
>>
>> if (listenAddr == NULL) {
>> +// No address of preferred addres family found, grab the fist one.
>> +
On Wed, 16 Aug 2023 08:09:42 GMT, Matthias Baesken wrote:
> AttachListener::pd_set_flag is the same across platforms (always returning
> JNI_ERR ). So it can be centralized or removed.
Looks good.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review:
On Wed, 16 Aug 2023 02:33:44 GMT, Alex Menkov wrote:
>> This is an attempt to fix suspicious code in the forceEarlyReturn002.java
>> and un-problemlist it to see if the problem appear again.
>>
>> The test fails in "virtual thread factory" mode with timeout for unclear
>> reason after it
On Tue, 15 Aug 2023 03:16:15 GMT, Chris Plummer wrote:
> > Should the bug have the label "noreg-self"?
>
> There are two fixes of almost identical code. One is in test infra code, and
> thus maybe a noreg-self is warranted, but the other is in jdb, so I'm not
> sure what is best in that case.
On Sat, 12 Aug 2023 03:56:05 GMT, Chris Plummer wrote:
> VMConnection.open() expects launchTarget(), attachTarget(), and
> listentTarget() to either throw an exception or return a valid VirtualMachine
> instance. Instead they were catching certain exceptions and returning null,
> which
On Mon, 14 Aug 2023 19:13:28 GMT, Chris Plummer wrote:
>> No need to use reflection to call Thread.isVirtual().
>>
>> Tested by running Tier5 CI (filtered to run just svc tests). This resulted
>> in running this test with and without JTREG_TEST_THREAD_FACTORY=Virtual and
>> also with a
On Mon, 14 Aug 2023 10:13:21 GMT, Matthias Baesken wrote:
> AttachListener::pd_find_operation always returns nullptr and seems to be
> obsolete, so we could probably remove it and clean up the coding a bit.
Marked as reviewed by sspitsyn (Reviewer).
-
PR Review:
On Mon, 7 Aug 2023 20:17:21 GMT, Chris Plummer wrote:
> Make sure when walking the stack that the "sender" frame is not at a lower or
> the same address as the current frame, which can result in an infinite loop.
>
> Tested with tier1 and stress testing sun/tools/jhsdb and
>
On Wed, 9 Aug 2023 11:06:04 GMT, Matthias Baesken wrote:
>> There is coding e.g. in
>> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
>> that deals with shared lib naming on different OS.
>> This code should be simplified.
>
> Matthias
On Tue, 8 Aug 2023 18:50:25 GMT, Leonid Mesnik wrote:
> Test might times out if it suspend thread before it starts breakpoint event
> handler.
> The fix is to replace sleep with better synchronization and suspend virtual
> thread only when it runs native code.
>
> Also, the completed monitor
On Fri, 4 Aug 2023 22:41:43 GMT, Chris Plummer wrote:
> Normally we want the test args passed to the SA debuggee. In fact for proper
> SA test coverage, it is more important for the test args to be passed to the
> debuggee than to be passed to the test or the the SA tool that the test
>
On Fri, 4 Aug 2023 18:34:52 GMT, Chris Plummer wrote:
>> There is coding e.g. in
>> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
>> that deals with shared lib naming on different OS.
>> This code should be simplified.
>
>
On Fri, 4 Aug 2023 19:45:56 GMT, Leonid Mesnik wrote:
>> The fix adds posting VmObjectAlloc events by
>> Unsafe.allocateInstance(Class cls). The previous attempt to post event
>> directly from 'LibraryCallKit::inline_unsafe_allocate()' cause performance
>> regression even if jvmti event is
On Fri, 4 Aug 2023 19:27:50 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/prims/unsafe.cpp line 111:
>>
>>> 109: }
>>> 110:
>>> 111: static inline int field_offset_from_byte_offset(int byte_offset) {
>>
>> Nit: I wonder if the same fix is needed for the previous function at line
>> 107
On Fri, 4 Aug 2023 14:37:07 GMT, Coleen Phillimore wrote:
> This patch fixes Wconversion in code in the src/hotspot/share/prims
> directory. Most of the changes correct the types. jfieldID's are created
> with the int offset returned by InstanceKlass::field_offset().
> int
On Wed, 26 Jul 2023 20:14:16 GMT, Kevin Walls wrote:
>> This test iterates an array of ThreadInfos in a few places (e.g. in the
>> method doCheck()), and needs to tolerate and ignore nulls, in case a thread
>> finishes and the test hits an NPE.
>>
>> There are other calls like
On Wed, 26 Jul 2023 21:01:24 GMT, Kevin Walls wrote:
>> test/jdk/java/lang/management/ThreadMXBean/Locks.java line 474:
>>
>>> 472: lock = ownerInfo.getLockName();
>>> 473: continue;
>>> 474: }
>>
>> What happens if you don't exclude these
On Wed, 26 Jul 2023 20:14:16 GMT, Kevin Walls wrote:
>> This test iterates an array of ThreadInfos in a few places (e.g. in the
>> method doCheck()), and needs to tolerate and ignore nulls, in case a thread
>> finishes and the test hits an NPE.
>>
>> There are other calls like
On Fri, 21 Jul 2023 18:01:45 GMT, Alan Bateman wrote:
> Thread::getState is an API for monitoring and management purposes to report
> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
>
On Fri, 21 Jul 2023 18:01:45 GMT, Alan Bateman wrote:
> Thread::getState is an API for monitoring and management purposes to report
> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
>
On Wed, 26 Jul 2023 17:38:24 GMT, Alan Bateman wrote:
>> I can't see why it would be needed.
>
>> It would be nice to add a short comment why this is needed.
>
> It's not needed here, it was needed in another version of the tests. While
> benign, I can remove it to avoid any confusion. Thanks.
On Fri, 21 Jul 2023 18:01:45 GMT, Alan Bateman wrote:
> Thread::getState is an API for monitoring and management purposes to report
> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
>
On Tue, 25 Jul 2023 21:48:24 GMT, Paul Hohensee wrote:
> MonitoringSupport_lock is initialized only when UseG1GC is true, but
> [JDK-8304074](https://bugs.openjdk.org/browse/JDK-8304074) uses it to
> implement getTotalThreadAllocatedBytes, which is available for all garbage
> collectors.
On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra wrote:
> This patch adds NestHost and NestMembers attributes to the class dumped by SA.
>
> Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb`
> Manual testing by dumping `j.l.String` and
>
On Fri, 21 Jul 2023 22:32:29 GMT, Serguei Spitsyn wrote:
> This is a clean 21 backport of the 22 fix:
> [JDK-8300051](https://bugs.openjdk.org/browse/JDK-8300051):
> assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event
> controller, JVM TI environment
On Fri, 21 Jul 2023 22:32:29 GMT, Serguei Spitsyn wrote:
> This is a clean 21 backport of the 22 fix:
> [JDK-8300051](https://bugs.openjdk.org/browse/JDK-8300051):
> assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event
> controller, JVM TI environment
This is a clean 21 backport of the 22 fix:
[JDK-8300051](https://bugs.openjdk.org/browse/JDK-8300051):
assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event
controller, JVM TI environments must exist
Testing:
- TBD: mach5 tiers 1-5
-
Commit messages:
-
On Thu, 20 Jul 2023 06:53:26 GMT, Serguei Spitsyn wrote:
> This problem is encountered when a JVMTI agent is loaded into running VM. The
> JvmtiExport::get_jvmti_interface() is called from the agent's Agent_OnAttach
> entrypoint. To support virtual threads it enables JVMTI notificat
On Thu, 20 Jul 2023 06:53:26 GMT, Serguei Spitsyn wrote:
> This problem is encountered when a JVMTI agent is loaded into running VM. The
> JvmtiExport::get_jvmti_interface() is called from the agent's Agent_OnAttach
> entrypoint. To support virtual threads it enables JVMTI notificat
This problem is encountered when a JVMTI agent is loaded into running VM. The
JvmtiExport::get_jvmti_interface() is called from the agent's Agent_OnAttach
entrypoint. To support virtual threads it enables JVMTI notifications from the
VirtualThread class with a call to:
On Tue, 18 Jul 2023 16:47:00 GMT, Sergey Nazarkin wrote:
> Hi!
>
> This is a minor HSDB fix. It prints "bad oop" instead of throwing an NPE
> message to the console when a corrupted object is found.
Looks good.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR
On Tue, 18 Jul 2023 16:48:55 GMT, Jean-Philippe Bempel
wrote:
>> Fix a small leak in constant pool merging during retransformation of a
>> class. If this class has a catch block with `Throwable`, the class
>> `Throwable` is pre-resolved in the constant pool, while all the other
>> classes
On Thu, 13 Jul 2023 03:41:28 GMT, Serguei Spitsyn wrote:
> Clean backport from mainline jdk repo to jdk21 for the fix of:
> [8311556](https://bugs.openjdk.org/browse/JDK-8311556): GetThreadLocalStorage
> not working for vthreads mounted during JVMTI attach
>
> Testing:
> -
601 - 700 of 1579 matches
Mail list logo
