On Fri, 16 Feb 2024 17:00:15 GMT, Albert Mingkun Yang wrote:
> Merging a super class into its single sub class.
>
> Test: tier1-6
Looks good, feels like the files should change name as well. Now when there no
longer is a `Space`. But maybe that's even better to do once we have moved
On Sat, 2 Dec 2023 07:37:26 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Only create CPUTimeCounters if supported
> -
On Fri, 1 Dec 2023 22:37:58 GMT, Jonathan Joo wrote:
>> I think the ideal approach to simplify this is to support Atomic operation
>> on a `PerfCounter`.
>> We could either introduce a `PerfAtomicCounter`/`PerfAtomicLongCounter`
>> class, or perform `Atomic::add()` on the `PerfData::_valuep`
On Sat, 2 Dec 2023 01:22:33 GMT, Jonathan Joo wrote:
>> I still think that a total counter is useful and I'd appreciate if you can
>> keep it. To second what @caoman said before, it is GC agnostic, easy to use
>> even for non GC experts and future proof with regards to implementation
>>
On Thu, 30 Nov 2023 21:43:36 GMT, Man Cao wrote:
>> @simonis was the original suggester of this counter, so I will defer to his
>> expertise. I do agree that dropping the counter would simplify things, but
>> it also might not hurt to just leave it in. I'm okay with either option!
>
> Right,
On Thu, 30 Nov 2023 01:43:28 GMT, Jonathan Joo wrote:
>> (I just realized that I made a typo in my previous msg; should be *callee*
>> instead.) That is what I have in mind.
>>
>>
>> void CPUTimeCounters::update_counter(name, total) {
>> auto counter = get_counter(name);
>> auto old_v =
On Thu, 30 Nov 2023 21:59:41 GMT, Man Cao wrote:
>> src/hotspot/share/runtime/cpuTimeCounters.hpp line 59:
>>
>>> 57: NONCOPYABLE(CPUTimeCounters);
>>> 58:
>>> 59: static CPUTimeCounters* _instance;
>>
>> I would prefer if we made the whole class static and got rid of the instance
>> and
On Thu, 30 Nov 2023 02:45:45 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing include
On Thu, 30 Nov 2023 02:45:45 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing include
Few more comments after the
On Thu, 30 Nov 2023 06:45:02 GMT, Albert Mingkun Yang wrote:
>> I agree that in the case that multiple closures are not active at the same
>> time, we wouldn't have to implement it in this way. However, isn't it
>> possible to have multiple closures active simultaneously, e.g. vm thread,
>>
gt;
>Co-authored-by: Stefan Johansson
> <54407259+kstef...@users.noreply.github.com>
> - Fix namespace issues
>
>Co-authored-by: Stefan Johansson
> <54407259+kstef...@users.noreply.github.com>
>From a testing point of view I think this is looking
On Thu, 23 Nov 2023 13:46:54 GMT, Albert Mingkun Yang wrote:
>> Jonathan Joo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup and address comments
>
> src/hotspot/share/runtime/cpuTimeCounters.cpp line 119:
>
>> 117: if
On Wed, 22 Nov 2023 23:08:36 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Cleanup and address comments
My additional testing
On Wed, 22 Nov 2023 23:08:36 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Cleanup and address comments
I think this looks
On Tue, 14 Nov 2023 21:33:37 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update parallel workers time after Remark
Thanks
On Thu, 9 Nov 2023 10:44:29 GMT, Thomas Schatzl wrote:
>> The JEP covers the idea very well, so I'm only covering some implementation
>> details here:
>>
>> * regions get a "pin count" (reference count). As long as it is non-zero, we
>> conservatively never reclaim that region even if there
On Thu, 9 Nov 2023 05:27:40 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing cpuTimeCounters files
One more thing I
On Thu, 9 Nov 2023 05:27:40 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing cpuTimeCounters files
On Thu, 9 Nov 2023 05:27:40 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add missing cpuTimeCounters files
A few more
On Fri, 3 Nov 2023 14:14:36 GMT, Albert Mingkun Yang wrote:
>> Parsing the separate components is easier :) Not sure if these tags in any
>> way ever indicated some level of abstraction.
>>
>> I do not have a strong opinion here. The combinations
>>
>> (Pinned)
>> (Allocation Failure)
>>
On Tue, 7 Nov 2023 01:06:12 GMT, Man Cao wrote:
> I think it looks great. It is mainly refactoring that consolidates the
> declarations/definitions of the hsperf counters in to a single file. Would it
> be better to name that class `CPUTimeCounters`, so we could move
>
On Wed, 1 Nov 2023 23:56:25 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - revert gitignore change
> - Attempt to fix broken
On Thu, 2 Nov 2023 01:20:59 GMT, Jonathan Joo wrote:
> Could you elaborate a bit on what you were thinking of here? If we are
> assuming something like a thread that updates all other threads, I think this
> implementation could get a bit complicated.
>
> There are two main issues that we can
On Tue, 31 Oct 2023 04:23:13 GMT, Jonathan Joo wrote:
>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Replace NULL with nullptr
Sorry for being a bit
On Thu, 4 May 2023 12:08:28 GMT, Stefan Johansson wrote:
> Please review this fix to avoid a tier1 test failure.
>
> **Summary**
> The newly added test wrongfully assumed that one of the transformed classes
> would be in use. This seem to be the case in most runs, but there is
On Thu, 4 May 2023 12:36:27 GMT, Coleen Phillimore wrote:
>> Please review this fix to avoid a tier1 test failure.
>>
>> **Summary**
>> The newly added test wrongfully assumed that one of the transformed classes
>> would be in use. This seem to be the case in most runs, but there is no
>>
Please review this fix to avoid a tier1 test failure.
**Summary**
The newly added test wrongfully assumed that one of the transformed classes
would be in use. This seem to be the case in most runs, but there is no
guarantee. This change fixes the test to only verify that nothing is seen as
On Fri, 28 Apr 2023 12:48:44 GMT, Stefan Johansson wrote:
> Hi all,
>
> Please review this change to avoid CleanClassLoaderDataMetaspaces safepoint
> when there is nothing that can be cleaned up.
>
> **Summary**
> When transforming/redefining classes a previous v
On Fri, 28 Apr 2023 15:57:49 GMT, Coleen Phillimore wrote:
>> Stefan Johansson has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Test refactor
>> - Serguei review
>
> This looks good. Thanks for all
ting**
> * A lot of manual testing verifying that we do get the safepoint when we
> should.
> * Added new test to verify expected behavior by parsing the logs. The test
> uses JFR to trigger redefinition of some shared classes (when -Xshare:on).
> * Mach5 run of new test and tier 1-
On Fri, 28 Apr 2023 15:57:49 GMT, Coleen Phillimore wrote:
>> Stefan Johansson has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Test refactor
>> - Serguei review
>
> This looks good. Thanks for all
Hi all,
Please review this change to avoid CleanClassLoaderDataMetaspaces safepoint
when there is nothing that can be cleaned up.
**Summary**
When transforming/redefining classes a previous version list is linked together
in the InstanceKlass. The original class is added to this list if it is
ith
implementation details.
Carter Kozak
On Wed, Nov 30, 2022, at 03:37, Stefan Johansson wrote:
Hi Carter,
Your mail made me pick up an old item from my wishlist: to have
native
memory tracking information available in JFR recordings. When we,
in GC,
do im
Hi Carter,
Your mail made me pick up an old item from my wishlist: to have native
memory tracking information available in JFR recordings. When we, in GC,
do improvements to decrease the native memory overhead of our
algorithms, NMT is a very good tool to track the progress. We have
scripts
34 matches
Mail list logo
