Re: RFR: 8286185: The Java manpage can be more platform inclusive [v3]

2022-11-28 Thread David Holmes
On Mon, 28 Nov 2022 21:48:40 GMT, Ioi Lam wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix formatting > > LGTM Thanks @iklam ! - PR: https://git.openjdk.org/jdk/pull/11340

Re: RFR: 8286185: The Java manpage can be more platform inclusive [v3]

2022-11-28 Thread Ioi Lam
On Thu, 24 Nov 2022 00:50:22 GMT, David Holmes wrote: >> This is mainly an expansion of the included platforms by changing "linux and >> macOS" to "Non-Windows". There are a few additional examples, and >> clarification that they are just examples. There are also some minor edits >> and

Re: RFR: 8286185: The Java manpage can be more platform inclusive [v3]

2022-11-27 Thread David Holmes
On Fri, 25 Nov 2022 20:22:25 GMT, Vladimir Kozlov wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix formatting > > Good. Thanks @vnkozlov ! - PR: https://git.openjdk.org/jdk/pull/11340

Re: RFR: 8286185: The Java manpage can be more platform inclusive [v3]

2022-11-25 Thread Vladimir Kozlov
On Thu, 24 Nov 2022 00:50:22 GMT, David Holmes wrote: >> This is mainly an expansion of the included platforms by changing "linux and >> macOS" to "Non-Windows". There are a few additional examples, and >> clarification that they are just examples. There are also some minor edits >> and

Re: RFR: 8286185: The Java manpage can be more platform inclusive [v3]

2022-11-23 Thread David Holmes
On Thu, 24 Nov 2022 01:23:00 GMT, Serguei Spitsyn wrote: >> David Holmes has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix formatting > > Nice doc update. > Looks good to me. > Thanks, > Serguei Thanks for looking at this @sspitsyn !

Re: RFR: 8286185: The Java manpage can be more platform inclusive [v3]

2022-11-23 Thread Serguei Spitsyn
On Thu, 24 Nov 2022 00:50:22 GMT, David Holmes wrote: >> This is mainly an expansion of the included platforms by changing "linux and >> macOS" to "Non-Windows". There are a few additional examples, and >> clarification that they are just examples. There are also some minor edits >> and

Re: RFR: 8286185: The Java manpage can be more platform inclusive [v3]

2022-11-23 Thread David Holmes
> This is mainly an expansion of the included platforms by changing "linux and > macOS" to "Non-Windows". There are a few additional examples, and > clarification that they are just examples. There are also some minor edits > and corrections I spotted. > > One actual fix relates to the