On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra wrote:
> This patch adds NestHost and NestMembers attributes to the class dumped by SA.
>
> Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb`
> Manual testing by dumping `j.l.String` and
>
On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra wrote:
> This patch adds NestHost and NestMembers attributes to the class dumped by SA.
>
> Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb`
> Manual testing by dumping `j.l.String` and
>
On Thu, 3 Aug 2023 15:59:14 GMT, Chris Plummer wrote:
>> @ashu-mehra thanks for doing the additional testing. Pity there is no
>> regression/functional test for this.
>
>> @dholmes-ora @plummercj I have improved [dumpclass
>>
On Thu, 3 Aug 2023 15:59:14 GMT, Chris Plummer wrote:
>> @ashu-mehra thanks for doing the additional testing. Pity there is no
>> regression/functional test for this.
>
>> @dholmes-ora @plummercj I have improved [dumpclass
>>
On Wed, 2 Aug 2023 05:07:31 GMT, David Holmes wrote:
>> @dholmes-ora I verified the case for hidden dynamically injected classes.
>> The dumped class data for a hidden dynamically injected class does not have
>> any Nest-Host attribute. When generating these classes dynamically the VM
>> does
On Wed, 2 Aug 2023 05:07:31 GMT, David Holmes wrote:
> Pity there is no regression/functional test for this.
@dholmes-ora @plummercj I have improved [dumpclass
tests](https://github.com/openjdk/jdk/commit/97618cc9bbadce4b51fc0fbee93557f4dcc8d26a)
to cover up some cases for this PR and
On Tue, 1 Aug 2023 20:53:45 GMT, Ashutosh Mehra wrote:
>> @ashu-mehra That was one case. I also want to know that you have tested
>> deeply nested classes; and hidden classes (if applicable). Thanks.
>
> @dholmes-ora I verified the case for hidden dynamically injected classes. The
> dumped
On Tue, 1 Aug 2023 08:33:24 GMT, David Holmes wrote:
>> @dholmes-ora I confirmed there is no nest-host or nest-members attributes
>> generated by this patch for a top level class which doesn't have any
>> nest-members. Is that what you wanted to verify?
>
> @ashu-mehra That was one case. I
On Mon, 31 Jul 2023 15:27:36 GMT, Ashutosh Mehra wrote:
>> @ashu-mehra you indicated that you had only done two basic manual tests to
>> check the output. You need to check it for the cases that I flagged too. In
>> the VM every top-level class is its own nest-host, but that is not expressed
On Thu, 27 Jul 2023 22:39:03 GMT, David Holmes wrote:
>> @dholmes-ora sorry for responding late. I got sidetracked by some other work.
>>
>>> We need to be sure this works as expected for top-level classes that have
>>> no nest members, and deeply nested nest members, plus dynamically injected
On Thu, 27 Jul 2023 16:16:37 GMT, Ashutosh Mehra wrote:
>> We need to be sure this works as expected for top-level classes that have no
>> nest members, and deeply nested nest members, plus dynamically injected
>> hidden classes that are nest members. I'm unclear if this is intended to
>>
On Tue, 25 Jul 2023 05:36:15 GMT, David Holmes wrote:
>> This patch adds NestHost and NestMembers attributes to the class dumped by
>> SA.
>>
>> Testing: `test/hotspot/jtreg/serviceability/sa` and
>> `test/jdk/sun/tools/jhsdb`
>> Manual testing by dumping `j.l.String` and
>>
On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra wrote:
> This patch adds NestHost and NestMembers attributes to the class dumped by SA.
>
> Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb`
> Manual testing by dumping `j.l.String` and
>
On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra wrote:
> This patch adds NestHost and NestMembers attributes to the class dumped by SA.
>
> Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb`
> Manual testing by dumping `j.l.String` and
>
On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra wrote:
> This patch adds NestHost and NestMembers attributes to the class dumped by SA.
>
> Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb`
> Manual testing by dumping `j.l.String` and
>
This patch adds NestHost and NestMembers attributes to the class dumped by SA.
Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb`
Manual testing by dumping `j.l.String` and
`j.l.String$CaseInsensitiveComparator` classes.
`j.l.String` shows one entry in `NestMembers`
16 matches
Mail list logo
