Re: RFR: 8320215: HeapDumper can use DumpWriter buffer during merge

2024-05-30 Thread Chris Plummer
On Fri, 19 Apr 2024 00:10:12 GMT, Alex Menkov wrote: > The fix updates HeapMerger to use writer buffer (no need to copy memory, also > writer buffer is 1MB instead of 4KB). > Additionally fixed small issue in FileWriter (looks like `ssize_t` instead of > `size_t` is a typo, the argument should

Re: RFR: 8320215: HeapDumper can use DumpWriter buffer during merge

2024-05-29 Thread Yi Yang
On Fri, 19 Apr 2024 00:10:12 GMT, Alex Menkov wrote: > The fix updates HeapMerger to use writer buffer (no need to copy memory, also > writer buffer is 1MB instead of 4KB). > Additionally fixed small issue in FileWriter (looks like `ssize_t` instead of > `size_t` is a typo, the argument should

Re: RFR: 8320215: HeapDumper can use DumpWriter buffer during merge

2024-05-29 Thread Alex Menkov
On Wed, 29 May 2024 02:03:42 GMT, Chris Plummer wrote: >> The fix updates HeapMerger to use writer buffer (no need to copy memory, >> also writer buffer is 1MB instead of 4KB). >> Additionally fixed small issue in FileWriter (looks like `ssize_t` instead >> of `size_t` is a typo, the argument

Re: RFR: 8320215: HeapDumper can use DumpWriter buffer during merge

2024-05-29 Thread Alex Menkov
On Wed, 29 May 2024 02:52:22 GMT, Yi Yang wrote: > I remember experimenting with different buffer sizes and figuring out that > 4KB was the sweet spot. We could potentially switch to 1MB, but it would be > better if we had some benchmark numbers to back that up. My experiments shown that with

Re: RFR: 8320215: HeapDumper can use DumpWriter buffer during merge

2024-05-28 Thread Yi Yang
On Fri, 19 Apr 2024 00:10:12 GMT, Alex Menkov wrote: > The fix updates HeapMerger to use writer buffer (no need to copy memory, also > writer buffer is 1MB instead of 4KB). > Additionally fixed small issue in FileWriter (looks like `ssize_t` instead of > `size_t` is a typo, the argument should

Re: RFR: 8320215: HeapDumper can use DumpWriter buffer during merge

2024-05-28 Thread Chris Plummer
On Fri, 19 Apr 2024 00:10:12 GMT, Alex Menkov wrote: > The fix updates HeapMerger to use writer buffer (no need to copy memory, also > writer buffer is 1MB instead of 4KB). > Additionally fixed small issue in FileWriter (looks like `ssize_t` instead of > `size_t` is a typo, the argument should

Re: RFR: 8320215: HeapDumper can use DumpWriter buffer during merge

2024-05-28 Thread Alex Menkov
On Fri, 19 Apr 2024 00:10:12 GMT, Alex Menkov wrote: > The fix updates HeapMerger to use writer buffer (no need to copy memory, also > writer buffer is 1MB instead of 4KB). > Additionally fixed small issue in FileWriter (looks like `ssize_t` instead of > `size_t` is a typo, the argument should

Re: RFR: 8320215: HeapDumper can use DumpWriter buffer during merge

2024-04-29 Thread Serguei Spitsyn
On Fri, 19 Apr 2024 00:10:12 GMT, Alex Menkov wrote: > The fix updates HeapMerger to use writer buffer (no need to copy memory, also > writer buffer is 1MB instead of 4KB). > Additionally fixed small issue in FileWriter (looks like `ssize_t` instead of > `size_t` is a typo, the argument should

RFR: 8320215: HeapDumper can use DumpWriter buffer during merge

2024-04-18 Thread Alex Menkov
The fix updates HeapMerger to use writer buffer (no need to copy memory, also writer buffer is 1MB instead of 4KB). Additionally fixed small issue in FileWriter (looks like `ssize_t` instead of `size_t` is a typo, the argument should be unsigned) Testing: all HeapDump-related tests on Oracle