On Wed, 28 Feb 2024 22:10:04 GMT, Chris Plummer wrote:
>> Fix numerous debug agent issues and testing deficiencies related to
>> Thread.interrupt(). As a first read you should look at the description in
>> the CR. More details in first comment below.
>>
>> Also, this PR is dependent on the
> Fix numerous debug agent issues and testing deficiencies related to
> Thread.interrupt(). As a first read you should look at the description in the
> CR. More details in first comment below.
>
> Also, this PR is dependent on the fix for
>
On Wed, 28 Feb 2024 22:10:04 GMT, Chris Plummer wrote:
>> Fix numerous debug agent issues and testing deficiencies related to
>> Thread.interrupt(). As a first read you should look at the description in
>> the CR. More details in first comment below.
>>
>> Also, this PR is dependent on the
On Wed, 28 Feb 2024 22:10:04 GMT, Chris Plummer wrote:
>> Fix numerous debug agent issues and testing deficiencies related to
>> Thread.interrupt(). As a first read you should look at the description in
>> the CR. More details in first comment below.
>>
>> Also, this PR is dependent on the
On Wed, 28 Feb 2024 22:10:04 GMT, Chris Plummer wrote:
>> Fix numerous debug agent issues and testing deficiencies related to
>> Thread.interrupt(). As a first read you should look at the description in
>> the CR. More details in first comment below.
>>
>> Also, this PR is dependent on the
On Wed, 28 Feb 2024 22:04:16 GMT, Chris Plummer wrote:
> I can see that the synchronized for interruptorThread.interrupt() call will
> end up deadlocking...
It is one of the reasons I tried to suggest to get rid of the
`interruptorThread.interrupt()`. :-)
-
PR Review Comment:
On Wed, 28 Feb 2024 22:26:52 GMT, Chris Plummer wrote:
>> ok
>
> Actually there are quite a few cases of this in this test, and most are
> pre-existing. The test consistently does not use a space, and I see this is
> pretty common in other JDI tests. Do we have an official policy on this?
One
On Wed, 28 Feb 2024 05:37:23 GMT, Chris Plummer wrote:
>> test/jdk/com/sun/jdi/InterruptHangTest.java line 134:
>>
>>> 132:
>>> 133: if (interruptorThread != null) {
>>> 134: synchronized(InterruptHangTarg.sync) {
>>
>> Nit: A space is missed after `synchronized` keyword.
On Wed, 28 Feb 2024 07:11:52 GMT, Serguei Spitsyn wrote:
>> Using the interrupt is carried over from the original version of the test. I
>> did consider replacing it, but opted to keep it in so there was one less
>> change in the test to review. I can do as you suggested if you wish.
>>
>> I
> Fix numerous debug agent issues and testing deficiencies related to
> Thread.interrupt(). As a first read you should look at the description in the
> CR. More details in first comment below.
>
> Also, this PR is dependent on the fix for
>
On Wed, 28 Feb 2024 05:37:05 GMT, Chris Plummer wrote:
>> test/jdk/com/sun/jdi/InterruptHangTest.java line 146:
>>
>>> 144: // When in precise mode, make sure that every interrupt sent
>>> resulted in
>>> 145: // an InterruptedException. Note the interruptor always ends
>>> up
On Fri, 23 Feb 2024 19:06:59 GMT, Chris Plummer wrote:
> Fix numerous debug agent issues and testing deficiencies related to
> Thread.interrupt(). As a first read you should look at the description in the
> CR. More details in first comment below.
>
> Also, this PR is dependent on the fix for
On Wed, 28 Feb 2024 05:24:49 GMT, Chris Plummer wrote:
>> test/jdk/com/sun/jdi/InterruptHangTest.java line 137:
>>
>>> 135: // Kill the interrupter thread
>>> 136: interruptorThread.interrupt();
>>> 137: }
>>
>> Nit: Just a suggestion to consider
On Wed, 28 Feb 2024 05:28:00 GMT, Chris Plummer wrote:
>> test/jdk/com/sun/jdi/InterruptHangTest.java line 140:
>>
>>> 138: }
>>> 139:
>>> 140: if (!remoteMode) { // we don't count interruptsSent when in
>>> remote mode
>>
>> Nit: This is a little bit confusing. In fact the
On Wed, 28 Feb 2024 03:33:33 GMT, Serguei Spitsyn wrote:
>> Fix numerous debug agent issues and testing deficiencies related to
>> Thread.interrupt(). As a first read you should look at the description in
>> the CR. More details in first comment below.
>>
>> Also, this PR is dependent on the
On Fri, 23 Feb 2024 19:06:59 GMT, Chris Plummer wrote:
> Fix numerous debug agent issues and testing deficiencies related to
> Thread.interrupt(). As a first read you should look at the description in the
> CR. More details in first comment below.
>
> Also, this PR is dependent on the fix for
On Fri, 23 Feb 2024 19:06:59 GMT, Chris Plummer wrote:
> Fix numerous debug agent issues and testing deficiencies related to
> Thread.interrupt(). As a first read you should look at the description in the
> CR. More details in first comment below.
>
> Also, this PR is dependent on the fix for
Fix numerous debug agent issues and testing deficiencies related to
Thread.interrupt(). As a first read you should look at the description in the
CR. More details in first comment below.
Also, this PR is dependent on the fix for
[JDK-8325187](https://bugs.openjdk.org/browse/JDK-8325187). The
18 matches
Mail list logo
