On Sat, 30 Mar 2024 01:32:27 GMT, Daniel D. Daugherty
wrote:
>> It wait for some increment of time upto a maximum of 100 seconds.
>
> I'm good with that. Thanks for clarifying.
Thanks, Dan.
I've decided to increase this timeout to 20 secs. Pushed now.
-
PR Review Comment:
On Fri, 29 Mar 2024 23:02:03 GMT, Serguei Spitsyn wrote:
>> So that would mean that the native side would always wait for 100 seconds?
>> Or will it wait for some increment of time upto a maximum of 100 seconds?
>
> It wait for some increment of time upto a maximum of 100 seconds.
I'm good with
On Fri, 29 Mar 2024 22:18:24 GMT, Daniel D. Daugherty
wrote:
>> Thank you for the example and for catching the typo. The timeout factor also
>> needs to be passed to the native side. I think, this fragment is not worth
>> this kind of extra complexity. One approach would be to just make it
On Fri, 29 Mar 2024 20:44:48 GMT, Serguei Spitsyn wrote:
>> runtime/8176717/TestInheritFD.java has an example of what I'm talking about:
>>
>> public static float timeoutFactor =
>> Float.parseFloat(System.getProperty("test.timeout.factor", "1.0"));
>> public static long
On Fri, 29 Mar 2024 13:29:15 GMT, Daniel D. Daugherty
wrote:
>> Thanks for the comments, Chris and Dan. Updated as Chris suggested. I've
>> added this with `-Xcomp` consideration as the worst case scenario in mind.
>> Now, I think it is more save to make it 10 seconds instead of one. Is it
On Thu, 28 Mar 2024 23:29:53 GMT, Serguei Spitsyn wrote:
>> Caught this comment in passing. Delays like this should be scaled with
>> defaultTimeoutFactor so that test tasks that invoke tests with options
>> that can slow the test down, e.g., `-Xcomp`, can be accommodated.
>>
>> I believe the
On Fri, 29 Mar 2024 03:50:03 GMT, Chris Plummer wrote:
>> test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest/libPopFrameTest.cpp
>> line 161:
>>
>>> 159: int attempts = 0;
>>> 160: while (!bp_sync_reached) {
>>> 161: LOG("Main: ensureAtBreakpoint: waitig 5 millis\n");
>>
>>
On Wed, 27 Mar 2024 19:59:28 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: improve diagnostics and reliability
>
>
On Wed, 27 Mar 2024 20:27:42 GMT, Daniel D. Daugherty
wrote:
>> test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest/libPopFrameTest.cpp
>> line 163:
>>
>>> 161: LOG("Main: ensureAtBreakpoint: waitig 5 millis\n");
>>> 162: if (++attempts > 100) {
>>> 163: fatal(jni,
On Wed, 27 Mar 2024 20:06:54 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: improve diagnostics and reliability
>
>
On Wed, 27 Mar 2024 20:08:19 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: improve diagnostics and reliability
>
>
On Wed, 27 Mar 2024 06:44:37 GMT, Serguei Spitsyn wrote:
>> This PR fixes a synchronization issue in the test:
>> `test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest`
>>
>> The method `notifyAtBreakpoint()` can notify the `TestTask` thread when it
>> has not reached an expected
> This PR fixes a synchronization issue in the test:
> `test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest`
>
> The method `notifyAtBreakpoint()` can notify the `TestTask` thread when it
> has not reached an expected breakpoint yet.
> The fix is to add a call to the method
13 matches
Mail list logo
