On Tue, 2 Apr 2024 21:13:33 GMT, Alex Menkov wrote:
>> The fix updated HeapDumper to always perform merge on the current thread.
>>
>> Testing: tier1-5, all HeapDump-related tests
>> Covered heap dumping scenarios:
>> - `jcmd GC.heap_dump` command;
>> -
On Wed, 3 Apr 2024 10:09:20 GMT, Kevin Walls wrote:
> Are we saying there is never any need to perform the merge in a VM Operation?
> Originally (JDK-8306441) it's either done in the attach thread, or a VM
> operation if we are in another thread. But maybe that was just being cautious.
On Tue, 2 Apr 2024 21:13:33 GMT, Alex Menkov wrote:
>> The fix updated HeapDumper to always perform merge on the current thread.
>>
>> Testing: tier1-5, all HeapDump-related tests
>> Covered heap dumping scenarios:
>> - `jcmd GC.heap_dump` command;
>> -
On Tue, 2 Apr 2024 20:44:13 GMT, Serguei Spitsyn wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> comment
>
> src/hotspot/share/services/heapDumper.cpp line 2648:
>
>> 2646:
>> 2647: DumpMerger merger(path, ,
On Tue, 2 Apr 2024 02:04:17 GMT, Yi Yang wrote:
> * jcmd GC.heap_dump command; `AttachListenerThread`
>
> * HotSpotDiagnosticMXBean.dumpHeap(); `JavaThread`
>
> * HeapDumpBeforeFullGC, HeapDumpAfterFullGC VM options; `VMThread`
>
> * HeapDumpOnOutOfMemoryError VM option.
> The fix updated HeapDumper to always perform merge on the current thread.
>
> Testing: tier1-5, all HeapDump-related tests
> Covered heap dumping scenarios:
> - `jcmd GC.heap_dump` command;
> - `HotSpotDiagnosticMXBean.dumpHeap()`;
> - `HeapDumpBeforeFullGC`, `HeapDumpAfterFullGC`
On Tue, 2 Apr 2024 00:40:37 GMT, Alex Menkov wrote:
> The fix updated HeapDumper to always perform merge on the current thread.
>
> Testing: tier1-5, all HeapDump-related tests
> Covered heap dumping scenarios:
> - `jcmd GC.heap_dump` command;
> - `HotSpotDiagnosticMXBean.dumpHeap()`;
On Tue, 2 Apr 2024 00:40:37 GMT, Alex Menkov wrote:
> The fix updated HeapDumper to always perform merge on the current thread.
>
> Testing: tier1-5, all HeapDump-related tests
> Covered heap dumping scenarios:
> - `jcmd GC.heap_dump` command;
> - `HotSpotDiagnosticMXBean.dumpHeap()`;
On Tue, 2 Apr 2024 00:40:37 GMT, Alex Menkov wrote:
> The fix updated HeapDumper to always perform merge on the current thread.
>
> Testing: tier1-5, all HeapDump-related tests
> Covered heap dumping scenarios:
> - `jcmd GC.heap_dump` command;
> - `HotSpotDiagnosticMXBean.dumpHeap()`;
