On Fri, 23 Feb 2024 16:23:43 GMT, Magnus Ihse Bursie wrote:
> The idea of setting up general "toolchains" in the native build was good, but
> it turned out that we really only need a single toolchain, with a single
> twist: if it should use CC or CPP to link. This is better described by a
>
On Sat, 17 Feb 2024 02:41:20 GMT, Alex Menkov wrote:
>> The fix updates heap dumpers to report correct instance size value for
>> HPROF_GC_CLASS_DUMP records (currently it's reported as size of all instance
>> fields)
>>
>> Testing: tier1, tier2, tier5-svc
>
> Alex Menkov has updated the pull
On Sat, 17 Feb 2024 02:41:20 GMT, Alex Menkov wrote:
>> The fix updates heap dumpers to report correct instance size value for
>> HPROF_GC_CLASS_DUMP records (currently it's reported as size of all instance
>> fields)
>>
>> Testing: tier1, tier2, tier5-svc
>
> Alex Menkov has updated the pull
On Fri, 23 Feb 2024 10:08:49 GMT, Kevin Walls wrote:
> In the CSR you mention the two places we document the format. If this goes
> ahead, we should be updating them to be more specific, to declare that this
> field is not VM-independent, it has specific VM knowledge, so maybe for
>
On Fri, 23 Feb 2024 19:06:59 GMT, Chris Plummer wrote:
> Fix numerous debug agent issues and testing deficiencies related to
> Thread.interrupt(). As a first read you should look at the description in the
> CR. More details in first comment below.
>
> Also, this PR is dependent on the fix for
Fix numerous debug agent issues and testing deficiencies related to
Thread.interrupt(). As a first read you should look at the description in the
CR. More details in first comment below.
Also, this PR is dependent on the fix for
[JDK-8325187](https://bugs.openjdk.org/browse/JDK-8325187). The
On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett wrote:
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
>
> The #include updates were performed mechanically, and builds would fail if
>
> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the
> spec.
> The function returns the following structure:
>
>
> typedef struct {
> jthread owner;
> jint entry_count;
> jint waiter_count;
> jthread* waiters;
> jint notify_waiter_count;
>
On Fri, 23 Feb 2024 16:23:43 GMT, Magnus Ihse Bursie wrote:
> The idea of setting up general "toolchains" in the native build was good, but
> it turned out that we really only need a single toolchain, with a single
> twist: if it should use CC or CPP to link. This is better described by a
>
> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the
> spec.
> The function returns the following structure:
>
>
> typedef struct {
> jthread owner;
> jint entry_count;
> jint waiter_count;
> jthread* waiters;
> jint notify_waiter_count;
>
On Thu, 22 Feb 2024 23:31:16 GMT, Alex Menkov wrote:
>> VirtualMachine.loadAgentPath/loadAgentLibrary can fail with
>> AgentLoadException in 2 cases:
>> - attach listener returns error; in the case the exception is thrown from
>> HotSpotVirtualMachine.processCompletionStatus (called from
>>
On Fri, 23 Feb 2024 16:23:43 GMT, Magnus Ihse Bursie wrote:
> The idea of setting up general "toolchains" in the native build was good, but
> it turned out that we really only need a single toolchain, with a single
> twist: if it should use CC or CPP to link. This is better described by a
>
The idea of setting up general "toolchains" in the native build was good, but
it turned out that we really only need a single toolchain, with a single twist:
if it should use CC or CPP to link. This is better described by a specific
argument to SetupNativeCompilation, LANG := C++ or LANG := C
> The implementation of the JVM TI `GetObjectMonitorUsage` does not match the
> spec.
> The function returns the following structure:
>
>
> typedef struct {
> jthread owner;
> jint entry_count;
> jint waiter_count;
> jthread* waiters;
> jint notify_waiter_count;
>
On Thu, 22 Feb 2024 23:31:16 GMT, Alex Menkov wrote:
>> VirtualMachine.loadAgentPath/loadAgentLibrary can fail with
>> AgentLoadException in 2 cases:
>> - attach listener returns error; in the case the exception is thrown from
>> HotSpotVirtualMachine.processCompletionStatus (called from
>>
On Fri, 16 Feb 2024 17:00:15 GMT, Albert Mingkun Yang wrote:
> Merging a super class into its single sub class.
>
> Test: tier1-6
Thanks for review.
-
PR Comment: https://git.openjdk.org/jdk/pull/17891#issuecomment-1961186277
On Fri, 16 Feb 2024 17:00:15 GMT, Albert Mingkun Yang wrote:
> Merging a super class into its single sub class.
>
> Test: tier1-6
This pull request has now been integrated.
Changeset: ef2d5c40
Author:Albert Mingkun Yang
URL:
On Sat, 17 Feb 2024 02:41:20 GMT, Alex Menkov wrote:
>> The fix updates heap dumpers to report correct instance size value for
>> HPROF_GC_CLASS_DUMP records (currently it's reported as size of all instance
>> fields)
>>
>> Testing: tier1, tier2, tier5-svc
>
> Alex Menkov has updated the pull
On Fri, 23 Feb 2024 06:11:29 GMT, Julian Waters wrote:
> > Please review this trivial change
>
> This doesn't look trivial at all :P
While there are a lot of files being touched, the changes to all but one are
purely mechanical, no thinking required.
-
PR Comment:
On Fri, 16 Feb 2024 17:00:15 GMT, Albert Mingkun Yang wrote:
> Merging a super class into its single sub class.
>
> Test: tier1-6
Looks good, feels like the files should change name as well. Now when there no
longer is a `Space`. But maybe that's even better to do once we have moved
20 matches
Mail list logo
