Integrated: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags

2023-09-05 Thread Leonid Mesnik
On Fri, 1 Sep 2023 20:38:28 GMT, Leonid Mesnik wrote: > The fix changes test serviceability/jdwp/AllModulesCommandTest.java to accept > VM flags. > 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start > debugee > 2) The stderr is just logging and test

Re: RFR: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests

2023-09-05 Thread Leonid Mesnik
On Thu, 31 Aug 2023 08:40:58 GMT, Aleksey Shipilev wrote: > Current vmTestbase/nsk/monitoring/stress/thread tests contains 21 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > reason to run these tests exclusively, though: they complete in reasonable

Re: RFR: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies [v2]

2023-09-10 Thread Leonid Mesnik
On Fri, 8 Sep 2023 10:21:23 GMT, Soumadipta Roy wrote: >> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with >> -XX:-VerifyDependencies >> >> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and >> takes about 330 seconds out of 670 seconds of the entire

Re: RFR: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies [v3]

2023-09-11 Thread Leonid Mesnik
On Mon, 11 Sep 2023 11:02:04 GMT, Soumadipta Roy wrote: >> 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with >> -XX:-VerifyDependencies >> >> serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and >> takes about 330 seconds out of 670 seconds of the entire

Re: RFR: 8312174: missing JVMTI events from vthreads parked during JVMTI attach [v4]

2023-09-11 Thread Leonid Mesnik
On Mon, 11 Sep 2023 09:08:26 GMT, Serguei Spitsyn wrote: >> This update fixes two important issues: >> - Issue reported by a bug submitter about missing JVMTI events on virtual >> threads after an a JVMTI agent dynamic attach >> - Known scalability/performance issue: a need to lazily create

Re: RFR: 8316147: Remove serviceability/sa/TestJhsdbJstackMixed.java from -Xcomp problem list

2023-09-14 Thread Leonid Mesnik
On Tue, 12 Sep 2023 23:23:39 GMT, Chris Plummer wrote: > [JDK-8248675](https://bugs.openjdk.org/browse/JDK-8248675) no longer seems to > be reproducing, even before > [JDK-8313800](https://bugs.openjdk.org/browse/JDK-8313800) was just pushed. > I'm not sure what may have fixed it, but even if

RFR: 8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags

2023-09-15 Thread Leonid Mesnik
The test is updated to start the target VM with tested flags in addition to heap size. Tested with tier1, and iter5/6 rt/svc with CI flags. - Commit messages: - 8314829 Changes: https://git.openjdk.org/jdk/pull/15771/files Webrev: https://webrevs.openjdk.org/?repo=jdk=15771=00

Re: RFR: 8315097: Rename createJavaProcessBuilder

2023-08-28 Thread Leonid Mesnik
On Mon, 28 Aug 2023 15:54:08 GMT, Leo Korinth wrote: > Rename createJavaProcessBuilder so that it is not used by mistake instead of > createTestJvm. > > I have used the following sed script: `find -name "*.java" | xargs -n 1 sed > -i -e >

Integrated: 8314834: serviceability/jdwp/AllModulesCommandTest.java ignores VM flags

2023-08-30 Thread Leonid Mesnik
On Mon, 28 Aug 2023 20:10:59 GMT, Leonid Mesnik wrote: > The test is fixed to start debuggee with tested VM options. > Verified with tier1, running svc tests with different vm flags and virtual > thread. This pull request has now been integrated. Changeset: 8e4cda06 Author: Leon

Integrated: 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags

2023-08-30 Thread Leonid Mesnik
On Mon, 28 Aug 2023 19:12:04 GMT, Leonid Mesnik wrote: > Arguments were added to the launcher arguments. This pull request has now been integrated. Changeset: 93e82c01 Author: Leonid Mesnik URL: https://git.openjdk.org/jdk/commit/93e82c01460a70f214653a558d53c1c6180ae0d3 Stats:

Re: RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834 [v4]

2023-09-01 Thread Leonid Mesnik
wversion' vm > option. Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision: - Merge

RFR: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags

2023-09-01 Thread Leonid Mesnik
The fix changes test serviceability/jdwp/AllModulesCommandTest.java to accept VM flags. 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);' is used to start debugee 2) The stderr is just logging and tests doesn't check if it is empty. stderr might contain some VM output which doesn't

Re: RFR: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags [v3]

2023-09-01 Thread Leonid Mesnik
On Fri, 1 Sep 2023 21:46:13 GMT, Chris Plummer wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> logging > > test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 100: &

Re: RFR: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags [v3]

2023-09-01 Thread Leonid Mesnik
On Fri, 1 Sep 2023 22:55:36 GMT, Leonid Mesnik wrote: >> test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 100: >> >>> 98: >>> 99: @Override >>> 100: public void onStringRead(String line) { >> >> Is there a reason

Re: RFR: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags [v3]

2023-09-01 Thread Leonid Mesnik
evious PR https://github.com/openjdk/jdk/pull/15499 because > GitHub incorrectly show changes after merge with backout if the first fix. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: logging - Changes: - all: https

Re: RFR: 8314828: Mark 3 jcmd command-line options test as vm.flagless

2023-09-01 Thread Leonid Mesnik
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote: > Mark 3 tests as flagless to don't run them if not needed. Also, small clean > up. these 3 tests verifies command-line options only like help, version, invalid versions. I don't think they any value by runnign with different

Re: RFR: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags [v2]

2023-09-01 Thread Leonid Mesnik
evious PR https://github.com/openjdk/jdk/pull/15499 because > GitHub incorrectly show changes after merge with backout if the first fix. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: Update test/hotspot/jtreg/serviceability/jdwp/De

Withdrawn: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags

2023-09-01 Thread Leonid Mesnik
On Wed, 30 Aug 2023 21:03:17 GMT, Leonid Mesnik wrote: > Test failed because of unexpected output of version string. > The standard convention for tests is to skip any unexpected output (version > string, VM warning, vm logging) and only fail on expected error patterns. > F

Re: RFR: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags [v3]

2023-09-01 Thread Leonid Mesnik
On Fri, 1 Sep 2023 22:55:44 GMT, Leonid Mesnik wrote: >> I don't like approach to compare handlers. Better to just add logging into >> these listeners. > > updated stdout logging could be improved if needed when test fails. - PR Review Comment: https://git.op

Re: RFR: 8316147: Remove serviceability/sa/TestJhsdbJstackMixed.java from -Xcomp problem list

2023-09-12 Thread Leonid Mesnik
On Tue, 12 Sep 2023 23:23:39 GMT, Chris Plummer wrote: > [JDK-8248675](https://bugs.openjdk.org/browse/JDK-8248675) no longer seems to > be reproducing, even before > [JDK-8313800](https://bugs.openjdk.org/browse/JDK-8313800) was just pushed. > I'm not sure what may have fixed it, but even if

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-13 Thread Leonid Mesnik
On Tue, 12 Sep 2023 19:20:16 GMT, Aleksey Shipilev wrote: > Similar to [JDK-8315437](https://bugs.openjdk.org/browse/JDK-8315437), > current vmTestbase/nsk/monitoring/stress/lowmem tests contains 36 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no >

Re: RFR: 8316142: Enable parallelism in vmTestbase/nsk/monitoring/stress/lowmem tests

2023-09-13 Thread Leonid Mesnik
On Tue, 12 Sep 2023 19:20:16 GMT, Aleksey Shipilev wrote: > Similar to [JDK-8315437](https://bugs.openjdk.org/browse/JDK-8315437), > current vmTestbase/nsk/monitoring/stress/lowmem tests contains 36 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no >

Integrated: 8314828: Mark 3 jcmd command-line options test as vm.flagless

2023-09-13 Thread Leonid Mesnik
On Wed, 23 Aug 2023 22:58:05 GMT, Leonid Mesnik wrote: > Mark 3 tests as flagless to don't run them if not needed. Also, small clean > up. This pull request has now been integrated. Changeset: 23fab118 Author:Leonid Mesnik URL: https://git.openjdk.org/jdk/

Re: RFR: 8315437: Enable parallelism in vmTestbase/nsk/monitoring/stress/classload tests

2023-09-07 Thread Leonid Mesnik
On Thu, 31 Aug 2023 07:55:01 GMT, Aleksey Shipilev wrote: > Current vmTestbase/nsk/monitoring/stress/classload tests contains 24 tests, > each running exclusively. This drags the tier4 test times up. There seem to > be no reason to run these tests exclusively, though: they complete in >

Re: RFR: 8312174: missing JVMTI events from vthreads parked during JVMTI attach [v2]

2023-09-07 Thread Leonid Mesnik
On Thu, 7 Sep 2023 06:33:29 GMT, Serguei Spitsyn wrote: >> This update fixes two important issues: >> - Issue reported by a bug submitter about missing JVMTI events on virtual >> threads after an a JVMTI agent dynamic attach >> - Known scalability/performance issue: a need to lazily create

Re: RFR: 8312174: missing JVMTI events from vthreads parked during JVMTI attach [v2]

2023-09-07 Thread Leonid Mesnik
On Wed, 6 Sep 2023 20:26:51 GMT, Alex Menkov wrote: >> Serguei Spitsyn has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >>

Re: RFR: 8312174: missing JVMTI events from vthreads parked during JVMTI attach [v2]

2023-09-09 Thread Leonid Mesnik
On Fri, 8 Sep 2023 23:28:01 GMT, Serguei Spitsyn wrote: >> Would it makes sense also to check that thread state is TIMED_WAITING. It >> should be set TIMED_WAITING unmounted threads >> https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/Thread.State.html#TIMED_WAITING > >

RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834

2023-08-30 Thread Leonid Mesnik
Test failed because of unexpected output of version string. The standard convention for tests is to skip any unexpected output (version string, VM warning, vm logging) and only fail on expected error patterns. Fix is tested by running with default options and with '-showversion' vm option.

Re: RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834

2023-08-30 Thread Leonid Mesnik
On Wed, 30 Aug 2023 22:05:53 GMT, Daniel D. Daugherty wrote: >> Test failed because of unexpected output of version string. >> The standard convention for tests is to skip any unexpected output (version >> string, VM warning, vm logging) and only fail on expected error patterns. >> Fix is

Re: RFR: 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags [v2]

2023-08-29 Thread Leonid Mesnik
> Arguments were added to the launcher arguments. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fixed copyright - Changes: - all: https://git.openjdk.org/jdk/pull/15454/files - new: https://git.openjdk.org/

Re: RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834 [v2]

2023-08-30 Thread Leonid Mesnik
wversion' vm > option. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: restore errorhandler - Changes: - all: https://git.openjdk.org/jdk/pull/15499/files - new: https://git.openjdk.org/jdk/pull/15499/files/c19

Re: RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834 [v2]

2023-08-30 Thread Leonid Mesnik
On Wed, 30 Aug 2023 22:31:43 GMT, Chris Plummer wrote: >> Not exactly, the stderr is just ignored. We don't expect anything so just >> ignore it. > > So previously we would terminate the debuggee the first time we saw any > output on stderr, and now instead we ignore stderr. What if instead

Re: RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834 [v3]

2023-08-30 Thread Leonid Mesnik
On Thu, 31 Aug 2023 01:29:28 GMT, David Holmes wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> removed unused code. > > test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.jav

Re: RFR: 8315421: [BACKOUT] 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags

2023-08-30 Thread Leonid Mesnik
On Thu, 31 Aug 2023 01:50:48 GMT, Leonid Mesnik wrote: > Please review following trivial fix which reverts > 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags Tested with tier1. - PR Comment: https://git.openjdk.org/jdk/pull/15502#issuecomment-1700247867

Re: RFR: 8315421: [BACKOUT] 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags

2023-08-30 Thread Leonid Mesnik
On Thu, 31 Aug 2023 02:25:37 GMT, David Holmes wrote: >> Please review following trivial fix which reverts >> 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags > > Backout looks good. Thanks. @dholmes-ora, thank you forreview - PR Comment:

Re: RFR: JDK-8313656: assert(!JvmtiExport::can_support_virtual_threads()) with -XX:-DoJVMTIVirtualThreadTransitions

2023-08-30 Thread Leonid Mesnik
On Thu, 10 Aug 2023 01:45:47 GMT, Alex Menkov wrote: > The change fixes several issues with capability management: > - handling can_support_virtual_threads capability. > JvmtiExport::can_support_virtual_threads() should be set to true if we have > one or more agent with

Re: RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834 [v3]

2023-08-30 Thread Leonid Mesnik
wversion' vm > option. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: removed unused code. - Changes: - all: https://git.openjdk.org/jdk/pull/15499/files - new: https://git.openjdk.org/jdk/pull/15499/files/c16

Re: RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834 [v2]

2023-08-30 Thread Leonid Mesnik
On Wed, 30 Aug 2023 23:28:23 GMT, Chris Plummer wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> restore errorhandler > > test/hotspot/jtreg/serviceability/jdwp/DebuggeeLau

RFR: 8315421: [BACKOUT] 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags

2023-08-30 Thread Leonid Mesnik
Please review following trivial fix which reverts 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags - Commit messages: - Revert "8314834: serviceability/jdwp/AllModulesCommandTest.java ignores VM flags" Changes: https://git.openjdk.org/jdk/pull/15502/files

Integrated: 8315421: [BACKOUT] 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags

2023-08-30 Thread Leonid Mesnik
On Thu, 31 Aug 2023 01:50:48 GMT, Leonid Mesnik wrote: > Please review following trivial fix which reverts > 8314834 serviceability/jdwp/AllModulesCommandTest.java ignores VM flags This pull request has now been integrated. Changeset: 218829e0 Author:Leonid Mesnik URL:

RFR: 8316228: jcmd tests are broken by 8314828

2023-09-13 Thread Leonid Mesnik
The fix 8314828 removed dependency to /vmTestbase and tests started failing. Verified by running tests and submitting tier1. - Commit messages: - 8316228: jcmd tests are broken by 8314828 Changes: https://git.openjdk.org/jdk/pull/15731/files Webrev:

Integrated: 8316228: jcmd tests are broken by 8314828

2023-09-13 Thread Leonid Mesnik
On Wed, 13 Sep 2023 23:57:43 GMT, Leonid Mesnik wrote: > The fix 8314828 removed dependency to /vmTestbase and tests started failing. > Verified by running tests and submitting tier1. This pull request has now been integrated. Changeset: 11d431b2 Author:Leonid Mesnik URL:

Re: RFR: 8315442: Enable parallelism in vmTestbase/nsk/monitoring/stress/thread tests

2023-08-31 Thread Leonid Mesnik
On Thu, 31 Aug 2023 08:40:58 GMT, Aleksey Shipilev wrote: > Current vmTestbase/nsk/monitoring/stress/thread tests contains 21 tests, each > running exclusively. This drags the tier4 test times up. There seem to be no > reason to run these tests exclusively, though: they complete in reasonable

Re: Integrated: 8318843: ProblemList java/lang/management/MemoryMXBean/CollectionUsageThreshold.java in Xcomp

2023-10-25 Thread Leonid Mesnik
On Wed, 25 Oct 2023 21:05:06 GMT, Daniel D. Daugherty wrote: > A trivia fix to ProblemList > java/lang/management/MemoryMXBean/CollectionUsageThreshold.java in Xcomp. Thanks for fixing this! - Marked as reviewed by lmesnik (Reviewer). PR Review:

Integrated: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags

2023-10-17 Thread Leonid Mesnik
On Fri, 6 Oct 2023 20:47:22 GMT, Leonid Mesnik wrote: > Test fixed to accept vm flags. This pull request has now been integrated. Changeset: d6679031 Author: Leonid Mesnik URL: https://git.openjdk.org/jdk/commit/d6679031e0316f9ce0613b7db6bdf8ad46d31501 Stats: 4 lines in 1 f

Re: RFR: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper

2023-09-22 Thread Leonid Mesnik
On Thu, 21 Sep 2023 21:58:15 GMT, Leonid Mesnik wrote: > The code related to virtual threads support is moved into a separate class > DebugeeWrapper. > > The code of method main() remains the same. I don't mix code change with > moving code between files. > > Tesed b

Re: RFR: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper [v2]

2023-09-22 Thread Leonid Mesnik
/sun/jdi > make run-test JTREG_RETAIN=all JTREG_TEST_THREAD_FACTORY=Virtual > TEST=com/sun/jdi > locally and tier1 and hs-tier5 in Mach5 CI Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fixed comment - Changes:

Re: RFR: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper [v2]

2023-09-22 Thread Leonid Mesnik
On Fri, 22 Sep 2023 21:44:28 GMT, Chris Plummer wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed comment > > test/jdk/com/sun/jdi/TestScaffold.java line 555: > >&g

Re: RFR: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper [v3]

2023-09-22 Thread Leonid Mesnik
/sun/jdi > make run-test JTREG_RETAIN=all JTREG_TEST_THREAD_FACTORY=Virtual > TEST=com/sun/jdi > locally and tier1 and hs-tier5 in Mach5 CI Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fixed - Changes: - all:

Re: RFR: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper [v3]

2023-09-22 Thread Leonid Mesnik
On Fri, 22 Sep 2023 22:50:58 GMT, Chris Plummer wrote: >> It may break the tests that check this property in static initializers of >> debugee. In such case method could be called before main() and return an >> empty value if a property is not set yet. >> >> Probably the DebuggerWrapper

Re: RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-19 Thread Leonid Mesnik
On Wed, 20 Sep 2023 03:56:28 GMT, Leonid Mesnik wrote: > Test start failing because of unexpected VM logging. > The fix is to search expected string ignoring any unknown output from forked > process. > Tested with tier1 and by running test with various options used in CI. Ou

RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-19 Thread Leonid Mesnik
Test start failing because of unexpected VM logging. The fix is to search expected string ignoring any unknown output from forked process. Tested with tier1 and by running test with various options used in CI. - Commit messages: - 8316562:

Re: RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-19 Thread Leonid Mesnik
On Wed, 20 Sep 2023 03:56:28 GMT, Leonid Mesnik wrote: > Test start failing because of unexpected VM logging. > The fix is to search expected string ignoring any unknown output from forked > process. > Tested with tier1 and by running test with various options used in CI. So

RFR: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper

2023-09-21 Thread Leonid Mesnik
The code related to virtual threads support is moved into a separate class DebugeeWrapper. The code of method main() remains the same. I don't mix code change with moving code between files. Tesed by running make run-test JTREG_RETAIN=all TEST=com/sun/jdi make run-test JTREG_RETAIN=all

Integrated: 8316445: Mark com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java as vm.flagless

2023-09-28 Thread Leonid Mesnik
On Tue, 19 Sep 2023 17:24:15 GMT, Leonid Mesnik wrote: > Test > com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java > check how beans work with VM flags and ignore external flags. > It doesn't make sense to run it with external options so just mark it as > fla

Re: RFR: 8303773: Replace "main.wrapper" with "test.thread.factory" property in test code [v2]

2023-09-28 Thread Leonid Mesnik
rd and MainWrapper classes in JDI test > frameworks because they are actually more main wrappers than thread factories. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fix - Changes: - all: https://git.openjdk.org/jdk/p

RFR: 8308429: jvmti/StopThread/stopthrd007 failed with "NoClassDefFoundError: Could not initialize class jdk.internal.misc.VirtualThreads"

2023-09-28 Thread Leonid Mesnik
The test fails because ThreadDeath is raised during class jdk.internal.misc.VirtualThreads initialization. The proposed fix is to pre-initialize this step to avoid such failures. See more details in the bug. I reproduced the original problem and verified that it is not reproduced after fix.

Re: RFR: 8308429: jvmti/StopThread/stopthrd007 failed with "NoClassDefFoundError: Could not initialize class jdk.internal.misc.VirtualThreads" [v2]

2023-09-28 Thread Leonid Mesnik
On Thu, 28 Sep 2023 21:04:58 GMT, Leonid Mesnik wrote: >> The test fails because ThreadDeath is raised during class >> jdk.internal.misc.VirtualThreads initialization. The proposed fix is to >> pre-initialize this step to avoid such failures. See more details in the bu

Re: RFR: 8308429: jvmti/StopThread/stopthrd007 failed with "NoClassDefFoundError: Could not initialize class jdk.internal.misc.VirtualThreads" [v2]

2023-09-28 Thread Leonid Mesnik
topThreadTest/StopThreadTest.java > might be improved to cover them. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: missed import added. - Changes: - all: https://git.openjdk.org/jdk/pull/15966/files - new: https://

Re: RFR: JDK-8316778: test hprof lib: invalid array element type from JavaValueArray.elementSize [v2]

2023-09-28 Thread Leonid Mesnik
On Fri, 29 Sep 2023 02:13:04 GMT, Alex Menkov wrote: >> The change fixes 2 issues in hprof test library. >> The issue were discovered during test development (logging values of dumped >> heap objects). >> - JavaValueArray.elementSize cannot determine size of the array elements and >> throws

Re: RFR: 8308429: jvmti/StopThread/stopthrd007 failed with "NoClassDefFoundError: Could not initialize class jdk.internal.misc.VirtualThreads" [v2]

2023-10-02 Thread Leonid Mesnik
On Thu, 28 Sep 2023 21:04:58 GMT, Leonid Mesnik wrote: >> The test fails because ThreadDeath is raised during class >> jdk.internal.misc.VirtualThreads initialization. The proposed fix is to >> pre-initialize this step to avoid such failures. See more details in the bu

RFR: 8303773: Replace "main.wrapper" with "test.thread.factory" property in test code

2023-09-27 Thread Leonid Mesnik
The main.wrapper was the first name for jtreg test thread factory plugin. However, during integration of this feature in jtreg it was decided to use test.thread.factory name. So this fix just renames "main.wrapper" property to "test.thread.factory" so it is more compliant with jtreg naming.

Integrated: 8303773: Replace "main.wrapper" with "test.thread.factory" property in test code

2023-10-03 Thread Leonid Mesnik
On Wed, 27 Sep 2023 20:23:03 GMT, Leonid Mesnik wrote: > The main.wrapper was the first name for jtreg test thread factory plugin. > However, during integration of this feature in jtreg it was decided to use > test.thread.factory name. So this fix just renames "main.wra

Integrated: 8308429: jvmti/StopThread/stopthrd007 failed with "NoClassDefFoundError: Could not initialize class jdk.internal.misc.VirtualThreads"

2023-10-03 Thread Leonid Mesnik
On Thu, 28 Sep 2023 17:00:00 GMT, Leonid Mesnik wrote: > The test fails because ThreadDeath is raised during class > jdk.internal.misc.VirtualThreads initialization. The proposed fix is to > pre-initialize this step to avoid such failures. See more details in the bug. >

Re: RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-19 Thread Leonid Mesnik
On Wed, 20 Sep 2023 05:32:07 GMT, David Holmes wrote: >> Test start failing because of unexpected VM logging. >> The fix is to search expected string ignoring any unknown output from forked >> process. >> Tested with tier1 and by running test with various options used in CI. > >

Re: RFR: 8316445: Mark com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java as vm.flagless [v2]

2023-09-20 Thread Leonid Mesnik
> Test > com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java > check how beans work with VM flags and ignore external flags. > It doesn't make sense to run it with external options so just mark it as > flagless. > Tested with running tier1 and test with/without additiona

Re: RFR: 8299560: Assertion failed: currentQueryIndex >= 0 && currentQueryIndex < numberOfJavaProcessesAtInitialization

2023-09-20 Thread Leonid Mesnik
On Thu, 14 Sep 2023 17:24:39 GMT, Kevin Walls wrote: > This assert happens rarely, but is seen in testing a few times. > > getCurrentQueryIndexForProcess comments that it can return -1, but it asserts > that the value is >=0 > > If we let it return -1 for failure as its comment documents, the

Re: RFR: 8316445: Mark com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java as vm.flagless

2023-09-20 Thread Leonid Mesnik
On Tue, 19 Sep 2023 17:24:15 GMT, Leonid Mesnik wrote: > Test > com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java > check how beans work with VM flags and ignore external flags. > It doesn't make sense to run it with external options so just mark it as > fla

Integrated: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

2023-09-20 Thread Leonid Mesnik
On Wed, 20 Sep 2023 03:56:28 GMT, Leonid Mesnik wrote: > Test start failing because of unexpected VM logging. > The fix is to search expected string ignoring any unknown output from forked > process. > Tested with tier1 and by running test with various options used in CI. This pull

Re: RFR: JDK-8315486: vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java timed out [v2]

2023-09-19 Thread Leonid Mesnik
On Thu, 7 Sep 2023 01:25:19 GMT, Alex Menkov wrote: >> To test ForceEarlyReturn command for NO_MORE_FRAMES case the test creates >> ThreadStartEventRequest with SUSPEND_ALL policy and requests debuggee to >> start new thread. >> If debuggee JVM starts some internal threads before the request

Integrated: 8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags

2023-09-19 Thread Leonid Mesnik
On Fri, 15 Sep 2023 23:18:06 GMT, Leonid Mesnik wrote: > The test is updated to start the target VM with tested flags in addition to > heap size. > Tested with tier1, and iter5/6 rt/svc with CI flags. This pull request has now been integrated. Changeset: e0f8d168 Author: Leonid Me

Re: RFR: 8299560: Assertion failed: currentQueryIndex >= 0 && currentQueryIndex < numberOfJavaProcessesAtInitialization

2023-09-26 Thread Leonid Mesnik
On Thu, 14 Sep 2023 17:24:39 GMT, Kevin Walls wrote: > This assert happens rarely, but is seen in testing a few times. > > getCurrentQueryIndexForProcess comments that it can return -1, but it asserts > that the value is >=0 > > If we let it return -1 for failure as its comment documents, the

Re: RFR: 8299560: Assertion failed: currentQueryIndex >= 0 && currentQueryIndex < numberOfJavaProcessesAtInitialization

2023-09-26 Thread Leonid Mesnik
On Tue, 26 Sep 2023 08:59:21 GMT, Kevin Walls wrote: >> src/jdk.management/windows/native/libmanagement_ext/OperatingSystemImpl.c >> line 780: >> >>> 778: int currentQueryIndex = currentQueryIndexForProcess(); >>> 779: >>> 780: assert(currentQueryIndex <

Integrated: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper

2023-09-26 Thread Leonid Mesnik
On Thu, 21 Sep 2023 21:58:15 GMT, Leonid Mesnik wrote: > The code related to virtual threads support is moved into a separate class > DebugeeWrapper. > > The code of method main() remains the same. I don't mix code change with > moving code between files. > > Tesed b

RFR: 8316445: Mark com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java as vm.flagless

2023-09-19 Thread Leonid Mesnik
Test com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java check how beans work with VM flags and ignore external flags. It doesn't make sense to run it with external options so just mark it as flagless. Tested with running tier1 and test with/without additional options. -

Re: RFR: 8303773: Replace "main.wrapper" with "test.thread.factory" property in test code [v3]

2023-09-29 Thread Leonid Mesnik
rd and MainWrapper classes in JDI test > frameworks because they are actually more main wrappers than thread factories. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: spaces added. - Changes: - all: https://git.openjdk.org

Re: RFR: JDK-8316778: test hprof lib: invalid array element type from JavaValueArray.elementSize [v3]

2023-09-29 Thread Leonid Mesnik
On Fri, 29 Sep 2023 19:21:14 GMT, Alex Menkov wrote: >> The change fixes 2 issues in hprof test library. >> The issue were discovered during test development (logging values of dumped >> heap objects). >> - JavaValueArray.elementSize cannot determine size of the array elements and >> throws

RFR: 8316447: 8 sun/management/jmxremote tests ignore VM flags

2023-10-04 Thread Leonid Mesnik
Updated test to use createTesJvm. Removed internal timeout to not fail when Xcomp is used and also to get more info if the test times out., Tested by running tier1, hs-tier5 and executing test with various VM flags. - Commit messages: - jdp test removed from commit. - 8316447: 5

Integrated: 8316464: 3 sun/tools tests ignore VM flags

2023-10-12 Thread Leonid Mesnik
On Fri, 6 Oct 2023 19:24:03 GMT, Leonid Mesnik wrote: > I marked tests > sun/tools/jcmd/TestProcessHelper.java > sun/tools/jinfo/JInfoTest.java > as headless. They used different specific VM options and are not worth > executing with other VM flags. > And fixed

Re: RFR: 8316233: VirtualThreadStart events should not be thread-filtered [v2]

2023-10-06 Thread Leonid Mesnik
On Fri, 6 Oct 2023 18:46:42 GMT, Serguei Spitsyn wrote: >> The JVMTI VirtualThreadStart events have to follow the ThreadStart events >> pattern and so, should not be thread-filtered. >> The fix includes: >> - `jvmti.xml`: remov the attribute `filtered="thread"` in the >> `VirtuallThreadStart`

RFR: 8316464: 3 sun/tools tests ignore VM flags

2023-10-06 Thread Leonid Mesnik
I marked tests sun/tools/jcmd/TestProcessHelper.java sun/tools/jinfo/JInfoTest.java as headless. They used different specific VM options and are not worth executing with other VM flags. And fixed sun/tools/jstat/JStatInterval.java Tested with tier1, local execution of tests, and running

RFR: 8316452: java/lang/instrument/modules/AppendToClassPathModuleTest.java ignores VM flags

2023-10-06 Thread Leonid Mesnik
The test uses specific classpath, and jar and is intended to test modules. So I marked is as flagless, - Commit messages: - 8316452 Changes: https://git.openjdk.org/jdk/pull/16080/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16080=00 Issue:

RFR: 8316446: 4 sun/management/jdp tests ignore VM flags

2023-10-06 Thread Leonid Mesnik
The launcher class is fixed. Tested by tier1 and running test with different VM flags - Commit messages: - 8316446 Changes: https://git.openjdk.org/jdk/pull/16079/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16079=00 Issue: https://bugs.openjdk.org/browse/JDK-8316446

Re: RFR: JDK-8316691: Heap dump: separate stack traces for mounted virtual threads [v3]

2023-10-06 Thread Leonid Mesnik
On Fri, 29 Sep 2023 02:20:10 GMT, Alex Menkov wrote: >> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread >> stack references >> The change: >> - reorganize thread-related code/prepare it to use for unmounted vthreads: >> - new ThreadDumper class caches stack frames,

RFR: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags

2023-10-06 Thread Leonid Mesnik
Test fixed to accept vm flags. - Commit messages: - 8316462 Changes: https://git.openjdk.org/jdk/pull/16081/files Webrev: https://webrevs.openjdk.org/?repo=jdk=16081=00 Issue: https://bugs.openjdk.org/browse/JDK-8316462 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod

Re: RFR: 8316447: 8 sun/management/jmxremote tests ignore VM flags

2023-10-05 Thread Leonid Mesnik
On Thu, 5 Oct 2023 05:32:20 GMT, Leonid Mesnik wrote: > Updated test to use createTesJvm. > Removed internal timeout to not fail when Xcomp is used and also to get more > info if the test times out., > > Tested by running tier1, hs-tier5 and executing test with various VM fl

Re: RFR: 8316447: 8 sun/management/jmxremote tests ignore VM flags [v2]

2023-10-05 Thread Leonid Mesnik
On Thu, 5 Oct 2023 18:21:06 GMT, Leonid Mesnik wrote: >> Updated test to use createTesJvm. >> Removed internal timeout to not fail when Xcomp is used and also to get more >> info if the test times out., >> >> Tested by running tier1, hs-tier5 and execut

Re: RFR: 8316447: 8 sun/management/jmxremote tests ignore VM flags [v2]

2023-10-06 Thread Leonid Mesnik
On Fri, 6 Oct 2023 22:34:40 GMT, Serguei Spitsyn wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> simplifed usage, removed classpath adding. > > test/jdk/sun/management/jmxremote/boo

Re: RFR: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags

2023-10-10 Thread Leonid Mesnik
On Fri, 6 Oct 2023 21:03:03 GMT, Daniel D. Daugherty wrote: >> Test fixed to accept vm flags. > > Hmmm... what kind of testing has been done to make sure that we don't > suddenly get a bunch of new failures by allowing this test to accept VM flags? @dcubed-ojdk I tested this fix by running it

Re: RFR: 8316464: 3 sun/tools tests ignore VM flags [v2]

2023-10-10 Thread Leonid Mesnik
local execution of tests, and running > sun/tools/jstat/JStatInterval.java with different options. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fixed JInfoTest.java - Changes: - all: https://git.openjdk.org/jdk/pull

Re: RFR: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags [v2]

2023-10-10 Thread Leonid Mesnik
On Mon, 9 Oct 2023 08:29:39 GMT, Kevin Walls wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed test. > > test/jdk/sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTermina

Re: RFR: 8316462: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java ignores VM flags [v2]

2023-10-10 Thread Leonid Mesnik
> Test fixed to accept vm flags. Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision: fixed test. - Changes: - all: https://git.openjdk.org/jdk/pull/16081/files - new: https://git.openjdk.org/jdk/pull/16081/fi

Re: RFR: 8316464: 3 sun/tools tests ignore VM flags [v2]

2023-10-10 Thread Leonid Mesnik
On Fri, 6 Oct 2023 23:31:57 GMT, Chris Plummer wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed JInfoTest.java > > test/jdk/sun/tools/jinfo/JInfoTest.java line 41: > >&

Integrated: 8316452: java/lang/instrument/modules/AppendToClassPathModuleTest.java ignores VM flags

2023-10-10 Thread Leonid Mesnik
On Fri, 6 Oct 2023 19:58:13 GMT, Leonid Mesnik wrote: > The test uses specific classpath, and jar and is intended to test modules. So > I marked is as flagless, This pull request has now been integrated. Changeset: fec1d497 Author:Leonid Mesnik URL: https://git.openjdk.o

Re: RFR: JDK-8316691: Heap dump: separate stack traces for mounted virtual threads [v5]

2023-10-10 Thread Leonid Mesnik
On Sat, 7 Oct 2023 00:49:09 GMT, Alex Menkov wrote: >> This is subtask of JDK-8299426: Heap dump does not contain virtual Thread >> stack references >> The change: >> - reorganize thread-related code/prepare it to use for unmounted vthreads: >> - new ThreadDumper class caches stack frames,

RFR: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed.

2023-10-19 Thread Leonid Mesnik
There are several failure with reason "Cannot invoke "String.equals(Object)" because "" is null" which really caused by reading the command from debugee via socket. Like: String command = pipe.readln(); if (!command.equals(AbstractDebuggeeTest.COMMAND_READY)) {

Re: RFR: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed. [v2]

2023-10-20 Thread Leonid Mesnik
vmTestbase_nsk_jdi_VirtualMachine_dispose_dispose002_TestDescription_java/classes/0/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose002/TestDescription.d > \ > > -Dtest.class.path=/home/lmesnik/ws/jdk-vmTestbase/build/linux-x64/test-support/jtreg_open_test_hotspot_jtreg_vmTe

Re: RFR: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed. [v2]

2023-10-20 Thread Leonid Mesnik
On Fri, 20 Oct 2023 04:49:22 GMT, Chris Plummer wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update test/hotspot/jtreg/vmTestbase/nsk/share/jpda/SocketConnection.java >> >

Re: RFR: 8209595: MonitorVmStartTerminate.java timed out [v2]

2023-10-20 Thread Leonid Mesnik
On Fri, 20 Oct 2023 13:30:49 GMT, Kevin Walls wrote: >> From studying test failures, it looks like the way the test identifies its >> related processes is failing. >> It checks the mainArgs of a process by attaching, and looks like it >> occasionally misses getting a valid match. The

Re: RFR: 8318573: The nsk.share.jpda.SocketConnection should fail if socket was closed. [v2]

2023-10-20 Thread Leonid Mesnik
On Fri, 20 Oct 2023 16:20:52 GMT, Chris Plummer wrote: >> The line with results contains it: TEST RESULT: Failed. Execution failed: >> `main' threw exception: nsk.share.Failure: Caught EOFException while reading >> an object from PipeIO Listener Thread connection. Check if debugee process >>

  1   2   3   4   5   6   >