Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-30 Thread Roman Kennke
On Tue, 28 Mar 2023 02:59:31 GMT, Dean Long wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure safepoint when processing lock-stack > > src/hotspot/share/runtime/objectMonitor.inline.hpp line 36: > >> 34:

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-30 Thread Roman Kennke
On Tue, 28 Mar 2023 02:56:47 GMT, David Holmes wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure safepoint when processing lock-stack > > src/hotspot/share/runtime/lockStack.hpp line 43: > >> 41: //

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-30 Thread Roman Kennke
On Tue, 28 Mar 2023 21:39:21 GMT, Daniel D. Daugherty wrote: >> src/hotspot/share/runtime/threads.cpp line 1433: >> >>> 1431: >>> 1432: JavaThread* Threads::owning_thread_from_monitor(ThreadsList* t_list, >>> ObjectMonitor* monitor) { >>> 1433:

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-30 Thread Roman Kennke
On Tue, 28 Mar 2023 00:53:57 GMT, Dean Long wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure safepoint when processing lock-stack > > src/hotspot/share/interpreter/interpreterRuntime.cpp line 746: > >> 744:

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-30 Thread Roman Kennke
On Tue, 28 Mar 2023 00:17:21 GMT, Dean Long wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure safepoint when processing lock-stack > > src/hotspot/cpu/aarch64/aarch64.ad line 3844: > >> 3842: >> 3843:

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-28 Thread Daniel D . Daugherty
On Tue, 28 Mar 2023 02:48:30 GMT, David Holmes wrote: >> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Ensure safepoint when processing lock-stack > > src/hotspot/share/runtime/threads.cpp line 1433: > >> 1431: >> 1432:

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-27 Thread Dean Long
On Mon, 27 Mar 2023 20:24:14 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-27 Thread Dean Long
On Mon, 27 Mar 2023 20:24:14 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-27 Thread David Holmes
On Mon, 27 Mar 2023 20:24:14 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-27 Thread David Holmes
On Mon, 27 Mar 2023 20:24:14 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-27 Thread Dean Long
On Mon, 27 Mar 2023 20:24:14 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-27 Thread Dean Long
On Mon, 27 Mar 2023 20:24:14 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-27 Thread Dean Long
On Mon, 27 Mar 2023 20:24:14 GMT, Roman Kennke wrote: >> This change adds a fast-locking scheme as an alternative to the current >> stack-locking implementation. It retains the advantages of stack-locking >> (namely fast locking in uncontended code-paths), while avoiding the overload >> of

Re: RFR: 8291555: Implement alternative fast-locking scheme [v30]

2023-03-27 Thread Roman Kennke
> This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mark word. That overloading causes massive problems with