Re: [sheepdog] [PATCH v2] fix systemd service to run sheep in foreground and with defaults

2015-04-18 Thread Alexander Guy
On Tue, Apr 14, 2015 at 10:59:51AM +0800, Liu Yuan wrote: Hi Alexander, Could you please give this patch a review? Hey Yuan / Vasiliy, Sorry for the slow reply. On Mon, Apr 13, 2015 at 01:32:56PM +0300, Vasiliy Tolstov wrote: [Service] +Environment=SHEEPDOG_ARGS=--cluster

Re: [sheepdog] [PATCH v1] fix systemd service to run sheep in foreground and with defaults

2015-04-09 Thread Alexander Guy
On Wed, Apr 08, 2015 at 09:27:50AM +0300, Vasiliy Tolstov wrote: 2015-04-08 9:22 GMT+03:00 Liu Yuan namei.u...@gmail.com: I am no guru of systemd but I noticed '--cluster local'. Does it mean we run sheep by local driver for default setup? Local driver is basically for testing for a

Re: [sheepdog] [PATCH v1] add foreground option

2015-03-17 Thread Alexander Guy
On Tue, Mar 17, 2015 at 07:15:03PM +0300, Vasiliy Tolstov wrote: Signed-off-by: Vasiliy Tolstov v.tols...@selfip.ru Hey Vasiliy, It doesn't look like you tested this at all. --- sheep/sheep.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

Re: [sheepdog] [PATCH v1] try to set RLIMIT_NOFILE ro recommended value

2015-03-16 Thread Alexander Guy
On Mon, Mar 16, 2015 at 07:23:59PM +0300, Vasiliy Tolstov wrote: I don't want setrlimit because it sets values to global space. Hi Vasiliy, Are you sure about that? I'm pretty sure setrlimit(RLIMIT_NOFILE, ...) applies to the calling process, just like prlimit(0, RLIMIT_NOFILE, ...) would.

Re: [sheepdog] [PATCH v2] try to set RLIMIT_NOFILE to recommended value

2015-03-16 Thread Alexander Guy
Hey Vasiliy, Thanks for updating your patch. On Tue, Mar 17, 2015 at 12:46:10AM +0300, Vasiliy Tolstov wrote: Signed-off-by: Vasiliy Tolstov v.tols...@selfip.ru --- sheep/sheep.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git

[sheepdog] [PATCH] automake: work-around for not expanding variables in _SOURCES.

2015-03-09 Thread Alexander Guy
/bugreport.cgi?bug=13928 Signed-off-by: Alexander Guy alexan...@andern.org --- tests/unit/dog/Makefile.am | 9 - tests/unit/sheep/Makefile.am | 13 ++--- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/tests/unit/dog/Makefile.am b/tests/unit/dog/Makefile.am index

Re: [sheepdog] [PATCH 1/2] configure: shut up autotool warning but option 'subdir-objects' is disabled

2015-03-09 Thread Alexander Guy
On Fri, Mar 06, 2015 at 04:20:56PM +0800, Liu Yuan wrote: following patch can workaround the problem, but I'm not sure if we could put it in our master branch. how do you think? [...] Hi Yuan, Thanks for tracking down the bug report for automake. Your patch would work for the 'make

Re: [sheepdog] [PATCH 1/2] configure: shut up autotool warning but option 'subdir-objects' is disabled

2015-03-05 Thread Alexander Guy
On Thu, Mar 05, 2015 at 04:20:08PM +0800, Liu Yuan wrote: From: Liu Yuan liuy...@cmss.chinamobile.com Signed-off-by: Liu Yuan liuy...@cmss.chinamobile.com --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index

[sheepdog] [PATCH] deb: enable dh_systemd and provide a Debian-specific service file.

2015-02-09 Thread Alexander Guy
. This patch provides a simple fix for the current issue, until the time unification of variable names is desired/worked on. Signed-off-by: Alexander Guy alexan...@andern.org --- debian/control | 1 + debian/rules| 2 +- debian/sheepdog.service | 17 + 3 files changed

[sheepdog] [PATCH] deb: escape forward slashes in DAEMON_ARGS

2015-02-02 Thread Alexander Guy
This allows arguments that take things like paths (e.g. -l dir=/somewhere) to be handled properly. Signed-off-by: Alexander Guy alexan...@andern.org --- debian/sheepdog.postinst | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/sheepdog.postinst b/debian/sheepdog.postinst index bc72f06

[sheepdog] [PATCH] sheepdog proto: avoid using stdint.h macros, so sbd can build.

2015-01-19 Thread Alexander Guy
The Linux kernel headers don't have the *_C suffix macros, so they can't be used in a header file shared between sheepdog userspace and the sbd kernel module. Signed-off-by: Alexander Guy alexan...@andern.org --- include/sheepdog_proto.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion