[Spice-devel] audio issues with VD

2012-07-11 Thread Wallace Michaelson
When I connect to the Virtual desktop with my home machine I am getting an echo in my headset. I have tried several headsets all with the same results.. the headsets run OK when I am directly using Skype. Am I missing a driver or setting on the server or remote machine? __

[Spice-devel] [PATCH] usb-device-manager: do not try to connect a usb device that was removed

2012-07-11 Thread Uri Lublin
If a device that is asked to be shared with the guest, is unplugged out of the machine before being redirected, then let the user know that usbredir of that device failed (and cleanup nicely). For Windows client, the time between request and redir is larger, as it includes the time it takes to

[Spice-devel] [PATCH] validate tcp port values

2012-07-11 Thread Peter Hatina
Hi, I had a request to validate TCP port values in spice-xpi, so does this make sense for you? More info at https://bugzilla.redhat.com/show_bug.cgi?id=805602 --- SpiceXPI/src/plugin/plugin.cpp | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git

[Spice-devel] [PATCH 1/2] server/red_worker: fix wrong spice_error in commit 706232a8

2012-07-11 Thread Alon Levy
--- server/red_worker.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index c492443..ac9baf2 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1212,7 +1212,7 @@ static inline void

[Spice-devel] [PATCH 2/2] server/reds: fix wrong spice_error in d2c99b59

2012-07-11 Thread Alon Levy
--- server/reds.c | 52 ++-- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/server/reds.c b/server/reds.c index c8b5fc4..c33c86c 100644 --- a/server/reds.c +++ b/server/reds.c @@ -547,7 +547,7 @@ void

Re: [Spice-devel] [PATCH] validate tcp port values

2012-07-11 Thread Alon Levy
On Wed, Jul 11, 2012 at 01:03:28PM +0200, Peter Hatina wrote: Hi, I had a request to validate TCP port values in spice-xpi, so does this make sense for you? More info at https://bugzilla.redhat.com/show_bug.cgi?id=805602 --- SpiceXPI/src/plugin/plugin.cpp | 27

Re: [Spice-devel] [PATCH] validate tcp port values

2012-07-11 Thread Peter Hatina
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 07/11/2012 01:41 PM, Christophe Fergeau wrote: On Wed, Jul 11, 2012 at 01:03:28PM +0200, Peter Hatina wrote: Hi, I had a request to validate TCP port values in spice-xpi, so does this make sense for you? This sounds like a good thing

Re: [Spice-devel] [PATCH] validate tcp port values

2012-07-11 Thread Uri Lublin
On 07/11/2012 02:03 PM, Peter Hatina wrote: Hi, I had a request to validate TCP port values in spice-xpi, so does this make sense for you? More info at https://bugzilla.redhat.com/show_bug.cgi?id=805602 --- SpiceXPI/src/plugin/plugin.cpp | 27 +-- 1 file changed,

[Spice-devel] [PATCH spice-gtk 1/2] usbutil: look up usb.ids under g_get_system_data_dirs() by default

2012-07-11 Thread Marc-André Lureau
Simplify a little bit the portability by looking up usb.ids file under g_get_system_data_dirs(). This is how most resources are found under other OS, looking up files under various places, since installation location may vary. --- gtk/spice-util-priv.h |1 + gtk/usbutil.c | 72

[Spice-devel] [PATCH spice-gtk 2/2] usbutil: fix crash on windows

2012-07-11 Thread Marc-André Lureau
vendor_count is the last access index, the actually count is +1. On Windows, it crashes later on because of corrupted memory. Thanks to valgrind for this precious help: ==4535== Invalid write of size 2 ==4535==at 0x40197E: spice_usbutil_parse_usbids (usbutil.c:170) ==4535==by 0x401CEC:

Re: [Spice-devel] [PATCH spice-gtk 1/2] usbutil: look up usb.ids under g_get_system_data_dirs() by default

2012-07-11 Thread Hans de Goede
Hi, Series looks good, ack series. Regards, Hans On 07/11/2012 02:45 PM, Marc-André Lureau wrote: Simplify a little bit the portability by looking up usb.ids file under g_get_system_data_dirs(). This is how most resources are found under other OS, looking up files under various places,

Re: [Spice-devel] [PATCH 1/2] server/red_worker: fix wrong spice_error in commit 706232a8

2012-07-11 Thread Hans de Goede
Hi, Series looks good, ack series. Regards, Hans On 07/11/2012 01:41 PM, Alon Levy wrote: --- server/red_worker.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index c492443..ac9baf2

Re: [Spice-devel] [PATCH] usb-device-manager: do not try to connect a usb device that was removed

2012-07-11 Thread Hans de Goede
Good one, ACK. On 07/11/2012 11:50 AM, Uri Lublin wrote: If a device that is asked to be shared with the guest, is unplugged out of the machine before being redirected, then let the user know that usbredir of that device failed (and cleanup nicely). For Windows client, the time between request

Re: [Spice-devel] audio issues with VD

2012-07-11 Thread David Jaša
Hi Wally, could you tell us your guest and client OS, qemu and spice version and possibly your qemu command line? David Wallace Michaelson píše v Út 10. 07. 2012 v 14:58 -0400: When I connect to the Virtual desktop with my home machine I am getting an echo in my headset. I have tried several