Re: [Spice-devel] [PATCH 1/6] usbclerk: dos2unix

2012-07-24 Thread Arnon Gilboa
Thanks Hans, I'll fix that. Hans de Goede wrote: Hi, Series looks good, only remark I have is that with 6/6 you're not passing in interface information, that really is not a good idea, since for almost all devices if you want to filter on usb classes (which you usually do) the interesting bits

Re: [Spice-devel] [PATCH 6/6] usbclerk: add device filter support

2012-07-24 Thread Uri Lublin
Hi Arnon, Two comments below. On 07/23/2012 12:23 PM, Arnon Gilboa wrote: read from HKLM\Software\USBClerk\filter_rules same format as in client --- usbclerk.cpp| 69 +++ usbclerk.vcproj | 40 +++ 2

Re: [Spice-devel] [PATCH 6/6] usbclerk: add device filter support

2012-07-24 Thread Arnon Gilboa
Uri Lublin wrote: filter_rules should be initialized to NULL and filter_count to 0. In case they are not initialized by usbredirfilter_string_to_rules (e.g. if that registry entry does not exist). sure, already fixed, name was also with no _prefix... diff --git a/usbclerk.vcproj

Re: [Spice-devel] [PATCH 2/2] Add controller messages for USB redirection

2012-07-24 Thread flooding Controlled
Hi: The code ''' * @rule1|@rule2|@rule3 * * The default setting filters out HID (class 0x03) USB devices from auto * connect and auto connects anything else. Note the explicit allow rule at * the end, this is necessary since by default all devices without a *

Re: [Spice-devel] [PATCH 2/2] Add controller messages for USB redirection

2012-07-24 Thread Hans de Goede
Hi, On 07/24/2012 02:22 PM, flooding Controlled wrote: Hi: The code ''' * @rule1|@rule2|@rule3 * * The default setting filters out HID (class 0x03) USB devices from auto * connect and auto connects anything else. Note the explicit allow rule at * the end, this

Re: [Spice-devel] [PATCH 2/2] Add controller messages for USB redirection

2012-07-24 Thread flooding Controlled
Yes , I am on Linux client. And I attach the log as you mentioned above. So, I seem to get some inspire, the value of the rule is some item in the log, right ? Thanks! 2012/7/24 Hans de Goede hdego...@redhat.com Hi, On 07/24/2012 02:22 PM, flooding Controlled wrote: Hi: The code

Re: [Spice-devel] [PATCH 2/2] Add controller messages for USB redirection

2012-07-24 Thread Hans de Goede
Hi, On 07/24/2012 03:50 PM, flooding Controlled wrote: Yes , I am on Linux client. And I attach the log as you mentioned above. Hmm, looking at the log it seems that you're running your linux client inside a vmware vm ?? Regards, Hans ___

Re: [Spice-devel] [PATCH 2/2] Add controller messages for USB redirection

2012-07-24 Thread flooding Controlled
Yes! Can you tell me how to reflect the rule value to the log I attatch ? Thanks! 2012/7/24 Hans de Goede hdego...@redhat.com Hi, On 07/24/2012 03:50 PM, flooding Controlled wrote: Yes , I am on Linux client. And I attach the log as you mentioned above. Hmm, looking at the log it seems

Re: [Spice-devel] [PATCH 2/2] Add controller messages for USB redirection

2012-07-24 Thread Hans de Goede
Hi, On 07/24/2012 03:56 PM, flooding Controlled wrote: Yes! Can you tell me how to reflect the rule value to the log I attatch ? So have you redirect the printer to the vmware-vm ? Otherwise things don't work also stacking redirection on redirection is going to be really hard to debug ... Can

Re: [Spice-devel] [PATCH 2/2] Add controller messages for USB redirection

2012-07-24 Thread flooding Controlled
Oh~~ I am sorry that in my company we have to use vms... Though I think that a real machine is more perfect... I catch a new part of log with my USB plugin in . Bus 001 Device 003: ID 154b:6001 PNY Device Descriptor: bLength18 bDescriptorType 1 bcdUSB

Re: [Spice-devel] [PATCH 2/2] Add controller messages for USB redirection

2012-07-24 Thread Hans de Goede
Hi, On 07/24/2012 04:03 PM, flooding Controlled wrote: Oh~~ I am sorry that in my company we have to use vms... Though I think that a real machine is more perfect... I catch a new part of log with my USB plugin in . Bus 001 Device 003: ID 154b:6001 PNY Device Descriptor: bLength

Re: [Spice-devel] [PATCH 2/2] Add controller messages for USB redirection

2012-07-24 Thread David Jaša
Hans de Goede píše v Út 24. 07. 2012 v 16:14 +0200: Hi, On 07/24/2012 04:03 PM, flooding Controlled wrote: Oh~~ I am sorry that in my company we have to use vms... Though I think that a real machine is more perfect... I catch a new part of log with my USB plugin in . Bus 001

Re: [Spice-devel] [PATCH 2/2] Add controller messages for USB redirection

2012-07-24 Thread Hans de Goede
Hi, On 07/24/2012 04:25 PM, flooding Controlled wrote: Hi: I catch a log from my guys's real PC. And it seems that the device Bus 001 Device 035: ID 0557:2407 ATEN International Co., Ltd is filtered by the default rule I mentioned above. Can you tell me how the rule match now ? Thanks a

[Spice-devel] guytricht...@gmail.com

2012-07-24 Thread Guy Trichter
-- *Guy Trichter* ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/spice-devel