[Spice-devel] [PATCH 01/10] red_worker: mark DRAW_ALL as broken

--- server/red_worker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/red_worker.c b/server/red_worker.c index 9896696..08e2a43 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -87,6 +87,7 @@ //#define DUMP_BITMAP //#define PIPE_DEBUG //#define RED_WORKER_STAT +/*

[Spice-devel] [PATCH 02/10] server/red_worker.c:red_process_drawable: rename drawable to red_drawable

--- server/red_worker.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 08e2a43..29a6295 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4185,11 +4185,11 @@ static inline void

[Spice-devel] [PATCH 03/10] server/red_worker.c:red_process_drawable: rename item to drawable

--- server/red_worker.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 29a6295..0674174 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4189,23 +4189,23 @@ static inline void

[Spice-devel] [PATCH 04/10] server: move dump_bitmap to separate file

--- server/Makefile.am | 2 + server/red_worker.c | 157 ++-- server/spice_bitmap_utils.c | 152 ++ server/spice_bitmap_utils.h | 6 ++ 4 files changed, 164 insertions(+), 153 deletions(-) create

[Spice-devel] [PATCH 07/10] server: move surface_format_to_image_type to spice_bitmap_utils

--- server/red_worker.c | 24 ++-- server/spice_bitmap_utils.c | 17 + server/spice_bitmap_utils.h | 2 ++ 3 files changed, 21 insertions(+), 22 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 334a709..0aa00be 100644 ---

[Spice-devel] [PATCH 05/10] server: move bit set/clear utilities out of red_worker.h

--- server/Makefile.am | 1 + server/red_dispatcher.c | 4 +++- server/red_worker.c | 1 + server/red_worker.h | 18 -- 4 files changed, 5 insertions(+), 19 deletions(-) diff --git a/server/Makefile.am b/server/Makefile.am index e5392ba..feee2f1 100644 ---

[Spice-devel] [PATCH 08/10] server/red_worker: s/image_cache_eaging/image_cache_aging/

--- server/red_worker.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 0aa00be..2cd2b1a 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4431,7 +4431,7 @@ static void image_cache_reset(ImageCache *cache)

[Spice-devel] [PATCH 06/10] server: move three functions to red_channel

Three blocking functions, one was split to leave the display channel specific referencing of the DrawablePipeItem being sent inside red_worker, but the rest (most) of the timeout logic was moved to red_channel, including the associated constants. Moved functions:

[Spice-devel] [PATCH 10/10] shared memory support for display channel.

See spice-protocol commit f24154b87f92ae65b1aa83b97378f9c687d09017 for complete details. --- configure.ac | 4 +- server/red_dispatcher.c| 50 - server/red_dispatcher.h| 4 + server/red_worker.c| 413

[Spice-devel] [PATCH 09/10] server: split spice_image_cache from red_worker

--- server/Makefile.am | 2 + server/red_worker.c| 158 + server/spice_image_cache.c | 135 ++ server/spice_image_cache.h | 39 +++ spice-common | 2 +- 5 files changed, 178

Re: [Spice-devel] [PATCH 05/10] server: move bit set/clear utilities out of red_worker.h

Hi, You forgot to add spice_server_utils.h :) Yonit. On 08/12/2013 08:49 AM, Alon Levy wrote: --- server/Makefile.am | 1 + server/red_dispatcher.c | 4 +++- server/red_worker.c | 1 + server/red_worker.h | 18 -- 4 files changed, 5 insertions(+), 19

Re: [Spice-devel] [PATCH 01/10] red_worker: mark DRAW_ALL as broken

Please ignore this patchset, I did two mistakes, sending the shared memory not-yet-done patches and merging spice-common change from them into the patch before last. - Original Message - --- server/red_worker.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Spice-devel] [PATCH 04/10] server: move dump_bitmap to separate file

Hi, Just a nitpick (below) On 08/12/2013 08:49 AM, Alon Levy wrote: --- server/Makefile.am | 2 + server/red_worker.c | 157 ++-- server/spice_bitmap_utils.c | 152 ++

Re: [Spice-devel] [PATCH 07/10] server: move surface_format_to_image_type to spice_bitmap_utils

- Mensaje original - --- server/red_worker.c | 24 ++-- server/spice_bitmap_utils.c | 17 + server/spice_bitmap_utils.h | 2 ++ 3 files changed, 21 insertions(+), 22 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c

Re: [Spice-devel] [PATCH 05/10] server: move bit set/clear utilities out of red_worker.h

On Mon, Aug 12, 2013 at 09:08:36AM -0400, Yonit Halperin wrote: Hi, You forgot to add spice_server_utils.h :) There's a spice-common/common/bitops.h file, maybe it makes sense to have these functions there? Christophe pgpoX_7Se7vV1.pgp Description: PGP signature

Re: [Spice-devel] [PATCH 05/10] server: move bit set/clear utilities out of red_worker.h

On Mon, Aug 12, 2013 at 10:41:43AM -0400, Alon Levy wrote: On Mon, Aug 12, 2013 at 09:08:36AM -0400, Yonit Halperin wrote: Hi, You forgot to add spice_server_utils.h :) There's a spice-common/common/bitops.h file, maybe it makes sense to have these functions there? But now

Re: [Spice-devel] [PATCH 05/10] server: move bit set/clear utilities out of red_worker.h

On Mon, Aug 12, 2013 at 09:08:36AM -0400, Yonit Halperin wrote: Hi, You forgot to add spice_server_utils.h :) There's a spice-common/common/bitops.h file, maybe it makes sense to have these functions there? But now that we have spice-common as a submodule, and since these functions

[Spice-devel] [PATCH v2 1/9] red_worker: mark DRAW_ALL as broken

--- server/red_worker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/red_worker.c b/server/red_worker.c index 9896696..08e2a43 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -87,6 +87,7 @@ //#define DUMP_BITMAP //#define PIPE_DEBUG //#define RED_WORKER_STAT +/*

[Spice-devel] [PATCH v2 2/9] server/red_worker.c:red_process_drawable: rename drawable to red_drawable

--- server/red_worker.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 08e2a43..29a6295 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4185,11 +4185,11 @@ static inline void

[Spice-devel] [PATCH v2 3/9] server/red_worker.c:red_process_drawable: rename item to drawable

--- server/red_worker.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 29a6295..0674174 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4189,23 +4189,23 @@ static inline void

[Spice-devel] [PATCH v2 5/9] server: move bit set/clear utilities out of red_worker.h

--- server/Makefile.am | 1 + server/red_dispatcher.c | 4 +++- server/red_worker.c | 1 + server/red_worker.h | 18 -- server/spice_server_utils.h | 23 +++ 5 files changed, 28 insertions(+), 19 deletions(-) create mode 100644

[Spice-devel] [PATCH v2 4/9] server: move dump_bitmap to separate file

--- server/Makefile.am | 2 + server/red_worker.c | 157 ++-- server/spice_bitmap_utils.c | 150 ++ server/spice_bitmap_utils.h | 6 ++ 4 files changed, 162 insertions(+), 153 deletions(-) create

[Spice-devel] [PATCH v2 6/9] server: move three functions to red_channel

Three blocking functions, one was split to leave the display channel specific referencing of the DrawablePipeItem being sent inside red_worker, but the rest (most) of the timeout logic was moved to red_channel, including the associated constants. Moved functions:

[Spice-devel] [PATCH v2 7/9] server: move surface_format_to_image_type to spice_bitmap_utils

--- server/red_worker.c | 28 server/spice_bitmap_utils.c | 17 + server/spice_bitmap_utils.h | 2 ++ 3 files changed, 23 insertions(+), 24 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 334a709..f1b7db6 100644 ---

Re: [Spice-devel] [PATCH v2 6/9] server: move three functions to red_channel

Hi, red_time.h is missing. On 08/12/2013 11:32 AM, Alon Levy wrote: Three blocking functions, one was split to leave the display channel specific referencing of the DrawablePipeItem being sent inside red_worker, but the rest (most) of the timeout logic was moved to red_channel, including the

Re: [Spice-devel] [PATCH v2 6/9] server: move three functions to red_channel

Hi, I think red_channel_client_wait_pipe_item_sent should ref and unref the pipe item by itself (using the hold/release-item callbacks). Then, you don't need dcc_wait_pipe_item_sent. Also, I'm not sure why PUSH_TIMEOUT is bigger than DETACH timeout. It would have been logical if the bigger

Re: [Spice-devel] [PATCH v2 6/9] server: move three functions to red_channel

Hi, I think red_channel_client_wait_pipe_item_sent should ref and unref the pipe item by itself (using the hold/release-item callbacks). Then, you don't need dcc_wait_pipe_item_sent. This is a bit scarier then my mechanical change. Since there are two versions of the release function, for

Re: [Spice-devel] [PATCH v2 6/9] server: move three functions to red_channel

On 08/12/2013 12:32 PM, Alon Levy wrote: Hi, I think red_channel_client_wait_pipe_item_sent should ref and unref the pipe item by itself (using the hold/release-item callbacks). Then, you don't need dcc_wait_pipe_item_sent. This is a bit scarier then my mechanical change. Since there are two

[Spice-devel] kbd_push_scan does not take effect for modifier key

hi, sometime modifier key state is not right. Spice-Warning **: inputs_channel.c:442:inputs_channel_handle_parsed: YY 0 leds=0, modifiers=6 Spice-Warning **: inputs_channel.c:442:inputs_channel_handle_parsed: YY 1 leds=0, modifiers=6 Spice-Warning **: