[Spice-devel] [PATCH 2/3] Introduce red_link_info_test_capability()

2014-03-20 Thread Christophe Fergeau
This just hides a bit of pointer arithmetic away from reds_send_link_ack. This helper will be used in the next commits. --- server/reds.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/server/reds.c b/server/reds.c index fb2a19b..79a685b 100644 ---

[Spice-devel] [PATCHv2 0/3] Fix use of SPICE in fips mode

2014-03-20 Thread Christophe Fergeau
In FIPS mode, the 1024 bit RSA key which is hardcoded in the protocol through SpiceLinkReply::pub_key cannot be created, causing any connection attempt to fail as it's unconditionnally generated. However, when using SASL, we don't need that key. Unfortunately, we don't have way of knowing if the

Re: [Spice-devel] [PATCH spice-gtk 1/2] Add webdav channel

2014-03-20 Thread Alon Levy
On 03/19/2014 07:33 PM, Marc-André Lureau wrote: Hi On Mon, Mar 17, 2014 at 8:54 AM, Alon Levy al...@redhat.com wrote: Would be nice to use an actual constant for this instead of relying on G_MAXUINT16 here and above. Sorry, I forgot to address your comments. What about

[Spice-devel] [PATCH 3/3] Don't set SpiceLinkReply::pub_key if client advertises SASL cap

2014-03-20 Thread Christophe Fergeau
If the client advertises the SASL cap, it means it guarantees it will be able to use SASL if the server supports, and that it does not need a valid SpiceLinkReply::pub_key field when using SASL. When the client cap is set, we thus don't need to create a RSA public key if SASL is enabled server

Re: [Spice-devel] [PATCH 8/9] Ask for unencrypted tickets if client supports it

2014-03-20 Thread Christophe Fergeau
Hey, On Wed, Mar 12, 2014 at 06:45:37PM +, Dietmar Maurer wrote: support for unencrypted tickets, the server can instruct it it should send one. For now, this is restricted to encrypted channels as we don't want to expose an unencrypted password over a non-TLS channel. Clients with

Re: [Spice-devel] [PATCH spice] Translate docbook - asciidoc

2014-03-20 Thread Christophe Fergeau
Hey, On Wed, Mar 19, 2014 at 02:07:39PM +0100, Marc-André Lureau wrote: It's much much easier to read and edit Hmm, this changes things to one big txt file and one big html file. The one source file per section approach plus one html file per section versions were imo easier to handle, is it

[Spice-devel] [spice-gtk] Advertise SASL cap from client

2014-03-20 Thread Christophe Fergeau
A client setting this capability indicates to the server that it's able to handle SASL authentication, and it also indicates that if SASL is to be used for authentication, then it won't expect a valid 'pub_key' field in SpiceLinkReply. The reason for making guarantees about not looking at the

[Spice-devel] [PATCH 1/3] Add const to test_capability first argument

2014-03-20 Thread Christophe Fergeau
We don't modify the capabilities content, so it can be marked as const. --- server/red_channel.c | 2 +- server/red_channel.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 4f85365..617a0df 100644 --- a/server/red_channel.c

Re: [Spice-devel] [PATCH spice] Translate docbook - asciidoc

2014-03-20 Thread Marc-André Lureau
On Thu, Mar 20, 2014 at 12:11 PM, Christophe Fergeau cferg...@redhat.comwrote: Hey, On Wed, Mar 19, 2014 at 02:07:39PM +0100, Marc-André Lureau wrote: It's much much easier to read and edit Hmm, this changes things to one big txt file and one big html file. The one source file per section

Re: [Spice-devel] [spice-gtk] Advertise SASL cap from client

2014-03-20 Thread Marc-André Lureau
- Original Message - A client setting this capability indicates to the server that it's able to handle SASL authentication, and it also indicates that if SASL is to be used for authentication, then it won't expect a valid 'pub_key' field in SpiceLinkReply. sounds good to me. ack

Re: [Spice-devel] [PATCH 1/3] Add const to test_capability first argument

2014-03-20 Thread Marc-André Lureau
trivial, ack - Original Message - We don't modify the capabilities content, so it can be marked as const. --- server/red_channel.c | 2 +- server/red_channel.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index

Re: [Spice-devel] [PATCH spice] Translate docbook - asciidoc

2014-03-20 Thread Marc-André Lureau
- Original Message - Hey, On Wed, Mar 19, 2014 at 02:07:39PM +0100, Marc-André Lureau wrote: It's much much easier to read and edit Hmm, this changes things to one big txt file and one big html file. The one source file per section approach plus one html file per section

[Spice-devel] virt-viewer for Windows is quite difficult to download

2014-03-20 Thread Anthony Loiseau
Dear spice developpers and dear spice-space website maintainers, For you to know, the link to download virt viewer windows installer (msi file) is currently buggy. Page : http://www.spice-space.org/download.html extract : virt-viewer Windows installer - 32 bit -

Re: [Spice-devel] [PATCH spice] Translate docbook - asciidoc

2014-03-20 Thread Christophe Fergeau
On Thu, Mar 20, 2014 at 09:06:51AM -0400, Marc-André Lureau wrote: - Original Message - Hey, On Wed, Mar 19, 2014 at 02:07:39PM +0100, Marc-André Lureau wrote: It's much much easier to read and edit Hmm, this changes things to one big txt file and one big html file.

Re: [Spice-devel] virt-viewer for Windows is quite difficult to download

2014-03-20 Thread Christophe Fergeau
Hey, On Thu, Mar 20, 2014 at 02:12:47PM +0100, Anthony Loiseau wrote: Dear spice developpers and dear spice-space website maintainers, For you to know, the link to download virt viewer windows installer (msi file) is currently buggy. Page : http://www.spice-space.org/download.html

Re: [Spice-devel] [PATCH spice] Translate docbook - asciidoc

2014-03-20 Thread Jonathon Jongsma
for what it's worth, I think asciidoc looks a bit easier to maintain, so I'm in favor of using it. I don't really have an opinion on the other issues. - Original Message - From: Christophe Fergeau cferg...@redhat.com To: Marc-André Lureau mlur...@redhat.com Cc:

Re: [Spice-devel] virt-viewer for Windows is quite difficult to download

2014-03-20 Thread Jonathon Jongsma
alternately, we could just change the link text to something else so the user doesn't think that the link will lead directly to an .msi file? - Original Message - From: Christophe Fergeau cferg...@redhat.com To: Anthony Loiseau anthony.lois...@gmail.com Cc:

Re: [Spice-devel] [PATCH spice] Translate docbook - asciidoc

2014-03-20 Thread Christophe Fergeau
On Thu, Mar 20, 2014 at 01:50:31PM +0100, Marc-André Lureau wrote: On Thu, Mar 20, 2014 at 12:11 PM, Christophe Fergeau cferg...@redhat.comwrote: Hey, On Wed, Mar 19, 2014 at 02:07:39PM +0100, Marc-André Lureau wrote: It's much much easier to read and edit Hmm, this changes

Re: [Spice-devel] [PATCH spice] Translate docbook - asciidoc

2014-03-20 Thread Marc-André Lureau
On Thu, Mar 20, 2014 at 3:28 PM, Christophe Fergeau cferg...@redhat.comwrote: It seems it does not create previous/next/up links, which is not really useful :( a2x -f chunked manual.txt works here (see also the nice pdf output etc) -- Marc-André Lureau

Re: [Spice-devel] [PATCH 2/3] Introduce red_link_info_test_capability()

2014-03-20 Thread Marc-André Lureau
ack - Original Message - This just hides a bit of pointer arithmetic away from reds_send_link_ack. This helper will be used in the next commits. --- server/reds.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/server/reds.c

Re: [Spice-devel] virt-viewer for Windows is quite difficult to download

2014-03-20 Thread Uri Lublin
On 03/20/2014 04:22 PM, Jonathon Jongsma wrote: alternately, we could just change the link text to something else so the user doesn't think that the link will lead directly to an .msi file? Done. Thanks, Uri. ___ Spice-devel mailing list