FeatureScore is the only difference between the _vista options and the
rest, so just setting it also for windows xp using drivers results in a
simplification of the inf file, and no downside.
According to [1] we use a feature score of FC to indicate a windows 2000
display driver
[1]
---
xddm/build.bat | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/xddm/build.bat b/xddm/build.bat
index 1d19875..7dfe51b 100755
--- a/xddm/build.bat
+++ b/xddm/build.bat
@@ -16,6 +16,12 @@ if not DEFINED SPICE_COMMON_DIR (
set
---
xddm/build.bat | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/xddm/build.bat b/xddm/build.bat
index 7dfe51b..b2c5149 100755
--- a/xddm/build.bat
+++ b/xddm/build.bat
@@ -30,9 +30,10 @@ if not x%1 == x set DEST=%1
:build
cd miniport
-build -cZg
+build -ceZg
cd
---
xddm/display/amd64/x64.asm | 1 +
xddm/display/sources | 1 +
2 files changed, 2 insertions(+)
create mode 100644 xddm/display/amd64/x64.asm
diff --git a/xddm/display/amd64/x64.asm b/xddm/display/amd64/x64.asm
new file mode 100644
index 000..e32b0df
--- /dev/null
+++
---
xddm/display/res.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xddm/display/res.h b/xddm/display/res.h
index 6ce9a68..4d179c5 100644
--- a/xddm/display/res.h
+++ b/xddm/display/res.h
@@ -74,4 +74,4 @@ void EmptyReleaseRing(PDev *pdev);
void
---
xddm/display/driver.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/xddm/display/driver.c b/xddm/display/driver.c
index aa4fe42..5a3dbfa 100644
--- a/xddm/display/driver.c
+++ b/xddm/display/driver.c
@@ -1252,20 +1252,6 @@ char *BitmapTypeToStr(int type)
#include utils.h
From: Yonit Halperin yhalp...@redhat.com
This reverts commit 49feefa95d3595f04355c4aed53ec5bf26551046.
The patch causes the display to get stuck. Till we understand exactly
why, I'm reverting it.
---
xddm/miniport/qxl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xddm/miniport/qxl.c
---
xddm/display/res.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/xddm/display/res.c b/xddm/display/res.c
index bfb3571..289ece5 100644
--- a/xddm/display/res.c
+++ b/xddm/display/res.c
@@ -1811,13 +1811,11 @@ static void FreeBitmapImage(PDev *pdev,
This patchset ultimately does a little cleanup and mainly removes all inline
assembly that was used to supposedly have a faster memcpy implementation.
The patchset includes an amd64 implementation of the fast_memcpy_aligned and
fast_memcpy_unaligned functions and benchmarks comparing them to
It is common practice to use RtlCopyMemory. Currently it is defined by the
preprocessor to be memcpy, which outperforms our implementation, see
previous benchmark commit.
This commit removes the benchmarks and our internal implementation in
favor of RtlCopyMemory.
RHBZ: 705785
---
---
xddm/display/amd64/x64.asm | 13 +
xddm/display/res.c | 4
2 files changed, 17 insertions(+)
diff --git a/xddm/display/amd64/x64.asm b/xddm/display/amd64/x64.asm
index e32b0df..36971d3 100644
--- a/xddm/display/amd64/x64.asm
+++ b/xddm/display/amd64/x64.asm
@@ -1
Two benchmarks:
1. standalone, actually uses LIBCMT's memcpy to compare.
2. Part of qxldd.dll (in display/res.c called from display/driver.c)
so using the same implementation.
Note: next commit removes benchmark code as well as fast_memcpy_* code
and related SSE check and FPU save/restore.
Some notes:
Follows AMD64 calling conventions.
Uses masm 64 (ml64.exe).
Dropped in the next patches because it is too slow.
---
xddm/display/amd64/x64.asm | 236 +
xddm/display/res.c | 13 +--
2 files changed, 241 insertions(+), 8 deletions(-)
I forgot to mention in the cover letter: I fixed the comment here per
old review by Yonit.
Review appreciated!
On 04/30/2014 05:40 PM, Alon Levy wrote:
FeatureScore is the only difference between the _vista options and the
rest, so just setting it also for windows xp using drivers results in a
ack,
should the bug state be changed back to ASSIGNED?
- Original Message -
From: Yonit Halperin yhalp...@redhat.com
This reverts commit 49feefa95d3595f04355c4aed53ec5bf26551046.
The patch causes the display to get stuck. Till we understand exactly
why, I'm reverting it.
---
- Original Message -
---
xddm/build.bat | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/xddm/build.bat b/xddm/build.bat
index 1d19875..7dfe51b 100755
--- a/xddm/build.bat
+++ b/xddm/build.bat
@@ -16,6 +16,12 @@ if not DEFINED SPICE_COMMON_DIR
ack
- Original Message -
---
xddm/build.bat | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/xddm/build.bat b/xddm/build.bat
index 7dfe51b..b2c5149 100755
--- a/xddm/build.bat
+++ b/xddm/build.bat
@@ -30,9 +30,10 @@ if not x%1 == x set DEST=%1
:build
trivial, ack
- Original Message -
---
xddm/display/driver.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/xddm/display/driver.c b/xddm/display/driver.c
index aa4fe42..5a3dbfa 100644
--- a/xddm/display/driver.c
+++ b/xddm/display/driver.c
@@ -1252,20 +1252,6
Hi Christophe,
I don't understand what exactly goes wrong and how this
patch fixes the race.
On 04/01/2014 04:58 PM, Christophe Fergeau wrote:
During seamless migration, after switching host, if a client was connected
during the migration, it will have data to send back to the new
I opened.
https://bugs.freedesktop.org/show_bug.cgi?id=78131
- Original Message -
From: Greg Sheremeta gsher...@redhat.com
To: David Mansfield sp...@dm.cobite.com
Cc: spice-devel@lists.freedesktop.org
Sent: Monday, April 28, 2014 9:53:15 AM
Subject: Re: [Spice-devel] [PATCH] how can
20 matches
Mail list logo
