Re: [Spice-devel] [PATCH spice-protocol] Add agent information message

2014-10-24 Thread Pavel Grunt
Hi, I wanted to show information about the agent in the Guest Details dialog of virt-viewer ( http://people.freedesktop.org/~pgrunt/guest_details.png ). The information about other components (qxl driver, spice server) may also be displayed there as well. I think this can be useful for a user

[Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-24 Thread Marc-André Lureau
In an effort to reduce the wakeups per second, get rid of the write_to_dev timer when the implementation supports SPICE_CHAR_DEVICE_NOTIFY_WRITABLE. When this flag is set, the frontend instance is responsible for calling spice_char_device_wakeup() when the device is ready to perform IO. Related

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-24 Thread Christophe Fergeau
On Fri, Oct 24, 2014 at 10:54:24AM +0200, Marc-André Lureau wrote: @@ -407,6 +407,10 @@ typedef struct SpiceCharDeviceInterface SpiceCharDeviceInterface; typedef struct SpiceCharDeviceInstance SpiceCharDeviceInstance; typedef struct SpiceCharDeviceState SpiceCharDeviceState; +typedef

Re: [Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-24 Thread Marc-André Lureau
- Original Message - On Fri, Oct 24, 2014 at 10:54:24AM +0200, Marc-André Lureau wrote: @@ -407,6 +407,10 @@ typedef struct SpiceCharDeviceInterface SpiceCharDeviceInterface; typedef struct SpiceCharDeviceInstance SpiceCharDeviceInstance; typedef struct SpiceCharDeviceState

[Spice-devel] [PATCH spice] chardev: remove write polling

2014-10-24 Thread Marc-André Lureau
In an effort to reduce the wakeups per second, get rid of the write_to_dev timer when the implementation supports SPICE_CHAR_DEVICE_NOTIFY_WRITABLE. When this flag is set, the frontend instance is responsible for calling spice_char_device_wakeup() when the device is ready to perform IO. Related

[Spice-devel] [PATCH spice] Validate RedDrawable bbox before allocating drawable

2014-10-24 Thread Marc-André Lureau
Avoid unnecessary allocation (and possibly leaking) if the RedDrawable doesn't validate_drawable_bbox() Related to: rhbz#1135372 --- server/red_worker.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index e177b68..d56db35

Re: [Spice-devel] [PATCH spice] Validate RedDrawable bbox before allocating drawable

2014-10-24 Thread Christophe Fergeau
Hey, On Fri, Oct 24, 2014 at 03:10:29PM +0200, Marc-André Lureau wrote: Avoid unnecessary allocation (and possibly leaking) if the RedDrawable doesn't validate_drawable_bbox() Related to: rhbz#1135372 --- server/red_worker.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)

[Spice-devel] [PATCHv2 spice] Validate RedDrawable before allocating drawable

2014-10-24 Thread Marc-André Lureau
Avoid unnecessary allocation (and possibly leaking) if the RedDrawable is not valid. Related to: rhbz#1135372 --- server/red_worker.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index e177b68..9f18495

[Spice-devel] [PATCH spice-protocol v2] Add agent information message

2014-10-24 Thread Pavel Grunt
Message will be used by client for requesting an information about a version of the agent running on the guest side. --- v2: - removed 'type' field from VDAgentInformation - VD_AGENT_INFORMATION changed to VD_AGENT_GUEST_VERSION VDAgentInformation changed to VDAgentGuestVersion - added

[Spice-devel] [PATCH win32/vd_agent] Support for the VD_AGENT_GUEST_VERSION message

2014-10-24 Thread Pavel Grunt
The agent will send an information about its version to the client when VD_AGENT_CAP_GUEST_VERSION is set. --- depends on http://lists.freedesktop.org/archives/spice-devel/2014-October/017669.html --- vdagent/vdagent.cpp | 41 - 1 file changed, 40

[Spice-devel] [PATCH linux/vd_agent] Support for the VD_AGENT_GUEST_VERSION message

2014-10-24 Thread Pavel Grunt
The agent will send an information about its version to the client when VD_AGENT_CAP_GUEST_VERSION is set. --- depends on http://lists.freedesktop.org/archives/spice-devel/2014-October/017669.html --- src/vdagentd.c | 16 1 file changed, 16 insertions(+) diff --git

Re: [Spice-devel] [PATCH spice-protocol v2] Add agent information message

2014-10-24 Thread Marc-André Lureau
- Original Message - Message will be used by client for requesting an information about a version of the agent running on the guest side. --- v2: - removed 'type' field from VDAgentInformation - VD_AGENT_INFORMATION changed to VD_AGENT_GUEST_VERSION VDAgentInformation changed

[Spice-devel] [PATCH spice 1/4] Split spice.h

2014-10-24 Thread Marc-André Lureau
Make it easier to read the Spice server API. --- server/Makefile.am | 23 +- server/spice-audio.h | 96 server/spice-char.h | 61 + server/spice-core.h | 106 + server/spice-input.h | 91 +++ server/spice-migration.h | 64 +

[Spice-devel] [PATCH spice 2/4] s/SPICE_SERVER_INTERNAL/SPICE_COMPILATION

2014-10-24 Thread Marc-André Lureau
Use a more descriptive name for when the files are used during our compilation. --- server/Makefile.am | 2 +- server/spice-audio.h | 2 +- server/spice-char.h | 2 +- server/spice-core.h | 4 ++-- server/spice-input.h | 2 +- server/spice-migration.h | 2 +-

[Spice-devel] [PATCH spice 3/4] Remove spice-experimental

2014-10-24 Thread Marc-André Lureau
Remove unneded symbols that nobody should be using anyway. The ABI is broken, so we may bump library version or ignore functions removed (just like when tunneling support was removed) --- server/Makefile.am | 1 - server/reds.c | 18 -- server/smartcard.h

[Spice-devel] [PATCH spice 0/4] Various public headers cleanups

2014-10-24 Thread Marc-André Lureau
Hi, A small series to cleanup the server public headers and hopefully improve readability that way. Marc-André Lureau (4): Split spice.h s/SPICE_SERVER_INTERNAL/SPICE_COMPILATION Remove spice-experimental build-sys: generate spice-version.h configure.ac| 11 +

[Spice-devel] [PATCH spice 4/4] build-sys: generate spice-version.h

2014-10-24 Thread Marc-André Lureau
Editing the hexadecimal value of spice-version and keeping it in sync with actual release is a bit tedious. Let's generate it automatically (although handling of bumps will need temporarily static versions, when 0.12 - 1.0 for example) --- configure.ac | 11 +++

[Spice-devel] [PATCH spice-gtk 2/2] gtk: hide cursor when ungrabbed

2014-10-24 Thread Marc-André Lureau
Let's avoid confusion of multiple pointers visible on the client desktop: hide the guest pointer if the spice client doesn't have the grab, display it grain when the grab is taken back. --- gtk/spice-widget-cairo.c | 2 +- gtk/spice-widget.c | 7 --- 2 files changed, 5 insertions(+), 4

[Spice-devel] [PATCH spice-gtk 1/2] gtk: keep cursor in the same place on ungrab

2014-10-24 Thread Marc-André Lureau
On ungrab, the transition from remote (server-side) cursor to host cursor makes it jump somewhere else rather than staying at the same place. Restore cursor position on ungrab to match with guest position. https://bugs.freedesktop.org/show_bug.cgi?id=85117 --- gtk/spice-widget.c | 13

[Spice-devel] [PATCH] server: multiple clients works ok if we limit the pipe to the slowest client

2014-10-24 Thread Fabiano Fidêncio
From: Alon Levy a...@pobox.com --- server/red_worker.c | 5 +++-- server/reds.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index e177b68..8fed870 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4961,7

[Spice-devel] Spice and containers

2014-10-24 Thread ven...@gmail.com
Hi, because docker is coming in, I ask me if it recommendable to run spice/xspice in containers like docker instead of qemu/kvm? Or are containers not usefull for desktop virtualization? ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org

Re: [Spice-devel] [vdagent-linux v2] randr: handle XRRScreenChangeNotifyEvent

2014-10-24 Thread Alon Levy
On 10/08/2014 01:10 PM, Marc-André Lureau wrote: ping I didn't test this, looks good, just one single line if, do with it as you will. And unrelated, but you use TRUE/FALSE constants for handled, maybe nice to use them too (at least be consistent that is) in vdagent_x11_handle_event. On Mon,

Re: [Spice-devel] [vdagent-linux 1/2] randr: remove monitors.xml on auto-configuration

2014-10-24 Thread Christophe Fergeau
On Wed, Oct 08, 2014 at 12:28:53PM +0200, Marc-André Lureau wrote: Hi On Thu, Oct 2, 2014 at 2:10 PM, Christophe Fergeau cferg...@redhat.com wrote: Hey, On Wed, Aug 27, 2014 at 07:22:07PM +0200, Marc-André Lureau wrote: From: Marc-Andre Lureau marcandre.lur...@redhat.com

Re: [Spice-devel] win 7 terminal recognize usb as libusbx devicewhen exiting usb redirect

2014-10-24 Thread ????
On 10/22/2014 04:40 AM, wrote: hi, all: environment: terminal: win 7 guest: win 7 usb redirect: usb clerk (provided by Cody Chan) usb device: kinston data traveller 8G teclast 16G (use correctly) usb harddisk (use correctly)

Re: [Spice-devel] Spice and containers

2014-10-24 Thread Scott Dowdle
Greetings, - Original Message - Hi, because docker is coming in, I ask me if it recommendable to run spice/xspice in containers like docker instead of qemu/kvm? Or are containers not usefull for desktop virtualization? A Docker container is for a single application. Doing more than