Re: [Spice-devel] [PATCH spice-server 00/15] Remove unused functions

> > Hi, > > I noticed that there are some unused functions in our code. > Some of them were just defined, but haven't been used, others > stopped being used because some other functions were changed/removed. > I'm not sure about last 3-4 patches - if _create() is called then > it would make

[Spice-devel] [PATCH 04/18] worker: move dcc_add_drawable*

From: Marc-André Lureau --- server/dcc.c | 82 +++ server/dcc.h | 17 ++ server/display-channel.c | 65 + server/display-channel.h | 19 +-- server/red_worker.c | 144

[Spice-devel] [PATCH 01/18] worker: move more free_glz_drawable

From: Marc-André Lureau Acked-by: Fabiano Fidêncio --- server/dcc-encoders.c| 55 ++ server/dcc-encoders.h| 7 +++-- server/display-channel.c | 22 +++ server/display-channel.h | 1 +

[Spice-devel] [PATCH 07/18] stream: minor simplification

From: Marc-André Lureau --- server/red_worker.c | 2 +- server/stream.c | 21 +++-- server/stream.h | 3 +-- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 09ebc0d..ef27ebe

[Spice-devel] [PATCH 03/18] worker: improve some pre-conditions

From: Marc-André Lureau --- server/red_worker.c | 35 ++- 1 file changed, 2 insertions(+), 33 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 6e859fe..f6dfe28 100644 --- a/server/red_worker.c +++

[Spice-devel] [PATCH 02/18] worker: move attach_stream

From: Marc-André Lureau --- server/dcc.c| 5 ++-- server/red_worker.c | 74 +++-- server/stream.c | 65 -- server/stream.h | 1 - 4 files changed, 74

[Spice-devel] [PATCH 05/18] worker: tidy up cursor_connect a bit

From: Marc-André Lureau --- server/cursor-channel.c | 4 server/red_worker.c | 60 + 2 files changed, 30 insertions(+), 34 deletions(-) diff --git a/server/cursor-channel.c b/server/cursor-channel.c index

[Spice-devel] [PATCH 14/18] worker: move spice_bitmap_get_line

From: Marc-André Lureau --- server/spice_bitmap_utils.c | 27 +++ server/spice_bitmap_utils.h | 3 +++ 2 files changed, 30 insertions(+) diff --git a/server/spice_bitmap_utils.c b/server/spice_bitmap_utils.c index ae3fc8b..3b992a7 100644 ---

Re: [Spice-devel] [PATCH] log: add not fatal spice_return function

On Fri, 2015-11-20 at 12:31 +, Frediano Ziglio wrote: > Due to implementation details spice_return is by default fatal (program > is aborting). This is quite confusing but changing the current macros > would possibly break existing code. > Add not fatal (at least by default) macros. They use

Re: [Spice-devel] [PATCH 01/18] worker: move more free_glz_drawable

On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > Acked-by: Fabiano Fidêncio ^^^ Do we need further review on this? Were there changes? > --- > server/dcc-encoders.c| 55

Re: [Spice-devel] [PATCH spice-server] worker: Free encoders when client disconnects

On Fri, 2015-11-20 at 10:50 +0100, Fabiano Fidêncio wrote: > On Fri, Nov 20, 2015 at 10:08 AM, Pavel Grunt wrote: > > Signed-off-by: Pavel Grunt > > --- > > Seems that free functions haven't been used since there were introduced [1] > > > > [1]

Re: [Spice-devel] [PATCH spice-server] worker: Free encoders when client disconnects

> > On Fri, 2015-11-20 at 10:50 +0100, Fabiano Fidêncio wrote: > > > On Fri, Nov 20, 2015 at 10:08 AM, Pavel Grunt wrote: > > > > Signed-off-by: Pavel Grunt > > > > --- > > > > Seems that free functions haven't been used since there were introduced > > > >

Re: [Spice-devel] [NSIS 10/13] build: Add make dist

On Thu, Nov 19, 2015 at 03:58:18PM +0100, Christophe Fergeau wrote: > On Thu, Nov 19, 2015 at 04:48:20PM +0200, Yedidyah Bar David wrote: > > From: Christophe Fergeau > > When splitting these patches, I've mistakenly changed ownership of this > patch. I've set it back to you

[Spice-devel] [PATCH] worker: move dcc_add_surface_area_image

From: Marc-André Lureau Author:Marc-André Lureau --- server/Makefile.am | 1 + server/dcc.c| 62 +++ server/red_worker.c | 121 ++-- server/utils.c

Re: [Spice-devel] [PATCH 02/18] worker: move attach_stream

Okay, the patch that I have applied (git-pw apply 994) seems a bit different from this one as it doesn't have the changes on dcc.c, which are unrelated anyway. The commit message should be clear about moving detach_streams function as well. On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio

Re: [Spice-devel] [PATCH] worker: move dcc_add_surface_area_image

Reduced diff (I'm getting good at it!): --- before.c2015-11-20 13:30:01.465786520 + +++ after.c 2015-11-20 13:27:42.931050275 + @@ -128,20 +128,21 @@ spice_bitmap_utils.c\ spice_server_utils.h\ spice_image_cache.h

Re: [Spice-devel] [PATCH spice-server] worker: Free encoders when client disconnects

> On Fri, 2015-11-20 at 10:50 +0100, Fabiano Fidêncio wrote: > > On Fri, Nov 20, 2015 at 10:08 AM, Pavel Grunt wrote: > > > Signed-off-by: Pavel Grunt > > > --- > > > Seems that free functions haven't been used since there were introduced > > > [1] > > > >

Re: [Spice-devel] [PATCH 04/18] worker: move dcc_add_drawable*

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/dcc.c | 82 +++ > server/dcc.h | 17 ++ > server/display-channel.c | 65

Re: [Spice-devel] [PATCH 03/18] worker: improve some pre-conditions

> > On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/red_worker.c | 35 ++- > > 1 file changed, 2 insertions(+), 33 deletions(-) > > > > diff --git

Re: [Spice-devel] [PATCH 07/18] stream: minor simplification

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 2 +- > server/stream.c | 21 +++-- > server/stream.h | 3 +-- > 3 files changed, 13 insertions(+), 13

Re: [Spice-devel] [PATCH 08/18] server: remove OpenGL

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > This is really not supported, requires X11, so better to remove it for > now. Some day it might be revived, using DRM, .. > > Note for later, this could be

Re: [Spice-devel] [PATCH 08/18] server: remove OpenGL

On Fri, 2015-11-20 at 09:02 -0600, Jonathon Jongsma wrote: > Acked-by: Jonathon Jongsma > > (just testing whether this format marks the patch as acked in patchwork) ;) hey, it works! > > On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote: > > From: Marc-André Lureau

Re: [Spice-devel] [PATCH spice-server 00/15] Remove unused functions

On Fri, 2015-11-20 at 12:53 +0100, Christophe Fergeau wrote: > On Thu, Nov 19, 2015 at 08:44:50PM +0100, Pavel Grunt wrote: > > Hi, > > > > I noticed that there are some unused functions in our code. > > Did you find these functions manually? Or did you use something somehow > programmatic to

Re: [Spice-devel] [PATCH] worker: move dcc_add_surface_area_image

> > Reduced diff (I'm getting good at it!): > > > --- before.c 2015-11-20 13:30:01.465786520 + > +++ after.c 2015-11-20 13:27:42.931050275 + > @@ -128,20 +128,21 @@ > spice_bitmap_utils.c\ > spice_server_utils.h\ > spice_image_cache.h

Re: [Spice-devel] [PATCH spice-server] worker: Free encoders when client disconnects

On Fri, 2015-11-20 at 09:12 -0500, Frediano Ziglio wrote: > > On Fri, 2015-11-20 at 10:50 +0100, Fabiano Fidêncio wrote: > > > On Fri, Nov 20, 2015 at 10:08 AM, Pavel Grunt wrote: > > > > Signed-off-by: Pavel Grunt > > > > --- > > > > Seems that free

[Spice-devel] [PATCH] worker: move dcc_add_surface_area_image

From: Marc-André Lureau Author:Marc-André Lureau --- server/Makefile.am | 1 + server/dcc.c| 62 +++ server/red_worker.c | 121 ++-- server/utils.c

Re: [Spice-devel] [PATCH 03/18] worker: improve some pre-conditions

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 35 ++- > 1 file changed, 2 insertions(+), 33 deletions(-) > > diff --git a/server/red_worker.c

Re: [Spice-devel] [PATCH 05/18] worker: tidy up cursor_connect a bit

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/cursor-channel.c | 4 > server/red_worker.c | 60 > + > 2 files changed, 30

Re: [Spice-devel] [PATCH 08/18] server: remove OpenGL

Acked-by: Jonathon Jongsma (just testing whether this format marks the patch as acked in patchwork) ;) On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > This is really not supported, requires X11, so better

Re: [Spice-devel] [PATCH 2/2] worker: change spice_assert in dcc_free_glz_drawable_instance

NACK, I don't see a reason for changing it. Pavel On Thu, 2015-11-19 at 17:59 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > Signed-off-by: Frediano Ziglio > --- >  

Re: [Spice-devel] [PATCH 17/18] worker: move stream_clip_item_unref()

> > On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/red_worker.c | 14 ++ > > server/stream.c | 12 > > server/stream.h | 6 -- > > 3 files changed,

Re: [Spice-devel] [PATCH 18/18] worker: merge red_draw_qxl_drawable in drawable_draw

> > On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/red_worker.c | 22 +- > > 1 file changed, 9 insertions(+), 13 deletions(-) > > > > diff --git a/server/red_worker.c

Re: [Spice-devel] [PATCH 2/2] worker: change spice_assert in handle_dev_stop

NACK, I don't see a reason for changing it. Pavel On Thu, 2015-11-19 at 18:01 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- >  server/red_worker.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/server/red_worker.c

Re: [Spice-devel] [PATCH 08/18] worker: display_channel_flush_all_surfaces

> On Thu, 2015-11-19 at 10:03 -0500, Frediano Ziglio wrote: > > > On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio > > > wrote: > > > > From: Marc-André Lureau > > > > > > > > --- > > > > server/display-channel.c | 11 +++ > > > >

Re: [Spice-devel] [PATCH 14/18] worker: move dcc_freeze_glz

> > On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/dcc-encoders.c | 9 + > > server/dcc-encoders.h | 1 + > > server/red_worker.c | 12 +--- > > 3 files changed, 11

[Spice-devel] [PATCH spice-server] dcc: Fix unused display_channel variable

Avoid problem when compiling with lz4 and without COMPRESS_STAT dcc.c: In function 'dcc_compress_image_lz4': dcc.c:657:21: error: unused variable 'display_channel' [-Werror=unused-variable] DisplayChannel *display_channel = DCC_TO_DC(dcc); --- server/dcc.c | 5 ++--- 1 file changed, 2

Re: [Spice-devel] [PATCH 03/18] worker: remove cursor channel asserts

> On Thu, 2015-11-19 at 11:39 -0500, Frediano Ziglio wrote: > > > On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio > > > wrote: > > > > From: Marc-André Lureau > > > > > > > > --- > > > >  server/cursor-channel.c | 6 +++--- > > > >  1 file

Re: [Spice-devel] [PATCH 1/2] worker: move glz_drawable_count to DisplayChannel

> > On Thu, 2015-11-19 at 14:16 +, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > > server/display-channel.h | 2 ++ > > server/red_worker.c | 13 ++--- > > 2 files changed, 8 insertions(+), 7 deletions(-) > > > > diff --git

[Spice-devel] [PATCH 16/18] worker: move drawable_draw

From: Marc-André Lureau --- server/display-channel.c | 236 server/display-channel.h | 4 + server/red_worker.c | 251 +-- 3 files changed, 244 insertions(+), 247

Re: [Spice-devel] [PATCH libcacard 3/3] libcacard: add G_BEGIN/END_DECLS

On Thu, Nov 19, 2015 at 01:45:44PM -0500, Marc-André Lureau wrote: > > > - Original Message - > > On Thu, Nov 19, 2015 at 02:18:25PM -0200, Eduardo Lima (Etrunko) wrote: > > > On 11/19/2015 02:00 PM, Marc-André Lureau wrote: > > > > > > > > > > > > - Original Message - > > > >>

Re: [Spice-devel] [PATCH spice-server 00/15] Remove unused functions

Hi, On Fri, Nov 20, 2015 at 11:47:41AM +0100, Pavel Grunt wrote: > On Fri, 2015-11-20 at 04:32 -0500, Frediano Ziglio wrote: > > > > > > Hi, > > > > > > I noticed that there are some unused functions in our code. > > > Some of them were just defined, but haven't been used, others > > > stopped

Re: [Spice-devel] [PATCH 03/18] worker: remove cursor channel asserts

On Thu, Nov 19, 2015 at 11:39:51AM -0500, Frediano Ziglio wrote: > > On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote: > > > From: Marc-André Lureau > > > > > > --- > > > server/cursor-channel.c | 6 +++--- > > > 1 file changed, 3

[Spice-devel] [PATCH] reuse red_get_monotonic_time function

Signed-off-by: Frediano Ziglio --- server/main_channel.c | 10 ++ server/mjpeg_encoder.c | 9 +++-- server/red_channel.c | 13 +++-- 3 files changed, 8 insertions(+), 24 deletions(-) diff --git a/server/main_channel.c b/server/main_channel.c index

Re: [Spice-devel] [PATCH 06/18] worker: move dcc_add_surface_area_image

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > Author:Marc-André Lureau > --- > server/Makefile.am | 1 + > server/dcc.c| 62 +++ >

[Spice-devel] [PATCH 11/18] worker: move dcc_handle_message

From: Marc-André Lureau --- server/dcc-encoders.c | 131 +- server/dcc-encoders.h | 7 ++ server/dcc.c | 82 + server/dcc.h | 3 + server/red_worker.c | 251

[Spice-devel] [PATCH 13/18] worker: move dcc_release_item

From: Marc-André Lureau --- server/dcc.c | 124 + server/dcc.h | 3 + server/display-channel.h | 7 +++ server/red_worker.c | 158 --- 4 files changed,

[Spice-devel] [PATCH 09/18] worker: generalize surface_dirty_region_to_rects

From: Marc-André Lureau --- server/red_worker.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 8c0758e..b007040 100644 --- a/server/red_worker.c +++

[Spice-devel] [PATCH 08/18] server: remove OpenGL

From: Marc-André Lureau This is really not supported, requires X11, so better to remove it for now. Some day it might be revived, using DRM, .. Note for later, this could be removed too (not used by client): - spice-common/common/ogl_ctx --- server/Makefile.am

[Spice-devel] [PATCH 15/18] worker: move display_channel_free_some

From: Marc-André Lureau Author:Marc-André Lureau --- server/dcc-encoders.c| 25 + server/dcc-encoders.h| 3 +- server/display-channel.c | 108 ++ server/display-channel.h | 6

[Spice-devel] [PATCH 06/18] worker: move dcc_add_surface_area_image

From: Marc-André Lureau Author:Marc-André Lureau --- server/Makefile.am | 1 + server/dcc.c| 62 +++ server/red_worker.c | 121 ++-- server/utils.c

[Spice-devel] [PATCH 18/18] worker: rename update_area

From: Marc-André Lureau --- server/display-channel.c | 13 +++-- server/display-channel.h | 10 +++--- server/red_worker.c | 24 3 files changed, 26 insertions(+), 21 deletions(-) diff --git a/server/display-channel.c

[Spice-devel] [PATCH 17/18] display: replace some dubious asserts

From: Marc-André Lureau --- server/display-channel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index 381a582..7aa3ea9 100644 --- a/server/display-channel.c +++

[Spice-devel] [PATCH 12/18] worker: move dcc_handle_migrate_data

From: Marc-André Lureau --- server/dcc.c| 135 ++ server/dcc.h| 5 ++ server/red_worker.c | 165 ++-- 3 files changed, 145 insertions(+), 160 deletions(-) diff

[Spice-devel] [PATCH 10/18] worker: replace some precondition checks

From: Marc-André Lureau --- server/red_worker.c | 53 + 1 file changed, 17 insertions(+), 36 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index b007040..337748d 100644 ---

Re: [Spice-devel] [PATCH spice-server 00/15] Remove unused functions

> > On Thu, Nov 19, 2015 at 08:44:50PM +0100, Pavel Grunt wrote: > > Hi, > > > > I noticed that there are some unused functions in our code. > > Did you find these functions manually? Or did you use something somehow > programmatic to detect them? > > Christophe > I don't know how Pavel did

Re: [Spice-devel] [PATCH spice-server] worker: Free encoders when client disconnects

On Fri, Nov 20, 2015 at 10:08 AM, Pavel Grunt wrote: > Signed-off-by: Pavel Grunt > --- > Seems that free functions haven't been used since there were introduced [1] > > [1] > http://lists.freedesktop.org/archives/spice-devel/2015-November/023893.html > ---

Re: [Spice-devel] [PATCH 2/2] worker: change spice_assert in dcc_free_glz_drawable_instance

> NACK, I don't see a reason for changing it. > > Pavel > > On Thu, 2015-11-19 at 17:59 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > Signed-off-by: Frediano Ziglio

Re: [Spice-devel] [PATCH 00/18] Backported some patches from refactory branches (18th Nov)

> > Hi, > > On Thu, Nov 19, 2015 at 10:50:35AM +0100, Fabiano Fidêncio wrote: > > On Wed, Nov 18, 2015 at 5:19 PM, Frediano Ziglio > > wrote: > > >> > > >> This patchset supersedes last patchset. > > >> > > >> Changes: > > >> - rebased; > > >> - removed merged patches; > >

Re: [Spice-devel] [PATCH v2 01/18] worker: move encoders to dcc-encoders

> > Hi, > > I know this was merged already but just one comment bellow: > > On Wed, Nov 18, 2015 at 03:42:26PM -0600, Jonathon Jongsma wrote: > > From: Marc-André Lureau > > +static SPICE_GNUC_NORETURN SPICE_GNUC_PRINTF(2, 3) void > > +quic_usr_error(QuicUsrContext

[Spice-devel] [PATCH] worker: move red_drawable_count to DisplayChannel

Signed-off-by: Frediano Ziglio --- server/display-channel.h | 1 + server/red_worker.c | 13 ++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/server/display-channel.h b/server/display-channel.h index d47abf7..990d756 100644 ---

Re: [Spice-devel] [PATCH 2/2] worker: change spice_assert in handle_dev_stop

> > NACK, I don't see a reason for changing it. > > Pavel > > On Thu, 2015-11-19 at 18:01 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > >  server/red_worker.c | 2 +- > >  1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git

Re: [Spice-devel] [PATCH spice-server 00/15] Remove unused functions

On Fri, 2015-11-20 at 04:32 -0500, Frediano Ziglio wrote: > > > > Hi, > > > > I noticed that there are some unused functions in our code. > > Some of them were just defined, but haven't been used, others > > stopped being used because some other functions were changed/removed. > > I'm not sure

Re: [Spice-devel] [PATCH 1/2] worker: move dcc_free_glz_drawable_instance

> ACK > > On Thu, 2015-11-19 at 17:59 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/dcc-encoders.c | 47 +++ > > server/red_worker.c | 50 > >

Re: [Spice-devel] [PATCH 11/18] worker: add display_channel_free_glz_drawables_to_free()

> On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/dcc-encoders.c| 17 + > > server/dcc-encoders.h| 2 ++ > > server/display-channel.c | 12 > >

Re: [Spice-devel] [PATCH 1/2] worker: few function renames

> > ACK > > On Thu, 2015-11-19 at 18:01 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/red_worker.c | 21 - > > 1 file changed, 12 insertions(+), 9 deletions(-) > > > > diff --git a/server/red_worker.c

Re: [Spice-devel] [PATCH 15/18] worker: move dcc_pixmap_cache_add

> > On Wed, Nov 18, 2015 at 5:17 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/dcc.c| 90 > > > > server/dcc.h| 2 ++ > > server/red_worker.c |

Re: [Spice-devel] [PATCH spice-server] dcc: Fix unused display_channel variable

> > Avoid problem when compiling with lz4 and without COMPRESS_STAT > > dcc.c: In function 'dcc_compress_image_lz4': > dcc.c:657:21: error: unused variable 'display_channel' > [-Werror=unused-variable] > DisplayChannel *display_channel = DCC_TO_DC(dcc); > --- > server/dcc.c | 5 ++--- > 1

Re: [Spice-devel] [PATCH spice-server 00/15] Remove unused functions

On Thu, Nov 19, 2015 at 08:44:50PM +0100, Pavel Grunt wrote: > Hi, > > I noticed that there are some unused functions in our code. Did you find these functions manually? Or did you use something somehow programmatic to detect them? Christophe signature.asc Description: PGP signature

Re: [Spice-devel] [PATCH 09/18] worker: generalize surface_dirty_region_to_rects

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 26 +++--- > 1 file changed, 11 insertions(+), 15 deletions(-) > > diff --git a/server/red_worker.c

Re: [Spice-devel] [PATCH] log: add not fatal spice_return function

On Fri, Nov 20, 2015 at 05:03:25PM +0100, Christophe Fergeau wrote: > I looked at this today, one different between glib log functions and > SPICE is that the SPICE ones append the file name/line number/function > name to the logged message. Thinking a bit more about this, while it's nice to have

[Spice-devel] [PATCH] server: remove OpenGL

From: Marc-André Lureau This is really not supported, requires X11, so better to remove it for now. Some day it might be revived, using DRM, .. Note for later, this could be removed too (not used by client): - spice-common/common/ogl_ctx --- configure.ac

Re: [Spice-devel] [PATCH 13/18] worker: move dcc_release_item

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/dcc.c | 124 + > server/dcc.h | 3 + > server/display-channel.h | 7 +++ >

Re: [Spice-devel] [PATCH 14/18] worker: move spice_bitmap_get_line

hmm, rebase error? here's the original commit from alon's branch: http://cgit.fr eedesktop.org/~alon/spice/commit/?h=wip/replay=dfd114c195befecfbcfd79076670c4 aeda82f945 On Fri, 2015-11-20 at 17:25 +0100, Fabiano Fidêncio wrote: > Perhaps "add spice_bitmap_get_line()" would be a better commit

Re: [Spice-devel] spice-server, logging and style

On Tue, Nov 03, 2015 at 08:15:14AM -0500, Frediano Ziglio wrote: > Problems: > - the Spice_style.odt is outdated; > - spice_assert recall the standard assert but instead it mainly > call spice_error which like GLib is fatal and should call exit/abort. > It is not affected by NDEBUG or other

Re: [Spice-devel] [PATCH] log: add not fatal spice_return function

On Fri, Nov 20, 2015 at 10:36:12AM -0600, Jonathon Jongsma wrote: > On Fri, 2015-11-20 at 17:15 +0100, Christophe Fergeau wrote: > > On Fri, Nov 20, 2015 at 05:03:25PM +0100, Christophe Fergeau wrote: > > > I looked at this today, one different between glib log functions and > > > SPICE is that

[Spice-devel] [PATCH 1/3] stream: remove dcc parameter from stream_agent_stop()

From: Marc-André Lureau Author:Marc-André Lureau --- server/red_worker.c | 2 +- server/stream.c | 4 +++- server/stream.h | 3 +-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c

[Spice-devel] [PATCH 3/3] stream: remove red_stream_ prefix from mjpeg callbacks

From: Marc-André Lureau Author:Marc-André Lureau --- server/stream.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/server/stream.c b/server/stream.c index bd56601..85136ea 100644 ---

Re: [Spice-devel] [PATCH] server: remove OpenGL

On Fri, Nov 20, 2015 at 5:22 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > This is really not supported, requires X11, so better to remove it for > now. Some day it might be revived, using DRM, .. > > Note for later, this could be

Re: [Spice-devel] [PATCH 04/18] worker: move dcc_add_drawable*

> > On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > --- > > server/dcc.c | 82 +++ > > server/dcc.h | 17 ++ > > server/display-channel.c | 65

Re: [Spice-devel] [PATCH 14/18] worker: move spice_bitmap_get_line

> > Perhaps "add spice_bitmap_get_line()" would be a better commit message. > But why is this added? where is it going to be used? If it was really > supposed to be moved ... moved from where? > > On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > > From: Marc-André

Re: [Spice-devel] [PATCH 15/18] worker: move display_channel_free_some

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > Author:Marc-André Lureau > --- > server/dcc-encoders.c| 25 + > server/dcc-encoders.h| 3 +- >

Re: [Spice-devel] [PATCH] worker: move dcc_add_surface_area_image

Acked-by: Jonathon Jongsma On Fri, 2015-11-20 at 13:47 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > Author:Marc-André Lureau > --- > server/Makefile.am | 1 + > server/dcc.c| 62

Re: [Spice-devel] [PATCH 12/18] worker: move dcc_handle_migrate_data

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/dcc.c| 135 ++ > server/dcc.h| 5 ++ > server/red_worker.c | 165 >

Re: [Spice-devel] [PATCH 14/18] worker: move spice_bitmap_get_line

Perhaps "add spice_bitmap_get_line()" would be a better commit message. But why is this added? where is it going to be used? If it was really supposed to be moved ... moved from where? On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau

Re: [Spice-devel] [PATCH 18/18] worker: rename update_area

On Fri, Nov 20, 2015 at 5:00 PM, Jonathon Jongsma wrote: > Fine with me. > > Acked-by: Jonathon Jongsma > > On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote: >> From: Marc-André Lureau >> >> --- >>

Re: [Spice-devel] [PATCH 16/18] worker: move drawable_draw

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 236 > server/display-channel.h | 4 + > server/red_worker.c | 251 >

Re: [Spice-devel] [PATCH] log: add not fatal spice_return function

On Fri, 2015-11-20 at 16:26 +0100, Francois Gouget wrote: > On Thu, 19 Nov 2015, Frediano Ziglio wrote: > [...] > > > What do you mean by "100% compatible with the current code"? (why is > > > g_return_if-fail() not "100% compatible with the current code" ?) > > > > well... implementation is

Re: [Spice-devel] [PATCH] log: add not fatal spice_return function

Hey, On Fri, Nov 20, 2015 at 04:26:22PM +0100, Francois Gouget wrote: > On Thu, 19 Nov 2015, Frediano Ziglio wrote: > [...] > > > What do you mean by "100% compatible with the current code"? (why is > > > g_return_if-fail() not "100% compatible with the current code" ?) > > > > well...

Re: [Spice-devel] [PATCH] log: add not fatal spice_return function

On Fri, 2015-11-20 at 17:15 +0100, Christophe Fergeau wrote: > On Fri, Nov 20, 2015 at 05:03:25PM +0100, Christophe Fergeau wrote: > > I looked at this today, one different between glib log functions and > > SPICE is that the SPICE ones append the file name/line number/function > > name to the

Re: [Spice-devel] [PATCH 14/18] worker: move spice_bitmap_get_line

On Fri, 2015-11-20 at 11:38 -0500, Frediano Ziglio wrote: > > > > Perhaps "add spice_bitmap_get_line()" would be a better commit message. > > But why is this added? where is it going to be used? If it was really > > supposed to be moved ... moved from where? > > > > On Fri, Nov 20, 2015 at

Re: [Spice-devel] [PATCH] log: add not fatal spice_return function

On Thu, 19 Nov 2015, Frediano Ziglio wrote: [...] > > What do you mean by "100% compatible with the current code"? (why is > > g_return_if-fail() not "100% compatible with the current code" ?) > > well... implementation is quite different. I didn't get all differences but > - spice_logv use some

Re: [Spice-devel] [PATCH 10/18] worker: replace some precondition checks

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/red_worker.c | 53 > + > 1 file changed, 17 insertions(+), 36 deletions(-) > > diff --git

Re: [Spice-devel] [PATCH 18/18] worker: rename update_area

Fine with me. Acked-by: Jonathon Jongsma On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 13 +++-- > server/display-channel.h | 10 +++--- >

Re: [Spice-devel] [PATCH 04/18] worker: move dcc_add_drawable*

On Fri, Nov 20, 2015 at 5:04 PM, Frediano Ziglio wrote: >> >> On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: >> > From: Marc-André Lureau >> > >> > --- >> > server/dcc.c | 82 +++

Re: [Spice-devel] [PATCH] log: add not fatal spice_return function

On Fri, Nov 20, 2015 at 05:03:25PM +0100, Christophe Fergeau wrote: > On Fri, Nov 20, 2015 at 04:26:22PM +0100, Francois Gouget wrote: > > Does it matter? > > The client uses the g_return_xxx() functions already. Would it be a > > problem if the server did too instead of going its separate way? >

Re: [Spice-devel] [PATCH 14/18] worker: move spice_bitmap_get_line

On Fri, Nov 20, 2015 at 5:48 PM, Jonathon Jongsma wrote: > > > On Fri, 2015-11-20 at 11:38 -0500, Frediano Ziglio wrote: >> > >> > Perhaps "add spice_bitmap_get_line()" would be a better commit message. >> > But why is this added? where is it going to be used? If it was

Re: [Spice-devel] [PATCH 01/18] worker: move more free_glz_drawable

> > On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote: > > From: Marc-André Lureau > > > > Acked-by: Fabiano Fidêncio > > ^^^ > > > Do we need further review on this? Were there changes? > > > Yes, sorry, already pushed.

Re: [Spice-devel] [PATCH 11/18] worker: move dcc_handle_message

On Fri, Nov 20, 2015 at 12:17 PM, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/dcc-encoders.c | 131 +- > server/dcc-encoders.h | 7 ++ > server/dcc.c | 82 + > server/dcc.h

Re: [Spice-devel] [PATCH] log: add not fatal spice_return function

On Fri, Nov 20, 2015 at 08:53:19AM -0600, Jonathon Jongsma wrote: > On Fri, 2015-11-20 at 12:31 +, Frediano Ziglio wrote: > > Due to implementation details spice_return is by default fatal (program > > is aborting). This is quite confusing but changing the current macros > > would possibly

Re: [Spice-devel] [PATCH 17/18] display: replace some dubious asserts

On Fri, 2015-11-20 at 11:17 +, Frediano Ziglio wrote: > From: Marc-André Lureau > > --- > server/display-channel.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/server/display-channel.c b/server/display-channel.c > index

  1   2   >