Re: [Spice-devel] [PATCH 18/24] worker: rename process_commands process_display

> > From: Marc-André Lureau > > --- > server/red_worker.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index df1a2f1..da2889c 100644 > --- a/server/red_worker.c > +++

Re: [Spice-devel] [PATCH 16/24] red_channel: cleanup of red_channel_client blocking methods

> > From: Yonit Halperin > > (1) receive timeout as a parameter. > (2) add a return value and pass the handling > of failures to the calling routine. > --- > server/red_channel.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [Spice-devel] [PATCH 22/24] worker: make sure we dispatch after releasing items

> > From: Marc-André Lureau > > --- > server/display-channel.c | 2 ++ > server/red_worker.c | 10 ++ > server/red_worker.h | 1 + > 3 files changed, 13 insertions(+) > > diff --git a/server/display-channel.c b/server/display-channel.c > index

Re: [Spice-devel] [PATCH 13/18] display: replace some dubious asserts

On 11/27/2015 11:54 AM, Frediano Ziglio wrote: What about: display: move checks inside display_channel_wait_for_migrate_data Instead of relaying on the caller to use red_channel_waits_for_migrate_data to check if there are client waiting for migration data check inside the function. This

[Spice-devel] [PATCH 13/24] dcc: reduce statement wrapping

Signed-off-by: Marc-André Lureau Signed-off-by: Frediano Ziglio --- server/dcc-send.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/server/dcc-send.c b/server/dcc-send.c index 2340252..30303e7 100644 ---

[Spice-devel] [PATCH 04/24] worker: do not use dynamic memory for RedSurfaceCmd

Allocation on stack is sufficient and code is more similar to QXL_CMD_MESSAGE and QXL_CMD_UPDATE cases. Signed-off-by: Frediano Ziglio --- server/red_worker.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/server/red_worker.c

[Spice-devel] [PATCH 17/24] tests: test_display_base: use a faster wakeup time to easily test multiple client blocking

From: Alon Levy --- server/tests/test_display_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index c2c5705..575c704 100644 --- a/server/tests/test_display_base.c +++

[Spice-devel] [PATCH 23/24] server: move dispatcher GSource handling code

From: Marc-André Lureau --- server/dispatcher.c | 25 + server/dispatcher.h | 2 ++ server/red_worker.c | 40 3 files changed, 39 insertions(+), 28 deletions(-) diff --git a/server/dispatcher.c

[Spice-devel] [PATCH 21/24] channel: do not free rcc->stream in red_channel_client_disconnect

From: Marc-André Lureau This fixes the following scary racy corruption after glib loop switch: ==28173== ==28173== Debugger has detached. Valgrind regains control. We continue. ==28173== Invalid read of size 8 ==28173==at 0x4C7871E: reds_stream_read

[Spice-devel] [PATCH 11/24] server: rename files

From: Marc-André Lureau --- NEWS | 2 +- server/Makefile.am | 62 +++ server/{reds_sw_canvas.c => canvas.c} | 10 +- server/{reds_sw_canvas.h => canvas.h}

[Spice-devel] [PATCH 22/24] worker: make sure we dispatch after releasing items

From: Marc-André Lureau --- server/display-channel.c | 2 ++ server/red_worker.c | 10 ++ server/red_worker.h | 1 + 3 files changed, 13 insertions(+) diff --git a/server/display-channel.c b/server/display-channel.c index d168190..6b9affc 100644

[Spice-devel] [PATCH 19/24] worker: use glib main loop

From: Marc-André Lureau Clean up, more extensible. Avoid server hanging when no client are connected. --- server/Makefile.am | 2 - server/red_worker.c| 395 - server/red_worker.h| 1 +

[Spice-devel] [PATCH 20/24] server: multiple clients works ok if we limit the pipe to the slowest client

From: Alon Levy --- server/red_worker.c | 8 server/reds.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 1859d2a..0cd2c72 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -174,7

[Spice-devel] [PATCH 24/24] server/red_worker: add env SPICE_NOWAIT_CLIENTS

From: Marc-André Lureau --- server/red_worker.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index 2e3f522..9145875 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -87,6 +87,7 @@

Re: [Spice-devel] [spice-common v2 1/7] log: Use glib for logging

On Po, 2015-11-30 at 12:56 +0100, Christophe Fergeau wrote: > spice-common has been duplicating glib logging methods for a long while. > Now that spice-common is depending on glib, it's more consistent to use > glib logging too. However, the code base is still using spice logging > functions. >

Re: [Spice-devel] [spice-gtk PATCH v1 1/1] channel-usbredir: better control of usbredir log level

Hi, On Tue, Dec 01, 2015 at 06:41:47AM -0500, Marc-André Lureau wrote: > - Original Message - > > Hi > > > > - Original Message - > > > usbredir on debug level is highly verbose. That does not help much when > > > we are trying to debug the spice-gtk side of usbredir. > > > > > >

[Spice-devel] [PATCH 15/24] red_worker: make dcc_clear_surface_drawables_from_pipe declaration consistent with definition

From: Yonit Halperin --- server/dcc.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/server/dcc.h b/server/dcc.h index 14981ca..7b8a3b8 100644 --- a/server/dcc.h +++ b/server/dcc.h @@ -204,7 +204,8 @@ void dcc_release_item

[Spice-devel] [PATCH 02/24] worker: move get_drawable to display-channel.c

Signed-off-by: Marc-André Lureau Signed-off-by: Frediano Ziglio --- server/display-channel.c | 60 + server/display-channel.h | 5 server/red_worker.c | 64

[Spice-devel] [PATCH 06/24] worker: move red_process_draw to display-channel.c

Signed-off-by: Frediano Ziglio --- server/display-channel.c | 25 + server/display-channel.h | 7 ++- server/red_worker.c | 21 ++--- 3 files changed, 25 insertions(+), 28 deletions(-) diff --git a/server/display-channel.c

[Spice-devel] [PATCH 00/24] Backported some patches from refactory branches (1st Dec)

Changes: - rebased on current master; - removed merged patches; - split and change "display: move more logic in add_drawable()"; - split "misc cleanups"; - added some patches. Some patches on discussion were not posted. I added all patches that was missing from first part of refactory. Looks

[Spice-devel] [PATCH 07/24] display: misc style and rename changes

- remove some red_ prefix; - move red_drawable->self_bitmap check outside handle_self_bitmap; - move update check outside red_get_area (renamed surface_read_bits); - rename depend_on_surface_id argument to surface_id; - rename success variable to add_to_pipe. Signed-off-by: Marc-André Lureau

[Spice-devel] [PATCH 16/24] red_channel: cleanup of red_channel_client blocking methods

From: Yonit Halperin (1) receive timeout as a parameter. (2) add a return value and pass the handling of failures to the calling routine. --- server/red_channel.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/red_channel.c

[Spice-devel] [PATCH 18/24] worker: rename process_commands process_display

From: Marc-André Lureau --- server/red_worker.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index df1a2f1..da2889c 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -87,7

[Spice-devel] [PATCH 12/24] worker: change red_worker_new_channel result to CommonChannel*

Signed-off-by: Marc-André Lureau Signed-off-by: Frediano Ziglio --- server/cursor-channel.c | 2 +- server/red_worker.c | 4 ++-- server/red_worker.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

[Spice-devel] [PATCH 03/24] display: move more logic in display_channel_get_drawable()

Signed-off-by: Marc-André Lureau Signed-off-by: Frediano Ziglio --- server/display-channel.c | 185 +++ server/display-channel.h | 15 server/red_worker.c | 172

Re: [Spice-devel] [spice-common v2 7/7] log: Remove spice_backtrace()

On Mon, Nov 30, 2015 at 02:22:54PM -0500, Frediano Ziglio wrote: > > > > It's causing issues with selinux. The same is achieved through > > abrt/cores/... > > > > Acked-by: Jonathon Jongsma > [...] > Patch looks good but what about the interaction with Qemu/RHEV-M/whatever?

Re: [Spice-devel] [PATCH 24/24] server/red_worker: add env SPICE_NOWAIT_CLIENTS

> > From: Marc-André Lureau > > --- > server/red_worker.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/server/red_worker.c b/server/red_worker.c > index 2e3f522..9145875 100644 > --- a/server/red_worker.c > +++ b/server/red_worker.c

Re: [Spice-devel] [PATCH 23/24] server: move dispatcher GSource handling code

> > From: Marc-André Lureau > > --- > server/dispatcher.c | 25 + > server/dispatcher.h | 2 ++ > server/red_worker.c | 40 > 3 files changed, 39 insertions(+), 28 deletions(-) > > diff --git

[Spice-devel] [spice-gtk PATCH v1 1/1] channel-usbredir: better control of usbredir log level

usbredir on debug level is highly verbose. That does not help much when we are trying to debug the spice-gtk side of usbredir. This patch introduces SPICE_DEBUG_USBREDIR env var to set the log level for usbredir side. If this is not set, usbredir will behave the same way as it was by checking

Re: [Spice-devel] [spice-gtk PATCH v1 1/1] channel-usbredir: better control of usbredir log level

- Original Message - > Hi > > - Original Message - > > usbredir on debug level is highly verbose. That does not help much when > > we are trying to debug the spice-gtk side of usbredir. > > > > This patch introduces SPICE_DEBUG_USBREDIR env var to set the log level > > for

Re: [Spice-devel] [spice-gtk PATCH v1 1/1] channel-usbredir: better control of usbredir log level

Hi - Original Message - > usbredir on debug level is highly verbose. That does not help much when > we are trying to debug the spice-gtk side of usbredir. > > This patch introduces SPICE_DEBUG_USBREDIR env var to set the log level > for usbredir side. If this is not set, usbredir will

Re: [Spice-devel] [spice-common v2 1/7] log: Use glib for logging

On Mon, Nov 30, 2015 at 02:31:43PM -0500, Frediano Ziglio wrote: > > +g_setenv("G_MESSAGES_DEBUG", "all", FALSE); > > Do not set environment in a library. > This affects any usage of g_ logging macros in the process (and > possibly sub processes). Yes, but I don't think there's a

Re: [Spice-devel] [spice-gtk PATCH v1 1/1] channel-usbredir: better control of usbredir log level

- Original Message - > Hi, > > On Tue, Dec 01, 2015 at 06:41:47AM -0500, Marc-André Lureau wrote: > > - Original Message - > > > Hi > > > > > > - Original Message - > > > > usbredir on debug level is highly verbose. That does not help much when > > > > we are trying to

Re: [Spice-devel] [spice-gtk PATCH v1 1/1] channel-usbredir: better control of usbredir log level

Hi, On Tue, Dec 01, 2015 at 07:19:58AM -0500, Marc-André Lureau wrote: > - Original Message - > > Hi, > > > > On Tue, Dec 01, 2015 at 06:41:47AM -0500, Marc-André Lureau wrote: > > > - Original Message - > > > > Hi > > > > > > > > - Original Message - > > > > > usbredir on

Re: [Spice-devel] [spice-gtk PATCH v1 1/1] channel-usbredir: better control of usbredir log level

Hi - Original Message - > Hi, > > On Tue, Dec 01, 2015 at 07:19:58AM -0500, Marc-André Lureau wrote: > > - Original Message - > > > Hi, > > > > > > On Tue, Dec 01, 2015 at 06:41:47AM -0500, Marc-André Lureau wrote: > > > > - Original Message - > > > > > Hi > > > > > > > >

Re: [Spice-devel] [PATCH 11/24] server: rename files

> > From: Marc-André Lureau > > --- > NEWS | 2 +- > server/Makefile.am | 62 +++ > server/{reds_sw_canvas.c => canvas.c} | 10 +- > server/{reds_sw_canvas.h =>