Re: [Spice-devel] [PATCH 07/16] Remove use of global 'reds' var from spice_server_remove_interface()

On Fri, 2016-01-29 at 11:31 +0100, Pavel Grunt wrote: > On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote: > > From: Jonathon Jongsma > > > > Since this is public API, we can't easily change the signature of the > > function to take a RedsState argument, so instead we

Re: [Spice-devel] [PATCH 1/4] worker: push data when clients can receive them

On Fri, 2016-01-29 at 10:53 +, Frediano Ziglio wrote: > Data were pushed during the main red worker loop. > However there was no garantiee that there was some activities that > make the loop do another iteration. > This could cause in some condition the loop to stop till a new event > was

Re: [Spice-devel] [PATCH 2/4] replay: remove a message that could be caused by a race condition

On Fri, 2016-01-29 at 10:53 +, Frediano Ziglio wrote: > The req_cmd_notification callback is called by spice-server when it > has processed all commands and wants to be notified (by a wakeup) that > new commands has been appended to the command queue. s/has/have/ > Replay utility try to fill

[Spice-devel] [PATCH v2] Move ticketing_enabled to RedsState struct

Removing more global variables --- v2: - use gboolean type instead of int server/reds-private.h | 1 + server/reds.c | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/server/reds-private.h b/server/reds-private.h index bc790e8..504cb27 100644 ---

Re: [Spice-devel] [PATCH 3/4] worker: avoid blocking loop

Ack with minor changes below Acked-by: Jonathon Jongsma On Fri, 2016-01-29 at 10:53 +, Frediano Ziglio wrote: > Make sure we process commands after we can send data to client. > If during processing we detected that there was too data in the clients too much data >

Re: [Spice-devel] spice udp support

I heard that iptv uses udp multicast, so I thought that performance might be better if we use udp for video streaming. We can ignore missing and out of order frames. Does it make sense? I understand that we need tcp channels for all others such as input and audio channels. 2016-02-02 23:03

Re: [Spice-devel] [PATCH 04/18] Make default_security and channels_security non-global

> > From: Jonathon Jongsma > > Move them into the RedsState struct, adjust functions that use these > variables to take a RedsState arg. > --- > server/reds-private.h | 4 > server/reds.c | 27 --- > 2 files changed, 16 insertions(+),

[Spice-devel] spice udp support

Hi All, I have a few questions about udp version of spice protocol. Is there a plan to support udp in spice protocol? If we support udp, what do we need to implement? Is it enough to change tcp channels to udp ones? Would there be any benefits over tcp version? possibly better performance?

Re: [Spice-devel] spice udp support

> Hi All, > I have a few questions about udp version of spice protocol. > Is there a plan to support udp in spice protocol? > If we support udp, what do we need to implement? > Is it enough to change tcp channels to udp ones? > Would there be any benefits over tcp version? possibly better

Re: [Spice-devel] spice udp support

Hey, On Tue, Feb 02, 2016 at 06:10:28PM +0900, Sunny Shin wrote: > I have a few questions about udp version of spice protocol. > > Is there a plan to support udp in spice protocol? > > If we support udp, what do we need to implement? > Is it enough to change tcp channels to udp ones? Maybe

Re: [Spice-devel] please stop send this mail to me

Hey, On Tue, Feb 02, 2016 at 09:39:41AM +0800, 牛立新 wrote: > thanks a lot. Feel free to change your preferences in the mailman. Enter your mail and press the unsubscribe button at http://lists.freedesktop.org/mailman/options/spice-devel Cheers, > > 在

Re: [Spice-devel] [PATCH] compatibility patch for event loop

On Mon, Feb 01, 2016 at 10:36:52AM +, Frediano Ziglio wrote: > This patch use old code to implement timer events. > The new version use some function from GLib 2.34 however some systems > (like RHEL 6) have former GLib version (RHEL 6 has GLib 2.28 installed) > > Signed-off-by: Frediano

Re: [Spice-devel] [PATCH 05/18] Store 'renderers' as GArray in RedsState

On Mon, 2016-02-01 at 08:47 -0500, Frediano Ziglio wrote: > > > > From: Jonathon Jongsma > > > > Acked-by: Frediano Ziglio > > --- > > server/display-channel.c | 13 +++-- > > server/display-channel.h | 3 +-- > > server/reds-private.h| 1

Re: [Spice-devel] [PATCH 17/18] Move image_compression to RedsState struct

> > From: Jonathon Jongsma > > Removing more global variables > --- > server/red-dispatcher.c | 4 ++-- > server/red-worker.c | 3 ++- > server/reds-private.h | 1 + > server/reds.c | 14 +++--- > server/reds.h | 1 - > 5 files

Re: [Spice-devel] [PATCH 18/18] Move jpeg_state to RedsState struct

> > From: Jonathon Jongsma > > Also required adding reds_get_jpeg_state() for external access. > --- > server/red-worker.c | 2 +- > server/reds-private.h | 1 + > server/reds.c | 9 +++-- > server/reds.h | 2 +- > 4 files changed, 10 insertions(+), 4

[Spice-devel] [PATCH 14/18] Move 'core' into RedsState struct

From: Jonathon Jongsma Also add reds_get_core_interface() accessor for external use. --- server/char-device.c| 32 --- server/inputs-channel.c | 7 --- server/main-channel.c | 13 +++-- server/reds-private.h | 2 ++

[Spice-devel] [PATCH 04/18] Store 'renderers' as GArray in RedsState

From: Jonathon Jongsma Acked-by: Frediano Ziglio --- server/display-channel.c | 13 +++-- server/display-channel.h | 3 +-- server/reds-private.h| 1 + server/reds.c| 22 +- server/reds.h| 5

[Spice-devel] [PATCH 15/18] Add RedsState arg to reds_init_client_[ssl_]connection()

From: Jonathon Jongsma --- server/reds.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/server/reds.c b/server/reds.c index 690985c..8b2dab5 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2265,7 +2265,7 @@ static void

[Spice-devel] [PATCH 08/18] Move agent_mouse to RedsState struct

From: Jonathon Jongsma Required adding a RedsState arg to reds_get_agent_mouse() --- server/inputs-channel.c | 8 server/reds-private.h | 2 ++ server/reds.c | 10 +- server/reds.h | 2 +- 4 files changed, 12 insertions(+), 10

[Spice-devel] [PATCH 00/18] Backported some patches from refactory branches (2nd Feb)

Changes: - merged some patches; - added other patches to list. Jonathon Jongsma (18): Change spice_server_set_ticket() to use local 'reds' spice_server_add_interface: use local 'reds' variable Remove use of global 'reds' var from spice_server_remove_interface() Store 'renderers' as GArray

[Spice-devel] [PATCH 06/18] Move streaming_video to RedsState struct

From: Jonathon Jongsma Also requires adding reds_get_streaming_video() accessor so that other files can check this value. --- server/red-dispatcher.c | 7 --- server/red-worker.c | 2 +- server/reds-private.h | 1 + server/reds.c | 9 +++--

[Spice-devel] [PATCH 05/18] Move ticketing_enabled to RedsState struct

From: Jonathon Jongsma Removing more global variables --- server/reds-private.h | 1 + server/reds.c | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/server/reds-private.h b/server/reds-private.h index bc790e8..c76f3b0 100644 ---

[Spice-devel] [PATCH 03/18] Remove use of global 'reds' var from spice_server_remove_interface()

From: Jonathon Jongsma Since this is public API, we can't easily change the signature of the function to take a RedsState argument, so instead we apply a hack and store the reds argument inside the device state struct when the interface is added, and retrieve it for use

[Spice-devel] [PATCH 16/18] Add RedsState member to RedLinkInfo

From: Jonathon Jongsma This allows us to use local 'reds' variables in all of the various async callbacks rather than using the global 'reds' variable. --- server/reds.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/server/reds.c

[Spice-devel] [PATCH 18/18] Add RedsState arg to all stat functions

From: Jonathon Jongsma --- server/dcc-send.c| 6 +++--- server/display-channel.c | 12 ++-- server/main-channel.c| 2 +- server/red-channel.c | 4 ++-- server/red-worker.c | 12 ++-- server/reds.c| 22

[Spice-devel] [PATCH 17/18] Add RedsState arg to reds_handle_channel_event()

From: Jonathon Jongsma --- server/main-dispatcher.c | 2 +- server/reds.c| 2 +- server/reds.h| 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/main-dispatcher.c b/server/main-dispatcher.c index 132a693..777a44f 100644 ---

[Spice-devel] [PATCH 11/18] Move exit_on_disconnect to RedsState struct

From: Jonathon Jongsma Removing more global variables --- server/reds-private.h | 1 + server/reds.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/server/reds-private.h b/server/reds-private.h index 9c3db70..5042773 100644 ---

[Spice-devel] [PATCH 12/18] Move ssl_parameters to RedsState struct

From: Jonathon Jongsma Removing more global variables --- server/reds-private.h | 11 + server/reds.c | 65 ++- 2 files changed, 39 insertions(+), 37 deletions(-) diff --git a/server/reds-private.h

[Spice-devel] [PATCH 10/18] Move agent_file_xfer to RedsState struct

From: Jonathon Jongsma Removing more global variables --- server/reds-private.h | 1 + server/reds.c | 16 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/server/reds-private.h b/server/reds-private.h index 52f88f8..9c3db70 100644

[Spice-devel] [PATCH 09/18] Move agent_copypaste to RedsState struct

From: Jonathon Jongsma Removing more global variables --- server/reds-private.h | 1 + server/reds.c | 16 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/server/reds-private.h b/server/reds-private.h index 9bfade8..52f88f8 100644

Re: [Spice-devel] [PATCH 07/16] Remove use of global 'reds' var from spice_server_remove_interface()

On Tue, 2016-02-02 at 13:23 -0600, Jonathon Jongsma wrote: > On Fri, 2016-01-29 at 11:31 +0100, Pavel Grunt wrote: > > On Wed, 2016-01-27 at 12:48 +, Frediano Ziglio wrote: > > > From: Jonathon Jongsma > > > > > > Since this is public API, we can't easily change the

Re: [Spice-devel] spice udp support

On Mi, 2016-02-03 at 13:27 +0900, Sunny Shin wrote: > I heard that iptv uses udp multicast, so I thought that performance > might be better if we use udp for video streaming. spice != tv. No multicast here. Oh, and udp/multicast doesn't improve performance, it reduces the bandwidth needed. >

Re: [Spice-devel] spice udp support

On Út, 2016-02-02 at 10:24 +0100, Christophe Fergeau wrote: > Hey, > > On Tue, Feb 02, 2016 at 06:10:28PM +0900, Sunny Shin wrote: > > I have a few questions about udp version of spice protocol. > > > > Is there a plan to support udp in spice protocol? > > > > If we support udp, what do we need

Re: [Spice-devel] spice udp support

On Di, 2016-02-02 at 10:24 +0100, Christophe Fergeau wrote: > Hey, > > On Tue, Feb 02, 2016 at 06:10:28PM +0900, Sunny Shin wrote: > > I have a few questions about udp version of spice protocol. > > > > Is there a plan to support udp in spice protocol? > > > > If we support udp, what do we need