[Spice-devel] [PATCH v3 05/10] server: move bit set/clear utilities out of red_worker.h

2013-08-13 Thread Alon Levy
--- server/Makefile.am | 1 + server/red_dispatcher.c | 4 +++- server/red_worker.c | 1 + server/red_worker.h | 18 -- server/spice_server_utils.h | 23 +++ 5 files changed, 28 insertions(+), 19 deletions(-) create mode 100644

[Spice-devel] [PATCH v3 06/10] server: move three functions to red_channel

2013-08-13 Thread Alon Levy
Three blocking functions, one was split to leave the display channel specific referencing of the DrawablePipeItem being sent inside red_worker, but the rest (most) of the timeout logic was moved to red_channel, including the associated constants. Moved functions:

[Spice-devel] [PATCH v3 08/10] server: move surface_format_to_image_type to spice_bitmap_utils

2013-08-13 Thread Alon Levy
--- server/red_worker.c | 28 server/spice_bitmap_utils.c | 17 + server/spice_bitmap_utils.h | 2 ++ 3 files changed, 23 insertions(+), 24 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 175cf92..1caaa51 100644 ---

[Spice-devel] [PATCH v3 07/10] server: s/red_wait_all_sent/red_channel_wait_all_sent/

2013-08-13 Thread Alon Levy
--- server/red_channel.c | 2 +- server/red_channel.h | 2 +- server/red_worker.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index d0b979e..37b0c1c 100644 --- a/server/red_channel.c +++ b/server/red_channel.c @@ -2274,7

[Spice-devel] [PATCH v3 09/10] server/red_worker: s/image_cache_eaging/image_cache_aging/

2013-08-13 Thread Alon Levy
--- server/red_worker.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 1caaa51..df5d01c 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4421,7 +4421,7 @@ static void image_cache_reset(ImageCache *cache)

[Spice-devel] [PATCH v3 10/10] server: split spice_image_cache from red_worker

2013-08-13 Thread Alon Levy
--- server/Makefile.am | 2 + server/red_worker.c| 158 + server/spice_image_cache.c | 135 ++ server/spice_image_cache.h | 39 +++ 4 files changed, 177 insertions(+), 157 deletions(-)

Re: [Spice-devel] [PATCH v3 10/10] server: split spice_image_cache from red_worker

2013-08-13 Thread Alon Levy
On Tue, Aug 13, 2013 at 10:47:29AM +0300, Alon Levy wrote: diff --git a/server/spice_image_cache.h b/server/spice_image_cache.h new file mode 100644 index 000..f11cebc --- /dev/null +++ b/server/spice_image_cache.h @@ -0,0 +1,39 @@ +#ifndef H_SPICE_IMAGE_CACHE +#define

Re: [Spice-devel] [PATCH v3 01/10] red_worker: mark DRAW_ALL as broken

2013-08-13 Thread Alon Levy
On Tue, Aug 13, 2013 at 08:50:50AM -0400, Alon Levy wrote: On Tue, Aug 13, 2013 at 10:47:20AM +0300, Alon Levy wrote: --- server/red_worker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/red_worker.c b/server/red_worker.c index 9896696..08e2a43 100644

[Spice-devel] [RFC 2/2] add shared memory display channel support

2013-08-13 Thread Alon Levy
The new protocol is an extension optionally supported by the client if setting this capability bit. It includes 4 new messages, 3 are new messages (SHM_OFFER, SHM_REPLY, SHM_DAMAGE) and one replaces an existing message (SURFACE_CREATE_SHM replaces SURFACE_CREATE), plus a capability bit that both

[Spice-devel] [RFC] shared memory support in display channel

2013-08-13 Thread Alon Levy
see spice protocol commit add shared memory display channel support for the design. This commit adds messages to support sharing the primary surface between the remote client for the display channel and the server. This commit updates the spice-protocol submodule as well. ---

[Spice-devel] [PATCH 01/10] red_worker: mark DRAW_ALL as broken

2013-08-12 Thread Alon Levy
--- server/red_worker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/red_worker.c b/server/red_worker.c index 9896696..08e2a43 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -87,6 +87,7 @@ //#define DUMP_BITMAP //#define PIPE_DEBUG //#define RED_WORKER_STAT +/*

[Spice-devel] [PATCH 02/10] server/red_worker.c:red_process_drawable: rename drawable to red_drawable

2013-08-12 Thread Alon Levy
--- server/red_worker.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 08e2a43..29a6295 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4185,11 +4185,11 @@ static inline void

[Spice-devel] [PATCH 03/10] server/red_worker.c:red_process_drawable: rename item to drawable

2013-08-12 Thread Alon Levy
--- server/red_worker.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 29a6295..0674174 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4189,23 +4189,23 @@ static inline void

[Spice-devel] [PATCH 04/10] server: move dump_bitmap to separate file

2013-08-12 Thread Alon Levy
--- server/Makefile.am | 2 + server/red_worker.c | 157 ++-- server/spice_bitmap_utils.c | 152 ++ server/spice_bitmap_utils.h | 6 ++ 4 files changed, 164 insertions(+), 153 deletions(-) create

[Spice-devel] [PATCH 07/10] server: move surface_format_to_image_type to spice_bitmap_utils

2013-08-12 Thread Alon Levy
--- server/red_worker.c | 24 ++-- server/spice_bitmap_utils.c | 17 + server/spice_bitmap_utils.h | 2 ++ 3 files changed, 21 insertions(+), 22 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 334a709..0aa00be 100644 ---

[Spice-devel] [PATCH 05/10] server: move bit set/clear utilities out of red_worker.h

2013-08-12 Thread Alon Levy
--- server/Makefile.am | 1 + server/red_dispatcher.c | 4 +++- server/red_worker.c | 1 + server/red_worker.h | 18 -- 4 files changed, 5 insertions(+), 19 deletions(-) diff --git a/server/Makefile.am b/server/Makefile.am index e5392ba..feee2f1 100644 ---

[Spice-devel] [PATCH 08/10] server/red_worker: s/image_cache_eaging/image_cache_aging/

2013-08-12 Thread Alon Levy
--- server/red_worker.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 0aa00be..2cd2b1a 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4431,7 +4431,7 @@ static void image_cache_reset(ImageCache *cache)

[Spice-devel] [PATCH 06/10] server: move three functions to red_channel

2013-08-12 Thread Alon Levy
Three blocking functions, one was split to leave the display channel specific referencing of the DrawablePipeItem being sent inside red_worker, but the rest (most) of the timeout logic was moved to red_channel, including the associated constants. Moved functions:

[Spice-devel] [PATCH 10/10] shared memory support for display channel.

2013-08-12 Thread Alon Levy
See spice-protocol commit f24154b87f92ae65b1aa83b97378f9c687d09017 for complete details. --- configure.ac | 4 +- server/red_dispatcher.c| 50 - server/red_dispatcher.h| 4 + server/red_worker.c| 413

[Spice-devel] [PATCH 09/10] server: split spice_image_cache from red_worker

2013-08-12 Thread Alon Levy
--- server/Makefile.am | 2 + server/red_worker.c| 158 + server/spice_image_cache.c | 135 ++ server/spice_image_cache.h | 39 +++ spice-common | 2 +- 5 files changed, 178

Re: [Spice-devel] [PATCH 01/10] red_worker: mark DRAW_ALL as broken

2013-08-12 Thread Alon Levy
Please ignore this patchset, I did two mistakes, sending the shared memory not-yet-done patches and merging spice-common change from them into the patch before last. - Original Message - --- server/red_worker.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Spice-devel] [PATCH 05/10] server: move bit set/clear utilities out of red_worker.h

2013-08-12 Thread Alon Levy
On Mon, Aug 12, 2013 at 09:08:36AM -0400, Yonit Halperin wrote: Hi, You forgot to add spice_server_utils.h :) There's a spice-common/common/bitops.h file, maybe it makes sense to have these functions there? But now that we have spice-common as a submodule, and since these functions

[Spice-devel] [PATCH v2 1/9] red_worker: mark DRAW_ALL as broken

2013-08-12 Thread Alon Levy
--- server/red_worker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/red_worker.c b/server/red_worker.c index 9896696..08e2a43 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -87,6 +87,7 @@ //#define DUMP_BITMAP //#define PIPE_DEBUG //#define RED_WORKER_STAT +/*

[Spice-devel] [PATCH v2 2/9] server/red_worker.c:red_process_drawable: rename drawable to red_drawable

2013-08-12 Thread Alon Levy
--- server/red_worker.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 08e2a43..29a6295 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4185,11 +4185,11 @@ static inline void

[Spice-devel] [PATCH v2 3/9] server/red_worker.c:red_process_drawable: rename item to drawable

2013-08-12 Thread Alon Levy
--- server/red_worker.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 29a6295..0674174 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4189,23 +4189,23 @@ static inline void

[Spice-devel] [PATCH v2 5/9] server: move bit set/clear utilities out of red_worker.h

2013-08-12 Thread Alon Levy
--- server/Makefile.am | 1 + server/red_dispatcher.c | 4 +++- server/red_worker.c | 1 + server/red_worker.h | 18 -- server/spice_server_utils.h | 23 +++ 5 files changed, 28 insertions(+), 19 deletions(-) create mode 100644

[Spice-devel] [PATCH v2 4/9] server: move dump_bitmap to separate file

2013-08-12 Thread Alon Levy
--- server/Makefile.am | 2 + server/red_worker.c | 157 ++-- server/spice_bitmap_utils.c | 150 ++ server/spice_bitmap_utils.h | 6 ++ 4 files changed, 162 insertions(+), 153 deletions(-) create

[Spice-devel] [PATCH v2 6/9] server: move three functions to red_channel

2013-08-12 Thread Alon Levy
Three blocking functions, one was split to leave the display channel specific referencing of the DrawablePipeItem being sent inside red_worker, but the rest (most) of the timeout logic was moved to red_channel, including the associated constants. Moved functions:

[Spice-devel] [PATCH v2 7/9] server: move surface_format_to_image_type to spice_bitmap_utils

2013-08-12 Thread Alon Levy
--- server/red_worker.c | 28 server/spice_bitmap_utils.c | 17 + server/spice_bitmap_utils.h | 2 ++ 3 files changed, 23 insertions(+), 24 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 334a709..f1b7db6 100644 ---

Re: [Spice-devel] [PATCH v2 6/9] server: move three functions to red_channel

2013-08-12 Thread Alon Levy
11:32 AM, Alon Levy wrote: Three blocking functions, one was split to leave the display channel specific referencing of the DrawablePipeItem being sent inside red_worker, but the rest (most) of the timeout logic was moved to red_channel, including the associated constants. Moved

[Spice-devel] [PATCH win qxl] miniport/qxl.inf: simplify by having FeatureScore for everyone

2013-08-07 Thread Alon Levy
FeatureScore is the only difference between the _vista options and the rest, so just setting it also for windows xp using drivers results in a simplification of the inf file, and no downside. --- miniport/qxl.inf | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff

Re: [Spice-devel] QXL_DRAW_TEXT example

2013-08-06 Thread Alon Levy
Hi all, is there some example code for QXL_DRAW_TEXT. A simple command for spice-0.12.4/server/tests/ would be great. Or is there some documentation? What font is used? I would love a test, but someone needs to write one. The best option to learn how it is used is to

Re: [Spice-devel] SPICE_INTERFACE_KEYBOARD - scancodes vs. utf8

2013-08-06 Thread Alon Levy
Seems the keyboard interface only return scancodes? Is there a way to get the corresponding utf8 character (using client side keyboard mapping)? Scancodes are great for use in qemu/X11, but other applications needs utf8. Which?

Re: [Spice-devel] SPICE_INTERFACE_KEYBOARD - scancodes vs. utf8

2013-08-06 Thread Alon Levy
Scancodes are great for use in qemu/X11, but other applications needs utf8. Which? I want to write a terminal emulator, exporting the vt100 display over spice. Example: # spiceterm -c /bin/bash That way you can run any terminal based command over spice. We already have

Re: [Spice-devel] Spice agent for XSpice

2013-07-31 Thread Alon Levy
On Wed, 2013-07-31 at 17:53 +0200, Hans de Goede wrote: Hi, On 07/31/2013 05:43 PM, Alon Levy wrote: Hi, On 03/09/2012 11:57 AM, Alon Levy wrote: On Fri, Mar 09, 2012 at 10:46:50AM +0100, Hans de Goede wrote: Hi Eike, Alon, On 03/08/2012 08:33 PM, Eike Hein wrote: Hi, I

[Spice-devel] [PATCH v2 qxl-win] miniport: halve QXL_IO_UPDATE_IRQ calls

2013-07-30 Thread Alon Levy
QXL_IO_UPDATE_IRQ causes the device to check int_mask and int_pending and issue an interrupt if that is required. Since we just zeroed int_mask, no interrupt will ever be issued. Since we issue another QXL_IO_UPDATE_IRQ in the interrupt routine DPC right after resetting int_mask any pending

[Spice-devel] [PATCH 1/3] display/driver: DrvDeleteDeviceBitmap: log if pdev disabled

2013-07-29 Thread Alon Levy
Alternative is to leak, and this happens regularely. Perhaps we should be keeping track and destroying these surfaces later (in case no reset happens in the middle, which destroys all off screen surfaces anyway). --- display/driver.c | 5 + 1 file changed, 5 insertions(+) diff --git

[Spice-devel] [PATCH 2/3] miniport: use a limited interrupt mask

2013-07-29 Thread Alon Levy
--- miniport/qxl.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/miniport/qxl.c b/miniport/qxl.c index 33efac7..f5d6b48 100644 --- a/miniport/qxl.c +++ b/miniport/qxl.c @@ -26,6 +26,10 @@ #endif #include minimal_snprintf.h +#define WIN_QXL_INT_MASK

[Spice-devel] [PATCH 3/3] miniport: halve QXL_IO_UPDATE_IRQ calls

2013-07-29 Thread Alon Levy
RHBZ: 856246 --- miniport/qxl.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/miniport/qxl.c b/miniport/qxl.c index f5d6b48..629fbdb 100644 --- a/miniport/qxl.c +++ b/miniport/qxl.c @@ -1298,7 +1298,7 @@ err: VOID InterruptCallback(PVOID dev_extension, PVOID

Re: [Spice-devel] [PATCH spice-server 1/8] red_channel: prevent adding and pushing pipe items after a channel_client has diconnected

2013-07-28 Thread Alon Levy
On Fri, 2013-07-26 at 14:08 -0400, Yonit Halperin wrote: ACK series, looks good. Fixes: leaks of pipe items red_client_destroy: assertion `rcc-send_data.size == 0' red_channel_disconnect clears the pipe. It is called only once. After, it was called, not items should be added to the pipe.

[Spice-devel] [PATCH] server/red_channel: fix unused variable

2013-07-28 Thread Alon Levy
unused variable 'so_unsent_size' [-Werror=unused-variable] --- Nahum, could you check that this works for you? server/red_channel.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/server/red_channel.c b/server/red_channel.c index 31c991b..33af388

[Spice-devel] [qxl-win PATCH] display: add punting where it is missing

2013-07-26 Thread Alon Levy
--- display/brush.c | 4 +++- display/driver.c | 2 ++ display/pointer.c | 8 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/display/brush.c b/display/brush.c index 0b9400d..fe94f1c 100644 --- a/display/brush.c +++ b/display/brush.c @@ -235,10 +235,12 @@ BOOL APIENTRY

Re: [Spice-devel] [PATCH] xddm/miniport/qxl.inf: bump version and touch date

2013-07-18 Thread Alon Levy
the driver. On 07/17/2013 05:53 PM, Yonit Halperin wrote: ACK. Maybe Arnon knows more about the version scheme. On 07/17/2013 10:15 AM, Alon Levy wrote: We haven't done this for most any change. Perhaps we should do this? No idea what the x.y.z.w convention is, so I made the most minor change

[Spice-devel] [PATCH qxl-win] miniport: disable surfaces by default

2013-07-17 Thread Alon Levy
Change the registry checking logic we already have, instead of enabling surfaces by default we now disable surfaces by default. They can be enabled without driver change by creating a registry key name SurfacesEnabled of type DWORD with any value under the adapter key. To find the adapter key,

Re: [Spice-devel] [PATCH 11/11] Release 0.12.4

2013-07-17 Thread Alon Levy
ACK series, just one minor spelling mistake below. --- NEWS | 13 + configure.ac | 4 ++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index acfffb8..684e993 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,16 @@ +Major changes in 0.12.4:

[Spice-devel] [PATCH] xddm/miniport/qxl.inf: bump version and touch date

2013-07-17 Thread Alon Levy
We haven't done this for most any change. Perhaps we should do this? No idea what the x.y.z.w convention is, so I made the most minor change right now. But the date is the important bit. --- xddm/miniport/qxl.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Spice-devel] [PATCH xf86-video-qxl 0/4] cleanup and one bug fix

2013-07-15 Thread Alon Levy
The first, second and fourth patches are trivial. The third is a fix for a segmentation fault with DFPS turned on when resizing the monitor, the damage rectangle list ends up containing out of bounds rectangles. The fix I chose is more generic then fixing the dfps code. Alon Levy (4): Xspice

[Spice-devel] [PATCH xf86-video-qxl 1/4] Xspice: don't pull in kms functions

2013-07-15 Thread Alon Levy
--- src/qxl_driver.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index ac5408e..b42deb3 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1214,10 +1214,15 @@ qxl_init_scrn (ScrnInfoPtr pScrn, Bool kms) pScrn-name =

[Spice-devel] [PATCH xf86-video-qxl 2/4] src/spiceqxl_main_loop: fix typo in comment

2013-07-15 Thread Alon Levy
--- src/spiceqxl_main_loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spiceqxl_main_loop.c b/src/spiceqxl_main_loop.c index 92579eb..6c1f7d5 100644 --- a/src/spiceqxl_main_loop.c +++ b/src/spiceqxl_main_loop.c @@ -274,7 +274,7 @@ static void

[Spice-devel] [PATCH xf86-video-qxl 3/4] qxl_surface: protect from out of bounds rectangles

2013-07-15 Thread Alon Levy
upload_one_primary_region which is called by dfps for each damage box can contain rectangles that are outside of the primary surface if the primary surface has been destroyed in the mean while. Adding a check at upload_one_primary_region solves this problem and also prevents possibly other future

[Spice-devel] [PATCH xf86-video-qxl 4/4] qxl_surface: remove unused variables, add static where needed

2013-07-15 Thread Alon Levy
--- src/qxl_surface.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/qxl_surface.c b/src/qxl_surface.c index f82119a..dea3945 100644 --- a/src/qxl_surface.c +++ b/src/qxl_surface.c @@ -484,10 +484,8 @@ image_from_surface_internal(qxl_screen_t *qxl, return

Re: [Spice-devel] [PATCH xf86-video-qxl 3/4] qxl_surface: protect from out of bounds rectangles

2013-07-15 Thread Alon Levy
- Original Message - - Mensaje original - upload_one_primary_region which is called by dfps for each damage box can contain rectangles that are outside of the primary surface if the primary surface has been destroyed in the mean while. Adding a check at

Re: [Spice-devel] [PATCH xf86-video-qxl 1/4] Xspice: don't pull in kms functions

2013-07-15 Thread Alon Levy
- Original Message - - Mensaje original - --- src/qxl_driver.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/qxl_driver.c b/src/qxl_driver.c index ac5408e..b42deb3 100644 --- a/src/qxl_driver.c +++ b/src/qxl_driver.c @@ -1214,10 +1214,15 @@

Re: [Spice-devel] Spice agent for XSpice

2013-07-15 Thread Alon Levy
Hi, On 03/09/2012 11:57 AM, Alon Levy wrote: On Fri, Mar 09, 2012 at 10:46:50AM +0100, Hans de Goede wrote: Hi Eike, Alon, On 03/08/2012 08:33 PM, Eike Hein wrote: Hi, I recently sent a mail to Marc-André Lureau, inquiring about clipboard sharing support in his virt-viewer

Re: [Spice-devel] [server/tests PATCH 4/6] server/tests: remove option from usage if AUTOMATED_TESTS is not configured

2013-07-14 Thread Alon Levy
On Tue, 2013-07-09 at 19:15 +0300, Uri Lublin wrote: ACK, just one comment that is nice to fix before pushing. --- server/tests/test_display_base.c | 25 +++-- 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/server/tests/test_display_base.c

Re: [Spice-devel] [server/tests PATCH 1/6] server/tests: test_display_base: set rect according to appropriate surface

2013-07-14 Thread Alon Levy
On Tue, 2013-07-09 at 19:15 +0300, Uri Lublin wrote: ACK series. When surface_id == 0, primary is used. Otherwise (currently 1), secondary is used. Also, remove unused test_width and test_height. Since commit caea7699434c20dceef8fc79d21b8eeb663fbf53, test-width and test-height are used.

Re: [Spice-devel] [PATCH 1/3] qxl: disable image cache for KMS

2013-07-07 Thread Alon Levy
On Fri, 2013-07-05 at 14:49 +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com Currently this code can't work with KMS, need to work out how the image cache could be effectively used with KMS enabled. ACK All 3 patches. Signed-off-by: Dave Airlie airl...@redhat.com ---

Re: [Spice-devel] [PATCH qxl-win] display: apply the fix in fc314927bc48835e to Alpha Bitmaps

2013-07-07 Thread Alon Levy
On Fri, 2013-07-05 at 11:25 -0400, Yonit Halperin wrote: rhbz#968050 Looks great to me, ACK. In contrast to Microsoft Msdn documentation, the iUniq of a SURFOBJ doesn't always change when the surface changes. However, it seems that the iUniq of the associated color_trans (XLATEOBJ)

[Spice-devel] [PATCH qxl-win] miniport/qxl.c: fail a custom mode that would not fit memory (RHBZ#863488)

2013-06-30 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- miniport/qxl.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/miniport/qxl.c b/miniport/qxl.c index 58ba15e..69d1b16 100644 --- a/miniport/qxl.c +++ b/miniport/qxl.c @@ -994,16 +994,29

Re: [Spice-devel] New SPICE client for Android

2013-06-10 Thread Alon Levy
Hello everyone! I put together my multi-touch UI from bVNC with spice-gtk to create a SPICE client for Android called aSPICE. It has integrated SSH tunneling functionality. The entire project is open source, and is currently based on spice-gtk v.0.19. The source is available here:

Re: [Spice-devel] [PATCH spice] reds: look up the right matching channel during link ack

2013-06-07 Thread Alon Levy
It's quite surprising that the server is not looking up the matching channel when setting up the link. It went probably unnoticed becauses channels of the same kind usually share the same capabilities, and it's unlikely to remove channel 0. But I happen to hit that error because channel 0 was

Re: [Spice-devel] [PATCH spice-gtk 5/5] Teach spicy to use a NBD channel

2013-06-05 Thread Alon Levy
Looks good except for an unrelated bit you left in there, marked below. --- gtk/spicy.c | 102 +++- 1 file changed, 95 insertions(+), 7 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index dff9d44..0b5b1ea 100644 ---

Re: [Spice-devel] kde/spice crashes when firefox is started

2013-05-30 Thread Alon Levy
-fix-strncat-bufferoverflow.patch) Cheers Rob 2013/5/29 Alon Levy al...@redhat.com: Hello all, Hi Rob, I'm using spice with kde on opensuse. When using spice via a ssh encrypted connection, all works fine and is very fast untill I start firefox. The connection freezes

[Spice-devel] [PATCH] spice.html: remove default password

2013-05-30 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- spice.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spice.html b/spice.html index 0f705fd..bd8d1ab 100644 --- a/spice.html +++ b/spice.html @@ -119,7 +119,7 @@ span class=logoSPICE/span label

[Spice-devel] [PATCH xf86-video-qxl] spiceqxl_main_loop: fix use of watch after removal

2013-05-30 Thread Alon Levy
rhbz 968931 Signed-off-by: Alon Levy al...@redhat.com --- src/spiceqxl_main_loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spiceqxl_main_loop.c b/src/spiceqxl_main_loop.c index a8a67de..92579eb 100644 --- a/src/spiceqxl_main_loop.c +++ b/src/spiceqxl_main_loop.c

Re: [Spice-devel] kde/spice crashes when firefox is started

2013-05-29 Thread Alon Levy
Hello all, Hi Rob, I'm using spice with kde on opensuse. When using spice via a ssh encrypted connection, all works fine and is very fast untill I start firefox. The connection freezes for a while and when I'm able to connect I see the console. The Xorg.0.log gives a huge amount off

Re: [Spice-devel] aboutRemote access for a physical machine

2013-05-28 Thread Alon Levy
thank you, Christophe i know xspice is aimed to it, but i don't konw it's process, does it support windows os now ? It doesn't. It is doable for windows xp and windows 7 using the mirror driver as a starting point. I'm clueless about windows 8. Weston seems support linux only, am i right?

Re: [Spice-devel] aboutRemote access for a physical machine

2013-05-28 Thread Alon Levy
thank you, Christophe i know xspice is aimed to it, but i don't konw it's process, does it support windows os now ? Weston seems support linux only, am i right? I'll try actually windows 8 should work just like any other graphics driver. But still no one afaik has started work on this.

Re: [Spice-devel] [PATCH spice-server] red_channel: replace an assert upon threads mismatch with a warning

2013-05-24 Thread Alon Levy
The assert: spice_assert(pthread_equal(pthread_self(), client-thread_id)) and the assert: spice_assert(pthread_equal(pthread_self(), rcc-channel-thread_id)) were coded in order to protect data that is accessed from the main context (red_client and most of the channels), from access by

Re: [Spice-devel] [PATCH] main_channel: fix double release of migration target data

2013-05-23 Thread Alon Levy
If client_migrate_info was called once with cert-host-subject and then again without cert-host-subject, on a third call to client_migrate info, the cert-host-subject from the first call would have been freed for the second time. ACK --- server/main_channel.c | 2 ++ 1 file changed, 2

Re: [Spice-devel] Support about for OpenGL|ES

2013-05-22 Thread Alon Levy
On Wed, 2013-05-22 at 15:07 +0800, jojo wrote: Hi, In the client side, i want to accelerate the performance of rendering, i want to use the OpenGL|ES in the client. Du to the http://spice-space.org/features.html;, i saw there are some similar features in progress that i want to add. is it

[Spice-devel] [PATCH 0/9] 0.12.3 + a bunch of small fixes I had laying around

2013-05-17 Thread Alon Levy
Feel free to shoot down anything (like the rename for no apparent reason other then using the word cap) Alon Levy (9): server/red_worker: s/driver_has_monitors_config/driver_cap_monitors_config/ (plus small comment) server/red_worker: turn critical (assert) non error into warning

[Spice-devel] [PATCH 1/9] server/red_worker: s/driver_has_monitors_config/driver_cap_monitors_config/ (plus small comment)

2013-05-17 Thread Alon Levy
--- server/red_worker.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index fb736b5..8f3e478 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1040,7 +1040,7 @@ typedef struct RedWorker { uint64_t

[Spice-devel] [PATCH 2/9] server/red_worker: turn critical (assert) non error into warning

2013-05-17 Thread Alon Levy
The situation causing this assert is unknown but it doesn't cause correctness issues with later rendering, and it is causing an abort. --- server/red_worker.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index 8f3e478..14d219b

[Spice-devel] [PATCH 3/9] server/tests/test_display_base: add missing set_client_capabilities, fix client_monitors_config signature

2013-05-17 Thread Alon Levy
--- server/tests/test_display_base.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index 588e960..8657e91 100644 --- a/server/tests/test_display_base.c +++ b/server/tests/test_display_base.c @@

[Spice-devel] [PATCH 4/9] server/red_worker: simplify monitors_config update

2013-05-17 Thread Alon Levy
--- server/red_worker.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 14d219b..f047d29 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -1279,6 +1279,9 @@ static MonitorsConfig

[Spice-devel] [PATCH 5/9] server/tests: test_display_width_stride

2013-05-17 Thread Alon Levy
--- server/tests/Makefile.am | 8 ++- server/tests/test_display_base.c | 48 ++--- server/tests/test_display_base.h | 13 + server/tests/test_display_width_stride.c | 92 4 files changed, 154 insertions(+), 7

[Spice-devel] [PATCH 6/9] server/red_dispatcher: close pa hole in RedWorkerMessageDisplayConnect for valgrind

2013-05-17 Thread Alon Levy
--- server/red_dispatcher.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red_dispatcher.h b/server/red_dispatcher.h index 4d0d2a8..7d23b11 100644 --- a/server/red_dispatcher.h +++ b/server/red_dispatcher.h @@ -43,10 +43,10 @@ void

[Spice-devel] [PATCH 7/9] server/dispatchers: initialize stack to 0 for valgrind

2013-05-17 Thread Alon Levy
--- server/main_dispatcher.c | 2 +- server/red_dispatcher.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/server/main_dispatcher.c b/server/main_dispatcher.c index 92b0791..e7a451a 100644 --- a/server/main_dispatcher.c +++ b/server/main_dispatcher.c @@ -78,7 +78,7

[Spice-devel] [PATCH 8/9] server/red_parse_qxl: two coding convention pointer cast fix

2013-05-17 Thread Alon Levy
--- server/red_parse_qxl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index 4b39029..65781e7 100644 --- a/server/red_parse_qxl.c +++ b/server/red_parse_qxl.c @@ -104,7 +104,7 @@ static size_t

[Spice-devel] [PATCH 9/9] 0.12.3 release

2013-05-17 Thread Alon Levy
--- NEWS | 18 ++ configure.ac | 4 ++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 30912c5..acfffb8 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,21 @@ +Major changes in 0.12.3: + +* monitor client bandwidth and

[Spice-devel] spice server release 0.12.3

2013-05-17 Thread Alon Levy
I'm pleased to announce a bug fixing minor release of spice server: http://spice-space.org/download/releases/spice-0.12.3.tar.bz2 here is the excerpt from NEWS: * monitor client bandwidth and latency. * dynamically adjust video stream quality based on client bandwidth latency. ** new

Re: [Spice-devel] how to infer the spice channel type corresponding to a specific port.

2013-05-15 Thread Alon Levy
On Wed, 2013-05-15 at 18:05 +0800, bigclouds wrote: hi, 1.how to know the channel type of a port? There is no way, since there is a single port, and the order of client connection to the server is determined by the client, and the ports are determined by the operating system. You will have to

Re: [Spice-devel] why spice server is not aware of client-disconnection.

2013-05-14 Thread Alon Levy
On Tue, 2013-05-14 at 17:38 +0800, bigclouds wrote: hi,all look at the output of netstat, it is after at least 30minutes i un-plug cable. how to make server know client's disconnect and disconnect channels(clean channels). tcp0 0 192.168.5.240:5903

Re: [Spice-devel] [xf86-video-qxl] Eliminate gcc warning initialization discards 'const' qualifier from pointer target type

2013-05-13 Thread Alon Levy
ACK from me. Soren, are you ok with this? On Thu, 2013-03-21 at 13:03 -0500, Jeremy White wrote: Signed-off-by: Jeremy White jwh...@codeweavers.com --- This is the controversial patch; see previous conversation here:

Re: [Spice-devel] [xf86-video-qxl] Eliminate gcc warning initialization discards 'const' qualifier from pointer target type

2013-05-13 Thread Alon Levy
Sorry for the noise, brain fart. On Mon, 2013-05-13 at 14:01 +0300, Alon Levy wrote: ACK from me. Soren, are you ok with this? On Thu, 2013-03-21 at 13:03 -0500, Jeremy White wrote: Signed-off-by: Jeremy White jwh...@codeweavers.com --- This is the controversial patch; see

Re: [Spice-devel] [Users] Server 2k8

2013-04-23 Thread Alon Levy
Ryan Wilkinson píše v Po 22. 04. 2013 v 14:43 -0600: Sounds like I'm missing something. We're looking at using Windows Server 2k8 as a workstation OS as the licensing seems to be more reasonable for vdi. Ah, OK. Then it would be reasonable to add server systems as supported to driver

Re: [Spice-devel] [PATCH spice] server: Add public spice_qxl_driver_unload method

2013-04-23 Thread Alon Levy
With a SPICE_DISPLAY_CAP_MONITORS_CONFIG capable client, the client needs to know what part of the primary to use for each monitor. If the guest driver does not support this, the server sends messages to the client for a single monitor spanning the entire primary. As soon as the guest calls

Re: [Spice-devel] [PATCH spice-server 00/28] adaptive video streaming

2013-04-17 Thread Alon Levy
On Mon, 2013-04-15 at 14:54 -0400, Yonit Halperin wrote: Hi, On 04/14/2013 09:37 AM, Alon Levy wrote: On Tue, Feb 26, 2013 at 01:03:46PM -0500, Yonit Halperin wrote: ACK series, sorry for the delay. I have to admit I don't understand the first patches as well as I should, but seeing

Re: [Spice-devel] [spice-xpi 1/3] build: Adjust plugin name when building xpi

2013-04-17 Thread Alon Levy
The plugin binary name was changed from libnsISpice to npSpiceConsole, but the Makefile.am rule optionnally building SpiceXpi.xpi was not changed to take this rename into account. ACK series. --- SpiceXPI/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Spice-devel] [PATCH spice-gtk 3/8] channel-playback: provide access to playback properties via the session

2013-04-17 Thread Alon Levy
Support checking whether an audio playback is active and what its latency is. ACK, one comment. --- gtk/Makefile.am | 1 + gtk/channel-playback-priv.h | 23 +++ gtk/channel-playback.c | 24 gtk/spice-session-priv.h| 3

Re: [Spice-devel] [PATCH spice-gtk 4/8] channel-display: video stream quality report

2013-04-17 Thread Alon Levy
handle MSG_STREAM_ACTIVIATE_REPORT and send MSGC_STREAM_REPORT periodically, or when the playback is out of sync. ACK with one comment --- gtk/channel-display-priv.h | 10 gtk/channel-display.c | 116 - spice-common |

Re: [Spice-devel] [PATCH spice-gtk 6/8] spice-pulse: adjust the playback latency when the min-latency property changes

2013-04-17 Thread Alon Levy
If the current latency is smaller than the new min-latency value, we cork the playback till the target latency is achieved. Note: I didn't modify the prebuf configuration and used pa_stream_prebuf, because pulse updated the prebuf only if I set both prebuf and tlength to be

Re: [Spice-devel] [PATCH spice-server 00/28] adaptive video streaming

2013-04-17 Thread Alon Levy
On 04/17/2013 10:47 AM, Alon Levy wrote: On Mon, 2013-04-15 at 14:54 -0400, Yonit Halperin wrote: Hi, On 04/14/2013 09:37 AM, Alon Levy wrote: On Tue, Feb 26, 2013 at 01:03:46PM -0500, Yonit Halperin wrote: ACK series, sorry for the delay. I have to admit I don't understand

Re: [Spice-devel] [PATCH spice-server 01/28] red_worker: stream agent - fix miscounting of frames

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:47PM -0500, Yonit Halperin wrote: Frames counting was skipped when the previous frame was already sent completely to the client. ACK --- server/red_worker.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git

Re: [Spice-devel] [PATCH spice-server 02/28] server/red_worker: streams: moving mjpeg_encoder from Stream to StreamAgent

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:48PM -0500, Yonit Halperin wrote: The mjpeg_encoder should be client specific, and not shared between different clients**, for the following reasons: (1) Since we use abbreviated jpeg datastream for mjpeg, employing the same mjpeg_encoder for different clients

Re: [Spice-devel] [PATCH spice-server 03/28] mjpeg_encoder: configure mjpeg quality and frame rate according to a given bit rate

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:49PM -0500, Yonit Halperin wrote: Previously, the mjpeg quality was always 70. The frame rate was tuned according to the frames' congestion in the pipe. This patch sets the quality and frame rate according to a given bit rate and the size of the first encoded

Re: [Spice-devel] [PATCH spice-server 04/28] mjpeg_encoder: re-configure stream parameters when the frame's encoding size changes

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:50PM -0500, Yonit Halperin wrote: If the encoding size seems to get smaller/bigger, re-evaluate the stream quality and frame rate. ACK. --- server/mjpeg_encoder.c | 147 ++--- 1 file changed, 139 insertions(+), 8

Re: [Spice-devel] [PATCH spice-server 05/28] mjpeg_encoder: adjust the stream bit rate based on periodic client feedback

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:51PM -0500, Yonit Halperin wrote: mjpeg_encoder can receive periodic reports about the playback status on the client side. Then, mjpeg_encoder analyses the report and can increase or decrease the stream bit rate, depending on the report. When the bit rate is

Re: [Spice-devel] [PATCH spice-server 06/28] mjpeg_encoder: modify stream bit rate based on server side pipe congestion

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:52PM -0500, Yonit Halperin wrote: Downgrading stream bit rate when the input frame rate in the server exceeds the output frame rate, and frames are being dropped from the output pipe. ACK. --- server/mjpeg_encoder.c | 103

<    1   2   3   4   5   6   7   8   9   10   >