Re: [Spice-devel] [PATCH spice-server 07/28] mjpeg_encoder: update the client with estimations for the required playback latency

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:53PM -0500, Yonit Halperin wrote: The required client playback latency is assessed based on the current estimation of the bit rate, the network latency, and the encoding size of the frames. When the playback delay that is reported by the client seems too small, or

Re: [Spice-devel] [PATCH spice-server 10/28] mjpeg_encoder: add stream warmup time, in which we avoid server and client drops

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:56PM -0500, Yonit Halperin wrote: The stream starts after lossless frames were sent to the client, and without rate control (except for pipe congestion). Thus, on the beginning of the stream, we might observe frame drops on the client and server side which are

Re: [Spice-devel] [PATCH spice-server 11/28] server: spice_timer_queue

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:57PM -0500, Yonit Halperin wrote: Each thread can create a spice_timer_queue, for managing its own timers. ACK. nitpick: why ms and not nano? --- server/Makefile.am | 2 + server/spice_timer_queue.c | 268

Re: [Spice-devel] [PATCH spice-server 12/28] server/red_worker: assign timer callbacks to worker_core, using spice_timer_queue

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:58PM -0500, Yonit Halperin wrote: display channel - supplying timeouts interface to red_channel, in order to allow periodic latency monitoring (see next patch). ACK --- server/red_worker.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

Re: [Spice-devel] [PATCH spice-server 13/28] red_channel: monitor connection latency using MSG_PING

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:59PM -0500, Yonit Halperin wrote: ACK. just a note: maybe we should not send our time, but an id, to not leak information? another note: should we drop the special case main channel ping later? other notes (all nitpick quality) below. ---

Re: [Spice-devel] [PATCH spice-server 14/28] red_worker: stream - update periodically the input frame rate

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:04:00PM -0500, Yonit Halperin wrote: Periodically calculate the rate of frames arriving from the guest to the server. ACK. red_now should be put in a header later. --- server/red_worker.c | 36 +++- 1 file changed, 35

Re: [Spice-devel] [PATCH spice-server 15/28] server/red_worker: enable latency monitoring in the display channel

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:04:01PM -0500, Yonit Halperin wrote: ACK --- server/red_worker.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index 82f2fc9..5043c10 100644 --- a/server/red_worker.c +++ b/server/red_worker.c

Re: [Spice-devel] [PATCH spice-server 16/28] red_worker: start using mjpeg_encoder rate control capabilities

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:04:02PM -0500, Yonit Halperin wrote: This patch only employs setting the stream parameters based on the initial given bit-rate, the latency, and the encoding size. Later patches will also employ mjpeg_encoder response to client reports, and its control over frame

Re: [Spice-devel] [PATCH spice-server 17/28] red_worker: support SPICE_MSGC_DISPLAY_STREAM_REPORT

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:04:03PM -0500, Yonit Halperin wrote: ACK, one spelling error below. update mjpeg_encoder with reports from the client about the playback quality. --- server/red_dispatcher.c | 1 + server/red_worker.c | 86 +++--

Re: [Spice-devel] [PATCH spice-server 18/28] red_worker: notify mjpeg_encoder on server frame drops

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:04:04PM -0500, Yonit Halperin wrote: ACK --- server/red_worker.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 23f9ca5..ff26f84 100644 --- a/server/red_worker.c +++

Re: [Spice-devel] [PATCH spice-server 19/28] red_worker: ignoring video frame drops that are not due to pipe congestion

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:04:05PM -0500, Yonit Halperin wrote: A frame can be dropped if a new frame was added during the same call to red_process_command (we didn't attempt to send the older frame). Such drops are ignored. ACK. rant red_detach_stream / red_attach_stream and

Re: [Spice-devel] [PATCH spice-server 20/28] dispatcher.h: fix - s/#define MAIN_DISPATCHER_H/#define DISPATCHER_H

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:04:06PM -0500, Yonit Halperin wrote: ACK --- server/dispatcher.h | 6 +++--- server/main_dispatcher.h | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/server/dispatcher.h b/server/dispatcher.h index a468c58..1b389bd 100644 ---

Re: [Spice-devel] [PATCH spice-server 21/28] snd_worker: support sending SPICE_MSG_PLAYBACK_LATENCY

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:04:07PM -0500, Yonit Halperin wrote: also update spice-common submodule ACK with one line removed. --- server/snd_worker.c | 45 + server/snd_worker.h | 2 ++ 2 files changed, 47 insertions(+) diff --git

Re: [Spice-devel] [PATCH spice-server 22/28] reds: support mm_time latency adjustments

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:04:08PM -0500, Yonit Halperin wrote: When there is no audio playback, we set the mm_time in the client to be older than the one in the server by at least the requested latency (the delta is actually bigger, due to the network latency). When there is an audio

Re: [Spice-devel] [PATCH spice-server 23/28] red_worker: video streams - adjust client playback latency

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:04:09PM -0500, Yonit Halperin wrote: ACK one comment below --- server/red_worker.c | 56 - 1 file changed, 51 insertions(+), 5 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index

Re: [Spice-devel] [PATCH spice-server 24/28] server/red_worker.c: use the bit rate of old streams as a start point for new streams

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:04:10PM -0500, Yonit Halperin wrote: mjpeg_encoder modify the initial bit we supply it, according to the client feedback. If it reaches a bit rate which is higher than the initial one, we use the higher bit rate as the new bit rate estimation. ACK to this and the

Re: [Spice-devel] [PATCH spice-server 00/28] adaptive video streaming

2013-04-14 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:46PM -0500, Yonit Halperin wrote: ACK series, sorry for the delay. I have to admit I don't understand the first patches as well as I should, but seeing as they have been tested and that I would just be delaying them further, I prefer to let you push them. I hope to

Re: [Spice-devel] UMS memory management

2013-03-27 Thread Alon Levy
Hi, On 03/27/2013 06:17 AM, Hans de Goede wrote: Hi, On 03/27/2013 09:07 AM, Søren Sandmann wrote: Hello, The following is some notes on what I am planning to do for UMS memory management. It basically amounts to a rewrite of qxl-surface-ums.c Looks / sounds good, a few

Re: [Spice-devel] [xf86-video-qxl] Eliminate gcc warning initialization discards 'const' qualifier from pointer target type

2013-03-21 Thread Alon Levy
Signed-off-by: Jeremy White jwh...@codeweavers.com --- I'm all for this, as usual. I suggest you just push it. This is the controversial patch; see previous conversation here: http://lists.freedesktop.org/archives/spice-devel/2012-September/010801.html I feel the benefit (nearly zero

Re: [Spice-devel] [PATCH spice 1/4] main-channel: Make main_channel_push_notify deal with dynamic memory

2013-03-14 Thread Alon Levy
ACK series, thanks for fixing my todo :) - Original Message - Currently main_channel_push_notify only gets passed a static string, but chances are in the future it may get passed dynamically allocated strings, prepare it for this. While at it also make clear that the arguments to

Re: [Spice-devel] German keymap in Windows 7

2013-03-13 Thread Alon Levy
Hi, i`m running Windows 7 Prof. 32-bit under KVM/QEMU. I`m using spice togehter with qxl. Guest drivers are all installed. I can succesfully connect to the guest client and everything works fine. But my keyboard is not using qwertz. The input language in the Windows 7 guest is DE. When

Re: [Spice-devel] [spice-devel] [bug] is this a little bug ? (spice-common/common/region.c)

2013-03-10 Thread Alon Levy
Hi, Thanks for catching this! On 03/07/2013 11:55 AM, zhou link wrote: int region_bounds_intersects(const QRegion *rgn1, const QRegion *rgn2) { pixman_box32_t *extents1, *extents2; extents1 = pixman_region32_extents((pixman_region32_t *)rgn1); extents2 =

Re: [Spice-devel] [PATCH spice-server 05/28] mjpeg_encoder: adjust the stream bit rate based on periodic client feedback

2013-03-10 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:03:51PM -0500, Yonit Halperin wrote: mjpeg_encoder can receive periodic reports about the playback status on the client side. Then, mjpeg_encoder analyses the report and can increase or decrease the stream bit rate, depending on the report. When the bit rate is

Re: [Spice-devel] [PATCH spice 3/3] server/reds: Send the agent a CLIENT_DISCONNECTED msg on client disconnect

2013-03-06 Thread Alon Levy
Looks good to me, couldn't resist a nitpick though. Client - agent messages can spawn multiple VDIChunks. When this happens the agent re-assembles the chunks into a complete VDAgentMessage before processing it. The server only guarentees coherency at the chunk level, so it is not possible

Re: [Spice-devel] [PATCH spice-protocol 2/2] Prepare for a 0.12.5 release

2013-03-06 Thread Alon Levy
Both look good, as well as the whole spice-server 3 patchset using the message. Ack series. - Original Message - Signed-off-by: Hans de Goede hdego...@redhat.com --- NEWS | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS b/NEWS index df5d31c..a602292 100644 ---

Re: [Spice-devel] [PATCH spice] Silence __spice_char_device_write_buffer_get: internal buf is not available

2013-03-04 Thread Alon Levy
These messages are printed when the server tries to push a mouse event to the agent before the previous one has been flushed. This is a normal condition (which gets tracked by the reds-pending_mouse_event boolean), and as such it should *not* trigger the printing of error messages. I've

Re: [Spice-devel] spice crashes

2013-03-03 Thread Alon Levy
Hi Klaus I am also having trouble with a windows 7 guest when I install guest-tools. I'm using some software called Altium Designer which freezes when I have guest-tools installed. I then installed just the win-qlx-debug driver and now, rather then freezing, the windows 7

Re: [Spice-devel] how can i set display resolution before connecting

2013-02-27 Thread Alon Levy
10:48,Alon Levy al...@redhat.com 写道: changxiaodong píše v St 20. 02. 2013 v 12:32 +0800: hello: how can i set the display resolution before connect to a desktop? no, that isn't possible. The windowed client will pick up whatever resolution is currently used in the guest, if the client

Re: [Spice-devel] how can i set display resolution before connecting

2013-02-27 Thread Alon Levy
Alon Levy píše v St 27. 02. 2013 v 03:57 -0500: In fact, I went a API that can send a message to agent in the guest and change resolution. There is no such API. You could make spice-gtk allow listening on a socket and receiving agent messages, or just a dbus protocol. What

Re: [Spice-devel] [PATCH] uxa: port over tiled fill code from EXA

2013-02-26 Thread Alon Levy
On Mon, Feb 25, 2013 at 03:39:00PM +1000, airl...@gmail.com wrote: From: Dave Airlie airl...@gmail.com This makes X -retro actually render fast, as opposed to glacially slow. Works with xspice. Didn't grok it otherwise. Tested-by ... Signed-off-by: Dave Airlie airl...@redhat.com ---

Re: [Spice-devel] qxl X.org driver bo abstraction for user mode setting

2013-02-26 Thread Alon Levy
On Tue, Feb 26, 2013 at 02:32:03PM +1000, Dave Airlie wrote: Hi, Patches don't apply on top of uxa: port over tiled fill code from EXA. Okay this is the next chunk of prep for getting KMS into the driver, the first 8 patches are just preparation work and moving stuff around, along with a

Re: [Spice-devel] how can i set display resolution before connecting

2013-02-26 Thread Alon Levy
changxiaodong píše v St 20. 02. 2013 v 12:32 +0800: hello: how can i set the display resolution before connect to a desktop? no, that isn't possible. The windowed client will pick up whatever resolution is currently used in the guest, if the client is run from full screen, it will try

Re: [Spice-devel] [PATCH 9/9] qxl: abstract object allocation away from surface/image/cursor code

2013-02-26 Thread Alon Levy
On Tue, Feb 26, 2013 at 02:32:12PM +1000, Dave Airlie wrote: ACK all the patches above, ACK this one too with small nit picks. Did not break xspice :) Regarding application of patches - I had to manually merge but the merges were the trivial ones so probably some whitespace? so if you manage to

Re: [Spice-devel] xorg driver cleanups

2013-02-25 Thread Alon Levy
On Mon, Feb 25, 2013 at 03:31:08PM +1000, airl...@gmail.com wrote: Hi, these patches just move code around in the X.org driver so it looks more like something that can be maintained, I'm going to start adding KMS support to it soon and i'd like to get stuff split out a bit better with an eye

Re: [Spice-devel] xorg driver cleanups

2013-02-25 Thread Alon Levy
On 02/24/2013 11:31 PM, airl...@gmail.com wrote: Hi, these patches just move code around in the X.org driver so it looks more like something that can be maintained, I'm going to start adding KMS support to it soon and i'd like to get stuff split out a bit better with an eye

Re: [Spice-devel] spice crashes

2013-02-21 Thread Alon Levy
- Original Message - 2013/2/20 Alon Levy al...@redhat.com: I haven't recompiled with debugging for the stack trace yet; is it still necessary, or does the information above suffice? Sorry for dropping the ball on this. I'm afraid it's hard to debug even with this information

Re: [Spice-devel] spice crashes

2013-02-21 Thread Alon Levy
What is the qemu command line? Are you running with kvm or with tcg? - Original Message - Hello Alon, ok, I've got the VM running under valgrind now, but valgrind quits logging due to excessive errors. The log is attached. Best regards, TF 2013/2/21 Trebor Forban

Re: [Spice-devel] spice crashes

2013-02-21 Thread Alon Levy
Can you run qemu built with debugging symbols? same goes for spice-server. - Original Message - Hello Alon, ok, I've got the VM running under valgrind now, but valgrind quits logging due to excessive errors. The log is attached. Best regards, TF 2013/2/21 Trebor Forban

Re: [Spice-devel] spice crashes

2013-02-20 Thread Alon Levy
disabled - see http://spice-space.org/wiki/index.php?title=Valgrind) it would perhaps point to the culprit. Stack trace would help too, but it won't point to the problem assuming it is memory corruption. Regards, TF 2013/1/22 Alon Levy al...@redhat.com: Hello All, while using remote

Re: [Spice-devel] recent spice-protocol doc

2013-02-20 Thread Alon Levy
Hi, Is there a more recent spice protocol definition than this one: http://spice-space.org/docs/spice_protocol.pdf ? Not that I'm aware of. You can always look at: http://cgit.freedesktop.org/spice/spice-common/tree/spice.proto Vincent DESPREZ

Re: [Spice-devel] Dinner tomorrow night (Mon Feb 17) in Brno

2013-02-17 Thread Alon Levy
Hi All, My plane lands in Brno tomorrow around 15:30, so I should be at Hotel Avanti around 16:30. Once I've checked in, I would like to go out and grab some dinner. So are there any other people in Brno tomorrow, who would also like to go out for dinner ? I would like to suggest to get

Re: [Spice-devel] [PATCH] Implement sending audio to the client from a directory of FIFO queues

2013-02-12 Thread Alon Levy
diff --git a/src/Makefile.am b/src/Makefile.am index 6950ba5..21d8dfc 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -77,6 +77,8 @@ spiceqxl_drv_la_SOURCES =\ spiceqxl_main_loop.h \ spiceqxl_display.c \ spiceqxl_display.h \ + spiceqxl_audio.c \ + spiceqxl_audio.h \

Re: [Spice-devel] Packaging spice-html5

2013-02-07 Thread Alon Levy
I'm going to put together a fedora package for spice-html5 and apply to become a package maintainer. That leads me to questions: 1. The process likes to have a static download location for the source tar ball. Presuming I make a spice-html5-0.0.1.tgz, where can I stash it?

Re: [Spice-devel] [PATCH] Establish a preferred default of 1024x768 correctly.

2013-02-05 Thread Alon Levy
Looks good to me, ACK. - Original Message - This fixes a bug with x-spice where you could not specify a default mode in an xorg.conf modeline that was greater than 1024x768. This also eliminates (and partially reverts) patch c1b537fc. It also fixes bug 894421, where gnome modes

Re: [Spice-devel] FOSDEM?

2013-01-31 Thread Alon Levy
Hi everyone, On Fri, Jan 25, 2013 at 03:15:06PM +0100, Christophe Fergeau wrote: On Tue, Jan 22, 2013 at 10:47:05AM +0100, Hans de Goede wrote: On 01/21/2013 09:04 PM, Jeremy White wrote: Are there going to be any SPICE devs at FOSDEM? Anyone interested in trying to connect for

Re: [Spice-devel] settings for qxl memory size

2013-01-24 Thread Alon Levy
2013/1/23 Alon Levy al...@redhat.com: Looks like the client isn't supplying the correct password set below. You can also disable passwords by the disable-ticketing option, i.e. -spice disable-ticketing,... I didn't notice that warning, I should have disabled passwords for the sake

Re: [Spice-devel] Fedora 18 guest's GUI is slow. Due to 3D driver?

2013-01-24 Thread Alon Levy
hi list, I am running Fedora 18 (GNOME version) as a guest in a host with qemu 1.3. But the desktop is slow. I have already opened 3D acceleration in the guest's xml definition file.But the desktop is slow. I have already opened 3D acceleration in the guest's xml definition file. By the

[Spice-devel] [PATCH] RFC: add QXLListCmd for batched commands

2013-01-24 Thread Alon Levy
--- spice/qxl_dev.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h index a3e91a5..c2fda3a 100644 --- a/spice/qxl_dev.h +++ b/spice/qxl_dev.h @@ -351,6 +351,12 @@ typedef struct SPICE_ATTR_PACKED QXLCursorCmd { uint8_t

[Spice-devel] [PATCH spice-common] common/draw.h: add SpiceCopyBits

2013-01-24 Thread Alon Levy
Similar to the almost identity relation between QXLFoo and SpiceFoo for other structs, this one has just been left out. --- common/draw.h | 4 1 file changed, 4 insertions(+) diff --git a/common/draw.h b/common/draw.h index 3704358..1df42e8 100644 --- a/common/draw.h +++ b/common/draw.h @@

[Spice-devel] [PATCH] server/red_parse_qxl.h: use SpiceCopyBits

2013-01-24 Thread Alon Levy
--- server/red_parse_qxl.h | 4 +--- spice-common | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/server/red_parse_qxl.h b/server/red_parse_qxl.h index 3adc9fa..58dc52d 100644 --- a/server/red_parse_qxl.h +++ b/server/red_parse_qxl.h @@ -43,9 +43,7 @@ typedef

Re: [Spice-devel] Fedora 18 guest's GUI is slow. Due to 3D driver?

2013-01-24 Thread Alon Levy
to speed that up, the usual spice approach of passing through commands all the way to the client only applies to 2d rendering. Windows XP/7 are not doing 3d rendering, hence the difference. Thanks. On 01/24/2013 09:13 PM, Alon Levy wrote: hi list, I am running Fedora 18 (GNOME version

Re: [Spice-devel] Question about poor performance of Ubuntu VMs

2013-01-24 Thread Alon Levy
Greetings, I'm a big Red Hat / clone slash Fedora guy... and I use use a lot of KVM. I primarily create Fedora, RHEL/clone, and Windows KVM guests and they work great... but every once in a while I like to try out an Ubuntu release just to see what's new. I have tried their Unity spin as

Re: [Spice-devel] spice crashes

2013-01-22 Thread Alon Levy
Hello All, while using remote-viewer, qemu and libs as compiled below, my 32bit-win7-VMs (spice-guest-tools-0.3.exe) are crashing quit frequently, and the following error is shown in the hosts dmesg log: segfault at 50 ip 7f8b6bab3119 sp 7f8b64db3b00 error 6 in

Re: [Spice-devel] [video-qxl 2/2] Default to only one head, not 4.

2013-01-22 Thread Alon Levy
BTW reading patch 1 again, I wonder what exactly it tries to solve, since currently when using spice with qemu (no experience with x-spice) you can already set modes 1024x768 without problems. This will teach me to set down a patch for a few months while I work on other things :-(.

Re: [Spice-devel] settings for qxl memory size

2013-01-18 Thread Alon Levy
Thanks for your reply, I did more tests with this new patch for qxl, but it still doesn't work: http://lists.xen.org/archives/html/xen-devel/2013-01/msg01405.html Hi Davide, Perhaps you should ask on xen-devel? I am curios about this effort but I don't think anyone involved with it is on

[Spice-devel] win7 guest display flipped

2013-01-18 Thread Alon Levy
Hi, Did this ever work: start win7 guest (I'm using 64 bit), desktop, screen resolution, choose one of the flipped options (landscape/portrait) - I get an error dialog: title: Change Settings Contents: Unable to save display settings. Choosing both of the non flipped modes (landscape,

Re: [Spice-devel] spice multi-clients issue

2013-01-16 Thread Alon Levy
Hi,All, Currently I'm trying the multi-client feature of spice, the server side is spice-server-0.10 and qemu-kvm-1.1, if I use only from Linux machine the spicec-0.10 or spice-gtk-0.10 as clients, the multi-clients works fine, but if I use the old version(e.g. spicec-0.6) spicec-win32 or

Re: [Spice-devel] [PATCH spice 1/2] server: Fix SpiceWorker-CRITICAL **: red_worker.c:10968:red_push_monitors_config: condition `monitors_config != NULL' failed

2013-01-15 Thread Alon Levy
On Thu, Jan 10, 2013 at 11:52:38PM +0100, Hans de Goede wrote: During my dynamic monitor support testing today, I hit the following assert in red_worker.c: red_push_monitors_config: condition `monitors_config != NULL' failed This is caused by the following scenario: 1) Guest causes

Re: [Spice-devel] [PATCH] link libspice server with libm libpthread

2013-01-14 Thread Alon Levy
On Fri, Jan 11, 2013 at 11:23:33PM +0400, Michael Tokarev wrote: Ping? Pushed. More than half a year has been passed away, but the patch is still needed for current 0.12.2 version... (patchwork url: http://patchwork.freedesktop.org/patch/10546/ ) Thanks, /mjt 04.06.2012 13:35,

Re: [Spice-devel] Could you please give me some help on windows display driver?

2013-01-07 Thread Alon Levy
Forwarding to spice-devel. Please post there next time, thanks. Alon, I'm new to windows display driver, I read the qxl xddm driver and found you are the main committer to this project. I write a miniport driver and a display driver, install them to windows xp. And infos from

Re: [Spice-devel] multi-clients issue

2012-12-23 Thread Alon Levy
On Wed, Dec 19, 2012 at 01:05:04PM +0800, Rozen Lin wrote: Hi,All, Currently I'm trying the multi-client feature of spice, the server side is spice-server-0.10 and qemu-kvm-1.1, if I use only from Linux machine the spicec-0.10 or spice-gtk-0.10 as clients, the multi-clients works fine, but

Re: [Spice-devel] Announcing spice 0.12.2 spice-protocol 0.12.3

2012-12-23 Thread Alon Levy
On Thu, Dec 20, 2012 at 09:18:17PM +0100, Hans de Goede wrote: Hi All, I'm happy to announce a new bugfix (+ a small feature) release in the stable spice-0.12.x series. Changes in spice-0.12.2: * Skipped 0.12.1, it existed in git but was never released *

Re: [Spice-devel] [PATCH] red_parse_qxl: fix throwing away drawables that have masks

2012-12-13 Thread Alon Levy
All looks good except the assert. We should be removing them whenever they are guest trigerable - maybe I'm not following the code, but if in red_get_image sees no pallete in the qxl struct then palette will be NULL, which means it's guest trigerable. Non rgb bitmaps are allowed to not have a

Re: [Spice-devel] Translating the Spice protocol using spice-client-glib

2012-12-11 Thread Alon Levy
Hello, I am looking to use spice-client-glib (which seems to be the only low-level client library available) to implement a plugin for guacd which translates between the Spice protocol and the Guacamole protocol, thus adding Spice support to Guacamole (an HTML5 remote desktop gateway).

Re: [Spice-devel] [PATCH spice-server] red_worker: revert 8855438a

2012-12-06 Thread Alon Levy
ACK - Original Message - red_proccess_commands calls were added after calling guest_set_client_capabilities in order to cleanup the command ring from old commands that the client might not be able to handle. However, calling red_process_commands at this stage does send messages to

Re: [Spice-devel] Building qxl w/WDK

2012-12-06 Thread Alon Levy
Hi, Is building qxl supported with the latest WDK 8.59.25584? http://www.spice-space.org/page/WinQXL I am trying to follow the directions. I open up a command prompt called Microsoft Windows 7 x64 Debug Build Environment and set SPICE_COMMON_DIR and run the build -cZg command. I get

Re: [Spice-devel] Adding the support for chromium to spice-xpi

2012-12-03 Thread Alon Levy
The goal of the following patches is to add the support for the chromium browser. Along the way small issues has been fixed. The resulting build for fedora 17 can be found here: http://fsimonce.fedorapeople.org/spice-xpi-chromium-f17/ And it has been succesfully tested with

Re: [Spice-devel] [Qemu-devel] [PATCH 2/6] spice-qemu-char: write to chardev whatever amount it can read

2012-12-02 Thread Alon Levy
The current code waits until the chardev can read MIN(len, VMC_MAX) But some chardev may never reach than amount, in fact some of them will only ever accept write of 1. Fix the min computation and remove the VMC_MAX constant. Looks good to me. Signed-off-by: Marc-André Lureau

Re: [Spice-devel] server RFC: 2 significant build-time changes

2012-11-28 Thread Alon Levy
On Fri, Nov 23, 2012 at 04:58:23PM +0100, Christophe Fergeau wrote: Hey, This patch series introduces 2 build system changes that are worth some attention. The first one disables client build by default as it's deprecated, and the second patch adds a dependency on glib2. Both of

Re: [Spice-devel] Spice Display updates

2012-11-28 Thread Alon Levy
Hi, Technologies like VNC send screen updates primarily to the client to reduce bandwidth utilization between client and server. But after every few seconds, VNC sends across entire screen data to VNC client (I believe to recover from any corruption). Does spice send entire screen data to

Re: [Spice-devel] [PATCH spice-protocol V3] vd_agent.h: drag-and-drop support

2012-11-28 Thread Alon Levy
Hi - Mensaje original - At present, Vmware and Virtualbox has supported file dragdrop feature, I think it's a good feature for users, so we want qemu/spice to supports it. This patch first adds communication protocol between client and guest, we must make the agent

Re: [Spice-devel] [PATCH spice-server 2/2] red_worker: no need to align the stride of internal images

2012-11-28 Thread Alon Levy
Why is there no need to align the stride of internal images? what happens if we keep this alignment? Please add the answers to the patch log message. --- server/red_worker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/red_worker.c b/server/red_worker.c index

Re: [Spice-devel] [PATCH spice-server 2/2] red_worker: no need to align the stride of internal images

2012-11-28 Thread Alon Levy
On 11/28/2012 05:54 PM, Alon Levy wrote: Why is there no need to align the stride of internal images? what happens if we keep this alignment? Please add the answers to the patch log message. Why do you think there may be a need? those images are just read from the surface, compressed

Re: [Spice-devel] [PATCH 1/3] Don't build client by default

2012-11-26 Thread Alon Levy
ACK Note that packages will need to be updated. - Original Message - It has been superseded by virt-viewer/remote-viewer --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d02ea19..a12e119 100644 ---

Re: [Spice-devel] spice-vdagent start failed

2012-11-18 Thread Alon Levy
Hi, I use this qemu command line to start my virtual machine, but didn't get /dev/virtio-ports/com.redhat.spice.0 Is the guest kernel loading virtio-console module? You should see something like: # cat /proc/devices | grep virt 252 virtio-portsdev you should have

Re: [Spice-devel] [RFC] server/red_parse_qxl: introduce visitor for cursor

2012-11-15 Thread Alon Levy
Hi On Wed, Nov 14, 2012 at 9:36 PM, Alon Levy al...@redhat.com wrote: This is a second attempt at recording commands received from the qxl device. The visitor allows more code to be shared between the device to spice struct verifier and copier and the logger. I missed

Re: [Spice-devel] [PATCH spice-gtk] win32: clip and move cursor within window region

2012-11-15 Thread Alon Levy
Windows grab do not exist like on X11, so we need to clip the cursor to our client window, while making sure it doesn't overlap with windows statusbar. When wrapping the cursor, we need to make sure we also stay within the clip region, or else the clip is inverted (pointer can't enter the

Re: [Spice-devel] spice-server: the guest crash

2012-11-12 Thread Alon Levy
0x7f2402279fff in ?? () #10 0x7f2402273534 in main () 2012-11-12 10:06:46.120+: shutting down wangyingying From: Alon Levy Date: 2012-11-10 16:34 To: wangyingying CC: spice-devel Subject: Re: [Spice-devel] spice-server: the guest crash The client connect the guest serval

Re: [Spice-devel] [RFC] [PATCH spice-gtk 0/4] simply implement of file drag-and-drop

2012-11-12 Thread Alon Levy
- Original Message - Hi! On Mon, Nov 5, 2012 at 10:01 AM, Dunrong Huang riegama...@gmail.com wrote: These patches simply implement file drag-and-drop from client to guest. nice! There are some TODOs needed to be done: * transfer multiple files and

Re: [Spice-devel] spice-server: the guest crash

2012-11-10 Thread Alon Levy
The client connect the guest serval times when the guest play the movie, the guest is crash. The error is spice-server : SpiceWorker-ERROR **: ../spice-common/common/ring.h:121:ring_next: assertion `pos-next != NULL pos-prev != NULL' failed What is the stack trace when this happens?

Re: [Spice-devel] Spice arm port 2D rendering/requirements

2012-11-10 Thread Alon Levy
Hello, I have come to know that GNU/Linux Arm ports for various arm platforms out there usually dont have a working X server. The GPUs usually lack a dedicated X server driver. That being the case arm platforms usually support OpenGLES/OpenVG libraries. spice-gtk arm port is 2D

Re: [Spice-devel] [PATCH 0/5] move vio-serial use to vdagent, remove named pipe

2012-11-07 Thread Alon Levy
-move virtio-serial use from vdservice to vdagent -remove named pipe between vdservice vdagent pros: -make agent independent so it can run seperately without service (e.g. single user, testing) -simplify service to just a launcher of agents -performance - data is currently copied on

[Spice-devel] [PATCH] common/lz.c: improve lz_encode comment

2012-11-04 Thread Alon Levy
--- common/lz.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/common/lz.c b/common/lz.c index 3d77aed..aca3a16 100644 --- a/common/lz.c +++ b/common/lz.c @@ -521,8 +521,9 @@ int lz_encode(LzContext *lz, LzImageType type, int width, int height, int top_do }

Re: [Spice-devel] [Users] Unable to establish spice session

2012-11-04 Thread Alon Levy
On 11/02/2012 01:35 AM, Alex Leonhardt wrote: Hi, Since today I'm unable to establish a spice session to any/all VMs - the ony thing I see in the (local) logs is this : did you make any change? Nov 1 23:29:02 ale spice: _=/usr/bin/env Nov 1 23:29:03 ale spice:

[Spice-devel] [PATCH] server/red_worker: don't call set_client_capabilities if vm is stopped

2012-11-01 Thread Alon Levy
We try to inject an interrupt to the vm in this case, which we cannot do if it is stopped. Instead log this and update when vm restarts. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=870972 (that bz is on qemu, it will be cloned or just changed, not sure yet) --- server/red_worker.c | 64

Re: [Spice-devel] [RFC PATCH] log: warn on spice_return*_if_fail instead of aborting

2012-10-29 Thread Alon Levy
Hi - Mensaje original - Currently log level for spice_return_if_fail and spice_return_val_if_failed functions (#define macros really) is SPICE_LOG_LEVEL_CRITICAL. By default spice abort level is SPICE_LOG_LEVEL_CRITICAL. That means the program aborts upon a call to

[Spice-devel] [PATCH] server/red_worker: stride 0 is tested, remove abort

2012-10-25 Thread Alon Levy
Tested using the wip driver and xf86-video-modesetting. --- server/red_worker.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 3e78c63..31d1341 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -9270,9 +9270,6 @@ static inline

Re: [Spice-devel] Hardware acceleration

2012-10-25 Thread Alon Levy
Hello, i'm wondering if it is possible to develop an electronic cart to add it to the server. this card will speed up and improve the remote connection using the spice protocol. this is simular to pcoip and their cart. So before starting this project and before beginning the study of

Re: [Spice-devel] configure: error: Package requirements (libcacard = 0.1.2) were not met:

2012-10-24 Thread Alon Levy
Hi, everyone! I am working on the spice with xen-4.2.0. My host OS is Fedora 14. While installing spice server(spice-0.12.0.tar.bz2), there is a confusing error as below message shows. I spent a few days in the configure process and I am sure the libcacard has been installed,

Re: [Spice-devel] [PATCH 4/5] server: add websockets support via libwebsockets

2012-10-23 Thread Alon Levy
On Fri, Oct 19, 2012 at 01:50:11PM +0200, Alon Levy wrote: New API: spice_server_set_ws_ports This adds an optional dependency on libwebsockets. You need to get my patched 0.0.3 version here: git://people.freedesktop.org/~alon/libwebsockets There is no qemu patches yet, to test

Re: [Spice-devel] [PATCH 4/5] server: add websockets support via libwebsockets

2012-10-23 Thread Alon Levy
New API: spice_server_set_ws_ports Dropping this for now, I've noticed repeated connections failing, I screwed up something with adding multiple watches for the same fd (you end up having ERROR prints from libwebsockets - which still needs to be patched to reduce the amount of default

Re: [Spice-devel] [RFC] Implement of file drag-and-drop between host and guest

2012-10-22 Thread Alon Levy
Hi, all I want to implement the feature: file drag-and-drop between the host and guest. But i dont know whether someone is working on it, if this feature has not been implemented, i want to implement it in my spare time. Any suggestion is welcome. My idea is: 0) Now i only

[Spice-devel] [PATCH 1/5] configure.ac: add libcacard to SPICE_REQUIRES if built with smartcard support

2012-10-19 Thread Alon Levy
--- configure.ac | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.ac b/configure.ac index 261f870..dff930d 100644 --- a/configure.ac +++ b/configure.ac @@ -234,6 +234,7 @@ if test x$enable_smartcard = xyes; then SMARTCARD_CFLAGS=$CAC_CARD_CFLAGS AC_SUBST(SMARTCARD_LIBS)

[Spice-devel] [PATCH 0/5] reds-private websockets

2012-10-19 Thread Alon Levy
), or with the qemu from http://cgit.freedesktop.org/~alon/qemu/ which adds a ws-port argument. Alon Levy (5): configure.ac: add libcacard to SPICE_REQUIRES if built with smartcard support server/reds.c: split off reds-private.h server/tests/test_display_base: fix segfault in test server: add

[Spice-devel] [PATCH 2/5] server/reds.c: split off reds-private.h

2012-10-19 Thread Alon Levy
--- server/reds-private.h | 182 ++ server/reds.c | 180 ++--- 2 files changed, 186 insertions(+), 176 deletions(-) create mode 100644 server/reds-private.h diff --git a/server/reds-private.h

[Spice-devel] [PATCH 3/5] server/tests/test_display_base: fix segfault in test

2012-10-19 Thread Alon Levy
--- server/tests/test_display_base.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c index 8c7f512..588e960 100644 --- a/server/tests/test_display_base.c +++ b/server/tests/test_display_base.c @@ -703,7

[Spice-devel] [PATCH 4/5] server: add websockets support via libwebsockets

2012-10-19 Thread Alon Levy
New API: spice_server_set_ws_ports This adds an optional dependency on libwebsockets. You need to get my patched 0.0.3 version here: git://people.freedesktop.org/~alon/libwebsockets There is no qemu patches yet, to test change in reds.c the default value of spice_ws_port to 5959 (for the

[Spice-devel] [PATCH 5/5] release 0.12.1

2012-10-19 Thread Alon Levy
--- configure.ac | 4 ++-- server/spice.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 5561d2c..6582edb 100644 --- a/configure.ac +++ b/configure.ac @@ -13,9 +13,9 @@ AC_PREREQ([2.57]) # 4. Follow the libtool manual for the so

Re: [Spice-devel] [PATCH 4/5] server: add websockets support via libwebsockets

2012-10-19 Thread Alon Levy
Some notes I forgot / updates. New API: spice_server_set_ws_ports This adds an optional dependency on libwebsockets. You need to get my patched 0.0.3 version here: git://people.freedesktop.org/~alon/libwebsockets These patches are already upstream (git://git.warmcat.com/libwebsockets).

Re: [Spice-devel] [PATCH 4/5] server: add websockets support via libwebsockets

2012-10-19 Thread Alon Levy
On 10/19/12 6:50 AM, Alon Levy wrote: New API: spice_server_set_ws_ports This adds an optional dependency on libwebsockets. You need to get my patched 0.0.3 version here: git://people.freedesktop.org/~alon/libwebsockets Very cool! I'll try to give this a try early next week

<    1   2   3   4   5   6   7   8   9   10   >