On Mon, May 07, 2012 at 12:01:42PM +0200, Gerd Hoffmann wrote:
Hi,
But there is no concept of an additional surface in the guest driver.
RANDR 1.2 (and I think the same for 1.3, 1.4, since we don't have per
CRTC pixmaps) has a single screen wide pixmap. A screen is one per X
server,
On Mon, May 07, 2012 at 01:28:58PM +0300, Alon Levy wrote:
On Mon, May 07, 2012 at 12:01:42PM +0200, Gerd Hoffmann wrote:
Hi,
But there is no concept of an additional surface in the guest driver.
RANDR 1.2 (and I think the same for 1.3, 1.4, since we don't have per
CRTC pixmaps
On Mon, May 07, 2012 at 01:36:03PM +0300, Alon Levy wrote:
On Mon, May 07, 2012 at 01:28:58PM +0300, Alon Levy wrote:
On Mon, May 07, 2012 at 12:01:42PM +0200, Gerd Hoffmann wrote:
Hi,
But there is no concept of an additional surface in the guest driver.
RANDR 1.2 (and I think
RHBZ: 819484
Signed-off-by: Alon Levy al...@redhat.com
---
server/reds.c |1 +
1 file changed, 1 insertion(+)
diff --git a/server/reds.c b/server/reds.c
index 1696fbc..26d6f89 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3971,6 +3971,7 @@ SPICE_GNUC_VISIBLE int
On Mon, May 07, 2012 at 01:57:37PM +0200, Gerd Hoffmann wrote:
On 05/07/12 12:28, Alon Levy wrote:
On Mon, May 07, 2012 at 12:01:42PM +0200, Gerd Hoffmann wrote:
Hi,
But there is no concept of an additional surface in the guest driver.
RANDR 1.2 (and I think the same for 1.3, 1.4
On Mon, May 07, 2012 at 02:19:43PM +0200, Marc-André Lureau wrote:
On Mon, May 7, 2012 at 1:37 PM, Alon Levy al...@redhat.com wrote:
RHBZ: 819484
Signed-off-by: Alon Levy al...@redhat.com
---
server/reds.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/server/reds.c b
On Mon, May 07, 2012 at 02:16:09PM +0200, Marc-André Lureau wrote:
On Mon, May 7, 2012 at 8:28 AM, Alon Levy al...@redhat.com wrote:
RANDR introduces a concept of a CRTC and an OUTPUT. The CRTC scansout a
portion of the framebuffer onto one or more OUTPUTs. I propose having a
1:1
On Thu, May 03, 2012 at 10:16:01PM -0500, Jeremy White wrote:
I've got a pure Javascript based client with which
I can control a few xterms, start and use gedit, and just generally
operate an Xspice server. It's still extremely limited; a few kinds of
draws, no
masks or clips, no
On Fri, May 04, 2012 at 11:36:55AM -0500, Jeremy White wrote:
So I've probed more deeply after my naive misunderstanding
of the consequence of the EAGAIN.
I believe I am closer to the source of the problem; I also
believe the problem is more serious than I realized; it's likely to bite
On Thu, May 03, 2012 at 05:33:31PM +0200, Christophe Fergeau wrote:
X.Org adds -Wcast-qual to its default WARNCFLAGS, but then it
doesn't use const in the API it exports, which leads to warnings
when trying to initialize some fields of the various DriverRec
structures with string literals.
, Alon Levy wrote:
---
src/qxl_driver.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 6e06174..af5bfca 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -1619,6 +1619,8 @@ static PciChipsets qxlPciChips
On Wed, May 02, 2012 at 05:01:42PM +0300, Yonit Halperin wrote:
rhbz #813826
This patch doesn't apply. The patch needs some fixing anyway, comments
below.
When playing a youtube video on Windows guest, the driver sometimes sends
images which contain the video frames, but also other parts of
On Wed, May 02, 2012 at 05:01:45PM +0300, Yonit Halperin wrote:
From: Alon Levy al...@redhat.com
No longer required, superceded by 39565707a9b9b6460ca18c5c9749ae565d583e2a
(minus a missing space but de nada).
---
server/tests/test_display_base.c |4 ++--
1 files changed, 2 insertions
On Wed, May 02, 2012 at 05:01:36PM +0300, Yonit Halperin wrote:
ACK series, minus two commented patches. Another comment that you can
fix or not coming up (same as last time, the *1.3 turned to *2 constant,
but just a nitpick).
We need some rect/region getters methods that were added
---
On Mon, Apr 30, 2012 at 08:21:13AM -0400, Marian Krcmarik wrote:
- Original Message -
From: Nick Causton add.n...@associateddata.co.uk
To: spice-devel@lists.freedesktop.org
Sent: Monday, April 30, 2012 12:51:08 PM
Subject: Re: [Spice-devel] Audio recording device - Win 7 guest
On Thu, Apr 26, 2012 at 08:30:25PM +0200, Christophe Fergeau wrote:
On Thu, Apr 26, 2012 at 02:19:00PM +0300, Alon Levy wrote:
On Wed, Apr 25, 2012 at 04:18:19PM +0200, Christophe Fergeau wrote:
On second thought, please change XOrg to X.Org below (that's how it is
on the wiki front page
On Thu, Apr 26, 2012 at 12:12:09PM -0500, Jeremy White wrote:
My display channels were instantly timing out; turns out that the
implementation of red_now() doesn't work on my 32 bit system.
This patch should fix that.
Thanks! ACK, I'll commit. Could you please send the patches inline next
On Thu, Apr 26, 2012 at 12:12:09PM -0500, Jeremy White wrote:
My display channels were instantly timing out; turns out that the
implementation of red_now() doesn't work on my 32 bit system.
This patch should fix that.
Cheers,
Jeremy
From 77b366c0d33befceb530c095be276c1e0e2146b7 Mon
On Wed, Apr 25, 2012 at 03:12:38PM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
ACK.
Functions with no arguments must use (void) in C
---
net_slirp.c | 12 ++--
net_slirp.h |6 +++---
2 files changed, 9 insertions(+), 9 deletions(-)
diff
On Wed, Apr 25, 2012 at 04:18:19PM +0200, Christophe Fergeau wrote:
ACK.
---
configure.ac |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index a97f477..691e2c6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -36,7 +36,7 @@
On Wed, Apr 25, 2012 at 04:18:19PM +0200, Christophe Fergeau wrote:
On second thought, please change XOrg to X.Org below (that's how it is
on the wiki front page http://www.x.org/wiki/)
---
configure.ac |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac
On Thu, Apr 19, 2012 at 01:48:38PM +0300, Alon Levy wrote:
Ping.
---
server/tests/test_display_base.c | 79
++
1 file changed, 45 insertions(+), 34 deletions(-)
diff --git a/server/tests/test_display_base.c
b/server/tests/test_display_base.c
On Thu, Apr 26, 2012 at 09:46:49AM -0500, Jeremy White wrote:
This patch should make it reflect the on wire size.
This one cost me an hour and some hair; hopefully it'll save someone
else in the future.
Thanks, ACK.
In general the on wire format is defined by spice.proto :
enum8 clip_type
On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote:
At least in Fedora 17, the correct RPM name is xorg-x11-util-macros
Please fix your emailer to not split lines, it causes a malformed patch
- see the '-' and '+' lines below, there should not be an extra EOL
between them.
diff
On Wed, Apr 25, 2012 at 01:21:45PM +0100, Daniel P. Berrange wrote:
On Wed, Apr 25, 2012 at 03:15:00PM +0300, Alon Levy wrote:
On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote:
At least in Fedora 17, the correct RPM name is xorg-x11-util-macros
Please fix your emailer
On Wed, Apr 25, 2012 at 03:05:55PM +0200, Christophe Fergeau wrote:
On Wed, Apr 25, 2012 at 12:59:46PM +0300, Yaniv Kaul wrote:
It does not harm them in any way, AFAIK - I could not find similar
named packages in either. So better get the name right on one
distribution than none.
I'd
On Tue, Apr 24, 2012 at 09:47:47AM +0800, 蒋媛园 wrote:
Hi
I want to filter the graphics to the client. For example, only the
graphics of a calculator(in guest OS Win7) are send to the client.
I know that there is always the possibility of falling all the way back to
CPU drawing to a
---
src/qxl.h|1 +
src/qxl_cursor.c |1 +
src/qxl_driver.c |1 +
src/qxl_image.c |1 +
src/qxl_mem.c|1 +
src/qxl_option_helpers.c |1 +
src/qxl_ring.c |1 +
src/qxl_surface.c|1 +
8 files
---
src/spiceqxl_inputs.c | 64 -
1 file changed, 37 insertions(+), 27 deletions(-)
diff --git a/src/spiceqxl_inputs.c b/src/spiceqxl_inputs.c
index 62ef19f..5cfa823 100644
--- a/src/spiceqxl_inputs.c
+++ b/src/spiceqxl_inputs.c
@@ -46,26 +46,6
---
src/qxl_driver.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 6e06174..af5bfca 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -1619,6 +1619,8 @@ static PciChipsets qxlPciChips[] =
#endif
#endif /* !XSPICE */
---
src/qxl_driver.c | 14 ++
src/spiceqxl_inputs.c |4 ++--
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index af5bfca..fcb1b6b 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -58,6 +58,12 @@ extern void
On Tue, Apr 24, 2012 at 01:22:41PM +0300, Yaniv Kaul wrote:
At least in Fedora 17, the correct RPM name is xorg-x11-util-macros
We could use the upstream name too, xorg-util-macros (kinda):
http://cgit.freedesktop.org/xorg/util/macros/tree/configure.ac#n25
But this is better anyway.
ACK.
---
src/qxl_ring.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/qxl_ring.c b/src/qxl_ring.c
index 7a11fbb..d701791 100644
--- a/src/qxl_ring.c
+++ b/src/qxl_ring.c
@@ -42,7 +42,7 @@ struct ring
struct qxl_ring
{
-volatile struct ring *ring;
+
__attribute__((always_inline)) does not replace inline and they
still need to be used together. This fixes always_inline function
might not be inlinable [-Wattributes] warning in gcc 4.7
---
src/murmurhash3.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/murmurhash3.c
On Mon, Apr 23, 2012 at 09:04:36AM +0300, Yonit Halperin wrote:
The QXL_IO_NOTIFY_OOM is intended exactly for handling occurrences of
lacking memory. The spice server tries to first release resources that
are no longer in the current tree (and thus, do not need rendering).
It renders drawables
On Fri, Apr 20, 2012 at 01:59:05AM +0200, Marc-André Lureau wrote:
Hi
Now that I implemented it a bit more correctly, using a timer, and
splitting the in two patches, I realize that it doesn't work with
windows. Windows expect to receive several key press events
apparently. Hans, the hack
On Sun, Apr 22, 2012 at 03:16:20PM +0200, Marc-André Lureau wrote:
Hi
On Sun, Apr 22, 2012 at 9:40 AM, Alon Levy al...@redhat.com wrote:
On Fri, Apr 20, 2012 at 01:59:05AM +0200, Marc-André Lureau wrote:
So it seems like we should keep sending repeat key press in fact. And
it's probably
---
server/tests/test_display_base.c | 79 ++
1 file changed, 45 insertions(+), 34 deletions(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index f6c3f6b..e376195 100644
--- a/server/tests/test_display_base.c
+++
---
server/tests/test_display_base.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index e376195..d060f3f 100644
--- a/server/tests/test_display_base.c
+++ b/server/tests/test_display_base.c
@@ -533,7
---
server/tests/test_display_base.c | 16
server/tests/test_display_base.h |3 +++
2 files changed, 19 insertions(+)
diff --git a/server/tests/test_display_base.c b/server/tests/test_display_base.c
index d060f3f..fd9a37e 100644
--- a/server/tests/test_display_base.c
+++
---
server/tests/test_display_base.c | 10 +++
server/tests/test_display_base.h | 33
server/tests/test_display_resolution_changes.c | 10 +++
3 files changed, 37 insertions(+), 16 deletions(-)
diff --git
---
server/tests/test_display_streaming.c | 44 +++--
1 file changed, 37 insertions(+), 7 deletions(-)
diff --git a/server/tests/test_display_streaming.c
b/server/tests/test_display_streaming.c
index 1b81d76..b4fe013 100644
---
On Tue, Apr 17, 2012 at 12:42:45PM +0200, nicolas prochazka wrote:
Hello,
I'm using qemu 1.0-usbredir from hans git.
If i'm starting a windows guest with :
/usr/local/bin/qemu -name TEST_QXL010 -readconfig
/etc/ich9-ehci-uhci.cfg -device usb-tablet -spice
On Mon, Apr 16, 2012 at 11:47:25AM -0500, Aric Stewart wrote:
---
common/gdi_canvas.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
ACK. I'll push
diff --git a/common/gdi_canvas.c b/common/gdi_canvas.c
index 4c5daea..0a04bf8 100644
--- a/common/gdi_canvas.c
+++
On Mon, Apr 16, 2012 at 01:10:01PM -0500, Aric Stewart wrote:
the python script is now in spice-common and client_marshallers.h needs to
be included instead of marshallers.h
Looks good, haven't tested but I'll assume you did :)
ACK, and pushing.
---
client/windows/generate.bat |4
On Mon, Apr 16, 2012 at 02:17:37PM -0500, Aric Stewart wrote:
This patch completes the copy from 4d8f39020ac83602c1647d4af04e8b19bf74ed6e
which missed this file.
ACK, pushing.
---
client/windows/getopt.h | 56
+++
1 files changed, 56
On Mon, Apr 16, 2012 at 02:25:33PM -0500, Aric Stewart wrote:
Hello,
My name is Aric Stewart. Primarily a WINE hacker, due to interest from a
client I am starting work on spice. I will mostly be focusing on the win32
client to begin with but we will see where work progresses.
I am
On Mon, Apr 16, 2012 at 01:10:01PM -0500, Aric Stewart wrote:
In the future could you send the patches inlined and not attached? I use
git format-patch or git send-email directly.
the python script is now in spice-common and client_marshallers.h needs to
be included instead of marshallers.h
On Mon, Apr 16, 2012 at 01:10:01PM -0500, Aric Stewart wrote:
the python script is now in spice-common and client_marshallers.h needs to
be included instead of marshallers.h
Third, the patch doesn't apply because of EOL issues. You should be
using no EOL convertion magic. If you use msysgit
On Tue, Apr 17, 2012 at 01:12:26PM +0300, Yonit Halperin wrote:
---
server/red_worker.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/server/red_worker.c b/server/red_worker.c
index 07782c8..5350195 100644
--- a/server/red_worker.c
+++ b/server/red_worker.c
On Tue, Apr 17, 2012 at 01:37:26PM +0200, Christophe Fergeau wrote:
On Tue, Apr 17, 2012 at 01:46:26PM +0300, Alon Levy wrote:
On Tue, Apr 17, 2012 at 01:12:26PM +0300, Yonit Halperin wrote:
---
server/red_worker.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions
On Tue, Apr 17, 2012 at 08:15:22AM -0500, Aric Stewart wrote:
Hello all,
Working away at making the current tip of spice build the win32 client. I
have run into another problem.
Since the last working win32 cllient build the code generated by
spice_codegen.py has shifted from CPP
On Wed, Apr 11, 2012 at 12:46:18PM +0200, Christophe Fergeau wrote:
On Tue, Apr 10, 2012 at 04:02:56PM +0300, Alon Levy wrote:
My bad for not putting it in. It's warning on a const attribute removal
cast, since a static string bla is (const char*).
For the record, the warning is -Wcast
qxl_driver_t will not access io ports and pci resources directly, but
through an opaque struct qxlhw which will have two implementations,
qxlhw_pci and qxlhw_drm.
---
src/Makefile.am |4
src/qxl.h |3 +++
src/qxlhw.c | 19 +++
src/qxlhw.h | 16
---
src/qxl.h | 14 ++
src/qxl_driver.c |1 +
src/qxl_image.c |1 +
src/qxl_mem.c |1 +
src/qxl_mem.h | 21 +
src/qxl_surface.c |1 +
6 files changed, 27 insertions(+), 12 deletions(-)
create mode 100644 src/qxl_mem.h
diff
---
src/qxl_driver.c | 38 --
src/qxlhw.c | 10 ++
src/qxlhw.h |5 +
src/qxlhw_pci.c | 24
4 files changed, 43 insertions(+), 34 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index
---
src/qxl_driver.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 6ffbfa9..a4c5912 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -950,7 +950,7 @@ qxl_leave_vt(int scrnIndex, int flags)
qxl-vt_surfaces =
data_alloc and data_free unused yet.
---
src/qxl_driver.c | 32 +-
src/qxl_mem.h |1 -
src/qxl_surface.c |4 +-
src/qxlhw.c | 12
src/qxlhw.h | 12
src/qxlhw_pci.c | 184 +
6 files changed, 211
cursor commands are now allocated on the stack in qxl_cursor.c and only
allocated on the pci bar in qxlhw_pci.
---
src/qxl.h|1 -
src/qxl_cursor.c | 58 ++
src/qxlhw.c |5 +
src/qxlhw.h |4
---
src/qxl_surface.c | 128 +
1 file changed, 61 insertions(+), 67 deletions(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 73a44b3..7554ca6 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@ -388,19 +388,15 @@ enum
qxlhw_surface_alloc will do it anyway.
---
src/qxl_surface.c |5 +
src/qxlhw_pci.c |8 ++--
2 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 6a6242e..0b8c884 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@
---
src/qxl.h |8
1 file changed, 8 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 585f204..a386651 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -224,14 +224,6 @@ struct _qxl_screen_t
#endif /* XSPICE */
};
-static inline uint64_t
-physical_address (qxl_screen_t *qxl, void
---
src/qxl.h | 10 --
src/qxlhw_pci.c |7 ---
2 files changed, 17 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index a386651..466b505 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -175,16 +175,6 @@ struct _qxl_screen_t
ScrnInfoPtrpScrn;
---
src/qxl.h |8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 466b505..7f1ae6a 100644
--- a/src/qxl.h
+++ b/src/qxl.h
@@ -339,16 +339,10 @@ voidqxl_drop_image_cache (qxl_screen_t
*qxl);
/*
- * I/O port
---
src/qxl_driver.c |9 +
src/qxlhw.c |5 +
src/qxlhw.h |2 ++
src/qxlhw_pci.c | 15 +++
4 files changed, 23 insertions(+), 8 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index c551282..3de060d 100644
--- a/src/qxl_driver.c
+++
---
src/qxl.h | 10 --
src/qxl_surface.c |5 ++---
src/qxlhw.c |5 +
src/qxlhw.h |3 +++
src/qxlhw_pci.c | 21 ++---
5 files changed, 28 insertions(+), 16 deletions(-)
diff --git a/src/qxl.h b/src/qxl.h
index 626abc3..25e6322
---
src/spiceqxl_io_port.c | 36 +---
1 file changed, 1 insertion(+), 35 deletions(-)
diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c
index 0b8acc8..db7d715 100644
--- a/src/spiceqxl_io_port.c
+++ b/src/spiceqxl_io_port.c
@@ -173,39 +173,6 @@ static
rely on qxlhw_check_device to initialize pScrn-videoRam and qxl-surface0_size
---
src/qxl_driver.c |9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 14bac17..67562aa 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@
Also some minor cleanup - make qxlhw_pci_get_ram_header for !xspice
---
src/qxlhw_pci.c |5 +
src/qxlhw_pci.h |2 ++
2 files changed, 7 insertions(+)
diff --git a/src/qxlhw_pci.c b/src/qxlhw_pci.c
index e1918c8..0d483fc 100644
--- a/src/qxlhw_pci.c
+++ b/src/qxlhw_pci.c
@@ -93,6
---
src/qxl.h |1 -
src/qxlhw_pci.c|7 +++
src/qxlhw_pci.h|1 +
src/spiceqxl_display.c |9 ++---
src/spiceqxl_driver.c |3 ++-
src/spiceqxl_io_port.c |5 +++--
6 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/src/qxl.h
On Tue, Apr 10, 2012 at 12:18:11PM +0200, Christophe Fergeau wrote:
On Mon, Apr 09, 2012 at 08:33:10PM +0300, Alon Levy wrote:
---
src/qxl_driver.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index 5c826f3..82a6ff1
On Tue, Apr 10, 2012 at 12:28:31PM +0200, Christophe Fergeau wrote:
Same question as the other patch, wouldn't we be better off just doing
(char *)xspice pointer casts? Or disabling this warning?
Same answer.
Christophe
On Mon, Apr 09, 2012 at 08:33:11PM +0300, Alon Levy wrote
On Tue, Apr 10, 2012 at 12:21:54PM +0200, Christophe Fergeau wrote:
On Mon, Apr 09, 2012 at 08:33:13PM +0300, Alon Levy wrote:
---
src/qxl_surface.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 6761bf6..a283d5e 100644
On Tue, Apr 10, 2012 at 12:26:23PM +0200, Christophe Fergeau wrote:
ACK
do we want to hide these attributes in slightly more readable #define?
I'll see if there are any other users, if so I'll do an additional
patch.
Christophe
On Mon, Apr 09, 2012 at 08:33:14PM +0300, Alon Levy wrote
On Tue, Apr 10, 2012 at 02:49:56PM +0300, Alon Levy wrote:
Eek, this isn't spice-protocol of course, it's xf86-video-qxl. Other
then that, review away!
This patchset has been tested with latest Xorg and qxl, and with Xspice. It
doesn't introduce any new functionality. It adds a callback holder
On Tue, Apr 10, 2012 at 02:06:25PM +0200, Christophe Fergeau wrote:
On Tue, Apr 10, 2012 at 02:59:02PM +0300, Alon Levy wrote:
On Tue, Apr 10, 2012 at 12:18:11PM +0200, Christophe Fergeau wrote:
On Mon, Apr 09, 2012 at 08:33:10PM +0300, Alon Levy wrote:
---
src/qxl_driver.c |6
---
spice/qxl_dev.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h
index 5e6ce06..741a1f6 100644
--- a/spice/qxl_dev.h
+++ b/spice/qxl_dev.h
@@ -53,8 +53,8 @@ enum {
#define QXL_DEVICE_ID_DEVEL 0x01ff
#define QXL_REVISION_DEVEL 0x01
---
src/spiceqxl_inputs.c | 64 -
1 file changed, 37 insertions(+), 27 deletions(-)
diff --git a/src/spiceqxl_inputs.c b/src/spiceqxl_inputs.c
index 62ef19f..5cfa823 100644
--- a/src/spiceqxl_inputs.c
+++ b/src/spiceqxl_inputs.c
@@ -46,26 +46,6
---
src/qxl_surface.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index 6761bf6..a283d5e 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@ -863,6 +863,8 @@ qxl_surface_prepare_access (qxl_surface_t *surface,
stride =
---
src/spiceqxl_io_port.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c
index ea02ac1..050e7b9 100644
--- a/src/spiceqxl_io_port.c
+++ b/src/spiceqxl_io_port.c
@@ -58,7 +58,7 @@
static int spiceqxl_io_port_debug_level =
---
src/spiceqxl_io_port.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/spiceqxl_io_port.c b/src/spiceqxl_io_port.c
index 050e7b9..f599b4e 100644
--- a/src/spiceqxl_io_port.c
+++ b/src/spiceqxl_io_port.c
@@ -175,7 +175,7 @@ static void
qxl_surface.c:735:6: warning: declaration of 'i' shadows a previous
local [-Wshadow]
---
src/qxl_surface.c |1 -
1 file changed, 1 deletion(-)
diff --git a/src/qxl_surface.c b/src/qxl_surface.c
index a283d5e..76b5579 100644
--- a/src/qxl_surface.c
+++ b/src/qxl_surface.c
@@ -730,7 +730,6 @@
---
src/qxl.h|1 +
src/qxl_cursor.c |1 +
src/qxl_driver.c |1 +
src/qxl_image.c |1 +
src/qxl_mem.c|1 +
src/qxl_option_helpers.c |1 +
src/qxl_ring.c |1 +
src/qxl_surface.c|1 +
8 files
---
src/qxl_driver.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/src/qxl_driver.c b/src/qxl_driver.c
index eb09662..77fc40b 100644
--- a/src/qxl_driver.c
+++ b/src/qxl_driver.c
@@ -129,6 +129,7 @@ qxl_available_options (int chipid, int busid)
return DefaultOptions;
}
+#ifndef
On Sun, Apr 08, 2012 at 06:42:36PM +0300, Yonit Halperin wrote:
For STREAM_DATA_SIZED and QOS_QUERY messages.
Signed-off-by: Yonit Halperin yhalp...@redhat.com
---
common/rect.h |2 +-
spice-protocol |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
On Fri, Apr 06, 2012 at 09:11:11PM +0200, David Jaša wrote:
Hi David,
David Mansfield píše v Pá 06. 04. 2012 v 14:17 -0400:
On 04/06/2012 03:05 AM, Alon Levy wrote:
On Thu, Apr 05, 2012 at 12:52:53PM -0400, David Mansfield wrote:
On 04/05/2012 11:58 AM, Alon Levy wrote
On Thu, Apr 05, 2012 at 11:49:35PM +0200, Michael Niehren wrote:
Hi Alon,
after setting up setxkbmap de i got the german keyboard, great. 2 issues
are left, the
ALT and ALT-GR Key's do not work as expected, so specially i could not type
the | Symbol
with ALT-GR and . Do you also have a
On Fri, Apr 06, 2012 at 04:08:17AM +0200, Marc-André Lureau wrote:
First notify about disconnection before resetting the channel data.
An audio recording task might expect the channel to be in a ready
state otherwise, for example.
I'm wondering if this is enough - what if the event emitted
approach to fix this problem, I will take
it.
Look for qemu_bh_new, qemu_bh_schedule - for example see
hw/virtio-serial-bus.c
-Original Message-
From: Alon Levy [mailto:al...@redhat.com]
Sent: Thursday, April 05, 2012 2:17 PM
To: Charles.Tsai-蔡清海-研究發展部
Cc: Hans de Goede; spice-devel
in vmc_state() */
qemu_chr_generic_open(chr);
-}
#endif
+} else {
+s-bh_register = qemu_bh_new(bh_vmc_register_interface, s);
+qemu_bh_schedule(s-bh_register);
+}
return chr;
}
-Original Message-
From: Alon Levy [mailto:al...@redhat.com
On Thu, Apr 05, 2012 at 01:24:54PM +0200, Michael Niehren wrote:
Hi together,
i successfully installed and connected to Xspice und FC16, great work, i was
very pleased
to see, what's possible with spice.
1 thing left to use it as an Server to connect from my thin client is the
orders with respect to #3 are possible).
Can you tell me how to resolve this problem based on the spice architecture?
Thanks.
-Original Message-
From: Charles.Tsai-蔡清海-研究發展部
Sent: Friday, March 30, 2012 9:27 AM
To: 'Alon Levy'
Cc: spice-devel@lists.freedesktop.org
Subject: RE
On Mon, Apr 02, 2012 at 12:23:41PM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
The red_worker_main method allocates a RedWorker struct instance
on the stack. This struct is a full 2 MB in size which is not
at all resonable to allocate on the stack.
Why?
On Tue, Apr 03, 2012 at 10:32:14AM +0200, Christophe Fergeau wrote:
---
ACK both.
spice/controller_prot.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/spice/controller_prot.h b/spice/controller_prot.h
index f7b1f26..355feac 100644
--- a/spice/controller_prot.h
On Mon, Apr 02, 2012 at 12:23:46PM +0100, Daniel P. Berrange wrote:
From: Daniel P. Berrange berra...@redhat.com
What's the source for manywarnings.m4 and warnings.m4 ? Could you add a
link somewhere in the commit message?
* m4/manywarnings.m4m, m4/warnings.m4: Import GNULIB warnings
;
...
}
-Original Message-
From: Alon Levy [mailto:al...@redhat.com]
Sent: Tuesday, April 03, 2012 9:14 PM
To: Charles.Tsai-蔡清海-研究發展部
Cc: Hans de Goede; spice-devel@lists.freedesktop.org
Subject: Re: [Spice-devel] [RFC] register vmc interface early for name !=
vdagent [was: Re: Read data
On Tue, Apr 03, 2012 at 03:56:12PM +0200, Peter Hatina wrote:
On 04/03/2012 03:39 PM, Marc-André Lureau wrote:
- Mensaje original -
void nsPluginInstance::Connect()
{
+const int port = portToInt(m_port);
+const int sport = portToInt(m_secure_port);
+
+
On Tue, Apr 03, 2012 at 11:21:07PM +0200, Marc-André Lureau wrote:
On Tue, Apr 3, 2012 at 6:12 PM, David Jaša dj...@redhat.com wrote:
The s- idio^W^W^W^Wlegacy goes much further, see the ovirt-engine
sources what you can expect:
On Sun, Apr 01, 2012 at 12:27:13PM +0100, Lee Essen wrote:
On 30 Mar 2012, at 22:16, Alon Levy wrote:
On Fri, Mar 30, 2012 at 05:12:26PM +0100, Lee Essen wrote:
Hi,
I'm relatively new to spice, and am using it very effectively with qemu,
however it strikes me
On Fri, Mar 30, 2012 at 06:07:49PM +0200, Christophe Fergeau wrote:
The hotkey parser was generating a string with sprintf and data it got
from the controller socket (ie data which can have an arbitrary
length). Using sprintf there is a bad idea, replace it with snprintf.
ACK.
---
701 - 800 of 2329 matches
Mail list logo
