Re: [Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-09 Thread Jeremy White
abort happens only on critical by default, not on error, so this is strange - unless you've set SPICE_ABORT_LEVEL_DEFAULT to something else. See http://cgit.freedesktop.org/spice/spice-common/tree/common/log.c#n84 Um, I think:

Re: [Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-09 Thread Alon Levy
On Sat, Jul 07, 2012 at 03:26:22PM -0500, Jeremy White wrote: On 07/06/2012 01:47 PM, Jeremy White wrote: On 07/05/2012 04:38 AM, Alon Levy wrote: Replaced mostly with spice_debug, but spice_warning spice_error as well where appropriate. Boy, I do like this patch, but oddly, it

Re: [Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-09 Thread Alon Levy
On Mon, Jul 09, 2012 at 08:47:34AM -0500, Jeremy White wrote: abort happens only on critical by default, not on error, so this is strange - unless you've set SPICE_ABORT_LEVEL_DEFAULT to something else. See http://cgit.freedesktop.org/spice/spice-common/tree/common/log.c#n84 Um, I think:

Re: [Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-08 Thread Alon Levy
On Sat, Jul 07, 2012 at 03:26:22PM -0500, Jeremy White wrote: On 07/06/2012 01:47 PM, Jeremy White wrote: On 07/05/2012 04:38 AM, Alon Levy wrote: Replaced mostly with spice_debug, but spice_warning spice_error as well where appropriate. Boy, I do like this patch, but oddly, it

Re: [Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-07 Thread Jeremy White
On 07/06/2012 01:47 PM, Jeremy White wrote: On 07/05/2012 04:38 AM, Alon Levy wrote: Replaced mostly with spice_debug, but spice_warning spice_error as well where appropriate. Boy, I do like this patch, but oddly, it generates a startup crash for me: ((null):26170): SpiceWorker-ERROR **:

[Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-05 Thread Alon Levy
Replaced mostly with spice_debug, but spice_warning spice_error as well where appropriate. --- server/red_worker.c | 182 +-- 1 file changed, 91 insertions(+), 91 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index

Re: [Spice-devel] [PATCH] server/red_worker: death to spice_printerr, too verbose by far

2012-07-05 Thread Hans de Goede
ACk, +100 ! On 07/05/2012 11:38 AM, Alon Levy wrote: Replaced mostly with spice_debug, but spice_warning spice_error as well where appropriate. --- server/red_worker.c | 182 +-- 1 file changed, 91 insertions(+), 91 deletions(-) diff --git