Re: [Spice-devel] [PATCH 14/20] Use GQueue for RedCharDevice::send_queue

2016-04-20 Thread David Jaša
On Po, 2016-04-18 at 05:17 -0400, Frediano Ziglio wrote: > > On Thu, 2016-04-14 at 16:50 -0500, Jonathon Jongsma wrote: > > > From: Christophe Fergeau > > > > > > There was an extra RedCharDeviceMsgToClientItem type whose only > > > purpose was to manage a linked list of

Re: [Spice-devel] [PATCH 14/20] Use GQueue for RedCharDevice::send_queue

2016-04-18 Thread Christophe Fergeau
On Fri, Apr 15, 2016 at 03:01:37PM -0500, Jonathon Jongsma wrote: > > @@ -394,21 +376,17 @@ static int > > red_char_device_read_from_device(RedCharDevice *dev) > > > > static void red_char_device_client_send_queue_push(RedCharDeviceClient > > *dev_client) > > { > > -RingItem *item; > > -

Re: [Spice-devel] [PATCH 14/20] Use GQueue for RedCharDevice::send_queue

2016-04-18 Thread Frediano Ziglio
> On Thu, 2016-04-14 at 16:50 -0500, Jonathon Jongsma wrote: > > From: Christophe Fergeau > > > > There was an extra RedCharDeviceMsgToClientItem type whose only > > purpose was to manage a linked list of items to send. GQueue has the > > same purpose as this type in

Re: [Spice-devel] [PATCH 14/20] Use GQueue for RedCharDevice::send_queue

2016-04-15 Thread Jonathon Jongsma
On Thu, 2016-04-14 at 16:50 -0500, Jonathon Jongsma wrote: > From: Christophe Fergeau > > There was an extra RedCharDeviceMsgToClientItem type whose only > purpose was to manage a linked list of items to send. GQueue has the > same purpose as this type in addition to being

[Spice-devel] [PATCH 14/20] Use GQueue for RedCharDevice::send_queue

2016-04-14 Thread Jonathon Jongsma
From: Christophe Fergeau There was an extra RedCharDeviceMsgToClientItem type whose only purpose was to manage a linked list of items to send. GQueue has the same purpose as this type in addition to being generic. As the length of the send queue is tracked, a GQueue is more