Re: [Spice-devel] [PATCH spice-common v3 0/5] Generate C declarations automatically

2019-03-18 Thread Jonathon Jongsma
On Mon, 2019-03-18 at 09:53 -0400, Frediano Ziglio wrote: > > On Mon, Mar 11, 2019 at 12:42:10PM -0400, Frediano Ziglio wrote: > > > > > > > > Series looks good to me, > > > > > > > > Reviewed-by: Christophe Fergeau > > > > > > > > > > Why not ack? Not good enough? Not tested? Missing

Re: [Spice-devel] [PATCH spice-common v3 0/5] Generate C declarations automatically

2019-03-18 Thread Frediano Ziglio
> On Mon, Mar 11, 2019 at 12:42:10PM -0400, Frediano Ziglio wrote: > > > > > > Series looks good to me, > > > > > > Reviewed-by: Christophe Fergeau > > > > > > > Why not ack? Not good enough? Not tested? Missing something? > > libvirt/qemu use of Reviewed-by/Acked-by confuses me, and to me

Re: [Spice-devel] [PATCH spice-common v3 0/5] Generate C declarations automatically

2019-03-18 Thread Christophe Fergeau
On Mon, Mar 11, 2019 at 12:42:10PM -0400, Frediano Ziglio wrote: > > > > Series looks good to me, > > > > Reviewed-by: Christophe Fergeau > > > > Why not ack? Not good enough? Not tested? Missing something? libvirt/qemu use of Reviewed-by/Acked-by confuses me, and to me they are more or less

Re: [Spice-devel] [PATCH spice-common v3 0/5] Generate C declarations automatically

2019-03-11 Thread Frediano Ziglio
> > Series looks good to me, > > Reviewed-by: Christophe Fergeau > Why not ack? Not good enough? Not tested? Missing something? > On Mon, Mar 11, 2019 at 01:59:09PM +, Frediano Ziglio wrote: > > Allows to declare C declarations (that were in common/messages.h) > > automatically. > > I

Re: [Spice-devel] [PATCH spice-common v3 0/5] Generate C declarations automatically

2019-03-11 Thread Christophe Fergeau
Series looks good to me, Reviewed-by: Christophe Fergeau On Mon, Mar 11, 2019 at 01:59:09PM +, Frediano Ziglio wrote: > Allows to declare C declarations (that were in common/messages.h) > automatically. > I added an attribute to: > - be compatible; > - allows to declare structure in

[Spice-devel] [PATCH spice-common v3 0/5] Generate C declarations automatically

2019-03-11 Thread Frediano Ziglio
Allows to declare C declarations (that were in common/messages.h) automatically. I added an attribute to: - be compatible; - allows to declare structure in different way than automatic ones; - allows to use different headers (as draw.h). Changes since v2: - use a --generate-header option