Hi,
On 07/02/2012 02:11 PM, Alon Levy wrote:
On Wed, Jun 27, 2012 at 06:16:41PM +0300, Yonit Halperin wrote:
I didn't review the whole series, but since I see Hans already provided
some comments on this patch I'll add my own.
I also think the patchset looks very good.
For the future, it
Hi,
Overall looks good, 2 comments:
1) When not using flow-control you set the tokens to max_uint32, and
assume that is enough, but with uwb-2 isoc traffic you can get upto
8000 packets / sec. Which translates to running out of tokens in
approx 145 hours. So if someone leaves a spice-client
On Wed, Jun 27, 2012 at 06:16:41PM +0300, Yonit Halperin wrote:
I didn't review the whole series, but since I see Hans already provided
some comments on this patch I'll add my own.
I also think the patchset looks very good.
For the future, it would be nice to have byte level accounting as well
On 07/02/2012 01:36 PM, Hans de Goede wrote:
Hi,
Overall looks good, 2 comments:
1) When not using flow-control you set the tokens to max_uint32, and
assume that is enough, but with uwb-2 isoc traffic you can get upto
8000 packets / sec. Which translates to running out of tokens in
approx 145
On 07/02/2012 02:11 PM, Alon Levy wrote:
On Wed, Jun 27, 2012 at 06:16:41PM +0300, Yonit Halperin wrote:
I didn't review the whole series, but since I see Hans already provided
some comments on this patch I'll add my own.
I also think the patchset looks very good.
For the future, it would be
SpiceCharDeviceState manages the (1) write-to-device queue
(2) wakeup and reading from the device (3) client tokens (4)
sending messages from the device to the client/s, considering the
available tokens.
SpiceCharDeviceState can be also stopped and started. When the device
is stopped, no reading
