Re: [Spice-devel] [PATCH spice-server] char-device: Make RedClient an opaque structure again

2019-04-03 Thread Victor Toso
Hi, On Fri, Feb 22, 2019 at 10:01:00AM +, Frediano Ziglio wrote: > RedClient was an opaque structure for RedCharDevice. > It started to be used when RedsState started to contain all > the global state. > Make it opaque again. Not particular familiar with the possibilities but I can't see any

Re: [Spice-devel] [PATCH spice-server] char-device: Make RedClient an opaque structure again

2019-03-29 Thread Christophe Fergeau
On Tue, Mar 12, 2019 at 05:58:40AM -0400, Frediano Ziglio wrote: > ping I guess I would reword this as "char-device: Don't use RedClient API" RedCharDevice only use red_client_get_server() once, we can store a Reds* in RedCharDeviceClient instead. This will make it possible to turn the RedClient

Re: [Spice-devel] [PATCH spice-server] char-device: Make RedClient an opaque structure again

2019-03-27 Thread Frediano Ziglio
ping > > > > On Tue, Mar 12, 2019 at 05:58:40AM -0400, Frediano Ziglio wrote: > > > ping > > > > > > > > > > > RedClient was an opaque structure for RedCharDevice. > > > > It started to be used when RedsState started to contain all > > > > the global state. > > > > Make it opaque again. > > >

Re: [Spice-devel] [PATCH spice-server] char-device: Make RedClient an opaque structure again

2019-03-12 Thread Frediano Ziglio
> > On Tue, Mar 12, 2019 at 05:58:40AM -0400, Frediano Ziglio wrote: > > ping > > > > > > > > RedClient was an opaque structure for RedCharDevice. > > > It started to be used when RedsState started to contain all > > > the global state. > > > Make it opaque again. > > It seems we don't put the

Re: [Spice-devel] [PATCH spice-server] char-device: Make RedClient an opaque structure again

2019-03-12 Thread Christophe Fergeau
On Tue, Mar 12, 2019 at 05:58:40AM -0400, Frediano Ziglio wrote: > ping > > > > > RedClient was an opaque structure for RedCharDevice. > > It started to be used when RedsState started to contain all > > the global state. > > Make it opaque again. It seems we don't put the same meaning to

Re: [Spice-devel] [PATCH spice-server] char-device: Make RedClient an opaque structure again

2019-03-12 Thread Frediano Ziglio
ping > > RedClient was an opaque structure for RedCharDevice. > It started to be used when RedsState started to contain all > the global state. > Make it opaque again. > > Signed-off-by: Frediano Ziglio > --- > server/char-device.c | 16 +++- > 1 file changed, 7 insertions(+), 9