[Spice-devel] [spice-gtk] Fix printf format string warning

2013-05-15 Thread Christophe Fergeau
When doing a mingw32 build, I hit the following warning (which became an error because of -Werror): channel-display.c: In function 'destroy_stream': channel-display.c:1546:9: error: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'uint64_t' [-Werror=format=]

Re: [Spice-devel] [spice-gtk] Fix printf format string warning

2013-05-15 Thread Hans de Goede
ACK. On 05/15/2013 11:32 AM, Christophe Fergeau wrote: When doing a mingw32 build, I hit the following warning (which became an error because of -Werror): channel-display.c: In function 'destroy_stream': channel-display.c:1546:9: error: format '%lu' expects argument of type 'long unsigned

[Spice-devel] [spice-gtk] mingw: Fix non-working AltGr with some layouts

2013-05-15 Thread Christophe Fergeau
From: Mattias Grönlund matt...@gronlund.se Running virt-viewer-x64-0.5.6.msi, on Windows 7, connecting to QEMU using spice, AltGR key combinations fails (using Swedish keyboard layout both at server and client). I suspect that this is a variant of

[Spice-devel] how to infer the spice channel type corresponding to a specific port.

2013-05-15 Thread bigclouds
hi, 1.how to know the channel type of a port? look at following output. sometime port on server side is not identical to client side. i want to find which channel is disconnected. 2.there are how many channel and its type-value. thanks - tcp0 0 192.168.5.163:60097

Re: [Spice-devel] why spice server is not aware of client-disconnection.

2013-05-15 Thread David Jaša
This is because spice relies on default tcp behaviour. IMO the only alternative is to have some heartbeat in main channel that would initiate client disconnection if the connection is interrupted. Spice behaviour is analogous to e.g. IRC behaviour while the latter is similar to e.g. XMPP/Jabber

Re: [Spice-devel] [spice-gtk] mingw: Fix non-working AltGr with some layouts

2013-05-15 Thread Marc-André Lureau
ack, although it still needs the gdk patch, since this solution only work when the widget has the keyboard focus, as explained in original thread. On Wed, May 15, 2013 at 11:34 AM, Christophe Fergeau cferg...@redhat.comwrote: From: Mattias Grönlund matt...@gronlund.se Running

[Spice-devel] [PATCH spice-gtk] widget: release keys on grab-broken by external applications

2013-05-15 Thread Marc-André Lureau
Fixes l key repeatition when pressing Alt+L on Windows when the pointer is over the display. https://bugzilla.redhat.com/show_bug.cgi?id=917986 --- gtk/spice-widget.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index de1cead..2e513a8 100644

Re: [Spice-devel] [PATCH spice-gtk] widget: release keys on grab-broken by external applications

2013-05-15 Thread Hans de Goede
Hi, Looks good, ACK. About the FIXME, no we should not always release the keys on ungrab, since an ungrab != focus loss in some cases, ie it can be done by the client through the PROP_KEYBOARD_GRAB property. Regards, Hans On 05/15/2013 08:02 PM, Marc-André Lureau wrote: Fixes l key

Re: [Spice-devel] how to infer the spice channel type corresponding to a specific port.

2013-05-15 Thread Alon Levy
On Wed, 2013-05-15 at 18:05 +0800, bigclouds wrote: hi, 1.how to know the channel type of a port? There is no way, since there is a single port, and the order of client connection to the server is determined by the client, and the ports are determined by the operating system. You will have to