[Spice-devel] [PATCH x11spice] Changes to build on the 32 bit raspberry pi.

2019-06-13 Thread Jeremy White
Signed-off-by: Jeremy White --- src/scan.c| 6 +++--- src/session.c | 8 src/spice.c | 18 +++--- 3 files changed, 18 insertions(+), 14 deletions(-) diff --git a/src/scan.c b/src/scan.c index bb020de..ebadaf8 100644 --- a/src/scan.c +++ b/src/scan.c @@ -70,7 +70,7

Re: [Spice-devel] [spice v2 2/2] utils: Remove the LL suffix from NSEC_PER_SEC

2019-06-13 Thread Uri Lublin
On 6/13/19 2:47 PM, Frediano Ziglio wrote: On 6/13/19 1:23 PM, Frediano Ziglio wrote: This constant fits in a 32 bit signed integer so it does not need the suffix. However some of the derived constants don't so use an uint64_t cast to avoid the long vs long long confusion (such as in print

Re: [Spice-devel] [spice v2 2/2] utils: Remove the LL suffix from NSEC_PER_SEC

2019-06-13 Thread Frediano Ziglio
> > On 6/13/19 1:23 PM, Frediano Ziglio wrote: > >> > >> This constant fits in a 32 bit signed integer so it does not need the > >> suffix. However some of the derived constants don't so use an uint64_t > >> cast to avoid the long vs long long confusion (such as in print > >> statements). > >>

Re: [Spice-devel] [PATCH spice-server] red-stream: Fix compilation on Fedora 30 for Windows using MingW

2019-06-13 Thread Uri Lublin
On 6/13/19 12:57 PM, Frediano Ziglio wrote: On 6/12/19 1:53 PM, Frediano Ziglio wrote: On Windows Fedora 30 reports these errors: In file included from /usr/x86_64-w64-mingw32/sys-root/mingw/include/openssl/crypto.h:29, from

Re: [Spice-devel] [spice v2 2/2] utils: Remove the LL suffix from NSEC_PER_SEC

2019-06-13 Thread Uri Lublin
On 6/13/19 1:23 PM, Frediano Ziglio wrote: This constant fits in a 32 bit signed integer so it does not need the suffix. However some of the derived constants don't so use an uint64_t cast to avoid the long vs long long confusion (such as in print statements). Also some of the expressions these

Re: [Spice-devel] [spice v2 2/2] utils: Remove the LL suffix from NSEC_PER_SEC

2019-06-13 Thread Frediano Ziglio
> > This constant fits in a 32 bit signed integer so it does not need the > suffix. However some of the derived constants don't so use an uint64_t > cast to avoid the long vs long long confusion (such as in print > statements). > Also some of the expressions these constants are used in may

Re: [Spice-devel] [PATCH spice-server] red-stream: Fix compilation on Fedora 30 for Windows using MingW

2019-06-13 Thread Frediano Ziglio
> On 6/12/19 1:53 PM, Frediano Ziglio wrote: > > On Windows Fedora 30 reports these errors: > > > > In file included from > > /usr/x86_64-w64-mingw32/sys-root/mingw/include/openssl/crypto.h:29, > > from > > > >

Re: [Spice-devel] [client] gstreamer: Fix the decoding time when not using GstVideoOverlay

2019-06-13 Thread Francois Gouget
On Wed, 12 Jun 2019, Snir Sheriber wrote: > Hi, > > On 6/11/19 9:42 PM, Francois Gouget wrote: > > schedule_frame() only pulls frames out of GStreamer's pipeline once all > > previous decoded frames have been displayed. Thus when the video delay > > > IIRC we used to pull when samples arrived

Re: [Spice-devel] [PATCH spice-server] red-stream: Fix compilation on Fedora 30 for Windows using MingW

2019-06-13 Thread Uri Lublin
On 6/12/19 1:53 PM, Frediano Ziglio wrote: On Windows Fedora 30 reports these errors: In file included from /usr/x86_64-w64-mingw32/sys-root/mingw/include/openssl/crypto.h:29, from /usr/x86_64-w64-mingw32/sys-root/mingw/include/openssl/bio.h:20, from

[Spice-devel] [spice v2 2/2] utils: Remove the LL suffix from NSEC_PER_SEC

2019-06-13 Thread Francois Gouget
This constant fits in a 32 bit signed integer so it does not need the suffix. However some of the derived constants don't so use an uint64_t cast to avoid the long vs long long confusion (such as in print statements). Also some of the expressions these constants are used in may overflow so perform

[Spice-devel] [spice v2 1/2] utils: Remove the LL suffix from NSEC_PER_MILLISEC

2019-06-13 Thread Francois Gouget
This constant fits in a regular 32 bit signed integer so it does not need the suffix. It is also not used in expressions that may overflow. Signed-off-by: Francois Gouget --- v2: No changes. v1: https://lists.freedesktop.org/archives/spice-devel/2019-May/049193.html server/utils.h | 2 +- 1

Re: [Spice-devel] [PATCH spice-common] build: Disable Celt support by default

2019-06-13 Thread Christophe Fergeau
Hey, yup fine with me too. Christophe On Thu, Jun 13, 2019 at 03:40:17AM -0400, Frediano Ziglio wrote: > > > > Hi, > > > > Fine with me. > > > > This is also related to > https://gitlab.freedesktop.org/spice/spice/merge_requests/2, > I talked with Christophe and he agreed would be sensible

Re: [Spice-devel] [PATCH spice-server 2/2] ci: Add test for 32 bit CentOS 7

2019-06-13 Thread Uri Lublin
On 6/11/19 9:43 PM, Frediano Ziglio wrote: Make sure the project compile and pass tests without problems on a 32 bit architecture. Signed-off-by: Frediano Ziglio Ack. Uri --- .gitlab-ci.yml | 22 ++ 1 file changed, 22 insertions(+) diff --git a/.gitlab-ci.yml

Re: [Spice-devel] [PATCH spice-server 1/2] Fix compile warnings on Linux 32bit system

2019-06-13 Thread Uri Lublin
On 6/12/19 9:30 AM, Frediano Ziglio wrote: Some typos/improves (just commit message) Subject: [PATCH spice-server 1/2] Fix compile warnings on Linux 32bit system Better "Remove compile warnings ..." Both are OK. Based on a patch from Hongzhi.Song . There are following compile errors

[Spice-devel] [PATCH spice-server] build: Disable Celt support by default

2019-06-13 Thread Frediano Ziglio
We started disabling Celt support making the option required. After 2 releases start making it disabled unless explicitly enabled. This makes https://gitlab.freedesktop.org/spice/spice/merge_requests/2 obsolete. Signed-off-by: Frediano Ziglio --- meson_options.txt| 1 +

Re: [Spice-devel] [PATCH spice-common] build: Disable Celt support by default

2019-06-13 Thread Frediano Ziglio
> > Hi, > > Fine with me. > This is also related to https://gitlab.freedesktop.org/spice/spice/merge_requests/2, I talked with Christophe and he agreed would be sensible to disable by default. > On 6/12/19 3:06 PM, Frediano Ziglio wrote: > > We started disabling Celt support making the

Re: [Spice-devel] [PATCH spice-server] ci: Remove dependencies from copr build

2019-06-13 Thread Frediano Ziglio
> > Assuming it passed the CI, Ack. > Yes and not. Yes as the specific job passes. No as there are some pending patches which are required in order to compiler for Fedora 30 (one for Windows that I sent yesterday, the others some weeks ago about alignment). > Acked-by: Snir Sheriber > > On

Re: [Spice-devel] [PATCH spice-common] build: Disable Celt support by default

2019-06-13 Thread Snir Sheriber
Hi, Fine with me. On 6/12/19 3:06 PM, Frediano Ziglio wrote: We started disabling Celt support making the option required. After 2 releases start making it disabled unless explicitly enabled. Signed-off-by: Frediano Ziglio --- m4/spice-deps.m4 | 14 ++ meson_options.txt | 1

Re: [Spice-devel] [PATCH spice-server] Update spice-common submodule

2019-06-13 Thread Snir Sheriber
It seems this was pushed already some time ago On 6/12/19 2:53 PM, Frediano Ziglio wrote: This brings in the following changes: Frediano Ziglio (4): gitignore: Ignore auto generated generated_messages.h file Do not check for HAVE_CONFIG_H build: Remove unused

[Spice-devel] [PATCH spice-server] Remove compile warnings on Linux 32bit system

2019-06-13 Thread Frediano Ziglio
Based on a patch from Hongzhi.Song . There are following compile errors on Linux 32bit system with -Werror for gcc. red-channel.c:207:73: error: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Werror=format=] |207| red_channel_debug(self,