Re: [Spice-devel] [spice-common v2 8/8] log: Let gcc know about the logging macros which abort

On Fri, Mar 29, 2019 at 06:51:54AM -0400, Frediano Ziglio wrote: > > > > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL) > > will never return. > > > > Signed-off-by: Christophe Fergeau > > I prefer the "for" way. But by the way, this is not telling the compiler > that

Re: [Spice-devel] [spice-common v2 8/8] log: Let gcc know about the logging macros which abort

On Fri, Mar 29, 2019 at 07:18:35AM -0400, Frediano Ziglio wrote: > > On Fri, Mar 29, 2019 at 06:57:59AM -0400, Frediano Ziglio wrote: > > > > On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote: > > > > > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL) > > > >

Re: [Spice-devel] [spice-common v2 8/8] log: Let gcc know about the logging macros which abort

> On Fri, Mar 29, 2019 at 06:57:59AM -0400, Frediano Ziglio wrote: > > > On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote: > > > > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL) > > > > will never return. > > > > > > > > Signed-off-by: Christophe Fergeau

Re: [Spice-devel] [spice-common v2 8/8] log: Let gcc know about the logging macros which abort

On Fri, Mar 29, 2019 at 06:57:59AM -0400, Frediano Ziglio wrote: > > On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote: > > > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL) > > > will never return. > > > > > > Signed-off-by: Christophe Fergeau > > > --- >

Re: [Spice-devel] [spice-common v2 8/8] log: Let gcc know about the logging macros which abort

> On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote: > > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL) > > will never return. > > > > Signed-off-by: Christophe Fergeau > > --- > > common/log.h | 5 + > > 1 file changed, 5 insertions(+) > > > > diff

Re: [Spice-devel] [spice-common v2 8/8] log: Let gcc know about the logging macros which abort

On Fri, Mar 29, 2019 at 11:30:46AM +0100, Christophe Fergeau wrote: > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL) > will never return. > > Signed-off-by: Christophe Fergeau > --- > common/log.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/common/log.h

Re: [Spice-devel] [spice-common v2 8/8] log: Let gcc know about the logging macros which abort

> > Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL) > will never return. > > Signed-off-by: Christophe Fergeau I prefer the "for" way. But by the way, this is not telling the compiler that spice_log (NOT g_log) is not returning but to call abort() after spice_log. I don't

[Spice-devel] [spice-common v2 8/8] log: Let gcc know about the logging macros which abort

Without the added abort(), it cannot know g_log(G_LOG_LEVEL_CRITICAL) will never return. Signed-off-by: Christophe Fergeau --- common/log.h | 5 + 1 file changed, 5 insertions(+) diff --git a/common/log.h b/common/log.h index 7c67e7a..1482358 100644 --- a/common/log.h +++ b/common/log.h @@