[sr-dev] git:master:fb7c4ec9: core/rthreads.h: fix missing returns

2024-02-06 Thread S-P Chan via sr-dev
Module: kamailio Branch: master Commit: fb7c4ec9a33d8147094aa664ce3c96b6c3cb7d35 URL: https://github.com/kamailio/kamailio/commit/fb7c4ec9a33d8147094aa664ce3c96b6c3cb7d35 Author: S-P Chan Committer: S-P Chan Date: 2024-02-07T14:08:01+08:00 core/rthreads.h: fix missing returns --- Modified:

[sr-dev] git:master:1a2993ca: core/rthreads.h: fix missing return

2024-02-06 Thread S-P Chan via sr-dev
Module: kamailio Branch: master Commit: 1a2993ca370da35c34abae1cb44086492faa0ade URL: https://github.com/kamailio/kamailio/commit/1a2993ca370da35c34abae1cb44086492faa0ade Author: S-P Chan Committer: S-P Chan Date: 2024-02-07T05:54:35+08:00 core/rthreads.h: fix missing return --- Modified:

[sr-dev] git:master:e52bc4ba: Sample etc/kamailio.cfg: add tls_threads_mode to config

2024-02-06 Thread S-P Chan via sr-dev
Module: kamailio Branch: master Commit: e52bc4ba41417362c79da1cd3d41b283aabc4eb8 URL: https://github.com/kamailio/kamailio/commit/e52bc4ba41417362c79da1cd3d41b283aabc4eb8 Author: S-P Chan Committer: S-P Chan Date: 2024-02-07T05:49:14+08:00 Sample etc/kamailio.cfg: add tls_threads_mode to

[sr-dev] git:master:aa15489f: core/rthreads.h: use global ksr_tls_threads_mode to constrain thread

2024-02-06 Thread S-P Chan via sr-dev
Module: kamailio Branch: master Commit: aa15489f0a8de4a27197602d771fe02cf5745287 URL: https://github.com/kamailio/kamailio/commit/aa15489f0a8de4a27197602d771fe02cf5745287 Author: S-P Chan Committer: S-P Chan Date: 2024-02-07T05:24:30+08:00 core/rthreads.h: use global ksr_tls_threads_mode to

[sr-dev] Re: [kamailio/kamailio] DRAFT: new global config var to constrain thread wrapping (PR #3745)

2024-02-06 Thread space88man via sr-dev
Closed #3745. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3745#event-1172474 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] [kamailio/kamailio] Kamailio segfaults when KEMI functions are invoked from app_python script (Issue #3746)

2024-02-06 Thread David Minh Phan via sr-dev
### Description Kamailio segfaults when KEMI functions are invoked from app_python script ### Troubleshooting The same code was running ok with the 5.6 branch. It seems that the function sr_apy_kemi_exec_func_ex has been re-written in 5.7 with the following main changes : - The long IF/ELSE

[sr-dev] Re: [kamailio/kamailio] DRAFT: new global config var to constrain thread wrapping (PR #3745)

2024-02-06 Thread space88man via sr-dev
> Looks like we were working in parallel Done - please check -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3745#issuecomment-1929671704 You are receiving this because you are subscribed to this thread. Message ID:

[sr-dev] Re: [kamailio/kamailio] DRAFT: new global config var to constrain thread wrapping (PR #3745)

2024-02-06 Thread space88man via sr-dev
Reopened #3745. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3745#event-11718365336 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development

[sr-dev] Re: [kamailio/kamailio] DRAFT: new global config var to constrain thread wrapping (PR #3745)

2024-02-06 Thread space88man via sr-dev
Closed #3745. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3745#event-11718342668 You are receiving this because you are subscribed to this thread. Message ID: ___ Kamailio (SER) - Development Mailing

[sr-dev] Re: [kamailio/kamailio] [DRAFT]: restrict thread execution to process_no = 0 (PR #3744)

2024-02-06 Thread space88man via sr-dev
@henning - so sorry tagged the wrong name. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3744#issuecomment-1929632822 You are receiving this because you commented. Message ID: ___ Kamailio (SER) -

[sr-dev] Re: [kamailio/kamailio] DRAFT: new global config var to constrain thread wrapping (PR #3745)

2024-02-06 Thread Daniel-Constantin Mierla via sr-dev
Looks like we were working in parallel and I pushed a commit to add the global parameter with the name `tls_threads_mode` (internal global variable `ksr_tls_threads_mode`). I also replied to the email on sr-dev where you asked for assistance on it. Maybe you can amend your code to use the

[sr-dev] Re: git:master:ba921b21: core/rthread.h: add prototype for db queries

2024-02-06 Thread Daniel-Constantin Mierla via sr-dev
Hello Richard, I added the global parameter tls_threads_mode, I consider to reflect better the purpose than the proposed enable_tls_threads. In the code it is the global variable ksr_tls_threads_mode which is exposed via core/globals.h -- you can see commit:   -

[sr-dev] Re: [kamailio/kamailio] [DRAFT]: restrict thread execution to process_no = 0 (PR #3744)

2024-02-06 Thread Richard Chan via sr-dev
Ah so sorry about that : I have a new DRAFT PR for master that implements enable_tls_threads = 0|1|2 that disables threading when not essential https://github.com/kamailio/kamailio/pull/3745 On Tue, 6 Feb 2024 at 21:21, Daniel-Constantin Mierla via sr-dev < sr-dev@lists.kamailio.org> wrote: >

[sr-dev] [kamailio/kamailio] DRAFT: new global config var to constrain thread wrapping (PR #3745)

2024-02-06 Thread space88man via sr-dev
!-- Kamailio Pull Request Template -- !-- IMPORTANT: - for detailed contributing guidelines, read: https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md - pull requests must be done to master branch, unless they are backports of fixes from master branch to a stable

[sr-dev] git:master:4d6e37fa: core: added tls_threads_mode global parameter

2024-02-06 Thread Daniel-Constantin Mierla via sr-dev
Module: kamailio Branch: master Commit: 4d6e37fa048a1aaa2d2fc6655985b4bcb9754258 URL: https://github.com/kamailio/kamailio/commit/4d6e37fa048a1aaa2d2fc6655985b4bcb9754258 Author: Daniel-Constantin Mierla Committer: Daniel-Constantin Mierla Date: 2024-02-06T14:24:08+01:00 core: added

[sr-dev] Re: [kamailio/kamailio] [DRAFT]: restrict thread execution to process_no = 0 (PR #3744)

2024-02-06 Thread Daniel-Constantin Mierla via sr-dev
@space88man: regarding the above comment, you tagged the wrong Henning in the PR description, the one involved in Kamailio development is @henningw. The patch in PR seems ok, just wait a bit till merging just in case someone else wants to take a look. -- Reply to this email directly or view

[sr-dev] Re: Working with arrays in MongoDB documents

2024-02-06 Thread Mario Pereira via sr-dev
Hi Henning, Thank you very much for your reply. I have a question: what do you mean when you talk about using ndb_mongodb module? Do you mean to use it from the configuration file or inside a module code? Our use case is to save all contacts related to an AOR in the same MongoDB document as an

[sr-dev] Re: [kamailio/kamailio] [DRAFT]: restrict thread execution to process_no = 0 (PR #3744)

2024-02-06 Thread space88man via sr-dev
> no idea what this is? Henning This is related to your comment on the 5,7 stable branch: this PR restricts thread wrapping to process_no=0, i.e., from workers POV - no change in behaviour so the same as 5.7.4, 5.7.3 ... For process_no=0 it will run libssl calls in a thread to prevent thread

[sr-dev] Re: [kamailio/kamailio] [DRAFT]: restrict thread execution to process_no = 0 (PR #3744)

2024-02-06 Thread Henning Sprang via sr-dev
no idea what this is? Henning On Tue 6. Feb 2024 at 12:34, space88man ***@***.***> wrote: > Pre-Submission Checklist > >- Commit message has the format required by CONTRIBUTING guide >- Commits are split per component (core, individual modules, libs, >utils, ...) >- Each

[sr-dev] Re: git:master:ba921b21: core/rthread.h: add prototype for db queries

2024-02-06 Thread Richard Chan via sr-dev
For 5.7 stable I have a draft PR https://github.com/kamailio/kamailio/pull/3744 that minimises thread execution: it will run functions in a thread only if process_no = 0. This restores unchanged behaviour to all workers. FYC. On Tue, 6 Feb 2024 at 16:02, Henning Westerholt via sr-dev <

[sr-dev] [kamailio/kamailio] [DRAFT]: restrict thread execution to process_no = 0 (PR #3744)

2024-02-06 Thread space88man via sr-dev
Pre-Submission Checklist - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for

[sr-dev] Re: git:master:ba921b21: core/rthread.h: add prototype for db queries

2024-02-06 Thread Richard Chan via sr-dev
Hi Daniel / Henning, I would like to propose a global config to restore the non-threaded default: enable_tls = no|yes #(EXISTING) boolean enable_tls_threads = 0 | 1 | 2 #(NEW) int 0: disable thread-wrappers (restores kamailio behaviour) - default when enable_tls = no 1: thread-wrapper only

[sr-dev] [kamailio/kamailio] Segfault in pua_dialoginfo.c when starting up with a dialog in the database (Issue #3743)

2024-02-06 Thread Gianluca Nitti via sr-dev
### Description Kamailio segfaults on startup. After a bit of digging, it looks like the issue is caused by trying to publish something related to an expired dalog which is present in the database: ``` kamailio=# select * from dialog; id | hash_entry | hash_id | callid |