The proposal to merge
~adam-collard/maas:create-discovered-subnet-in-correct-fabric into maas:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/444258
--
Your team MAAS Committers is subscri
Adam Collard has proposed merging
~adam-collard/maas:create-discovered-subnet-in-correct-fabric into maas:master.
Commit message:
LP:2011853 create discovered subnets in correct fabric.
Requested reviews:
MAAS Maintainers (maas-maintainers)
Related bugs:
Bug #2011853 in MAAS: "
The proposal to merge
~jjqq/maas:james-create-discovered-subnet-in-correct-fabric into maas:master
has been updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~jjqq/maas/+git/maas/+merge/439086
--
Your team MAAS Committers is subscribed to branch
Superseded by
https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/444258
--
https://code.launchpad.net/~jjqq/maas/+git/maas/+merge/439086
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors
The proposal to merge ~mfo/maas:lp2020397-opt-out into maas:master has been
updated.
Status: Needs review => Rejected
For more details, see:
https://code.launchpad.net/~mfo/maas/+git/maas/+merge/444127
--
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list:
Review: Approve
Don't forget to jenkins-job update
--
https://code.launchpad.net/~lloydwaltersj/maas-ci/+git/maas-ci-config/+merge/444182
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/maas-ci-config:master.
--
Mailing list:
The proposal to merge ~adam-collard/maas-kpi:github-issues-grafana-yaxis into
maas-kpi:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas-kpi/+git/maas-kpi/+merge/443873
--
Your team MAAS Committers is subscri
Adam Collard has proposed merging
~adam-collard/maas-kpi:github-issues-grafana-yaxis into maas-kpi:master.
Commit message:
Team dashboard fixes
* Set Y-axis minimum to 0
* Format Y-axis as no format (i.e. whole integers)
* Title tweaks
Requested reviews:
MAAS Lander (maas-lander): unittests
Adam Collard has proposed merging
~adam-collard/maas-site-manager:playwright-build-dep into
maas-site-manager:main.
Commit message:
Set fixed path to playwright browsers
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~adam-collard
The proposal to merge ~adam-collard/maas-site-manager:playwright-build-dep into
maas-site-manager:main has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~adam-collard/maas-site-manager/+git/site-manager/+merge/443866
--
Your t
Review: Approve
--
https://code.launchpad.net/~alexsander-souza/maas-ci/+git/maas-ci-internal/+merge/443816
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/maas-ci-internal:main.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
The proposal to merge
~alexsander-souza/maas-ci/+git/maas-ci-internal:add_gh_token_to_kpi into
~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated.
Status: Needs review => Approved
For more details, see:
Adam Collard has proposed merging
~adam-collard/maas-site-manager:bad-phony-make-targets into
maas-site-manager:main.
Commit message:
Fix .PHONY directives
Requested reviews:
MAAS Lander (maas-lander): unittests
MAAS Committers (maas-committers)
For more details, see:
https
The proposal to merge
~adam-collard/maas-ci/+git/maas-ci-internal:ubuntu-devel-mantic into
~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas-ci/+git/maas-ci-inter
Adam Collard has proposed merging
~adam-collard/maas-ci/+git/maas-ci-internal:ubuntu-devel-mantic into
~maas-committers/maas-ci/+git/maas-ci-internal:main.
Commit message:
Need the build-env building for 23.10 too
Requested reviews:
MAAS Committers (maas-committers)
For more details, see
The proposal to merge
~adam-collard/maas-ci/+git/maas-ci-internal:ubuntu-devel-mantic into
~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas-ci/+git/maas-ci-inter
Adam Collard has proposed merging
~adam-collard/maas-ci/+git/maas-ci-internal:ubuntu-devel-mantic into
~maas-committers/maas-ci/+git/maas-ci-internal:main.
Commit message:
Bump Ubuntu devel to 23.10 (Mantic Minotaur)
Requested reviews:
MAAS Committers (maas-committers)
For more details
Review: Approve
--
https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/443748
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
The proposal to merge ~adam-collard/maas:machine-config-hints-fixup into
maas:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/443658
--
Your team MAAS Committers is subscribed to bra
Review: Approve
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/443671
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~ack/maas/+git/maas/+merge/443657
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~sts-sponsors
Review: Approve
thanks! nit pick below
Diff comments:
> diff --git a/tox.ini b/tox.ini
> index 59e2209..6cbd791 100644
> --- a/tox.ini
> +++ b/tox.ini
> @@ -42,6 +42,7 @@ lint =
> src/provisioningserver \
> src/provisioningserver/refresh/50-maas-01-commissioning \
> src/tests/ \
> can't we rather move the script under src/provisioningserver/refresh ?
we can, but don't see how it's useful to run on controllers.
--
https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/443658
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: ht
The proposal to merge ~adam-collard/maas-ci/+git/system-tests:no-double-import
into ~maas-committers/maas-ci/+git/system-tests:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/443
Review: Approve
--
https://code.launchpad.net/~adam-collard/maas-ci/+git/system-tests/+merge/443654
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/system-tests:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors
Review: Needs Information
How will we remember to update this list?
--
https://code.launchpad.net/~ack/maas/+git/maas/+merge/443657
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Adam Collard has proposed merging ~adam-collard/maas:machine-config-hints-fixup
into maas:master.
Commit message:
LP:2020882 Don't run machine-config hints on controllers
Requested reviews:
MAAS Maintainers (maas-maintainers)
Related bugs:
Bug #2020882 in MAAS: "Machine config
The proposal to merge ~adam-collard/maas:flaky-profile-name into maas:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/443651
--
Your team MAAS Committers is subscribed to branch maas:mas
The proposal to merge ~adam-collard/maas:flaky-profile-name into maas:master
has been updated.
Commit message changed to:
fix: flaky maas_user profile name, use a hard-coded name
For more details, see:
https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/443651
--
Your team MAAS
Adam Collard has proposed merging ~adam-collard/maas:flaky-profile-name into
maas:master.
Commit message:
fix: flaky maas_user profile name
Keep trying usernames until we find one that doesn't start with a -
Requested reviews:
MAAS Maintainers (maas-maintainers)
Related bugs:
Bug #2020865
The proposal to merge
~adam-collard/maas-ci/+git/system-tests:image-to-test-fixture-rework into
~maas-committers/maas-ci/+git/system-tests:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas-ci/+git/system-te
Adam Collard has proposed merging
~adam-collard/maas-ci/+git/system-tests:image-to-test-fixture-rework into
~maas-committers/maas-ci/+git/system-tests:master.
Commit message:
image_to_test: each invocation gets a single image to test
albeit generated from a list
Requested reviews:
MAAS
The proposal to merge ~lloydwaltersj/maas-ci/+git/maas-ci-config:fix-gen-config
into ~maas-committers/maas-ci/+git/maas-ci-config:master has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
~lloydwaltersj/maas-ci/+git/system-tests:fix-image-test-command-name into
~maas-committers/maas-ci/+git/system-tests:master has been updated.
Status: Needs review => Approved
For more details, see:
Review: Approve
--
https://code.launchpad.net/~lloydwaltersj/maas-ci/+git/system-tests/+merge/443574
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/system-tests:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Adam Collard has proposed merging ~adam-collard/maas:flaky-dns-ipv4-no-gateways
into maas:master.
Commit message:
fix: get_default_dns_servers relied on ordering of routable ips
The flaky test was dependent on ordering of ips which were never
explicitly ordered.
We now sort the addresses
Review: Approve
--
https://code.launchpad.net/~lloydwaltersj/maas-ci/+git/system-tests/+merge/443491
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/system-tests:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Needs Fixing
Diff comments:
> diff --git a/src/maastesting/pytest/django.py
> b/src/maastesting/pytest/django.py
> index 5eb7915..83e18fc 100644
> --- a/src/maastesting/pytest/django.py
> +++ b/src/maastesting/pytest/django.py
> @@ -100,12 +100,12 @@ def
Review: Approve
--
https://code.launchpad.net/~lloydwaltersj/maas-ci/+git/system-tests/+merge/443284
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/system-tests:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Diff comments:
> diff --git a/systemtests/conftest.py b/systemtests/conftest.py
> index 0db6532..78c27c9 100644
> --- a/systemtests/conftest.py
> +++ b/systemtests/conftest.py
> @@ -329,3 +343,9 @@ def pytest_generate_tests(metafunc: Metafunc) -> None:
> if
The proposal to merge ~adam-collard/maas-kpi:no-alias-for-performance into
maas-kpi:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas-kpi/+git/maas-kpi/+merge/443361
--
Your team MAAS Committers is subscri
Adam Collard has proposed merging
~adam-collard/maas-kpi:no-alias-for-performance into maas-kpi:master.
Commit message:
Remove alias to let Grafana title the series itself
Requested reviews:
MAAS Lander (maas-lander)
MAAS Committers (maas-committers)
For more details, see:
https
Adam Collard has proposed merging
~adam-collard/maas-ci/+git/maas-ci-internal:grafana-dashboard-fix into
~maas-committers/maas-ci/+git/maas-ci-internal:main.
Commit message:
Fix make targets for grafana dashboards
Requested reviews:
Alberto Donato (ack)
MAAS Lander (maas-lander
Review: Approve
--
https://code.launchpad.net/~alexsander-souza/maas/+git/maas/+merge/443301
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Diff comments:
> diff --git a/src/provisioningserver/kernel_opts.py
> b/src/provisioningserver/kernel_opts.py
> index 7ecbcf7..5730052 100644
> --- a/src/provisioningserver/kernel_opts.py
> +++ b/src/provisioningserver/kernel_opts.py
> @@ -111,13 +112,23 @@ def compose_purpose_opts(params):
>
Diff comments:
> diff --git a/systemtests/fixtures.py b/systemtests/fixtures.py
> index 64d3974..fcf6f43 100644
> --- a/systemtests/fixtures.py
> +++ b/systemtests/fixtures.py
> @@ -484,10 +520,15 @@ def maas_region(
> maas_container.execute(["update-ca-certificates"])
>
> if
Review: Approve
--
https://code.launchpad.net/~ack/maas-kpi/+git/maas-kpi/+merge/443116
Your team MAAS Committers is subscribed to branch maas-kpi:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~ack/maas-kpi/+git/maas-kpi/+merge/443084
Your team MAAS Committers is subscribed to branch maas-kpi:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/442967
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
The proposal to merge ~philroche/maas-images:feature/opening-mantic into
maas-images:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~philroche/maas-images/+git/maas-images/+merge/442661
--
Your team maintainers of maas images is
Review: Approve
--
https://code.launchpad.net/~philroche/maas-images/+git/maas-images/+merge/442661
Your team maintainers of maas images is subscribed to branch maas-images:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe
The proposal to merge ~philroche/maas-images:feature/opening-mantic into
maas-images:master has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~philroche/maas-images/+git/maas-images/+merge/442661
--
Your team maintainers of maas images is
Review: Needs Fixing
-2
Diff comments:
> diff --git a/conf/meph-v3.yaml b/conf/meph-v3.yaml
> index 4214e98..7db7ef0 100644
> --- a/conf/meph-v3.yaml
> +++ b/conf/meph-v3.yaml
> @@ -40,6 +40,7 @@ subarches:
> - _hwe_jj_edge [generic, hwe-p, hwe-q, hwe-r, hwe-s, hwe-t,
> hwe-u,
The proposal to merge ~adam-collard/maas:virsh-amd64-passthru into maas:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/442644
--
Your team MAAS Committers is subscribed to branch maas:mas
The proposal to merge ~adam-collard/maas:virsh-amd64-passthru into maas:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/442644
--
Your team MAAS Committers is subscribed to branch maas:mas
Adam Collard has proposed merging ~adam-collard/maas:virsh-amd64-passthru into
maas:master.
Commit message:
fix: virsh - add host-passthrough for amd64, s390x
LP:1876365
Requested reviews:
MAAS Maintainers (maas-maintainers)
Related bugs:
Bug #1876365 in MAAS: "host passthrough not wo
The proposal to merge
~adam-collard/maas/+git/maas-release-tools:sync-milestones into
~maas-committers/maas/+git/maas-release-tools:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas/+git/maas-release-tools/+me
Adam Collard has proposed merging
~adam-collard/maas/+git/maas-release-tools:sync-milestones into
~maas-committers/maas/+git/maas-release-tools:main.
Commit message:
Add milestone syncing
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https
Diff comments:
> diff --git a/debian/extras/99-maas-common-sudoers
> b/debian/extras/99-maas-common-sudoers
> index 412c60b..c00627c 100644
> --- a/debian/extras/99-maas-common-sudoers
> +++ b/debian/extras/99-maas-common-sudoers
> @@ -2,7 +2,6 @@ maas ALL= NOPASSWD: /usr/bin/lshw
> maas
The proposal to merge
~cgrabowski/maas-ci/+git/system-tests:ha_postgres_system_tests into
~maas-committers/maas-ci/+git/system-tests:master has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge ~ack/maas:2017504-allow-empty-address-list into
maas:master has been updated.
Commit message changed to:
LP:2017504 don't error if address list in reduce_routable_address_map is empty
also, simplify/cleanup logic in Node.get_default_dns_servers
For more details, see:
The proposal to merge
~adam-collard/maas-ci/+git/maas-ci-internal:console-not-consoleText into
~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~adam-collard/maas-ci/+git/maas-ci-inter
The proposal to merge
~adam-collard/maas-ci/+git/maas-ci-internal:console-not-consoleText into
~maas-committers/maas-ci/+git/maas-ci-internal:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~adam-collard/maas-ci/+git/maas
Adam Collard has proposed merging
~adam-collard/maas-ci/+git/maas-ci-internal:console-not-consoleText into
~maas-committers/maas-ci/+git/maas-ci-internal:main.
Commit message:
Link to console, not consoleText
Requested reviews:
MAAS Committers (maas-committers)
For more details, see
Diff comments:
> diff --git a/backend/msm/schema/_models.py b/backend/msm/schema/_models.py
> index 9a80683..76ed5e9 100644
> --- a/backend/msm/schema/_models.py
> +++ b/backend/msm/schema/_models.py
> @@ -112,6 +123,23 @@ class Token(CreateToken):
> id: int
>
>
> +class
Review: Approve
--
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441654
Your team MAAS Committers is subscribed to branch
~petermakowski/maas-site-manager:remove-duplicated-await.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
--
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/441580
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
The proposal to merge ~philroche/maas-images:feature/shim-signed-rename into
maas-images:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~philroche/maas-images/+git/maas-images/+merge/441575
--
Your team maintainers of maas images
Review: Approve
+1, thanks
--
https://code.launchpad.net/~philroche/maas-images/+git/maas-images/+merge/441575
Your team maintainers of maas images is subscribed to branch maas-images:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
The proposal to merge ~cgrabowski/maas:cleanup_rpc_disconnect_logging into
maas:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/441113
--
Your team MAAS Committers is subscribed to branch
Diff comments:
> diff --git a/docker-compose.yaml b/docker-compose.yaml
> index b1dbec9..38e90ad 100644
> --- a/docker-compose.yaml
> +++ b/docker-compose.yaml
> @@ -30,6 +30,11 @@ services:
>- "8000:8000"
> links:
>- "postgres:db"
> +healthcheck:
> + test:
The proposal to merge ~igor-brovtsin/maas:report-bulk-action-errors into
maas:master has been updated.
Commit message changed to:
Report reasons for failure for machine bulk actions
Fixes LP:2009045
For more details, see:
https://code.launchpad.net/~igor-brovtsin/maas/+git/maas/+merge/441297
Review: Approve
--
https://code.launchpad.net/~igor-brovtsin/maas/+git/maas/+merge/441297
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~igor-brovtsin/maas/+git/maas/+merge/440724
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Diff comments:
> diff --git a/src/maasserver/websockets/handlers/machine.py
> b/src/maasserver/websockets/handlers/machine.py
> index 63b181f..d150cb5 100644
> --- a/src/maasserver/websockets/handlers/machine.py
> +++ b/src/maasserver/websockets/handlers/machine.py
> @@ -1012,25 +1012,28 @@
The proposal to merge
~maas-committers/maas-ci/+git/system-tests:improve-ansible-performance into
~maas-committers/maas-ci/+git/system-tests:master has been updated.
Status: Needs review => Approved
For more details, see:
Diff comments:
> diff --git a/systemtests/ansible.py b/systemtests/ansible.py
> index 7c671c8..10aedba 100644
> --- a/systemtests/ansible.py
> +++ b/systemtests/ansible.py
> @@ -21,6 +23,9 @@ if TYPE_CHECKING:
> NAME = "systemtests.ansible"
> LOG = getLogger(NAME)
>
> +# match a string
Adam Collard has proposed merging ~adam-collard/maas-images:drop-xgene-lunar
into maas-images:master.
Commit message:
Drop xgene kernel for Lunar
Fixes LP:2015363
Requested reviews:
maintainers of maas images (maas-images-maintainers)
Related bugs:
Bug #2015363 in maas-images: "MAAS
> Hi Björn, you approved it but left a comment. Do you want me to fix that or it
> is good as is?
>
> I'm fine either way, it's a simple method replace.
Please fix it - we do not want to add any more assertThat()s to MAAS
--
The proposal to merge ~emdw/maas:backport-fix-1959648-to-3.3 into maas:3.3 has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~emdw/maas/+git/maas/+merge/440928
--
Your team MAAS Committers is subscribed to branch maas:3.3.
--
Mailing
Review: Approve
+1 with nitpick
Diff comments:
> diff --git a/systemtests/conftest.py b/systemtests/conftest.py
> index 58fc4aa..b198c97 100644
> --- a/systemtests/conftest.py
> +++ b/systemtests/conftest.py
> @@ -5,6 +5,7 @@ from logging import getLogger
> from typing import TYPE_CHECKING,
Review: Approve
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/440881
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:fix-db-schema.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Diff comments:
> diff --git a/systemtests/conftest.py b/systemtests/conftest.py
> index 58fc4aa..74238e5 100644
> --- a/systemtests/conftest.py
> +++ b/systemtests/conftest.py
> @@ -198,6 +199,18 @@ def pytest_runtest_makereport(item: Any, call: Any) ->
> Iterator[Any]:
>
Review: Approve
--
https://code.launchpad.net/~ack/maas-site-manager/+git/site-manager/+merge/440859
Your team MAAS Committers is subscribed to branch
~ack/maas-site-manager:fix-starlette-warning.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Adam Collard has proposed merging
~adam-collard/maas-ci/+git/system-tests:improve-ansible-performance into
~maas-committers/maas-ci/+git/system-tests:improve-ansible-performance.
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~adam
Diff comments:
> diff --git a/systemtests/conftest.py b/systemtests/conftest.py
> index 58fc4aa..74238e5 100644
> --- a/systemtests/conftest.py
> +++ b/systemtests/conftest.py
> @@ -198,6 +199,18 @@ def pytest_runtest_makereport(item: Any, call: Any) ->
> Iterator[Any]:
>
Review: Needs Information
Diff comments:
> diff --git a/systemtests/fixtures.py b/systemtests/fixtures.py
> index ce4c5cd..0cf6a82 100644
> --- a/systemtests/fixtures.py
> +++ b/systemtests/fixtures.py
> @@ -543,6 +540,8 @@ def maas_region(
> setup_o11y(config["o11y"], maas_container,
Review: Approve
--
https://code.launchpad.net/~igor-brovtsin/maas/+git/maas/+merge/440659
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Diff comments:
> diff --git a/src/maasserver/utils/osystems.py
> b/src/maasserver/utils/osystems.py
> index 9b09303..cb1e6aa 100644
> --- a/src/maasserver/utils/osystems.py
> +++ b/src/maasserver/utils/osystems.py
> @@ -403,6 +404,95 @@ def get_release(string):
> return release
>
>
>
Review: Disapprove
This is not the right approach - will need another look
--
https://code.launchpad.net/~jorge-merlino/maas/+git/maas/+merge/437352
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
--
https://code.launchpad.net/~ack/maas/+git/maas-release-tools/+merge/440400
Your team MAAS Committers is subscribed to branch
~maas-committers/maas/+git/maas-release-tools:main.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
The proposal to merge ~emdw/maas:fix_1959648_ws_vlan_handler_subnet_id_incl
into maas:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~emdw/maas/+git/maas/+merge/440266
--
Your team MAAS Committers is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~emdw/maas/+git/maas/+merge/440266
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
Diff comments:
> diff --git a/src/maasserver/websockets/handlers/vlan.py
> b/src/maasserver/websockets/handlers/vlan.py
> index c642143..7236d2c 100644
> --- a/src/maasserver/websockets/handlers/vlan.py
> +++ b/src/maasserver/websockets/handlers/vlan.py
> @@ -67,6 +67,9
Review: Needs Fixing
--
https://code.launchpad.net/~emdw/maas/+git/maas/+merge/440266
Your team MAAS Committers is subscribed to branch maas:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to : sts-sponsors@lists.launchpad.net
Unsubscribe :
Review: Approve
--
https://code.launchpad.net/~maas-committers/maas-ci/+git/maas-ci-config/+merge/440306
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/maas-ci-config:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Review: Approve
--
https://code.launchpad.net/~maas-committers/maas-ci/+git/maas-ci-config/+merge/440259
Your team MAAS Committers is subscribed to branch
~maas-committers/maas-ci/+git/maas-ci-config:master.
--
Mailing list: https://launchpad.net/~sts-sponsors
Post to :
Diff comments:
> diff --git a/systemtests/ansible.py b/systemtests/ansible.py
> index 7c671c8..b69b96b 100644
> --- a/systemtests/ansible.py
> +++ b/systemtests/ansible.py
> @@ -300,6 +305,8 @@ class AnsibleMain:
> self.ansible_repo_path = "/home/ubuntu/ansible_repo"
>
Review: Approve
nit-picks inline
Diff comments:
> diff --git a/setup.py b/setup.py
> index 21d75cd..3143a0a 100644
> --- a/setup.py
> +++ b/setup.py
> @@ -8,6 +9,7 @@ install_requires = (
> 'pytest-steps',
> 'pyyaml',
> 'retry',
> +'requests',
sort before retry
>
Review: Needs Information
Diff comments:
> diff --git a/stubs/netaddr/ip/__init__.pyi b/stubs/netaddr/ip/__init__.pyi
> new file mode 100644
> index 000..034d875
> --- /dev/null
> +++ b/stubs/netaddr/ip/__init__.pyi
hmm, are we sure we need this? i see typeshed has an entry for netaddr
1 - 100 of 441 matches
Mail list logo
