The proposal to merge
~petermakowski/maas-site-manager:add-eslint-plugin-unused-imports into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/443547
--
Your
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:add-eslint-plugin-unused-imports into
maas-site-manager:main.
Commit message:
test: add eslint-plugin-unused-imports
- fix: remove unused error arg
Requested reviews:
MAAS Committers (maas-committers)
For more details
The proposal to merge ~petermakowski/maas-site-manager:remove-test-warnings
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/443196
--
Your team MAAS
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:remove-test-warnings into
maas-site-manager:main.
Commit message:
remove warnings in tests
- set isDev to read value from NODE_ENV
- render NoRegions inside a table to avoid warnings about invalid DOM nesting
Requested
The proposal to merge
~petermakowski/maas-site-manager:react-hooks-testing-lib-MAASENG-1713 into
maas-site-manager:main has been updated.
Commit message changed to:
chore: remove @testing-library/react-hooks
- use renderHook from @testing-library/react
- update tests to use act
- upgrade all
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:react-hooks-testing-lib-MAASENG-1713 into
maas-site-manager:main.
Commit message:
chore: remove @testing-library/react-hooks
- use renderHook from @testing-library/react
- update tests to use act
Requested reviews:
MAAS
> Is there a better way to select `tbody`?
I think it's one of those rare examples where using specific DOM nodes is fine.
This is a relatively low-level component. Plus, there's no semantic way for
selecting tbody unfortunately.
--
The proposal to merge
~petermakowski/maas-site-manager:header-height-MAASENG-1609 into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442849
--
Your team
The proposal to merge ~petermakowski/maas-site-manager:add-total_machines-key
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442742
--
Your team MAAS
The proposal to merge
~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
Diff comments:
> diff --git a/frontend/src/components/MainLayout/MainLayout.tsx
> b/frontend/src/components/MainLayout/MainLayout.tsx
> index 9be3fca..3fe61c0 100644
> --- a/frontend/src/components/MainLayout/MainLayout.tsx
> +++ b/frontend/src/components/MainLayout/MainLayout.tsx
> @@ -19,21
The proposal to merge
~petermakowski/maas-site-manager:header-height-MAASENG-1609 into
maas-site-manager:main has been updated.
Commit message changed to:
set dynamic header height MAASENG-1609
For more details, see:
The proposal to merge
~petermakowski/maas-site-manager:header-height-MAASENG-1609 into
maas-site-manager:main has been updated.
Description changed to:
Adds DynamicTable component that sets a fixed height for the table body
allowing it to be scrolled independently of the page.
This ensures
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:header-height-MAASENG-1609 into
maas-site-manager:main.
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442849
The proposal to merge
~petermakowski/maas-site-manager:fix-validation-message-cutoff-MAASENG-1611
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
A quick note on `useTokensExportQuery` - I'm not sure react query will be the
right solution for handling file downloads.
In case you're having issues with it, might make sense to use axios directly.
--
I'd suggest adding a static csv file to src/mocks instead of trying to generate
it manually.
In the mock service worker you'll most likely want to use binary response type
https://mswjs.io/docs/recipes/binary-response-type
You'd also need to add header for the response to be handled correctly
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:add-total_machines-key into
maas-site-manager:main.
Commit message:
add total_machines key
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site
> A little bit og the message is still cut off on the tokens page and the bottom
> border also goes hidden when the error message is displayed, screenshot below
> https://imgur.com/a/MADpezy
This is due to the use of fixed height on this page, which will be addressed in
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549
into maas-site-manager:main.
Commit message:
separate context for different views MAASENG-1549
- extract RowSelectionContextProviders
- move app context consumer
The proposal to merge
~petermakowski/maas-site-manager:polling-frequency-value-MAASENG-1545 into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442647
--
The proposal to merge
~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
The proposal to merge
~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549
into maas-site-manager:main has been updated.
Status: Needs review => Work in progress
For more details, see:
The proposal to merge
~petermakowski/maas-site-manager:display-request-errors-MAASENG-1629 into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442646
--
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:separate-context-providers-for-different-views-MAASENG-1549
into maas-site-manager:main.
Commit message:
separate context for different views MAASENG-1549
- extract RowSelectionContextProviders
- move app context consumer
The proposal to merge
~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method
into maas-site-manager:main has been updated.
Description changed to:
QA Steps
Go to /settings/requests
Select a few requests
Press Accept or Deny
Verify the correct API call has been made using
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:MAASENG-1676-requests-endpoint-POST-method
into maas-site-manager:main.
Commit message:
use POST method for requests MAASENG-1676
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:polling-frequency-value-MAASENG-1545 into
maas-site-manager:main with
~petermakowski/maas-site-manager:display-request-errors-MAASENG-1629 as a
prerequisite.
Commit message:
set polling frequency value MAASENG-1545
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:display-request-errors-MAASENG-1629 into
maas-site-manager:main.
Commit message:
display request errors
- add vanilla animation utilities
- update TableCaption width on mobile
- rely on automatic Sentry error capturing instead
The proposal to merge
~petermakowski/maas-site-manager:fix-validation-message-cutoff-MAASENG-1611
into maas-site-manager:main has been updated.
Description changed to:
QA Steps
Enter an invalid value into current page input field
Verify that the error message is displayed correctly
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:fix-validation-message-cutoff-MAASENG-1611
into maas-site-manager:main.
Commit message:
fix: validation message cutoff MAASENG-1611
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https
I noticed you placed tests in TokensListDelete.test.tsx but there is no
component file named TokensListDelete.tsx. Let's follow our convention and
place tests in the file related to the component it's testing (TokensList.tsx,
TokensList.test.tsx).
--
Instead of mocking useDeleteTokensMutation it would be better to return an
error from mock service worker handler for that particular endpoint.
Diff comments:
> diff --git a/frontend/src/components/TokensList/TokensListDelete.test.tsx
>
The proposal to merge
~petermakowski/maas-site-manager:add-VITE_USE_MOCK_DATA-env-var into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442286
--
Your
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:add-VITE_USE_MOCK_DATA-env-var into
maas-site-manager:main.
Commit message:
add VITE_USE_MOCK_DATA env var
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net
Review: Approve
--
https://code.launchpad.net/~nickdv99/maas-site-manager/+git/site-manager/+merge/442192
Your team MAAS Committers is requested to review the proposed merge of
~nickdv99/maas-site-manager:adjust-sticky-styling into maas-site-manager:main.
--
Mailing list:
Diff comments:
> diff --git
> a/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss
> b/frontend/src/components/TokensList/components/TokensTable/_TokensTable.scss
> index 2dd28ec..1793d8e 100644
> ---
>
Diff comments:
> diff --git a/frontend/src/components/TokensList/_TokensList.scss
> b/frontend/src/components/TokensList/_TokensList.scss
> index 3171cbd..cf0fca6 100644
> --- a/frontend/src/components/TokensList/_TokensList.scss
> +++ b/frontend/src/components/TokensList/_TokensList.scss
>
The proposal to merge ~petermakowski/maas-site-manager:enable-stylelint into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442220
--
Your team MAAS
The proposal to merge ~petermakowski/maas-site-manager:enable-stylelint into
maas-site-manager:main has been updated.
Description changed to:
QA Steps
Go to /settings/requests
Inspect the pagination input component
Verify that the expected browser prefix is present (-moz-appearance)
For more
Diff comments:
> diff --git
> a/frontend/src/components/base/TablePagination/_TablePagination.scss
> b/frontend/src/components/base/TablePagination/_TablePagination.scss
> index c663d8f..3c96af4 100644
> --- a/frontend/src/components/base/TablePagination/_TablePagination.scss
> +++
Diff comments:
> diff --git a/frontend/src/_settings.scss b/frontend/src/_settings.scss
> index 0588138..bdcb88c 100644
> --- a/frontend/src/_settings.scss
> +++ b/frontend/src/_settings.scss
> @@ -2,11 +2,9 @@
>
> // Vanilla settings:
> $grid-max-width: math.div(1920, 16) * 1rem;
> -
>
Diff comments:
> diff --git a/frontend/src/_settings.scss b/frontend/src/_settings.scss
> index 0588138..bdcb88c 100644
> --- a/frontend/src/_settings.scss
> +++ b/frontend/src/_settings.scss
> @@ -2,11 +2,9 @@
>
> // Vanilla settings:
> $grid-max-width: math.div(1920, 16) * 1rem;
> -
>
The proposal to merge ~petermakowski/maas-site-manager:enable-stylelint into
maas-site-manager:main has been updated.
Commit message changed to:
enable stylelint
- fix existing stylelint errors via stylelint --fix
For more details, see:
Diff comments:
> diff --git a/frontend/src/_settings.scss b/frontend/src/_settings.scss
> index 0588138..bdcb88c 100644
> --- a/frontend/src/_settings.scss
> +++ b/frontend/src/_settings.scss
> @@ -2,11 +2,9 @@
>
> // Vanilla settings:
> $grid-max-width: math.div(1920, 16) * 1rem;
> -
>
The proposal to merge
~petermakowski/maas-site-manager:remove-region-dialog-MAASENG-1559 into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442206
--
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:enable-stylelint into maas-site-manager:main.
Commit message:
enable stylelint
- fix existing stylelint errors
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net
The proposal to merge
~petermakowski/maas-site-manager:remove-region-dialog-MAASENG-1559 into
maas-site-manager:main has been updated.
Description changed to:
https://warthogs.atlassian.net/browse/MAASENG-1559
https://warthogs.atlassian.net/browse/MAASENG-1500
QA Steps
go to /sites
select a
The proposal to merge
~petermakowski/maas-site-manager:remove-region-dialog-MAASENG-1559 into
maas-site-manager:main has been updated.
Commit message changed to:
add useSiteQueryData hook
- rename hooks/api to hooks/react-query
For more details, see:
The proposal to merge
~petermakowski/maas-site-manager:remove-region-dialog-MAASENG-1559 into
maas-site-manager:main has been updated.
Commit message changed to:
add useSiteQueryData hook
- rename hooks/api to hooks/react-query
- MAASENG-1500
- MAASENG-1559
For more details, see:
Diff comments:
> diff --git a/frontend/src/components/Navigation/Navigation.tsx
> b/frontend/src/components/Navigation/Navigation.tsx
> index 701e93c..1b39a24 100644
> --- a/frontend/src/components/Navigation/Navigation.tsx
> +++ b/frontend/src/components/Navigation/Navigation.tsx
> @@ -37,6
This works great, but would be good to get rid of arbitrary height values. Have
you tried using grid with grid-auto-rows on the container?
https://developer.mozilla.org/en-US/docs/Web/CSS/grid-auto-rows
Diff comments:
> diff --git a/frontend/src/components/TokensList/TokensList.tsx
>
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:remove-region-dialog-MAASENG-1559 into
maas-site-manager:main.
Commit message:
add useSiteQueryData hook
- rename hooks/api to hooks/react-query
Requested reviews:
MAAS Committers (maas-committers)
For more details, see
The proposal to merge ~petermakowski/maas-site-manager:update-frontend-deps
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442178
--
Your team MAAS
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:update-frontend-deps into
maas-site-manager:main.
Commit message:
chore(deps): update all front-end deps
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~petermakowski
The proposal to merge
~petermakowski/maas-site-manager:refactor-auth-context-useReducer into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442091
--
Your
Diff comments:
> diff --git a/frontend/src/components/TokensList/_TokensList.scss
> b/frontend/src/components/TokensList/_TokensList.scss
> new file mode 100644
> index 000..25d995b
> --- /dev/null
> +++ b/frontend/src/components/TokensList/_TokensList.scss
> @@ -0,0 +1,7 @@
>
Diff comments:
> diff --git a/frontend/src/components/TokensList/_TokensList.scss
> b/frontend/src/components/TokensList/_TokensList.scss
> new file mode 100644
> index 000..25d995b
> --- /dev/null
> +++ b/frontend/src/components/TokensList/_TokensList.scss
> @@ -0,0 +1,7 @@
>
The proposal to merge
~petermakowski/maas-site-manager:refactor-auth-context-useReducer into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442091
--
Your
The proposal to merge
~petermakowski/maas-site-manager:refactor-auth-context-useReducer into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442091
--
Your
The proposal to merge ~petermakowski/maas-site-manager:strict-router-types into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441882
--
Your team MAAS
The proposal to merge
~petermakowski/maas-site-manager:invalidate-queries-on-mutation into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442026
--
Your
The proposal to merge ~petermakowski/maas-site-manager:strict-router-types into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441882
--
Your team MAAS
The proposal to merge ~petermakowski/maas-site-manager:strict-router-types into
maas-site-manager:main has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441882
--
Your team MAAS
The proposal to merge ~petermakowski/maas-site-manager:strict-router-types into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441882
--
Your team MAAS
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:refactor-auth-context-useReducer into
maas-site-manager:main.
Commit message:
refactor: auth context useReducer
- split context providers into AppContext and AuthContext
Requested reviews:
MAAS Committers (maas-committers
The proposal to merge
~petermakowski/maas-site-manager:invalidate-queries-on-mutation into
maas-site-manager:main has been updated.
Description changed to:
QA Steps
Go to /settings/tokens
Open developer tools in the network tab
Select a token and click Delete
Verify that a /tokens DELETE
The proposal to merge
~petermakowski/maas-site-manager:invalidate-queries-on-mutation into
maas-site-manager:main has been updated.
Description changed to:
QA Steps
Go to /tokens
Open developer tools in the network tab
Select a token and click Delete
Verify that a DELETE request has been made
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:invalidate-queries-on-mutation into
maas-site-manager:main.
Commit message:
invalidate queries on mutation success
- fix displayed dates by using internal UTC formatting util functions
- update token post data to match back
The proposal to merge ~petermakowski/maas-site-manager:fix-iso-duration-value
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441958
--
Your team MAAS
The proposal to merge ~petermakowski/maas-site-manager:pagination-e2e-test into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442000
--
Your team MAAS
The proposal to merge
~petermakowski/maas-site-manager:non-unique-name-MAASENG-1578 into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/442008
--
Your
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:non-unique-name-MAASENG-1578 into
maas-site-manager:main.
Commit message:
add non-unique name warning MAASENG-1578
- remove default TooltipButton iconName
Requested reviews:
MAAS Lander (maas-lander): unittests
MAAS
The proposal to merge
~petermakowski/maas-site-manager:non-unique-name-MAASENG-1578 into
maas-site-manager:main has been updated.
Description changed to:
design spec: https://zpl.io/Z0vYxwq
QA Steps
go to /sites
hover over any displayed warning icons in the name column
verify that the correct
The proposal to merge ~petermakowski/maas-site-manager:fix-iso-duration-value
into maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441958
--
Your team MAAS
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:pagination-e2e-test into
maas-site-manager:main.
Commit message:
fix pagination input index
- add e2e test for pagination
- add playwright yarn scripts
Requested reviews:
MAAS Committers (maas-committers)
For more details
Diff comments:
> diff --git a/frontend/src/components/base/TablePagination/TablePagination.tsx
> b/frontend/src/components/base/TablePagination/TablePagination.tsx
> index c716638..070f187 100644
> --- a/frontend/src/components/base/TablePagination/TablePagination.tsx
> +++
The proposal to merge ~petermakowski/maas-site-manager:add-a11y-tests into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441890
--
Your team MAAS
The proposal to merge
~petermakowski/maas-site-manager:connection-column-MAASENG-1557 into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441938
--
Your
The proposal to merge
~petermakowski/maas-site-manager:fix-validation-onSubmit-MAASENG-1571 into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441949
--
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:fix-iso-duration-value into
maas-site-manager:main.
Commit message:
fix: use reduced iso duration format
Requested reviews:
MAAS Lander (maas-lander): unittests
MAAS Committers (maas-committers)
For more details, see
The proposal to merge
~petermakowski/maas-site-manager:connection-column-MAASENG-1557 into
maas-site-manager:main has been updated.
Commit message changed to:
update connection column MAASENG-1557
- fix line-height 0 text collapsing issue
- cleanup redundant table resizer code
- update
Diff comments:
> diff --git a/frontend/src/components/TokensCreate/TokensCreate.test.tsx
> b/frontend/src/components/TokensCreate/TokensCreate.test.tsx
> index 2519f7f..4665b36 100644
> --- a/frontend/src/components/TokensCreate/TokensCreate.test.tsx
> +++
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:fix-validation-onSubmit-MAASENG-1571 into
maas-site-manager:main.
Commit message:
fix validation onSubmit MAASENG-1571
Requested reviews:
MAAS Lander (maas-lander): unittests
MAAS Committers (maas-committers)
For more
The proposal to merge ~petermakowski/maas-site-manager:add-a11y-tests into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441890
--
Your team MAAS
The proposal to merge ~petermakowski/maas-site-manager:add-a11y-tests into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441890
--
Your team MAAS
The proposal to merge ~petermakowski/maas-site-manager:fix-mobile-nav into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441918
--
Your team MAAS
Diff comments:
> diff --git
> a/frontend/src/components/TokensList/components/TokensTable/TokensTable.tsx
> b/frontend/src/components/TokensList/components/TokensTable/TokensTable.tsx
> index a4c2b15..a6a4354 100644
> ---
>
Peter Makowski has proposed merging
~petermakowski/maas-site-manager:connection-column-MAASENG-1557 into
maas-site-manager:main.
Commit message:
update connection column MAASENG-1557
- fix line-height 0 text collapsing issue
- cleanup redundant table resizer code
Requested reviews:
MAAS
The proposal to merge ~petermakowski/maas-site-manager:update-api-shapes into
maas-site-manager:main has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/441774
--
Your team MAAS
The proposal to merge ~petermakowski/maas-site-manager:update-api-shapes into
maas-site-manager:main has been updated.
Description changed to:
- update API data shapes
- update pagination to start at index 1
QA Steps
Go to sites, tokens, and requests pages and make sure they load correctly
The proposal to merge ~petermakowski/maas-site-manager:fix-mobile-nav into
maas-site-manager:main has been updated.
Commit message changed to:
fix: primary and secondary navigation on mobile
- hide secondary navigation on mobile
- fix primary navigation collapse on mobile
- simplify stylesheet
The proposal to merge ~petermakowski/maas-site-manager:fix-mobile-nav into
maas-site-manager:main has been updated.
Description changed to:
### QA Steps
Open google chrome
Go to MAAS Site Manager
Toggle device toolbar (ctrl/cmd + shift + M)
Choose mobile phone dimensions (e.g. Google Pixel)
Go
The proposal to merge ~petermakowski/maas-site-manager:fix-mobile-nav into
maas-site-manager:main has been updated.
Description changed to:
### QA Steps
Open google chrome
Go to MAAS Site Manager
Toggle device toolbar (ctrl/cmd + shift + M)
Choose mobile phone dimensions (e.g. Google Pixel)
Go
The proposal to merge ~petermakowski/maas-site-manager:fix-mobile-nav into
maas-site-manager:main has been updated.
Description changed to:
### QA Steps
Open google chrome
Go to MAAS Site Manager
Toggle device toolbar (ctrl/cmd + shift + M)
Choose mobile phone dimensions (e.g. Google Pixel)
Go
The proposal to merge ~petermakowski/maas-site-manager:fix-mobile-nav into
maas-site-manager:main has been updated.
Description changed to:
### QA Steps
Open google chrome
Go to MAAS Site Manager
Toggle device toolbar (ctrl/cmd + shift + M)
Choose mobile phone dimensions (e.g. Google Pixel)
Go
The proposal to merge ~petermakowski/maas-site-manager:fix-mobile-nav into
maas-site-manager:main has been updated.
Description changed to:
### QA Steps
Open google chrome
Go to MAAS Site Manager
Toggle device toolbar (ctrl/cmd + shift + M)
Choose mobile phone dimensions (e.g. Google Pixel)
Go
The proposal to merge ~petermakowski/maas-site-manager:fix-mobile-nav into
maas-site-manager:main has been updated.
Description changed to:
### QA Steps
Open google chrome
Go to MAAS Site Manager
Toggle device toolbar (ctrl/cmd + shift + M)
Choose mobile phone dimensions (e.g. Google Pixel)
Go
The proposal to merge ~petermakowski/maas-site-manager:fix-mobile-nav into
maas-site-manager:main has been updated.
Description changed to:
### QA Steps
Open google chrome
Go to MAAS Site Manager
Toggle device toolbar (ctrl/cmd + shift + M)
Choose mobile phone dimensions (e.g. Google Pixel)
Go
The proposal to merge ~petermakowski/maas-site-manager:fix-mobile-nav into
maas-site-manager:main has been updated.
Description changed to:
### QA Steps
Open google chrome
Go to MAAS Site Manager
Toggle device toolbar (ctrl/cmd + shift + M)
Choose mobile phone dimensions (e.g. Google Pixel)
Go
1 - 100 of 312 matches
Mail list logo
