> On 13. Jan 2021, at 16:33, Kyle Evans wrote:
>
> On Wed, Jan 13, 2021 at 9:31 AM Michael Tuexen wrote:
>>
>>> On 13. Jan 2021, at 16:16, Kyle Evans wrote:
>>>
>>> On Wed, Jan 6, 2021 at 9:01 AM Kyle Evans wrote:
>>>>
>
> On 13. Jan 2021, at 16:33, Kyle Evans wrote:
>
> On Wed, Jan 13, 2021 at 9:31 AM Michael Tuexen wrote:
>>
>>> On 13. Jan 2021, at 16:16, Kyle Evans wrote:
>>>
>>> On Wed, Jan 6, 2021 at 9:01 AM Kyle Evans wrote:
>>>>
>
> On 13. Jan 2021, at 16:16, Kyle Evans wrote:
>
> On Wed, Jan 6, 2021 at 9:01 AM Kyle Evans wrote:
>>
>> On Mon, Nov 30, 2020 at 3:45 AM Michael Tuexen wrote:
>>>
>>> Author: tuexen
>>> Date: Mon Nov 30 09:45:44 2020
>>> New Revis
Author: tuexen
Date: Fri Dec 18 10:13:28 2020
New Revision: 368757
URL: https://svnweb.freebsd.org/changeset/base/368757
Log:
MFC r368593:
Clean up more resouces of an existing SCTP association in case of
a restart.
This fixes a use-after-free scenario, which was reported by Felix
Author: tuexen
Date: Fri Dec 18 10:08:11 2020
New Revision: 368755
URL: https://svnweb.freebsd.org/changeset/base/368755
Log:
MFC r368394:
When dropping packets (RRQ or WRQ) for debugging, report the send
operation as successful. Reporting a failure stops the transfer
instead of using
Author: tuexen
Date: Tue Dec 15 09:43:18 2020
New Revision: 368657
URL: https://svnweb.freebsd.org/changeset/base/368657
Log:
When receiving a file having a length, which is a mulitple of the blocksize,
close the file once it is received.
Reported by: Timo Voelker
MFC after:1 week
Author: tuexen
Date: Mon Dec 14 22:13:58 2020
New Revision: 368647
URL: https://svnweb.freebsd.org/changeset/base/368647
Log:
Improve the counting of blocks used to transfer a file from the
server to the client in case of not using an OACK: Don't miss
the first block in case of it is not
Author: tuexen
Date: Sun Dec 13 23:51:51 2020
New Revision: 368622
URL: https://svnweb.freebsd.org/changeset/base/368622
Log:
Harden the handling of outgoing streams in case of an restart or INIT
collision. This avouds an out-of-bounce access in case the peer can
break the cookie signature.
Author: tuexen
Date: Sat Dec 12 22:23:45 2020
New Revision: 368593
URL: https://svnweb.freebsd.org/changeset/base/368593
Log:
Clean up more resouces of an existing SCTP association in case of
a restart.
This fixes a use-after-free scenario, which was reported by Felix
Wilhelm from
Author: tuexen
Date: Thu Dec 10 19:36:33 2020
New Revision: 368521
URL: https://svnweb.freebsd.org/changeset/base/368521
Log:
Fix the TFTP client when performing a RRQ for files smaller than 512 bytes
and the server not sending an OACK:
* Close the file.
* Report the correct the number of
Author: tuexen
Date: Sun Dec 6 18:43:12 2020
New Revision: 368394
URL: https://svnweb.freebsd.org/changeset/base/368394
Log:
When dropping packets (RRQ or WRQ) for debugging, report the send
operation as successful. Reporting a failure stops the transfer
instead of using timeouts.
MFC
> On 29. Nov 2020, at 20:38, Matt Macy wrote:
>
> Author: mmacy
> Date: Sun Nov 29 19:38:03 2020
> New Revision: 368163
> URL: https://svnweb.freebsd.org/changeset/base/368163
>
> Log:
> Import kernel WireGuard support
>
> Data path largely shared with the OpenBSD implementation by
>
Author: tuexen
Date: Mon Nov 30 10:58:06 2020
New Revision: 368183
URL: https://svnweb.freebsd.org/changeset/base/368183
Log:
MFC r367530:
RFC 7323 specifies that:
* TCP segments without timestamps should be dropped when support for
the timestamp option has been negotiated.
* TCP
> On 30. Nov 2020, at 08:01, Michal Meloun wrote:
>
> Author: mmel
> Date: Mon Nov 30 07:01:12 2020
> New Revision: 368167
> URL: https://svnweb.freebsd.org/changeset/base/368167
>
> Log:
> NVME: Don't try to swap data on little endian machines.
> These swapping functions violate BUSDMA
Author: tuexen
Date: Mon Nov 30 09:45:44 2020
New Revision: 368181
URL: https://svnweb.freebsd.org/changeset/base/368181
Log:
MFC r367530:
RFC 7323 specifies that:
* TCP segments without timestamps should be dropped when support for
the timestamp option has been negotiated.
* TCP
Author: tuexen
Date: Mon Nov 30 09:22:33 2020
New Revision: 368180
URL: https://svnweb.freebsd.org/changeset/base/368180
Log:
MFC r367520:
Fix a potential use-after-free bug introduced in
https://svnweb.freebsd.org/changeset/base/363046
Thanks to Taylor Brandstetter for finding this
Author: tuexen
Date: Mon Nov 30 09:21:01 2020
New Revision: 368179
URL: https://svnweb.freebsd.org/changeset/base/368179
Log:
MFC r367464:
The ioctl() calls using FIONREAD, FIONWRITE, FIONSPACE, and SIOCATMARK
access the socket send or receive buffer. This is not possible for
listening
Author: tuexen
Date: Mon Nov 30 09:18:13 2020
New Revision: 368178
URL: https://svnweb.freebsd.org/changeset/base/368178
Log:
MFC r366750:
Improve the handling of cookie life times.
The staleness reported in an error cause is in us, not ms.
Enforce limits on the life time via sysct;
Author: tuexen
Date: Mon Nov 30 09:16:51 2020
New Revision: 368177
URL: https://svnweb.freebsd.org/changeset/base/368177
Log:
MFC r366517:
Minor cleanups.
Modified:
stable/12/sys/netinet/sctp_cc_functions.c
stable/12/sys/netinet/sctp_output.c
Directory Properties:
stable/12/
Author: tuexen
Date: Mon Nov 30 09:15:30 2020
New Revision: 368176
URL: https://svnweb.freebsd.org/changeset/base/368176
Log:
MFC r366489:
Reset delayed SACK state when restarting an SCTP association.
Modified:
stable/12/sys/netinet/sctp_input.c
Directory Properties:
stable/12/
Author: tuexen
Date: Mon Nov 30 09:14:01 2020
New Revision: 368175
URL: https://svnweb.freebsd.org/changeset/base/368175
Log:
MFC r366483:
Ensure variables are initialized before used.
Modified:
stable/12/sys/netinet/sctp_input.c
stable/12/sys/netinet/sctp_pcb.c
Directory Properties:
Author: tuexen
Date: Mon Nov 30 09:12:45 2020
New Revision: 368174
URL: https://svnweb.freebsd.org/changeset/base/368174
Log:
MFC r366482:
Remove dead stores reported by clang static code analysis
Modified:
stable/12/sys/netinet/sctp_input.c
stable/12/sys/netinet/sctp_output.c
Author: tuexen
Date: Mon Nov 30 09:11:24 2020
New Revision: 368173
URL: https://svnweb.freebsd.org/changeset/base/368173
Log:
MFC r366480:
Cleanup, no functional change intended.
Modified:
stable/12/sys/netinet/sctp_usrreq.c
Directory Properties:
stable/12/ (props changed)
Author: tuexen
Date: Mon Nov 30 09:10:05 2020
New Revision: 368172
URL: https://svnweb.freebsd.org/changeset/base/368172
Log:
MFC 366474:
Whitespace changes.
Modified:
stable/12/sys/netinet/sctp_input.c
Directory Properties:
stable/12/ (props changed)
Modified:
Author: tuexen
Date: Mon Nov 30 09:08:51 2020
New Revision: 368171
URL: https://svnweb.freebsd.org/changeset/base/368171
Log:
MFC r366426:
Use __func__ instead of __FUNCTION__ for consistency.
Modified:
stable/12/sys/netinet/sctp_bsd_addr.c
stable/12/sys/netinet/sctp_indata.c
Author: tuexen
Date: Mon Nov 30 09:07:21 2020
New Revision: 368170
URL: https://svnweb.freebsd.org/changeset/base/368170
Log:
MFC r366425:
Cleanup, no functional change intended.
Modified:
stable/12/sys/netinet/sctp_indata.c
Directory Properties:
stable/12/ (props changed)
Author: tuexen
Date: Mon Nov 23 10:13:56 2020
New Revision: 367946
URL: https://svnweb.freebsd.org/changeset/base/367946
Log:
Fix two occurences of a typo in a comment introduced in r367530.
Reported by: lstewart@
MFC after:1 week
Differential Revision:
On 20. Nov 2020, at 00:13, John Baldwin wrote:
>
> On 11/19/20 2:55 PM, John Baldwin wrote:
>> On 11/9/20 1:49 PM, Michael Tuexen wrote:
>>> Author: tuexen
>>> Date: Mon Nov 9 21:49:40 2020
>>> New Revision: 367530
>>> URL: https://svnweb.freebsd.
Author: tuexen
Date: Fri Nov 20 13:00:28 2020
New Revision: 367891
URL: https://svnweb.freebsd.org/changeset/base/367891
Log:
Fix an issue I introuced in r367530: tcp_twcheck() can be called
with to == NULL for SYN segments. So don't assume tp != NULL.
Thanks to jhb@ for reporting and
> On 20. Nov 2020, at 00:13, John Baldwin wrote:
>
> On 11/19/20 2:55 PM, John Baldwin wrote:
>> On 11/9/20 1:49 PM, Michael Tuexen wrote:
>>> Author: tuexen
>>> Date: Mon Nov 9 21:49:40 2020
>>> New Revision: 367530
>>> URL: https://sv
Author: tuexen
Date: Mon Nov 9 21:49:40 2020
New Revision: 367530
URL: https://svnweb.freebsd.org/changeset/base/367530
Log:
RFC 7323 specifies that:
* TCP segments without timestamps should be dropped when support for
the timestamp option has been negotiated.
* TCP segments with
Author: tuexen
Date: Mon Nov 9 13:12:07 2020
New Revision: 367520
URL: https://svnweb.freebsd.org/changeset/base/367520
Log:
Fix a potential use-after-free bug introduced in
https://svnweb.freebsd.org/changeset/base/363046
Thanks to Taylor Brandstetter for finding this issue using fuzz
Author: tuexen
Date: Sat Nov 7 21:17:49 2020
New Revision: 367464
URL: https://svnweb.freebsd.org/changeset/base/367464
Log:
The ioctl() calls using FIONREAD, FIONWRITE, FIONSPACE, and SIOCATMARK
access the socket send or receive buffer. This is not possible for
listening sockets since
Author: tuexen
Date: Fri Oct 16 10:44:48 2020
New Revision: 366750
URL: https://svnweb.freebsd.org/changeset/base/366750
Log:
Improve the handling of cookie life times.
The staleness reported in an error cause is in us, not ms.
Enforce limits on the life time via sysct; and socket options
Author: tuexen
Date: Wed Oct 7 15:22:48 2020
New Revision: 366517
URL: https://svnweb.freebsd.org/changeset/base/366517
Log:
Minor cleanups.
MFC after:3 days
Modified:
head/sys/netinet/sctp_cc_functions.c
head/sys/netinet/sctp_output.c
Modified:
Author: tuexen
Date: Tue Oct 6 14:26:05 2020
New Revision: 366489
URL: https://svnweb.freebsd.org/changeset/base/366489
Log:
Reset delayed SACK state when restarting an SCTP association.
MFC after:3 days
Modified:
head/sys/netinet/sctp_input.c
Modified:
Author: tuexen
Date: Tue Oct 6 11:29:08 2020
New Revision: 366483
URL: https://svnweb.freebsd.org/changeset/base/366483
Log:
Ensure variables are initialized before used.
MFC after:3 days
Modified:
head/sys/netinet/sctp_input.c
head/sys/netinet/sctp_pcb.c
Modified:
Author: tuexen
Date: Tue Oct 6 11:08:52 2020
New Revision: 366482
URL: https://svnweb.freebsd.org/changeset/base/366482
Log:
Remove dead stores reported by clang static code analysis
MFC after:3 days
Modified:
head/sys/netinet/sctp_input.c
head/sys/netinet/sctp_output.c
Author: tuexen
Date: Tue Oct 6 10:41:04 2020
New Revision: 366480
URL: https://svnweb.freebsd.org/changeset/base/366480
Log:
Cleanup, no functional change intended.
MFC after:3 days
Modified:
head/sys/netinet/sctp_usrreq.c
Modified: head/sys/netinet/sctp_usrreq.c
Author: tuexen
Date: Tue Oct 6 09:51:40 2020
New Revision: 366474
URL: https://svnweb.freebsd.org/changeset/base/366474
Log:
Whitespace changes.
MFC after:3 days
Modified:
head/sys/netinet/sctp_input.c
Modified: head/sys/netinet/sctp_input.c
Author: tuexen
Date: Sun Oct 4 15:37:34 2020
New Revision: 366426
URL: https://svnweb.freebsd.org/changeset/base/366426
Log:
Use __func__ instead of __FUNCTION__ for consistency.
MFC after:3 days
Modified:
head/sys/netinet/sctp_bsd_addr.c
head/sys/netinet/sctp_indata.c
Author: tuexen
Date: Sun Oct 4 15:22:14 2020
New Revision: 366425
URL: https://svnweb.freebsd.org/changeset/base/366425
Log:
Cleanup, no functional change intended.
MFC after:3 days
Modified:
head/sys/netinet/sctp_indata.c
Modified: head/sys/netinet/sctp_indata.c
> On 1. Oct 2020, at 21:17, Bryan Drewery wrote:
>
> Author: bdrewery
> Date: Thu Oct 1 19:17:03 2020
> New Revision: 366340
> URL: https://svnweb.freebsd.org/changeset/base/366340
>
> Log:
> Use unlocked page lookup for inmem() to avoid object lock contention
>
> Reviewed By: kib, markj
>
Author: tuexen
Date: Thu Oct 1 18:17:56 2020
New Revision: 366335
URL: https://svnweb.freebsd.org/changeset/base/366335
Log:
MFS r366324:
Improve the handling of receiving unordered and unreliable user
messages using DATA chunks. Don't use fsn_included when not being
sure that it is set
Author: tuexen
Date: Thu Oct 1 16:53:16 2020
New Revision: 366329
URL: https://svnweb.freebsd.org/changeset/base/366329
Log:
MFC r366248:
Improve the input validation and processing of cookies.
This avoids setting the association in an inconsistent
state, which could result in a
Author: tuexen
Date: Thu Oct 1 16:25:35 2020
New Revision: 366326
URL: https://svnweb.freebsd.org/changeset/base/366326
Log:
MFC r366226:
Minor cleanup.
Modified:
stable/12/sys/netinet/sctp_pcb.c
Directory Properties:
stable/12/ (props changed)
Modified:
Author: tuexen
Date: Thu Oct 1 16:24:28 2020
New Revision: 366325
URL: https://svnweb.freebsd.org/changeset/base/366325
Log:
MFC r366199:
Cleanup, no functional change intended.
Modified:
stable/12/sys/netinet/sctp_indata.c
Directory Properties:
stable/12/ (props changed)
Author: tuexen
Date: Thu Oct 1 16:23:35 2020
New Revision: 366324
URL: https://svnweb.freebsd.org/changeset/base/366324
Log:
MFC r366198:
Improve the handling of receiving unordered and unreliable user
messages using DATA chunks. Don't use fsn_included when not being
sure that it is set
Author: tuexen
Date: Thu Oct 1 16:22:34 2020
New Revision: 366323
URL: https://svnweb.freebsd.org/changeset/base/366323
Log:
MFC r366114:
Whitespace changes.
Modified:
stable/12/sys/netinet/sctp_cc_functions.c
stable/12/sys/netinet/sctp_header.h
stable/12/sys/netinet/sctp_indata.c
Author: tuexen
Date: Thu Oct 1 16:18:49 2020
New Revision: 366322
URL: https://svnweb.freebsd.org/changeset/base/366322
Log:
MFC r365688:
Add a -C option to netstat to display the congestion control for
TCP connections.
Modified:
stable/12/usr.bin/netstat/inet.c
Author: tuexen
Date: Thu Oct 1 16:14:00 2020
New Revision: 366321
URL: https://svnweb.freebsd.org/changeset/base/366321
Log:
MFC r365687:
Add a -C option to sockstat to display the congestion control for TCP
connections.
Modified:
stable/12/usr.bin/sockstat/sockstat.1
Author: tuexen
Date: Thu Oct 1 16:11:08 2020
New Revision: 366320
URL: https://svnweb.freebsd.org/changeset/base/366320
Log:
MFC r365686:
Export the name of the congestion control. This will be used by sockstat
and netstat.
Modified:
stable/12/sys/netinet/tcp_subr.c
Author: tuexen
Date: Thu Oct 1 16:09:23 2020
New Revision: 366319
URL: https://svnweb.freebsd.org/changeset/base/366319
Log:
MFC r365685:
Add a -t option to traceroute6 to control the traffic class used when
sending probe packets.
Modified:
stable/12/usr.sbin/traceroute6/traceroute6.8
Author: tuexen
Date: Tue Sep 29 09:36:06 2020
New Revision: 366248
URL: https://svnweb.freebsd.org/changeset/base/366248
Log:
Improve the input validation and processing of cookies.
This avoids setting the association in an inconsistent
state, which could result in a use-after-free
Author: tuexen
Date: Mon Sep 28 14:11:53 2020
New Revision: 366226
URL: https://svnweb.freebsd.org/changeset/base/366226
Log:
Minor cleanup.
MFC after:3 days
Modified:
head/sys/netinet/sctp_pcb.c
Modified: head/sys/netinet/sctp_pcb.c
Author: tuexen
Date: Sun Sep 27 13:32:02 2020
New Revision: 366199
URL: https://svnweb.freebsd.org/changeset/base/366199
Log:
Cleanup, no functional change intended.
MFC after:3 days
Modified:
head/sys/netinet/sctp_indata.c
Modified: head/sys/netinet/sctp_indata.c
Author: tuexen
Date: Sun Sep 27 13:24:01 2020
New Revision: 366198
URL: https://svnweb.freebsd.org/changeset/base/366198
Log:
Improve the handling of receiving unordered and unreliable user
messages using DATA chunks. Don't use fsn_included when not being
sure that it is set to an
Author: tuexen
Date: Thu Sep 24 12:26:06 2020
New Revision: 366114
URL: https://svnweb.freebsd.org/changeset/base/366114
Log:
Whitespace changes.
MFC after:3 days
Modified:
head/sys/netinet/sctp_cc_functions.c
head/sys/netinet/sctp_header.h
head/sys/netinet/sctp_indata.c
Author: tuexen
Date: Sun Sep 13 09:14:32 2020
New Revision: 365688
URL: https://svnweb.freebsd.org/changeset/base/365688
Log:
Add a -C option to netstat to display the congestion control for
TCP connections.
Reviewed by: rscheff
MFC after:1 week
Sponsored by:
Author: tuexen
Date: Sun Sep 13 09:12:25 2020
New Revision: 365687
URL: https://svnweb.freebsd.org/changeset/base/365687
Log:
Add a -C option to sockstat to display the congestion control for TCP
connections.
Reviewed by: rscheff
MFC after:1 week
Sponsored by:
Author: tuexen
Date: Sun Sep 13 09:06:50 2020
New Revision: 365686
URL: https://svnweb.freebsd.org/changeset/base/365686
Log:
Export the name of the congestion control. This will be used by sockstat
and netstat.
Reviewed by: rscheff
MFC after:1 week
Sponsored by:
Author: tuexen
Date: Sun Sep 13 09:00:00 2020
New Revision: 365685
URL: https://svnweb.freebsd.org/changeset/base/365685
Log:
Add a -t option to traceroute6 to control the traffic class used when
sending probe packets.
Reviewed by: rscheff
MFC after:1 week
Author: tuexen
Date: Sat Sep 12 11:24:36 2020
New Revision: 365658
URL: https://svnweb.freebsd.org/changeset/base/365658
Log:
Fix the length of probe packets when using UDP.
Since https://svnweb.freebsd.org/changeset/base/365378 a raw socket is
used for sending UDP probe packets instead of
Author: tuexen
Date: Sat Sep 12 11:19:54 2020
New Revision: 365657
URL: https://svnweb.freebsd.org/changeset/base/365657
Log:
Simplify code, no functional change.
Since https://svnweb.freebsd.org/base?view=revision=365378
UDP is handled the same way as SCTP and TCP (using a raw socket).
Author: tuexen
Date: Thu Sep 10 18:04:34 2020
New Revision: 365604
URL: https://svnweb.freebsd.org/changeset/base/365604
Log:
MFC r350061:
Fix compilation on platforms using gcc.
When compiling RACK on platforms using gcc, a warning that tcp_outflags
is defined but not used is issued and
Author: tuexen
Date: Thu Sep 10 17:49:21 2020
New Revision: 365601
URL: https://svnweb.freebsd.org/changeset/base/365601
Log:
MFC r356417 (from rrs):
This catches rack up in the recent changes to ECN and
also commonizes the functions that both the freebsd and
rack stack uses.
Modified:
Author: tuexen
Date: Thu Sep 10 17:44:27 2020
New Revision: 365598
URL: https://svnweb.freebsd.org/changeset/base/365598
Log:
MFC r353490 (from rrs):
if_hw_tsomaxsegsize needs to be initialized to zero, just
like in bbr.c and tcp_output.c
Modified:
stable/12/sys/netinet/tcp_stacks/rack.c
Author: tuexen
Date: Thu Sep 10 17:41:23 2020
New Revision: 365597
URL: https://svnweb.freebsd.org/changeset/base/365597
Log:
MFC r352661 (from rrs):
lets put (void) in a couple of functions to keep older platforms that
are stuck with gcc happy (ppc). The changes are needed in both bbr and
Author: tuexen
Date: Thu Sep 10 17:31:34 2020
New Revision: 365596
URL: https://svnweb.freebsd.org/changeset/base/365596
Log:
MFC r351782:
Fix two TCP RACK issues:
* Convert the TCP delayed ACK timer from ms to ticks as required.
This fixes the timer on platforms with hz != 1000.
*
Author: tuexen
Date: Thu Sep 10 17:29:20 2020
New Revision: 365595
URL: https://svnweb.freebsd.org/changeset/base/365595
Log:
MFC r351328 (by rrs):
Fix an issue when TSO and Rack play together. Basically
an retransmission of the initial SYN (with data) would
cause us to strip the SYN and
Author: tuexen
Date: Thu Sep 10 17:26:16 2020
New Revision: 365594
URL: https://svnweb.freebsd.org/changeset/base/365594
Log:
MFC r350973 (from rrs):
Place back in the dependency on HPTS via module depends versus
a fatal error in compiling. This was taken out by mistake
when I mis-merged
Author: tuexen
Date: Thu Sep 10 17:12:42 2020
New Revision: 365591
URL: https://svnweb.freebsd.org/changeset/base/365591
Log:
MFC r364754:
RFC 3465 defines a limit L used in TCP slow start for limiting the number
of acked bytes as described in Section 2.2 of that document.
This patch
Author: tuexen
Date: Thu Sep 10 17:03:36 2020
New Revision: 365590
URL: https://svnweb.freebsd.org/changeset/base/365590
Log:
MFC r357816 (from rrs)
This small fix makes it so we properly follow
the RFC and only enable ECN when both the
CWR and ECT bits our set within the SYN packet.
Author: tuexen
Date: Thu Sep 10 16:59:54 2020
New Revision: 365589
URL: https://svnweb.freebsd.org/changeset/base/365589
Log:
MFC r357100:
The server side of TCP fast open relies on the delayed ACK timer to allow
including user data in the SYN-ACK. When DSACK support was added in
Author: tuexen
Date: Thu Sep 10 16:47:08 2020
New Revision: 365587
URL: https://svnweb.freebsd.org/changeset/base/365587
Log:
MFC r358023:
Don't use uninitialised stack memory if the sysctl variable
net.inet.tcp.hostcache.enable is set to 0.
The bug resulted in using possibly a too
Author: tuexen
Date: Thu Sep 10 16:44:28 2020
New Revision: 365586
URL: https://svnweb.freebsd.org/changeset/base/365586
Log:
MFC r357116:
Sending CWR after an RTO is according to RFC 3168 generally required
and not only for the DCTCP congestion control.
Modified:
Author: tuexen
Date: Thu Sep 10 15:58:37 2020
New Revision: 365585
URL: https://svnweb.freebsd.org/changeset/base/365585
Log:
MFC r357115:
Don't set the ECT codepoint on retransmitted packets during SACK loss
recovery. This is required by RFC 3168.
Modified:
Author: tuexen
Date: Thu Sep 10 13:44:35 2020
New Revision: 365573
URL: https://svnweb.freebsd.org/changeset/base/365573
Log:
MFC r357114:
As a TCP client only enable ECN when the corresponding sysctl variable
indicates that ECN should be negotiated for the client side.
Modified:
Author: tuexen
Date: Thu Sep 10 13:27:53 2020
New Revision: 365572
URL: https://svnweb.freebsd.org/changeset/base/365572
Log:
MFC r356235:
Fix delayed ACK generation for DCTCP.
Manually changed to use TF_ECN_SND_ECE.
Modified:
stable/12/sys/netinet/cc/cc_dctcp.c
Author: tuexen
Date: Thu Sep 10 13:17:23 2020
New Revision: 365571
URL: https://svnweb.freebsd.org/changeset/base/365571
Log:
MFC r357101:
Don't delay the ACK for a TCP segment with the CWR flag set.
This allows the data sender to increase the CWND faster.
Modified:
Author: tuexen
Date: Thu Sep 10 13:15:17 2020
New Revision: 365570
URL: https://svnweb.freebsd.org/changeset/base/365570
Log:
MFC r358621:
When using automatically generated flow labels and using TCP SYN
cookies, use the same flow label for the segments sent during the
handshake and after
Author: tuexen
Date: Thu Sep 10 12:54:46 2020
New Revision: 365569
URL: https://svnweb.freebsd.org/changeset/base/365569
Log:
MFC r359926:
Improve the TCP blackhole detection. The principle is to reduce the
MSS in two steps and try each candidate two times. However, if two
candidates
Author: tuexen
Date: Thu Sep 10 12:52:50 2020
New Revision: 365568
URL: https://svnweb.freebsd.org/changeset/base/365568
Log:
MFC r359487:
Allow the TCP backhole detection to be disabled at all, enabled only
for IPv4, enabled only for IPv6, and enabled for IPv4 and IPv6.
The current
Author: tuexen
Date: Thu Sep 10 12:49:16 2020
New Revision: 365567
URL: https://svnweb.freebsd.org/changeset/base/365567
Log:
MFC 359422:
Be a bit more precisly in the description of the sysctl variable
net.inet.tcp.pmtud_blackhole_detection. Also remove three entries,
which are not
Author: tuexen
Date: Thu Sep 10 12:01:35 2020
New Revision: 365565
URL: https://svnweb.freebsd.org/changeset/base/365565
Log:
MFC r361081:
Allow only IPv4 addresses in sendto() for TCP on AF_INET sockets.
This problem was found by looking at syzkaller reproducers for some other
Author: tuexen
Date: Thu Sep 10 11:55:45 2020
New Revision: 365564
URL: https://svnweb.freebsd.org/changeset/base/365564
Log:
MFC r361752:
We should never allow either the broadcast or IN_ADDR_ANY to be
connected to or sent to. This was fond when working with Michael
Tuexen
Author: tuexen
Date: Thu Sep 10 11:46:36 2020
New Revision: 365563
URL: https://svnweb.freebsd.org/changeset/base/365563
Log:
MFC r364089:
Fix the following issues related to the TCP SYN-cache:
* Let the accepted TCP/IPv4 socket inherit the configured TTL and
TOS value.
* Let the
Author: tuexen
Date: Thu Sep 10 11:45:03 2020
New Revision: 365562
URL: https://svnweb.freebsd.org/changeset/base/365562
Log:
MFC r364054:
Improve the ECN negotiation when the TCP SYN-cache is used by making
sure that
* ECN is disabled if the client sends an non-ECN-setup SYN segment.
Author: tuexen
Date: Thu Sep 10 11:43:23 2020
New Revision: 365561
URL: https://svnweb.freebsd.org/changeset/base/365561
Log:
MFC r361750:
Restrict enabling TCP-FASTOPEN to end-points in CLOSED or LISTEN state
Enabling TCP-FASTOPEN on an end-point which is in a state other than
> On 2. Sep 2020, at 20:28, Pedro Giffuni wrote:
>
>
> On 02/09/2020 13:06, Alexey Dokuchaev wrote:
>> On Wed, Sep 02, 2020 at 10:18:15AM -0500, Pedro Giffuni wrote:
>>> On 01/09/2020 21:05, Alexey Dokuchaev wrote:
...
This is common sense. I can't count how often I wanted to hack on
> On 2. Sep 2020, at 04:05, Alexey Dokuchaev wrote:
>
> On Wed, Sep 02, 2020 at 12:41:43AM +0200, Michael Tuexen wrote:
>>> On 1. Sep 2020, at 23:19, Mateusz Guzik wrote:
>>> Author: mjg
>>> Date: Tue Sep 1 21:19:14 2020
>>> New Revision: 365071
> On 1. Sep 2020, at 23:19, Mateusz Guzik wrote:
>
> Author: mjg
> Date: Tue Sep 1 21:19:14 2020
> New Revision: 365071
> URL: https://svnweb.freebsd.org/changeset/base/365071
>
> Log:
> net: clean up empty lines in .c and .h files
Hi Mateusz,
which rules are enforced? Why?
Best regards
Author: tuexen
Date: Sat Aug 29 06:55:10 2020
New Revision: 364948
URL: https://svnweb.freebsd.org/changeset/base/364948
Log:
MFC r364937:
Fix a regression with the explicit EOR mode I introduced in r364268.
Modified:
stable/11/sys/netinet/sctp_output.c
Directory Properties:
stable/11/
Author: tuexen
Date: Sat Aug 29 06:54:39 2020
New Revision: 364947
URL: https://svnweb.freebsd.org/changeset/base/364947
Log:
MFC r364937:
Fix a regression with the explicit EOR mode I introduced in r364268.
Modified:
stable/12/sys/netinet/sctp_output.c
Directory Properties:
stable/12/
Author: tuexen
Date: Fri Aug 28 20:05:18 2020
New Revision: 364937
URL: https://svnweb.freebsd.org/changeset/base/364937
Log:
Fix a regression with the explicit EOR mode I introduced in r364268.
A short MFC time as discussed with the secteam.
Reported by: Taylor Brandstetter
Author: tuexen
Date: Tue Aug 25 09:42:03 2020
New Revision: 364754
URL: https://svnweb.freebsd.org/changeset/base/364754
Log:
RFC 3465 defines a limit L used in TCP slow start for limiting the number
of acked bytes as described in Section 2.2 of that document.
This patch ensures that this
Author: tuexen
Date: Mon Aug 24 09:46:36 2020
New Revision: 364651
URL: https://svnweb.freebsd.org/changeset/base/364651
Log:
MFC r364268:
Improve the handling of concurrent send() calls for SCTP sockets,
especially when having the explicit EOR mode enabled.
Manually resolved merge
Author: tuexen
Date: Mon Aug 24 09:19:05 2020
New Revision: 364644
URL: https://svnweb.freebsd.org/changeset/base/364644
Log:
MFC 364268:
Improve the handling of concurrent send() calls for SCTP sockets,
especially when having the explicit EOR mode enabled.
MFC r364270:
Remove a line
Author: tuexen
Date: Mon Aug 24 09:15:52 2020
New Revision: 364643
URL: https://svnweb.freebsd.org/changeset/base/364643
Log:
MFC r363456:
Clear the pointer to the socket when closing it also in case of
an ungraceful operation.
This fixes a use-after-free bug found and reported by Taylor
Author: tuexen
Date: Mon Aug 24 09:14:32 2020
New Revision: 364642
URL: https://svnweb.freebsd.org/changeset/base/364642
Log:
MFC r363440:
Detect and handle an invalid reassembly constellation, which results in
a memory leak.
Thanks to Felix Weinrank for finding this issue using fuzz
1 - 100 of 2723 matches
Mail list logo