svn commit: r347095 - in stable/12/sys/netinet: . tcp_stacks

Author: tuexen Date: Sat May 4 10:36:16 2019 New Revision: 347095 URL: https://svnweb.freebsd.org/changeset/base/347095 Log: MFC r344367: Use exponential backoff for retransmitting SYN segments as specified in the TCP RFCs. Reviewed by: rrs@, Richard Scheffenegger Sponsored

svn commit: r347094 - stable/12/sys/netinet

Author: tuexen Date: Sat May 4 10:33:31 2019 New Revision: 347094 URL: https://svnweb.freebsd.org/changeset/base/347094 Log: MFC r344148: Fix a byte ordering issue for the advertised receiver window in ACK segments sent in TIMEWAIT state, which I introduced in r336937. Sponsored by:

svn commit: r347093 - stable/12/sys/netinet

Author: tuexen Date: Sat May 4 10:13:37 2019 New Revision: 347093 URL: https://svnweb.freebsd.org/changeset/base/347093 Log: MFC r344048: Improve input validation for raw IPv4 socket using the IP_HDRINCL option. This issue was found by running syzkaller on OpenBSD. Greg Steuck made

svn commit: r347092 - stable/12/sys/netinet

Author: tuexen Date: Sat May 4 10:09:25 2019 New Revision: 347092 URL: https://svnweb.freebsd.org/changeset/base/347092 Log: MFC r343961: Fix a locking issue when reporing outbound messages. Modified: stable/12/sys/netinet/sctputil.c Directory Properties: stable/12/ (props changed)

svn commit: r347091 - stable/12/sys/netinet

Author: tuexen Date: Sat May 4 10:06:17 2019 New Revision: 347091 URL: https://svnweb.freebsd.org/changeset/base/347091 Log: MFC r343960: Fix a locking issue in the IPPROTO_SCTP level SCTP_PEER_ADDR_THLDS socket option. The problem affects only setsockopt with invalid parameters. This

svn commit: r347090 - stable/12/sys/netinet

Author: tuexen Date: Sat May 4 10:04:00 2019 New Revision: 347090 URL: https://svnweb.freebsd.org/changeset/base/347090 Log: MFC r340179: Don't use a function when neither INET nor INET6 are defined. This is a valid case for the userland stack, where this fixes two set-but-not-used

svn commit: r347087 - stable/12/sys/netinet

Author: tuexen Date: Sat May 4 09:28:11 2019 New Revision: 347087 URL: https://svnweb.freebsd.org/changeset/base/347087 Log: MFC r343954: Fix a locking bug in the IPPROTO_SCTP level SCTP_EVENT socket option. This occurs when call setsockopt() with invalid parameters. This issue was

svn commit: r347086 - stable/12/sys/netinet

Author: tuexen Date: Sat May 4 09:25:32 2019 New Revision: 347086 URL: https://svnweb.freebsd.org/changeset/base/347086 Log: MFC r343951: Fix locking for IPPROTO_SCTP level SCTP_DEFAULT_PRINFO socket option. This problem occurred when calling setsockopt() will invalid parameters. This

svn commit: r347085 - stable/12/sys/netinet

Author: tuexen Date: Sat May 4 09:18:19 2019 New Revision: 347085 URL: https://svnweb.freebsd.org/changeset/base/347085 Log: MFC r343770: Only reduce the PMTU after the send call. The only way to increase it, is via PMTUD. This fixes an MTU issue reported by Timo Voelker. Modified:

svn commit: r347083 - stable/12/lib/libsysdecode

Author: tuexen Date: Sat May 4 09:13:52 2019 New Revision: 347083 URL: https://svnweb.freebsd.org/changeset/base/347083 Log: MFC r343742: Add missing SCTP_EOR entry. Modified: stable/12/lib/libsysdecode/flags.c Directory Properties: stable/12/ (props changed) Modified:

svn commit: r347082 - in stable/12/sys/netinet: . tcp_stacks

Author: tuexen Date: Sat May 4 09:11:17 2019 New Revision: 347082 URL: https://svnweb.freebsd.org/changeset/base/347082 Log: MFC r343661: When handling SYN-ACK segments in the SYN-RCVD state, set tp->snd_wnd consistently. This inconsistency was observed when working on the bug

svn commit: r347084 - stable/12/sys/netinet

Author: tuexen Date: Sat May 4 09:15:57 2019 New Revision: 347084 URL: https://svnweb.freebsd.org/changeset/base/347084 Log: MFC r343769: Fix an off-by-one error in the input validation of the SCTP_RESET_STREAMS socketoption. This was found by running syzkaller. Modified:

svn commit: r347081 - in stable/12/sys/netinet: . tcp_stacks

Author: tuexen Date: Sat May 4 09:07:53 2019 New Revision: 347081 URL: https://svnweb.freebsd.org/changeset/base/347081 Log: MFC r343525: Fix the detection of ECN-setup SYN-ACK packets. RFC 3168 defines an ECN-setup SYN-ACK packet as on with the ECE flags set and the CWR flags not

svn commit: r347080 - stable/12/sys/netinet

Author: tuexen Date: Sat May 4 09:01:56 2019 New Revision: 347080 URL: https://svnweb.freebsd.org/changeset/base/347080 Log: MFC r343401: Update a comment to reflect the current reality. SYN-cache entries live for abaut 12 seconds, not 45, when default setting are used. MFC r343402:

svn commit: r346854 - head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip

Author: tuexen Date: Sun Apr 28 19:07:31 2019 New Revision: 346854 URL: https://svnweb.freebsd.org/changeset/base/346854 Log: Some test scripts use ncat --sctp --listen port to run an SCTP discard server in the background. However, when running in the background, stdin is closed and ncat

svn commit: r346406 - head/sys/netinet6

Author: tuexen Date: Fri Apr 19 18:09:37 2019 New Revision: 346406 URL: https://svnweb.freebsd.org/changeset/base/346406 Log: When an IPv6 packet is received for a raw socket which has the IPPROTO_IPV6 level socket option IPV6_CHECKSUM enabled and the checksum check fails, drop the message.

svn commit: r346402 - head/sys/netinet6

Author: tuexen Date: Fri Apr 19 17:28:28 2019 New Revision: 346402 URL: https://svnweb.freebsd.org/changeset/base/346402 Log: When a checksum has to be computed for a received IPv6 packet because it is requested by the application using the IPPROTO_IPV6 level socket option IPV6_CHECKSUM on

svn commit: r346401 - head/sys/netinet6

Author: tuexen Date: Fri Apr 19 17:21:35 2019 New Revision: 346401 URL: https://svnweb.freebsd.org/changeset/base/346401 Log: Avoid a buffer overwrite in rip6_output() when computing the checksum as requested by the user via the IPPROTO_IPV6 level socket option IPV6_CHECKSUM. The check if

svn commit: r346400 - head/sys/netinet6

Author: tuexen Date: Fri Apr 19 17:17:41 2019 New Revision: 346400 URL: https://svnweb.freebsd.org/changeset/base/346400 Log: Improve input validation for the socket option IPV6_CHECKSUM. When using the IPPROTO_IPV6 level socket option IPV6_CHECKSUM on a raw IPv6 socket, ensure that the

svn commit: r346197 - head/sys/net

Author: tuexen Date: Sun Apr 14 10:18:14 2019 New Revision: 346197 URL: https://svnweb.freebsd.org/changeset/base/346197 Log: When sending a routing message, don't allow the user to set the RTF_RNH_LOCKED flag in rtm_flags, since this flag is used only internally. Reported by:

svn commit: r346182 - head/sys/netinet

Author: tuexen Date: Sat Apr 13 10:47:47 2019 New Revision: 346182 URL: https://svnweb.freebsd.org/changeset/base/346182 Log: When sending IPv4 packets on a SOCK_RAW socket using the IP_HDRINCL option, ensure that the ip_hl field is valid. Furthermore, ensure that the complete IPv4 header

svn commit: r346134 - head/sys/netinet

Author: tuexen Date: Thu Apr 11 20:39:12 2019 New Revision: 346134 URL: https://svnweb.freebsd.org/changeset/base/346134 Log: Fix an SCTP related locking issue. Don't report that the TCB_SEND_LOCK is owned, when it is not. This issue was found by running syzkaller. MFC after:

svn commit: r345525 - head/sys/netinet

Author: tuexen Date: Tue Mar 26 08:27:00 2019 New Revision: 345525 URL: https://svnweb.freebsd.org/changeset/base/345525 Log: Fix a double free of an SCTP association in an error path. This is joint work with rrs@. The issue was found by running syzkaller. MFC after:1 week

svn commit: r345505 - head/sys/netinet

Author: tuexen Date: Mon Mar 25 16:40:54 2019 New Revision: 345505 URL: https://svnweb.freebsd.org/changeset/base/345505 Log: Initialize scheduler specific data for the FCFS scheduler. This is joint work with rrs@. The issue was reported by using syzkaller. MFC after:1 week

svn commit: r345504 - head/sys/netinet

Author: tuexen Date: Mon Mar 25 15:23:20 2019 New Revision: 345504 URL: https://svnweb.freebsd.org/changeset/base/345504 Log: Improve locking when tearing down an SCTP association. This is joint work with rrs@ and the issue was found by syzkaller. MFC after:1 week

svn commit: r345494 - head/sys/netinet

Author: tuexen Date: Mon Mar 25 09:47:22 2019 New Revision: 345494 URL: https://svnweb.freebsd.org/changeset/base/345494 Log: Fix the handling of fragmented unordered messages when using DATA chunks and FORWARD-TSN. This bug was reported in https://github.com/sctplab/usrsctp/issues/286

svn commit: r345465 - head/sys/netinet

Author: tuexen Date: Sun Mar 24 09:46:16 2019 New Revision: 345465 URL: https://svnweb.freebsd.org/changeset/base/345465 Log: Fix a signed/unsigned bug when receiving SCTP messages. This is joint work with rrs@. Reported by: syzbot+6b8a4bc8cc828e9d9...@syzkaller.appspotmail.com

svn commit: r345467 - head/sys/netinet

Author: tuexen Date: Sun Mar 24 12:13:05 2019 New Revision: 345467 URL: https://svnweb.freebsd.org/changeset/base/345467 Log: Fix build issue for the userland stack. Joint work with rrs@. MFC after:1 week Modified: head/sys/netinet/sctp_output.c

svn commit: r345466 - head/sys/netinet

Author: tuexen Date: Sun Mar 24 10:40:20 2019 New Revision: 345466 URL: https://svnweb.freebsd.org/changeset/base/345466 Log: Fox more signed unsigned issues. This time on the send path. This is joint work with rrs@ and was found by running syzkaller. MFC after:1 week

svn commit: r345461 - head/sys/netinet

Author: tuexen Date: Sat Mar 23 22:56:03 2019 New Revision: 345461 URL: https://svnweb.freebsd.org/changeset/base/345461 Log: Limit the size of messages sent on 1-to-many style SCTP sockets with the SCTP_SENDALL flag. Allow also only one operation per SCTP endpoint. This fixes an issue

svn commit: r345460 - head/sys/netinet

Author: tuexen Date: Sat Mar 23 22:46:29 2019 New Revision: 345460 URL: https://svnweb.freebsd.org/changeset/base/345460 Log: Limit the number of bytes which can be queued for SCTP sockets. This is joint work with rrs@. Reported by:

svn commit: r345458 - in head: share/man/man4 sys/netinet

Author: tuexen Date: Sat Mar 23 21:36:59 2019 New Revision: 345458 URL: https://svnweb.freebsd.org/changeset/base/345458 Log: Add sysctl variable net.inet.tcp.rexmit_initial for setting RTO.Initial used by TCP. Reviewed by: rrs@, 0mp@ Sponsored by: Netflix, Inc.

svn commit: r345441 - head/sys/netinet

Author: tuexen Date: Sat Mar 23 09:56:41 2019 New Revision: 345441 URL: https://svnweb.freebsd.org/changeset/base/345441 Log: Fix a KASSERT() in tcp_output(). When checking the length of the headers at this point, the IP level options have not been added to the mbuf chain. So don't

svn commit: r344925 - head/sys/netinet

Author: tuexen Date: Fri Mar 8 18:17:57 2019 New Revision: 344925 URL: https://svnweb.freebsd.org/changeset/base/344925 Log: Fix locking bug. MFC after:3 days Modified: head/sys/netinet/sctp_usrreq.c Modified: head/sys/netinet/sctp_usrreq.c

svn commit: r344924 - head/sys/netinet

Author: tuexen Date: Fri Mar 8 18:16:19 2019 New Revision: 344924 URL: https://svnweb.freebsd.org/changeset/base/344924 Log: Some cleanup and consistency improvements. MFC after:3 days Modified: head/sys/netinet/sctp_ss_functions.c Modified:

svn commit: r344872 - head/sys/netinet

Author: tuexen Date: Thu Mar 7 08:43:20 2019 New Revision: 344872 URL: https://svnweb.freebsd.org/changeset/base/344872 Log: After removing an entry from the stream scheduler list, set the pointers to NULL, since we are checking for it in case the element gets inserted again. This

svn commit: r344742 - head/sys/netinet

Author: tuexen Date: Sun Mar 3 19:55:06 2019 New Revision: 344742 URL: https://svnweb.freebsd.org/changeset/base/344742 Log: Allocate an assocition id and register the stcb with holding the lock. This avoids a race where stcbs can be found, which are not completely initialized. This

svn commit: r344724 - head/sys/netinet

Author: tuexen Date: Sat Mar 2 14:30:27 2019 New Revision: 344724 URL: https://svnweb.freebsd.org/changeset/base/344724 Log: Allow SCTP stream reconfiguration operations only in ESTABLISHED state. This issue was found by running syzkaller. MFC after:3 days Modified:

svn commit: r344723 - head/sys/netinet

Author: tuexen Date: Sat Mar 2 14:15:33 2019 New Revision: 344723 URL: https://svnweb.freebsd.org/changeset/base/344723 Log: Handle the case when calling the IPPROTO_SCTP level socket option SCTP_STATUS on an association with no primary path (early state). This issue was found by

svn commit: r344722 - head/lib/libc/net

Author: tuexen Date: Sat Mar 2 13:16:01 2019 New Revision: 344722 URL: https://svnweb.freebsd.org/changeset/base/344722 Log: Use correct buffer sizes in sctp_get[lp]addrs(). MFC after:3 days Modified: head/lib/libc/net/sctp_sys_calls.c Modified:

svn commit: r344721 - head/sys/netinet

Author: tuexen Date: Sat Mar 2 13:12:37 2019 New Revision: 344721 URL: https://svnweb.freebsd.org/changeset/base/344721 Log: Report the correct length when using the IPPROTO_SCTP level socket options SCTP_GET_PEER_ADDRESSES and SCTP_GET_LOCAL_ADDRESSES. Modified:

svn commit: r344726 - head/sys/netinet

Author: tuexen Date: Sat Mar 2 16:10:11 2019 New Revision: 344726 URL: https://svnweb.freebsd.org/changeset/base/344726 Log: Remove debug output. MFC after:3 days Modified: head/sys/netinet/sctp_usrreq.c Modified: head/sys/netinet/sctp_usrreq.c

svn commit: r344708 - head/sys/netinet

Author: tuexen Date: Fri Mar 1 18:47:41 2019 New Revision: 344708 URL: https://svnweb.freebsd.org/changeset/base/344708 Log: Honor the memory limits provided when processing the IPPROTO_SCTP level socket option SCTP_GET_LOCAL_ADDRESSES in a getsockopt() call. Thanks to Thomas Barabosch

svn commit: r344704 - head/sys/netinet

Author: tuexen Date: Fri Mar 1 15:57:55 2019 New Revision: 344704 URL: https://svnweb.freebsd.org/changeset/base/344704 Log: Improve consistency, not functional change. MFC after:3 days Modified: head/sys/netinet/sctp_usrreq.c Modified: head/sys/netinet/sctp_usrreq.c

svn commit: r344516 - stable/12/sys/netinet

Author: tuexen Date: Mon Feb 25 12:35:52 2019 New Revision: 344516 URL: https://svnweb.freebsd.org/changeset/base/344516 Log: MFC r344428: This patch addresses an issue brought up by bz@ in D18968: When TCP_REASS_LOGGING is defined, a NULL pointer dereference would happen, if user data

svn commit: r344515 - stable/12/sys/netinet

Author: tuexen Date: Mon Feb 25 12:33:11 2019 New Revision: 344515 URL: https://svnweb.freebsd.org/changeset/base/344515 Log: MFC r343439: Don't include two header files when not needed. This allows the part of the rewrite of TCP reassembly in this files to be MFCed to stable/11

svn commit: r344514 - stable/12/sys/netinet/cc

Author: tuexen Date: Mon Feb 25 12:25:44 2019 New Revision: 344514 URL: https://svnweb.freebsd.org/changeset/base/344514 Log: MFC r343920: Ensure that when using the TCP CDG congestion control and setting the sysctl variable net.inet.tcp.cc.cdg.smoothing_factor to 0, the smoothing is

svn commit: r344512 - stable/11/sys/netinet/cc

Author: tuexen Date: Mon Feb 25 10:51:21 2019 New Revision: 344512 URL: https://svnweb.freebsd.org/changeset/base/344512 Log: MFC r343920: Ensure that when using the TCP CDG congestion control and setting the sysctl variable net.inet.tcp.cc.cdg.smoothing_factor to 0, the smoothing is

svn commit: r344511 - in stable/11/sys: netinet netinet/tcp_stacks sys

Author: tuexen Date: Mon Feb 25 10:38:37 2019 New Revision: 344511 URL: https://svnweb.freebsd.org/changeset/base/344511 Log: Backport the new TCP reassembly code from head to stable/11. In particular: * Cherry pick the changes in sys/queue.h from r334804. * MFC r338102 with

Re: svn commit: r344368 - head/sys/netinet

> On 21. Feb 2019, at 09:32, Kubilay Kocak wrote: > > On 21/02/2019 5:03 am, Michael Tuexen wrote: >> Author: tuexen >> Date: Wed Feb 20 18:03:43 2019 >> New Revision: 344368 >> URL: https://svnweb.freebsd.org/changeset/base/344368 >> Log: >> Reduc

svn commit: r344433 - head/sys/netinet

Author: tuexen Date: Thu Feb 21 10:35:32 2019 New Revision: 344433 URL: https://svnweb.freebsd.org/changeset/base/344433 Log: The receive buffer autoscaling for TCP is based on a linear growth, which is acceptable in the congestion avoidance phase, but not during slow start. The MTU is is

svn commit: r344428 - head/sys/netinet

Author: tuexen Date: Thu Feb 21 09:34:47 2019 New Revision: 344428 URL: https://svnweb.freebsd.org/changeset/base/344428 Log: This patch addresses an issue brought up by bz@ in D18968: When TCP_REASS_LOGGING is defined, a NULL pointer dereference would happen, if user data was received

Re: svn commit: r344368 - head/sys/netinet

> On 21. Feb 2019, at 09:32, Kubilay Kocak wrote: > > On 21/02/2019 5:03 am, Michael Tuexen wrote: >> Author: tuexen >> Date: Wed Feb 20 18:03:43 2019 >> New Revision: 344368 >> URL: https://svnweb.freebsd.org/changeset/base/344368 >> Log: >> Reduc

svn commit: r344368 - head/sys/netinet

Author: tuexen Date: Wed Feb 20 18:03:43 2019 New Revision: 344368 URL: https://svnweb.freebsd.org/changeset/base/344368 Log: Reduce the TCP initial retransmission timeout from 3 seconds to 1 second as allowed by RFC 6298. Reviewed by: kbowling@, Richard Scheffenegger

svn commit: r344367 - in head/sys/netinet: . tcp_stacks

Author: tuexen Date: Wed Feb 20 17:56:38 2019 New Revision: 344367 URL: https://svnweb.freebsd.org/changeset/base/344367 Log: Use exponential backoff for retransmitting SYN segments as specified in the TCP RFCs. Reviewed by: rrs@, Richard Scheffenegger Sponsored by:

svn commit: r344148 - head/sys/netinet

Author: tuexen Date: Fri Feb 15 09:45:17 2019 New Revision: 344148 URL: https://svnweb.freebsd.org/changeset/base/344148 Log: Fix a byte ordering issue for the advertised receiver window in ACK segments sent in TIMEWAIT state, which I introduced in r336937. MFC after:3 days

Re: svn commit: r344027 - in stable/12/sys: dev/vmware/vmxnet3 modules/vmware/vmxnet3 net

> On 13. Feb 2019, at 00:54, Marius Strobl wrote: > > On Mon, Feb 11, 2019 at 05:24:18PM -0800, Rodney W. Grimes wrote: >>> On 2/11/19 4:26 PM, Rodney W. Grimes wrote: > Author: pkelsey > Date: Mon Feb 11 23:24:39 2019 > New Revision: 344027 > URL:

svn commit: r344048 - head/sys/netinet

Author: tuexen Date: Tue Feb 12 10:17:21 2019 New Revision: 344048 URL: https://svnweb.freebsd.org/changeset/base/344048 Log: Improve input validation for raw IPv4 socket using the IP_HDRINCL option. This issue was found by running syzkaller on OpenBSD. Greg Steuck made me aware that

Re: svn commit: r343949 - in head/sys: amd64/conf arm64/conf

> On 10. Feb 2019, at 08:54, Conrad Meyer wrote: > > Author: cem > Date: Sun Feb 10 07:54:46 2019 > New Revision: 343949 > URL: https://svnweb.freebsd.org/changeset/base/343949 > > Log: > Revert r343713 temporarily > > The COVERAGE option breaks xtoolchain-gcc GENERIC kernel early boot >

svn commit: r344012 - head/sys/conf

Author: tuexen Date: Mon Feb 11 15:38:05 2019 New Revision: 344012 URL: https://svnweb.freebsd.org/changeset/base/344012 Log: Fix flags used when compiling kern_kcov.c and subr_coverage.c. Without this fix, the usage of kernel coverage would lockup the system. Thanks to Andrew for

Re: svn commit: r343746 - head/sys/conf

lready slow, that doesn't mean we can just make it 10x > slower.) > > Best, > Conrad > > On Sun, Feb 10, 2019 at 12:03 AM Michael Tuexen wrote: >> >>> On 10. Feb 2019, at 08:50, Conrad Meyer wrote: >>> >>> Hi Andrew, >>> >>> T

svn commit: r343961 - head/sys/netinet

Author: tuexen Date: Sun Feb 10 14:02:14 2019 New Revision: 343961 URL: https://svnweb.freebsd.org/changeset/base/343961 Log: Fix a locking issue when reporing outbount messages. MFC after:3 days Modified: head/sys/netinet/sctputil.c Modified: head/sys/netinet/sctputil.c

svn commit: r343960 - head/sys/netinet

Author: tuexen Date: Sun Feb 10 13:55:32 2019 New Revision: 343960 URL: https://svnweb.freebsd.org/changeset/base/343960 Log: Fix a locking issue in the IPPROTO_SCTP level SCTP_PEER_ADDR_THLDS socket option. The problem affects only setsockopt with invalid parameters. This issue was

svn commit: r343954 - head/sys/netinet

Author: tuexen Date: Sun Feb 10 10:42:16 2019 New Revision: 343954 URL: https://svnweb.freebsd.org/changeset/base/343954 Log: Fix a locking bug in the IPPROTO_SCTP level SCTP_EVENT socket option. This occurs when call setsockopt() with invalid parameters. This issue was found by

Re: svn commit: r343746 - head/sys/conf

> On 10. Feb 2019, at 08:50, Conrad Meyer wrote: > > Hi Andrew, > > This makes it compile, but instead of a build failure the kernel is > broken hard at runtime in early boot with GCC < 8.1. E.g., > amd64-xtoolchain-gcc standard cross-toolchain is still on GCC 6.4.0. > > HEAD GENERIC has been

svn commit: r343951 - head/sys/netinet

Author: tuexen Date: Sun Feb 10 08:28:56 2019 New Revision: 343951 URL: https://svnweb.freebsd.org/changeset/base/343951 Log: Fix locking for IPPROTO_SCTP level SCTP_DEFAULT_PRINFO socket option. This problem occurred when calling setsockopt() will invalid parameters. This issue was

svn commit: r343920 - head/sys/netinet/cc

Author: tuexen Date: Fri Feb 8 20:42:49 2019 New Revision: 343920 URL: https://svnweb.freebsd.org/changeset/base/343920 Log: Ensure that when using the TCP CDG congestion control and setting the sysctl variable net.inet.tcp.cc.cdg.smoothing_factor to 0, the smoothing is disabled. Without

svn commit: r343770 - head/sys/netinet

Author: tuexen Date: Tue Feb 5 10:29:31 2019 New Revision: 343770 URL: https://svnweb.freebsd.org/changeset/base/343770 Log: Only reduce the PMTU after the send call. The only way to increase it, is via PMTUD. This fixes an MTU issue reported by Timo Voelker. MFC after:

svn commit: r343769 - head/sys/netinet

Author: tuexen Date: Tue Feb 5 10:13:51 2019 New Revision: 343769 URL: https://svnweb.freebsd.org/changeset/base/343769 Log: Fix an off-by-one error in the input validation of the SCTP_RESET_STREAMS socketoption. This was found by running syzkaller. MFC after:3 days

svn commit: r343742 - head/lib/libsysdecode

Author: tuexen Date: Mon Feb 4 13:30:47 2019 New Revision: 343742 URL: https://svnweb.freebsd.org/changeset/base/343742 Log: Add missing SCTP_EOR entry. MFC after:3 days Modified: head/lib/libsysdecode/flags.c Modified: head/lib/libsysdecode/flags.c

svn commit: r343661 - in head/sys/netinet: . tcp_stacks

Author: tuexen Date: Fri Feb 1 12:33:00 2019 New Revision: 343661 URL: https://svnweb.freebsd.org/changeset/base/343661 Log: When handling SYN-ACK segments in the SYN-RCVD state, set tp->snd_wnd consistently. This inconsistency was observed when working on the bug reported in PR

svn commit: r343525 - in head/sys/netinet: . tcp_stacks

Author: tuexen Date: Mon Jan 28 12:45:31 2019 New Revision: 343525 URL: https://svnweb.freebsd.org/changeset/base/343525 Log: Fix the detection of ECN-setup SYN-ACK packets. RFC 3168 defines an ECN-setup SYN-ACK packet as on with the ECE flags set and the CWR flags not set. The code was

svn commit: r343439 - head/sys/netinet

Author: tuexen Date: Fri Jan 25 17:08:28 2019 New Revision: 343439 URL: https://svnweb.freebsd.org/changeset/base/343439 Log: Don't include two header files when not needed. This allows the part of the rewrite of TCP reassembly in this files to be MFCed to stable/11 with manual change.

svn commit: r343437 - stable/11/sys/netinet

Author: tuexen Date: Fri Jan 25 15:48:00 2019 New Revision: 343437 URL: https://svnweb.freebsd.org/changeset/base/343437 Log: MFC r343089: Limit the user-controllable amount of memory the kernel allocates via IPPROTO_SCTP level socket options. This issue was found by running

svn commit: r343436 - stable/12/sys/netinet

Author: tuexen Date: Fri Jan 25 15:46:30 2019 New Revision: 343436 URL: https://svnweb.freebsd.org/changeset/base/343436 Log: MFC r343089: Limit the user-controllable amount of memory the kernel allocates via IPPROTO_SCTP level socket options. This issue was found by running

svn commit: r343435 - stable/12/sys/netinet

Author: tuexen Date: Fri Jan 25 15:44:53 2019 New Revision: 343435 URL: https://svnweb.freebsd.org/changeset/base/343435 Log: MFC r342879: Fix getsockopt() for IP_OPTIONS/IP_RETOPTS. r336616 copies inp->inp_options using the m_dup() function. However, this function expects an mbuf

svn commit: r343434 - stable/11/sys/kern

Author: tuexen Date: Fri Jan 25 15:40:51 2019 New Revision: 343434 URL: https://svnweb.freebsd.org/changeset/base/343434 Log: MFC r342857: Avoid overfow in vtruncbuf() Using daddr_t instead of int avoids trunclbn to become negative when it shouldn't. This isssue was found by

svn commit: r343433 - stable/12/sys/kern

Author: tuexen Date: Fri Jan 25 15:39:33 2019 New Revision: 343433 URL: https://svnweb.freebsd.org/changeset/base/343433 Log: MFC r342857: Avoid overfow in vtruncbuf() Using daddr_t instead of int avoids trunclbn to become negative when it shouldn't. This isssue was found by

svn commit: r343432 - stable/11/sys/netinet

Author: tuexen Date: Fri Jan 25 15:25:53 2019 New Revision: 343432 URL: https://svnweb.freebsd.org/changeset/base/343432 Log: MFC r338138: Enabling the IPPROTO_IPV6 level socket option IPV6_USE_MIN_MTU on a TCP socket resulted in sending fragmented IPV6 packets. This is fixes by

svn commit: r343431 - stable/11/sys/netinet

Author: tuexen Date: Fri Jan 25 15:21:42 2019 New Revision: 343431 URL: https://svnweb.freebsd.org/changeset/base/343431 Log: MFC r338137: Fix the inheritance of IPv6 level socket options on TCP sockets. This was broken for IPv6 listening socket, which are not IPV6_ONLY, and the

svn commit: r343428 - in head/sys/netinet: . cc tcp_stacks

Author: tuexen Date: Fri Jan 25 13:57:09 2019 New Revision: 343428 URL: https://svnweb.freebsd.org/changeset/base/343428 Log: Fix a bug in the restart window computation of TCP New Reno When implementing support for IW10, an update in the computation of the restart window used after an

svn commit: r343403 - head/sys/netinet

Author: tuexen Date: Thu Jan 24 16:47:18 2019 New Revision: 343403 URL: https://svnweb.freebsd.org/changeset/base/343403 Log: Get the arithmetic right... MFC after:3 days Sponsored by: Netflix, Inc. Modified: head/sys/netinet/tcp_syncache.c Modified:

svn commit: r343402 - head/sys/netinet

Author: tuexen Date: Thu Jan 24 16:43:13 2019 New Revision: 343402 URL: https://svnweb.freebsd.org/changeset/base/343402 Log: Kill a trailing whitespace character... MFC after:3 days Sponsored by: Netflix, Inc. Modified: head/sys/netinet/tcp_syncache.c Modified:

svn commit: r343401 - head/sys/netinet

Author: tuexen Date: Thu Jan 24 16:40:14 2019 New Revision: 343401 URL: https://svnweb.freebsd.org/changeset/base/343401 Log: Update a comment to reflect the current reality. SYN-cache entries live for abaut 12 seconds, not 45, when default setting are used. MFC after:1

svn commit: r343089 - head/sys/netinet

Author: tuexen Date: Wed Jan 16 11:33:47 2019 New Revision: 343089 URL: https://svnweb.freebsd.org/changeset/base/343089 Log: Limit the user-controllable amount of memory the kernel allocates via IPPROTO_SCTP level socket options. This issue was found by running syzkaller. MFC

svn commit: r342879 - head/sys/netinet

Author: tuexen Date: Wed Jan 9 06:36:57 2019 New Revision: 342879 URL: https://svnweb.freebsd.org/changeset/base/342879 Log: Fix getsockopt() for IP_OPTIONS/IP_RETOPTS. r336616 copies inp->inp_options using the m_dup() function. However, this function expects an mbuf packet header at

svn commit: r342857 - head/sys/kern

Author: tuexen Date: Tue Jan 8 09:04:27 2019 New Revision: 342857 URL: https://svnweb.freebsd.org/changeset/base/342857 Log: Avoid overfow in vtruncbuf() Using daddr_t instead of int avoids trunclbn to become negative when it shouldn't. This isssue was found by running syzkaller.

svn commit: r342378 - stable/12/sys/netinet

Author: tuexen Date: Sun Dec 23 09:48:36 2018 New Revision: 342378 URL: https://svnweb.freebsd.org/changeset/base/342378 Log: MFC r342280: Fix a regression in the TCP handling of received segments. When receiving TCP segments the stack protects itself by limiting the resources

svn commit: r342280 - head/sys/netinet

Author: tuexen Date: Thu Dec 20 16:05:30 2018 New Revision: 342280 URL: https://svnweb.freebsd.org/changeset/base/342280 Log: Fix a regression in the TCP handling of received segments. When receiving TCP segments the stack protects itself by limiting the resources allocated for a TCP

Re: svn commit: r342139 - in head: . bin/date libexec/rc/rc.d share/man/man5 tools/build/mk tools/build/options usr.sbin usr.sbin/timed

> On 15. Dec 2018, at 22:34, George V. Neville-Neil wrote: > > Author: gnn > Date: Sat Dec 15 21:34:40 2018 > New Revision: 342139 > URL: https://svnweb.freebsd.org/changeset/base/342139 > > Log: > Remove, the now very outdated, timed. > > Submitted by:Kyle Spiers ksspiers at

svn commit: r341506 - stable/11/sys/netinet

Author: tuexen Date: Tue Dec 4 22:52:15 2018 New Revision: 341506 URL: https://svnweb.freebsd.org/changeset/base/341506 Log: MFC r339042: Mitigate providing a timing signal if the COOKIE or AUTH validation fails. Thanks to jmg@ for reporting the issue, which was discussed in

svn commit: r341504 - stable/12/sys/netinet

Author: tuexen Date: Tue Dec 4 22:46:58 2018 New Revision: 341504 URL: https://svnweb.freebsd.org/changeset/base/341504 Log: MFC r339989, r339991: Improve a comment to refer to the actual sections in the TCP specification for the comparisons made. Thanks to lstewart@ for the

svn commit: r341503 - in stable/11/sys/netinet: . cc

Author: tuexen Date: Tue Dec 4 22:25:24 2018 New Revision: 341503 URL: https://svnweb.freebsd.org/changeset/base/341503 Log: MFC r341335: Limit option_len for the TCP_CCALGOOPT. Limiting the length to 2048 bytes seems to be acceptable, since the values used right now are using 8

svn commit: r341502 - in stable/12/sys/netinet: . cc

Author: tuexen Date: Tue Dec 4 22:15:56 2018 New Revision: 341502 URL: https://svnweb.freebsd.org/changeset/base/341502 Log: MFC r341335: Limit option_len for the TCP_CCALGOOPT. Limiting the length to 2048 bytes seems to be acceptable, since the values used right now are using 8

svn commit: r341501 - stable/12/sys/netinet/tcp_stacks

Author: tuexen Date: Tue Dec 4 22:14:18 2018 New Revision: 341501 URL: https://svnweb.freebsd.org/changeset/base/341501 Log: MFC r340782: A TCP stack is required to check SEG.ACK first, when processing a segment in the SYN-SENT state as stated in Section 3.9 of RFC 793, page 66.

svn commit: r341500 - stable/12/sys/netinet/tcp_stacks

Author: tuexen Date: Tue Dec 4 22:13:05 2018 New Revision: 341500 URL: https://svnweb.freebsd.org/changeset/base/341500 Log: MFC r340781: Ensure that the TCP RACK stack honours the setting of the net.inet.tcp.drop_synfin sysctl-variable. Reviewed by: rrs@ Sponsored by:

svn commit: r341499 - stable/12/sys/netinet/tcp_stacks

Author: tuexen Date: Tue Dec 4 22:11:41 2018 New Revision: 341499 URL: https://svnweb.freebsd.org/changeset/base/341499 Log: MFC r340777: Ensure that the default RTT stack can make an RTT measurement if the TCP connection was initiated using the RACK stack, but the peer does not

svn commit: r341498 - in stable/12/sys/netinet: . tcp_stacks

Author: tuexen Date: Tue Dec 4 22:10:09 2018 New Revision: 341498 URL: https://svnweb.freebsd.org/changeset/base/341498 Log: MFC r340774: Ensure that TCP RST-segments announce consistently a receiver window of zero. This was already done when sending them via tcp_respond().

svn commit: r341497 - stable/12/sys/netinet/tcp_stacks

Author: tuexen Date: Tue Dec 4 22:05:36 2018 New Revision: 341497 URL: https://svnweb.freebsd.org/changeset/base/341497 Log: MFC r340738: Improve two KASSERTs in the TCP RACK stack. There are two locations where an always true comparison was made in a KASSERT. Replace this by an

svn commit: r341335 - in head/sys/netinet: . cc

Author: tuexen Date: Fri Nov 30 10:50:07 2018 New Revision: 341335 URL: https://svnweb.freebsd.org/changeset/base/341335 Log: Limit option_len for the TCP_CCALGOOPT. Limiting the length to 2048 bytes seems to be acceptable, since the values used right now are using 8 bytes. Reviewed

<    3   4   5   6   7   8   9   10   11   12   >